Re: [RFC] V4L2 unified low-level decoder API

2017-06-08 Thread Pawel Osciak
Hi, On Fri, May 19, 2017 at 1:08 AM, Hugues FRUCHET wrote: > Before merging this work Hans would like to have feedback from peers, in > order to be sure that this is inline with other SoC vendors drivers > expectations. > > Thomasz, Pawel, could you give your view regarding ChromeOS and Rockchip

[PATCH] [media] Add multi-planar API documentation

2011-01-03 Thread Pawel Osciak
Add DocBook documentation for the new multi-planar API extensions to the Video for Linux 2 API DocBook. Signed-off-by: Pawel Osciak --- Documentation/DocBook/media-entities.tmpl |4 + Documentation/DocBook/v4l/common.xml |2 + Documentation/DocBook/v4l/compat.xml

Re: [PATCH] [media] Add multi-planar API documentation

2011-01-05 Thread Pawel Osciak
Hi Hans, Huge thanks for the review! On Mon, Jan 3, 2011 at 23:53, Hans Verkuil wrote: > On Tuesday, January 04, 2011 05:20:45 Pawel Osciak wrote: >> Add DocBook documentation for the new multi-planar API extensions to the >> Video for Linux 2 API DocBook. >> >>

[PATCH 1/2] [media] Fix mmap() example in the V4L2 API DocBook

2011-01-06 Thread Pawel Osciak
Correct ioctl return value handling and fix coding style issues. Signed-off-by: Pawel Osciak --- Documentation/DocBook/v4l/io.xml | 40 +++--- 1 files changed, 20 insertions(+), 20 deletions(-) diff --git a/Documentation/DocBook/v4l/io.xml b/Documentation

[PATCH v2] [media] Add multi-planar API documentation

2011-01-06 Thread Pawel Osciak
Add DocBook documentation for the new multi-planar API extensions to the Video for Linux 2 API DocBook. Signed-off-by: Pawel Osciak --- Documentation/DocBook/media-entities.tmpl |4 + Documentation/DocBook/v4l/common.xml |2 + Documentation/DocBook/v4l/compat.xml

Re: [PATCH 1/2] [media] Fix mmap() example in the V4L2 API DocBook

2011-01-06 Thread Pawel Osciak
On Thu, Jan 6, 2011 at 20:40, Pawel Osciak wrote: > Correct ioctl return value handling and fix coding style issues. > > Signed-off-by: Pawel Osciak > --- >  Documentation/DocBook/v4l/io.xml |   40 > +++--- >  1 files changed, 20 insert

Re: [GIT PATCHES FOR 2.6.38] Videbuf2 framework, NOON010PC30 sensor driver and s5p-fimc updates

2011-01-11 Thread Pawel Osciak
Hi Mauro, On Tue, Jan 11, 2011 at 10:23, Mauro Carvalho Chehab wrote: >> Pawel Osciak (8): >>       v4l: Add multi-planar API definitions to the V4L2 API >>       v4l: Add multi-planar ioctl handling code > >>       v4l: Add compat functions for the multi-planar API &

Re: [GIT PATCHES FOR 2.6.38] Videbuf2 framework, NOON010PC30 sensor driver and s5p-fimc updates

2011-01-11 Thread Pawel Osciak
Hi Mauro, On Tue, Jan 11, 2011 at 13:57, Mauro Carvalho Chehab wrote: > Em 03-01-2011 14:48, Sylwester Nawrocki escreveu: >> Pawel Osciak (8): >>       v4l: Add multi-planar API definitions to the V4L2 API > > Where are the corresponding DocBook changes

Re: [GIT PATCHES FOR 2.6.38] Videbuf2 framework, NOON010PC30 sensor driver and s5p-fimc updates

2011-01-12 Thread Pawel Osciak
ch. > > Thanks! > > As before, I'll be commenting the patches as I'll be seeing any issues. > >> Pawel Osciak (2): >>       Fix mmap() example in the V4L2 API DocBook > > In fact, the check for retval < 0 instead of retval == -1 is not a fix. > Ac

[PATCH for 2.6.38] [media] Fix double free of video_device in mem2mem_testdev

2011-01-16 Thread Pawel Osciak
video_device is already being freed in video_device.release callback on release. Signed-off-by: Pawel Osciak Reported-by: Roland Kletzing --- drivers/media/video/mem2mem_testdev.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/mem2mem_testdev.c b

[PATCH v3] [media] Add multi-planar API documentation

2011-01-16 Thread Pawel Osciak
Add DocBook documentation for the new multi-planar API extensions to the Video for Linux 2 API DocBook. Signed-off-by: Pawel Osciak --- Removed references to single-multi planar API conversion layer. Documentation/DocBook/media-entities.tmpl |4 + Documentation/DocBook/v4l/common.xml

[PATCH] [media] Remove compatibility layer from multi-planar API documentation

2011-01-16 Thread Pawel Osciak
This feature will probably be moved to libv4l2. Signed-off-by: Pawel Osciak --- Documentation/DocBook/v4l/planar-apis.xml | 35 +--- Documentation/DocBook/v4l/vidioc-querycap.xml | 22 +++ 2 files changed, 18 insertions(+), 39 deletions(-) diff --git a

[GIT FIXES for 2.6.38] Fix double free of video_device in mem2mem_testdev

2011-02-09 Thread Pawel Osciak
-0800) are available in the git repository at:  ssh://linuxtv.org/git/posciak/media_tree.git staging/for_v2.6.38rc Pawel Osciak (1):      [media] Fix double free of video_device in mem2mem_testdev drivers/media/video/mem2mem_testdev.c |    1 - 1 files changed, 0 insertions(+), 1 deletions

[GIT PATCHES for 2.6.39] Remove compatibility layer from multi-planar API documentation

2011-02-09 Thread Pawel Osciak
streaming mode (2011-02-02 12:06:14 -0200) are available in the git repository at: ssh://linuxtv.org/git/posciak/media_tree.git staging/for_v2.6.39 Pawel Osciak (1): [media] Remove compatibility layer from multi-planar API documentation Documentation/DocBook/v4l/planar-apis.xml | 35

Re: Mulling over multi-planar formats and videobuf2 for cx18

2011-02-27 Thread Pawel Osciak
CC's for each permutation applies. > > Such multiplanar image/data formats somewhat obviate the need to use the > seperate V4L2 device node for VBI when capturing video.  [I'd throw a > PCM audio data plane in there too, if I though I could get away with > it. ;) ] Those are all good ideas. It'd be great if we could do some more brainstorming, gather requirements for different devices and come up with an universal solution. -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC/PATCH 1/2] v4l: videobuf2: Handle buf_queue errors

2011-02-28 Thread Pawel Osciak
 return 0; > diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h > index 597efe6..3a92f75 100644 > --- a/include/media/videobuf2-core.h > +++ b/include/media/videobuf2-core.h > @@ -225,7 +225,7 @@ struct vb2_ops { >        int (*start_streaming)(struct vb2

Re: [RFC/PATCH 1/2] v4l: videobuf2: Handle buf_queue errors

2011-03-06 Thread Pawel Osciak
Hi Laurent, On Tue, Mar 1, 2011 at 02:54, Laurent Pinchart wrote: > Hi Pawel, > > On Monday 28 February 2011 16:44:38 Pawel Osciak wrote: >> Hi Laurent, >> A few questions from me below. I feel we need to talk about this >> change a bit more, it introduces so

Re: [PATCH 0/3] Another set of videobuf2 hotfixes

2011-03-12 Thread Pawel Osciak
to be desired as well. But as for the patches: Acked-by: Pawel Osciak -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] [media] sh_mobile_ceu_camera: Do not call vb2's mem_ops directly

2011-03-14 Thread Pawel Osciak
Use vb2_dma_contig_plane_paddr to retrieve a physical address for a plane instead of calling an internal mem_ops callback. Signed-off-by: Pawel Osciak --- drivers/media/video/sh_mobile_ceu_camera.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/media/video

[PATCH 2/2] [media] videobuf2-dma-contig: make cookie() return a pointer to dma_addr_t

2011-03-14 Thread Pawel Osciak
dma_addr_t may not fit into void* on some architectures. To be safe, make vb2_dma_contig_cookie() return a pointer to dma_addr_t and dereference it in vb2_dma_contig_plane_paddr() back to dma_addr_t. Signed-off-by: Pawel Osciak Reported-by: Hans Verkuil --- drivers/media/video/videobuf2-dma

Re: [Query] VIDIOC_QBUF and VIDIOC_STREAMON order

2011-03-14 Thread Pawel Osciak
on and periodically take a snapshot would be faster without having to call STREAMON anyway... -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] [media] vb2: vb2_poll() fix return values for file I/O mode

2011-03-20 Thread Pawel Osciak
poll() should be returning poll-specific error values, not E* errors. Signed-off-by: Pawel Osciak --- drivers/media/video/videobuf2-core.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/videobuf2-core.c b/drivers/media/video/videobuf2-core.c

[PATCH 2/2] [media] vb2: Handle return value from start_streaming callback

2011-03-20 Thread Pawel Osciak
Fix vb2 not handling return value from start_streaming() callback. Signed-off-by: Pawel Osciak --- drivers/media/video/videobuf2-core.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/videobuf2-core.c b/drivers/media/video/videobuf2-core.c

[PATCH] [media] Make 2.6.39 not 2.6.38 the version when Multi-planar API was added

2011-03-20 Thread Pawel Osciak
Multi-planar API was added to 2.6.39 version of Video for Linux 2 API. Signed-off-by: Pawel Osciak --- Documentation/DocBook/v4l/compat.xml | 13 - Documentation/DocBook/v4l/v4l2.xml | 13 ++--- 2 files changed, 6 insertions(+), 20 deletions(-) diff --git a

[GIT PULL for 2.6.39] videobuf2 fixes, docbook fix and update e-mail address

2011-03-20 Thread Pawel Osciak
18:09:02 -0300) are available in the git repository at: ssh://linuxtv.org/git/posciak/media_tree.git staging/for_v2.6.39 Pawel Osciak (4): [media] Make 2.6.39 not 2.6.38 the version when Multi-planar API was added Update Pawel Osciak's e-mail address. [media] vb2: vb2

RE: JPEG hw decoder

2010-07-29 Thread Pawel Osciak
e wrong on this though... Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v5 1/3] v4l: Add multi-planar API definitions to the V4L2 API

2010-07-30 Thread Pawel Osciak
uffer, together with video data. Signed-off-by: Pawel Osciak Signed-off-by: Kyungmin Park Reviewed-by: Marek Szyprowski --- drivers/media/video/v4l2-ioctl.c |2 + include/linux/videodev2.h| 126 +- 2 files changed, 126 insertions(+), 2 deletions(-)

[PATCH v5 0/3] Multi-planar video format and buffer support for the V4L2 API

2010-07-30 Thread Pawel Osciak
s of a buffer. Every mmap() call should be given the offsets provided in v4l2_plane structs. There is no need for those calls to be in any particular order. A v4l2_buffer changes state to mapped (V4L2_BUF_FLAG_MAPPED flag) only after all of its planes have been mmapped successfully. Best regar

[PATCH v5 3/3] v4l: Add compat functions for the multi-planar API

2010-07-30 Thread Pawel Osciak
Add multi-planar ioctl handling to the 32bit compatibility layer. Signed-off-by: Pawel Osciak Signed-off-by: Kyungmin Park --- drivers/media/video/v4l2-compat-ioctl32.c | 221 + 1 files changed, 190 insertions(+), 31 deletions(-) diff --git a/drivers/media/video

[PATCH v5 2/3] v4l: Add multi-planar ioctl handling code

2010-07-30 Thread Pawel Osciak
Add multi-planar API core ioctl handling and conversion functions. Signed-off-by: Pawel Osciak Signed-off-by: Kyungmin Park Reviewed-by: Marek Szyprowski --- drivers/media/video/v4l2-ioctl.c | 418 ++ include/media/v4l2-ioctl.h | 16 ++ 2 files

RE: [PATCH v5 0/3] Multi-planar video format and buffer support for the V4L2 API

2010-08-02 Thread Pawel Osciak
_format_mplane. Fourccs and other fields will be exactly the same. Only the location of those fields will differ, a v4l2_pix_format_mplane struct will have an array of v4l2_plane_pix_format of size one. Look at the fmt_sp_to_mp and fmt_mp_to_sp functions in v4l2-ioctl.c and it should become mo

RE: [PATCH v5 1/3] v4l: Add multi-planar API definitions to the V4L2 API

2010-08-02 Thread Pawel Osciak
Hi Hans, thank you for the review. >Hans Verkuil wrote: >On Friday 30 July 2010 10:49:41 Pawel Osciak wrote: >> @@ -157,9 +158,23 @@ enum v4l2_buf_type { >> /* Experimental */ >> V4L2_BUF_TYPE_VIDEO_OUTPUT_OVERLAY = 8, >> #endif >> +V4L

RE: [PATCH v5 2/3] v4l: Add multi-planar ioctl handling code

2010-08-02 Thread Pawel Osciak
Hi, >Hans Verkuil wrote: >On Friday 30 July 2010 10:49:42 Pawel Osciak wrote: >> static long __video_do_ioctl(struct file *file, >> unsigned int cmd, void *arg) >> { >> struct video_device *vfd = video_devdata(file); >> co

RE: [PATCH v3 1/8] ARM: Samsung: Add register definitions for Samsung S5P SoC camera interface

2010-08-02 Thread Pawel Osciak
Hello, >Kukjin Kim wrote: >Sylwester Nawrocki wrote: >> >> Add register definitions for the camera interface/video postprocessor >> contained in Samsung's S5P SoC series. >> >> Signed-off-by: Sylwester Nawrocki >> Signed-off-by: Kyungmin Park >

RE: [PATCH v3 1/8] ARM: Samsung: Add register definitions for Samsung S5P SoC camera interface

2010-08-02 Thread Pawel Osciak
>Russell King - ARM Linux wrote: >On Mon, Aug 02, 2010 at 12:32:20PM +0200, Pawel Osciak wrote: >> Well, some of them are indeed unused, but it's not an uncommon practice in >> kernel and might help future developers. > >On the other hand, arch/arm is getting soo big

[PATCH v6 0/3] Multi-planar video format and buffer support for the V4L2 API

2010-08-03 Thread Pawel Osciak
r API definitions to the V4L2 API [PATCH v6 2/3] v4l: Add multi-planar ioctl handling code [PATCH v6 3/3] v4l: Add compat functions for the multi-planar API Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe l

[PATCH v6 3/3] v4l: Add compat functions for the multi-planar API

2010-08-03 Thread Pawel Osciak
Add multi-planar ioctl handling to the 32bit compatibility layer. Signed-off-by: Pawel Osciak Signed-off-by: Kyungmin Park --- drivers/media/video/v4l2-compat-ioctl32.c | 221 + 1 files changed, 190 insertions(+), 31 deletions(-) diff --git a/drivers/media/video

[PATCH v6 2/3] v4l: Add multi-planar ioctl handling code

2010-08-03 Thread Pawel Osciak
Add multi-planar API core ioctl handling and conversion functions. Signed-off-by: Pawel Osciak Signed-off-by: Kyungmin Park Reviewed-by: Marek Szyprowski --- drivers/media/video/v4l2-ioctl.c | 418 ++ include/media/v4l2-ioctl.h | 16 ++ 2 files

[PATCH v6 1/3] v4l: Add multi-planar API definitions to the V4L2 API

2010-08-03 Thread Pawel Osciak
uffer, together with video data. Signed-off-by: Pawel Osciak Signed-off-by: Kyungmin Park Reviewed-by: Marek Szyprowski --- drivers/media/video/v4l2-ioctl.c |2 + include/linux/videodev2.h| 124 +- 2 files changed, 124 insertions(+), 2 deletions(-)

[GIT PATCHES FOR 2.6.36] Samsung fimc driver

2010-08-03 Thread Pawel Osciak
mode 100644 drivers/media/video/s5p-fimc/fimc-core.h create mode 100644 drivers/media/video/s5p-fimc/fimc-reg.c create mode 100644 drivers/media/video/s5p-fimc/regs-fimc.h Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list: send

RE: [PATCH 1/3 v2] media: Add a cached version of the contiguous video buffers

2010-08-04 Thread Pawel Osciak
d you elaborate more on this? How large are your buffers, can kmalloc really allocate them for you? I am not convinced how this is supposed to work reliably, especially in a long-running systems. Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Center -- To unsubscribe f

RE: [PATCH 1/3 v2] media: Add a cached version of the contiguous video buffers

2010-08-04 Thread Pawel Osciak
> Richard Röjfors wrote: >On 08/04/2010 09:55 AM, Pawel Osciak wrote: >> Hi Richard, >> >>> Richard Röjfors wrote: >>> This patch adds another init functions in the videobuf-dma-contig >>> which is named _cached in the end. It creates a buffer factory

RE: [PATCH 1/3 v2] media: Add a cached version of the contiguous video buffers

2010-08-04 Thread Pawel Osciak
>Richard Röjfors wrote: >On 08/04/2010 11:50 AM, Pawel Osciak wrote: >>> >>> How do you propose to allocate the buffers? They need to be contiguous >>> and using uncached memory gave really bad performance. >> >> 829440 bytes is a quite a lot and one c

[PATCH] v4l: s5p-fimc: Fix coding style issues

2010-08-06 Thread Pawel Osciak
Signed-off-by: Pawel Osciak Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-fimc/fimc-core.c | 36 + drivers/media/video/s5p-fimc/fimc-core.h | 30 +++-- 2 files changed, 44 insertions(+), 22 deletions(-) diff --git a/drivers/media

RE: [PATCH 1/3 v2] media: Add a cached version of the contiguous video buffers

2010-08-09 Thread Pawel Osciak
>Richard Röjfors wrote: >On 08/04/2010 12:34 PM, Pawel Osciak wrote: >>> Richard Röjfors wrote: >>> On 08/04/2010 11:50 AM, Pawel Osciak wrote: >>>>> >>>>> How do you propose to allocate the buffers? They need to be contiguous >&

Re: Linux Plumber's Conference: Call for Working Session Submissions

2010-08-20 Thread Pawel Osciak
or a topic about videobuf. If you think it needs any changes/corrections, please let me know. http://www.linuxplumbersconf.org/2010/ocw/proposals/915 -- Best regards, Pawel Osciak Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscr

[GIT PATCHES FOR 2.6.37] Multi-planar API extensions for V4L2

2010-08-25 Thread Pawel Osciak
v4l/multiplane-api Pawel Osciak (4): v4l: Add multi-planar API definitions to the V4L2 API v4l: Add multi-planar ioctl handling code v4l: Add compat functions for the multi-planar API v4l: fix copy sizes in compat32 for ext controls drivers/media/video/v4l2-compat-ioctl32

Re: [PATCH/RFCv4 0/6] The Contiguous Memory Allocator framework

2010-08-25 Thread Pawel Osciak
nd assume that it is close to impossible to have a contiguous allocator merged. Your help and support would be very much appreciated. Working in embedded Linux for some time now, I feel that the need is definitely there and is quite substantial. -- Best regards, Pawel Osciak Linux Platform Group

Re: [PATCH/RFCv4 0/6] The Contiguous Memory Allocator framework

2010-08-25 Thread Pawel Osciak
uld be any other allocator for that matter. -- Best regards, Pawel Osciak Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://v

[PATCH v1 3/7] v4l: mem2mem: port to videobuf2

2010-09-09 Thread Pawel Osciak
Port memory-to-memory framework to videobuf2 framework. Signed-off-by: Pawel Osciak Signed-off-by: Kyungmin Park --- drivers/media/video/Kconfig|3 +- drivers/media/video/v4l2-mem2mem.c | 185 ++-- include/media/v4l2-mem2mem.h | 49

[PATCH v1 5/7] v4l: videobuf2: add DMA coherent allocator

2010-09-09 Thread Pawel Osciak
Add an implementation of DMA coherent memory allocator and handling routines for videobuf2, implemented on top of dma_alloc_coherent() call. Signed-off-by: Pawel Osciak Signed-off-by: Kyungmin Park --- drivers/media/video/Kconfig |5 + drivers/media/video/Makefile

[PATCH v1 4/7] v4l: videobuf2: add vmalloc allocator

2010-09-09 Thread Pawel Osciak
Add an implementation of contiguous virtual memory allocator and handling routines for videobuf2, implemented on top of vmalloc()/vfree() calls. Signed-off-by: Pawel Osciak Signed-off-by: Kyungmin Park --- drivers/media/video/Kconfig |5 + drivers/media/video/Makefile

[PATCH/RFC v1 0/7] Videobuf2 framework

2010-09-09 Thread Pawel Osciak
d on this topic: - Laurent Pinchart "videobuf - the good, the bad and the ugly" http://linuxtv.org/downloads/presentations/summit_jun_2010/20100614-v4l2_summit-videobuf.pdf - Pawel Osciak "Future of the videobuf framework" http://linuxtv.org/downloads/presentations/summit_jun_2010/Vi

[PATCH v1 7/7] v4l: videobuf2: add CMA allocator

2010-09-09 Thread Pawel Osciak
Add support for the CMA contiguous memory allocator to videobuf2. Signed-off-by: Pawel Osciak Signed-off-by: Kyungmin Park --- drivers/media/video/Kconfig |5 + drivers/media/video/Makefile|2 + drivers/media/video/videobuf2-cma.c | 250

[PATCH v1 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-09-09 Thread Pawel Osciak
nging the high-level buffer management functions and API. The framework provides: - implementations of streaming I/O V4L2 ioctls and file operations - high-level video buffer, video queue and state management functions - video buffer memory allocation and management Signed-off-by: Pawel Osciak S

[PATCH v1 6/7] v4l: vivi: port to videobuf2

2010-09-09 Thread Pawel Osciak
Make vivi use videobuf2 in place of videobuf. Signed-off-by: Pawel Osciak Signed-off-by: Kyungmin Park --- drivers/media/video/Kconfig |2 +- drivers/media/video/vivi.c | 248 +-- 2 files changed, 124 insertions(+), 126 deletions(-) diff --git a

[PATCH v1 2/7] v4l: videobuf2: add generic memory handling routines

2010-09-09 Thread Pawel Osciak
Add generic memory handling routines for userspace pointer handling, contiguous memory verification and mapping. Signed-off-by: Pawel Osciak Signed-off-by: Kyungmin Park --- drivers/media/video/Kconfig|3 + drivers/media/video/Makefile |2 + drivers/media/video

Re: [PATCH/RFC v1 0/7] Videobuf2 framework

2010-09-09 Thread Pawel Osciak
On 09/09/2010 06:19 PM, Pawel Osciak wrote: Hello, These patches add a new driver framework for Video for Linux 2 driver - Videobuf2. Sorry, I failed to mention that these patches depend on the multi-planar API extensions, but do not require multi-planar support in drivers and in vivi

Re: [PATCH/RFC v1 0/7] Videobuf2 framework

2010-09-09 Thread Pawel Osciak
Hello Mauro, On 09/10/2010 02:53 AM, Mauro Carvalho Chehab wrote: Em 09-09-2010 06:19, Pawel Osciak escreveu: > Hello, > > These patches add a new driver framework for Video for Linux 2 driver > - Videobuf2. I didn't test the patches, but, from a source code review, they see

[GIT FIXES FOR 2.6.36] mem2mem_testdev fixes

2010-09-10 Thread Pawel Osciak
-2.6-samsung v4l/fixes_for_v2.6.36 Pawel Osciak (2): v4l: mem2mem_testdev: fix errorenous comparison v4l: mem2mem_testdev: add missing release for video_device drivers/media/video/mem2mem_testdev.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) -- Best regards, Pawel

Re: [PATCH v1 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-09-15 Thread Pawel Osciak
Hello Mauro, Thank you for the review. Please see my responses inline. Please also note that my e-mail address has changed. On 09/09/2010 07:29 PM, Mauro Carvalho Chehab wrote: Em 09-09-2010 06:19, Pawel Osciak escreveu: Videobuf2 is a Video for Linux 2 API-compatible driver framework for

Re: [PATCH v1 7/7] v4l: videobuf2: add CMA allocator

2010-09-15 Thread Pawel Osciak
not always call VIDIOC_REQBUFS(0) after finishing. If an application just closes the file descriptor (or even dies), we need a way to clean up the memory. -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a mess

Re: [PATCH v1 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-09-29 Thread Pawel Osciak
Hi Hans, Big thanks for the review! On 09/25/2010 07:27 AM, Hans Verkuil wrote: > Hi Pawel, > > I finally had some time for a code review: > > On Thursday, September 09, 2010 11:19:42 Pawel Osciak wrote: >> Videobuf2 is a Video for Linux 2 API-compatible driver framew

Re: V4L/DVB/IR patches pending merge

2010-10-23 Thread Pawel Osciak
lease help me to clean the list. >                == Videobuf2 series == > > Oct,20 2010: [7/7] v4l: videobuf2: add CMA allocator                           >      http://patchwork.kernel.org/patch/267521  Pawel Osciak > > Oct,20 2010: [2/7] v4l: videobuf2: add gen

[PATCH/RFC v1] Mem-to-mem device framework

2009-11-26 Thread Pawel Osciak
e support - transaction/abort timeouts - extracting more common code to the framework? (e.g. per-queue format details, transaction length, etc.) Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubsc

[PATCH 1/2] Added memory-to-memory device helper framework for V4L2.

2009-11-26 Thread Pawel Osciak
. Although no such devices are present in the V4L2 framework, a demand for such a model exists, e.g. for 'resizer devices'. Signed-off-by: Pawel Osciak Signed-off-by: Marek Szyprowski Reviewed-by: Kyungmin Park --- drivers/media/video/Kconfig|4 + drivers/media/video/Makefile

[PATCH 2/2] Added a mem-to-mem V4L2 framework test device.

2009-11-26 Thread Pawel Osciak
Signed-off-by: Pawel Osciak Signed-off-by: Marek Szyprowski Reviewed-by: Kyungmin Park --- drivers/media/video/Kconfig |7 + drivers/media/video/Makefile |1 + drivers/media/video/mem2mem_testdev.c | 1050 + 3 files changed, 1058

[EXAMPLE v1] Mem-to-mem userspace test application.

2009-11-26 Thread Pawel Osciak
processed. Signed-off-by: Pawel Osciak Reviewed-by: Kyungmin Park --- --- /dev/null 2009-11-17 07:51:25.574927259 +0100 +++ process-vmalloc.c 2009-11-26 11:00:26.0 +0100 @@ -0,0 +1,420 @@ +/** + * process-vmalloc.c + * Capture+output (process) V4L2 device tester. + * + * Pawel Osciak

Syncing videobuf buffers before an operation

2009-12-03 Thread Pawel Osciak
e to an agreement on this as well. Thank you! Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH/RFC v2 0/2] Mem-to-mem device framework

2009-12-23 Thread Pawel Osciak
- - read/write support - transaction/abort timeouts - extracting more common code to the framework? (e.g. per-queue format details, transaction length, etc.) Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Center -- To unsubsc

[PATCH v2 1/2] V4L: Add memory-to-memory device helper framework for V4L2.

2009-12-23 Thread Pawel Osciak
. Although no such devices are present in the V4L2 framework, a demand for such a model exists, e.g. for 'resizer devices'. This patch also adds a separate kconfig submenu for mem-to-mem V4L devices. Signed-off-by: Pawel Osciak Signed-off-by: Marek Szyprowski Reviewed-by: Kyu

[PATCH v2 2/2] V4L: Add a mem-to-mem V4L2 framework test device.

2009-12-23 Thread Pawel Osciak
operation (via the mem2mem framework). Signed-off-by: Pawel Osciak Signed-off-by: Marek Szyprowski Reviewed-by: Kyungmin Park --- drivers/media/video/Kconfig | 10 + drivers/media/video/Makefile |1 + drivers/media/video/mem2mem_testde

[EXAMPLE v2] Mem-to-mem userspace test application.

2009-12-23 Thread Pawel Osciak
processed. Tested on a 800x480 framebuffer with the following script: #!/bin/bash for i in {0..3} do ((x=$i * 100)) ./process-vmalloc 0 $(($i + 1)) $((2000 - $i * 500)) $((($i+1) * 4)) \ $x $x 100 100 & done Signed-off-by: Pawel Osciak Reviewed-by: Kyungmin Park --- --- /dev/

[PATCH 1/2] [ARM] samsung-rotator: Add rotator device platform definitions.

2009-12-23 Thread Pawel Osciak
Add S3C/S5P rotator platform device. Signed-off-by: Pawel Osciak Signed-off-by: Sylwester Nawrocki Reviewed-by: Marek Szyprowski Reviewed-by: Kyungmin Park --- arch/arm/mach-s3c6400/include/mach/map.h |2 + arch/arm/plat-s3c/Kconfig |5 ++ arch/arm/plat-s3c

[EXAMPLE] S3C/S5P image rotator test application

2009-12-23 Thread Pawel Osciak
(c) 2009 Samsung Electronics Co., Ltd. + * Pawel Osciak, + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by the + * Free Software Foundation; either version 2 of the + * License, or (at your option

[PATCH 0/2] [ARM] Add Samsung S3C/S5P image rotator driver

2009-12-23 Thread Pawel Osciak
] [ARM] samsung-rotator: Add rotator device platform definitions. [PATCH 2/2] [ARM] samsung-rotator: Add Samsung S3C/S5P rotator driver [EXAMPLE] S3C/S5P image rotator test application Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list:

[PATCH 2/2] [ARM] samsung-rotator: Add Samsung S3C/S5P rotator driver

2009-12-23 Thread Pawel Osciak
. Signed-off-by: Pawel Osciak Signed-off-by: Sylwester Nawrocki Reviewed-by: Marek Szyprowski Reviewed-by: Kyungmin Park --- drivers/media/video/Kconfig | 10 + drivers/media/video/Makefile |2 + drivers/media/video/samsung-rotator/Makefile |1

[PATCH/RFC v2.1 0/2] Mem-to-mem device framework

2009-12-23 Thread Pawel Osciak
--- Future work --- - read/write support - transaction/abort timeouts - extracting more common code to the framework? (e.g. per-queue format details, transaction length, etc.) Best regards

[PATCH v2.1 2/2] V4L: Add a mem-to-mem V4L2 framework test device.

2009-12-23 Thread Pawel Osciak
operation (via the mem2mem framework). Signed-off-by: Pawel Osciak Signed-off-by: Marek Szyprowski Reviewed-by: Kyungmin Park --- drivers/media/video/Kconfig | 14 + drivers/media/video/Makefile |1 + drivers/media/video/mem2mem_testde

[PATCH v2.1 1/2] V4L: Add memory-to-memory device helper framework for V4L2.

2009-12-23 Thread Pawel Osciak
. Although no such devices are present in the V4L2 framework, a demand for such a model exists, e.g. for 'resizer devices'. This patch also adds a separate kconfig submenu for mem-to-mem V4L devices. Signed-off-by: Pawel Osciak Signed-off-by: Marek Szyprowski Reviewed-by: Kyu

[EXAMPLE v2] Mem-to-mem userspace test application.

2009-12-23 Thread Pawel Osciak
processed. Tested on a 800x480 framebuffer with the following script: #!/bin/bash for i in {0..3} do ((x=$i * 100)) ./process-vmalloc 0 $(($i + 1)) $((2000 - $i * 500)) $((($i+1) * 4)) \ $x $x 100 100 & done Signed-off-by: Pawel Osciak Reviewed-by: Kyungmin Park --- --- /dev/

RE: [PATCH/RFC v2.1 0/2] Mem-to-mem device framework

2009-12-28 Thread Pawel Osciak
s as part of the meta-data associated with the image. There may well > be more of those. This got pushed back but now after m2m, it's become next task on my list. I expect to be posting patches in a week or two, hopefully. I understand that you'd like to make the pointer in the union

[PATCH/RFC v1 0/1] Buffer sync for non cache-coherent architectures

2010-01-19 Thread Pawel Osciak
ged. We will be posting cache coherency patches for dma-contig in the near future. Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.ker

[PATCH v1 1/1] V4L: Add sync before a hardware operation to videobuf.

2010-01-19 Thread Pawel Osciak
and handled by each memory type-specific module. Whether it is a sync before or after the operation can be determined from the current buffer state: VIDEOBUF_DONE and VIDEOBUF_ERROR indicate a sync called after an operation. Signed-off-by: Pawel Osciak Reviewed-by: Marek Szyprowski Reviewed-by

Re: [PATCH 2/2] [media] videobuf2-dma-contig: make cookie() return a pointer to dma_addr_t

2011-03-21 Thread Pawel Osciak
Hi Guennadi, On Mon, Mar 21, 2011 at 03:47, Guennadi Liakhovetski wrote: > On Mon, 14 Mar 2011, Pawel Osciak wrote: > >> dma_addr_t may not fit into void* on some architectures. To be safe, make >> vb2_dma_contig_cookie() return a pointer to dma_addr_t and de

Re: vb2_plane 'mapped' signed bit field

2011-04-03 Thread Pawel Osciak
                 *mem_priv; >       int                     mapped:1; > }; > > that probably should be an unsigned int (I can see code that assigns > 1 to it that just won't fit). Hi David, Thanks for the report, will fix soon. -- Best regards, Pawel Osciak -- To unsubscribe from this lis

Re: [PATCH/RFC 0/4] V4L: new ioctl()s to support multi-sized video-buffers

2011-04-03 Thread Pawel Osciak
complicates checks in many places and I don't think is worth it... - I understand SUBMIT is optional? - Could you give an example of how this could be used in an application? -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line "unsubscribe linux-media" in t

Re: [PATCH/RFC 2/4 v2] V4L: add videobuf2 helper functions to support multi-size video-buffers

2011-04-03 Thread Pawel Osciak
_ops { >        int (*queue_setup)(struct vb2_queue *q, unsigned int *num_buffers, >                           unsigned int *num_planes, unsigned long sizes[], >                           void *alloc_ctxs[]); > +       int (*queue_add)(struct vb2_queue *q, > +                        

[PATCH 1/3] [media] vb2: update and fix interface documentation

2011-04-03 Thread Pawel Osciak
Update documentation for videobuf2 driver callbacks and memory operations. Signed-off-by: Pawel Osciak --- include/media/videobuf2-core.h | 146 +--- 1 files changed, 91 insertions(+), 55 deletions(-) diff --git a/include/media/videobuf2-core.h b/include

[PATCH 2/3] [media] vb2: use unsigned int for the `mapped' bitfield

2011-04-03 Thread Pawel Osciak
Signed-off-by: Pawel Osciak Reported-by: David Alan Gilbert --- include/media/videobuf2-core.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h index 4c1e91f..f3bdbb2 100644 --- a/include/media/videobuf2

[PATCH 3/3] [media] vb2: prevent drivers from requesting too many buffers/planes.

2011-04-03 Thread Pawel Osciak
Add a sanity check to make sure drivers do not adjust the number of buffers or planes above the supported limit on reqbufs. Signed-off-by: Pawel Osciak --- drivers/media/video/videobuf2-core.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/media/video

vb2: stop_streaming() callback redesign

2011-04-03 Thread Pawel Osciak
[PATCH 4/5] [media] sh_mobile_ceu_camera: remove stop_streaming() callback return [PATCH 5/5] [media] mx3_camera: remove stop_streaming() callback return -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message

[PATCH 1/5] [media] vb2: redesign the stop_streaming() callback and make it obligatory

2011-04-03 Thread Pawel Osciak
. Signed-off-by: Pawel Osciak --- drivers/media/video/videobuf2-core.c | 16 ++-- include/media/videobuf2-core.h | 16 +++- 2 files changed, 21 insertions(+), 11 deletions(-) diff --git a/drivers/media/video/videobuf2-core.c b/drivers/media/video/videobuf2-core.c

[PATCH 4/5] [media] sh_mobile_ceu_camera: remove stop_streaming() callback return

2011-04-03 Thread Pawel Osciak
The stop_streaming() callback does not return a value anymore. Signed-off-by: Pawel Osciak --- drivers/media/video/sh_mobile_ceu_camera.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/sh_mobile_ceu_camera.c b/drivers/media/video

[PATCH 5/5] [media] mx3_camera: remove stop_streaming() callback return

2011-04-03 Thread Pawel Osciak
The stop_streaming() callback does not return a value anymore. Signed-off-by: Pawel Osciak --- drivers/media/video/mx3_camera.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/mx3_camera.c b/drivers/media/video/mx3_camera.c index 8630c0c..1703b93

[PATCH 3/5] [media] s5p-fimc: remove stop_streaming() callback return

2011-04-03 Thread Pawel Osciak
The stop_streaming() callback does not return a value anymore. Signed-off-by: Pawel Osciak --- drivers/media/video/s5p-fimc/fimc-capture.c |4 ++-- drivers/media/video/s5p-fimc/fimc-core.c|4 +--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/media/video/s5p

[PATCH 2/5] [media] vivi: adapt to the new stop_streaming() callback behavior

2011-04-03 Thread Pawel Osciak
Drivers are no longer required to call vb2_buffer_done() for all buffers they have queued in stop_streaming(). The return value for stop_streaming() has also been removed. Signed-off-by: Pawel Osciak --- drivers/media/video/vivi.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions

Re: vb2: stop_streaming() callback redesign

2011-04-05 Thread Pawel Osciak
Hi Laurent, On Mon, Apr 4, 2011 at 03:27, Laurent Pinchart wrote: > Hi Pawel, > > On Monday 04 April 2011 01:51:05 Pawel Osciak wrote: >> Hi, >> >> This series implements a slight redesign of the stop_streaming() callback >> in vb2. The callback has been made obl

Re: [PATCH 1/5] [media] vb2: redesign the stop_streaming() callback and make it obligatory

2011-04-05 Thread Pawel Osciak
On Sun, Apr 3, 2011 at 22:49, Marek Szyprowski wrote: > Hello, > > On Monday, April 04, 2011 1:51 AM Pawel Osciak wrote: > >> Drivers are now required to implement the stop_streaming() callback >> to ensure that all ongoing hardware operations are finished and their &g

Re: [PATCH 1/5] [media] vb2: redesign the stop_streaming() callback and make it obligatory

2011-04-05 Thread Pawel Osciak
Hi again Marek On Sun, Apr 3, 2011 at 22:49, Marek Szyprowski wrote: > Hello, > > On Monday, April 04, 2011 1:51 AM Pawel Osciak wrote: > >> Drivers are now required to implement the stop_streaming() callback >> to ensure that all ongoing hardware operations are finishe

  1   2   3   4   >