On Mon, Aug 22, 2016 at 02:17:28PM +0200, Hans Verkuil wrote:
> On 08/19/2016 12:23 PM, Sakari Ailus wrote:
> > The struct cdev embedded in struct media_devnode contains its own kobj.
> > Instead of trying to manage its lifetime separately from struct
> > media_devnode, make t
Hi Hans,
On Mon, Aug 22, 2016 at 02:40:39PM +0200, Hans Verkuil wrote:
> On 08/19/2016 12:23 PM, Sakari Ailus wrote:
> > devm functions are fine for managing resources that are directly related
> > to the device at hand and that have no other dependencies. However, a
> > p
On Mon, Aug 22, 2016 at 05:02:31PM +0300, Sakari Ailus wrote:
> Hi Hans,
>
> On Mon, Aug 22, 2016 at 02:40:39PM +0200, Hans Verkuil wrote:
> > On 08/19/2016 12:23 PM, Sakari Ailus wrote:
> > > devm functions are fine for managing resources that are directly related
> &g
get(dev, "enable", GPIOD_OUT_HIGH);
> + if (IS_ERR(ov5645->enable_gpio)) {
> + dev_err(dev, "cannot get enable gpio\n");
> + return PTR_ERR(ov5645->enable_gpio);
> + }
> +
> + ov5645->rst_gpio =
v4l2_err(&pcdev->v4l2_dev, "DMA does not support INTERLEAVE\n");
> + dev_err(&pdev->dev, "DMA does not support INTERLEAVE\n");
> goto rel_dma;
> }
>
Acked-by: Sakari Ailus
--
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMP
nt standby : 1;
> + unsigned int standby : 1;
I guess a bool would be a better match for this one. It's what it's used
for. [01] assignments should be replaced by boolean values.
I can submit a patch for this as well, up to you.
> };
>
> static int ad5820_write
Hi Todor,
On Wed, Aug 24, 2016 at 06:24:31PM +0300, Todor Tomov wrote:
> Hi Sakari,
>
> Thanks a lot for the time spent to review the driver!
You're welcome! :-)
> I have a few responses bellow.
>
>
> On 08/24/2016 01:17 PM, Sakari Ailus wrote:
> > Hi Todor,
Hi Todor,
On Thu, Aug 25, 2016 at 04:30:33PM +0300, Todor Tomov wrote:
> Hi Sakari, Rob,
>
> On 08/25/2016 10:18 AM, Sakari Ailus wrote:
> > Hi Todor,
> >
> > On Wed, Aug 24, 2016 at 06:24:31PM +0300, Todor Tomov wrote:
> >> Hi Sakari,
> >>
>
The release callback is only used to print a debug message. Drop it. (It
will be re-introduced later in a different form.)
Signed-off-by: Sakari Ailus
---
drivers/media/media-device.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/media/media-device.c b/drivers/media/media
Now that the media device can be allocated dynamically, drivers have no
longer a way to conveniently obtain the driver private data structure.
Provide one again in the form of a private pointer passed to the
media_device_alloc() function.
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
media_devnode.dev kobj's release callback.
Signed-off-by: Sakari Ailus
---
drivers/media/media-devnode.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/media/media-devnode.c b/drivers/media/media-devnode.c
index 7481c96..a8302fc 100644
--- a/drivers/media/
release the media device by calling
media_device_put() rather than media_device_cleanup().
Signed-off-by: Sakari Ailus
---
drivers/media/media-device.c | 13 +
include/media/media-device.h | 31 +++
2 files changed, 44 insertions(+)
diff --git a/drivers
The media device itself will be unregistered based on it being unbound and
driver's remove callback being called. The graph objects themselves may
still be in use; rely on the media device release callback to release
them.
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
---
drivers/
Call media_devnode_init() from media_device_init(). This has the effect of
creating a struct device for the media_devnode before it is registered,
making it possible to obtain a reference to it for e.g. video devices.
Signed-off-by: Sakari Ailus
---
drivers/media/media-device.c | 26
The release callback may be used by the driver to signal the release of
the media device. This way the lifetime of the driver's own memory
allocations may be made dependent on that of the media device.
Signed-off-by: Sakari Ailus
---
drivers/media/media-device.c | 4
include/media/
The struct device of the media device driver (i.e. not that of the media
devnode) is pointed to by the media device. The struct device pointer is
mostly used for debug prints.
Ensure it will stay around as long as the media device does.
Signed-off-by: Sakari Ailus
---
drivers/media/media
Use the media device release callback to release the isp device's data
structure. This approach has the benefit of not releasing memory which may
still be accessed through open file handles whilst the isp driver is being
unbound.
Signed-off-by: Sakari Ailus
---
drivers/media/platform/oma
will result in accessing released (and potentially reallocated)
memory.
Instead, rely on the media device which will stick around until all users
are gone.
Signed-off-by: Sakari Ailus
---
drivers/media/platform/omap3isp/isp.c | 38 ---
drivers/media/platform
The video device depends on the existence of its media device --- if there
is one. Acquire a reference to it.
Signed-off-by: Sakari Ailus
---
drivers/media/v4l2-core/v4l2-dev.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-dev.c
Use the new media_device_alloc() API to allocate and release the media
device.
Signed-off-by: Sakari Ailus
---
drivers/media/platform/omap3isp/isp.c | 24 +---
drivers/media/platform/omap3isp/isp.h | 2 +-
drivers/media/platform/omap3isp/ispvideo.c | 2 +-
3
As the call paths of the functions in question will change, move them
around in anticipation of that. No other changes.
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
---
drivers/media/media-device.c | 56 ++--
1 file changed, 28 insertions(+), 28
media-devnode: fix namespace mess")
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
---
drivers/media/media-device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
index 8bdc316..a431775 100644
--- a/drivers/m
This reverts commit 5b28dde51d0c ("[media] media: fix use-after-free in
cdev_put() when app exits after driver unbind"). The commit was part of an
original patchset to avoid crashes when an unregistering device is in use.
Signed-off-by: Sakari Ailus
---
drivers/media/media-devi
This reverts commit 6f0dd24a084a ("[media] media: fix media devnode
ioctl/syscall and unregister race"). The commit was part of an original
patchset to avoid crashes when an unregistering device is in use.
Signed-off-by: Sakari Ailus
---
drivers/media/media-devi
media device is allocated.
Don't distribute the effects of these changes yet. Add media_device_get()
and media_device_put() first.
Signed-off-by: Sakari Ailus
---
drivers/media/media-device.c | 18 +-
drivers/media/media-devnode.c | 17 +++--
include/media/
From: Sakari Ailus
Allow allocating the media device dynamically. As the struct media_device
embeds struct media_devnode, the lifetime of that object is that same than
that of the media_device.
Signed-off-by: Sakari Ailus
---
drivers/media/media-device.c | 15 +++
include/media
Drivers should no longer directly allocate media_device but rely on
media_device_alloc(), media_device_get() and media_device_put() instead.
Deprecate media_device_init() and media_device_cleanup().
Signed-off-by: Sakari Ailus
---
include/media/media-device.h | 8
1 file changed, 8
This reverts commit a087ce704b80 ("[media] media-device: dynamically
allocate struct media_devnode"). The commit was part of an original
patchset to avoid crashes when an unregistering device is in use.
Signed-off-by: Sakari Ailus
---
drivers/media/media-device.c
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
---
drivers/media/media-device.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
index a1cd50f..8bdc316 100644
--- a/drivers/media/media-device.c
+++ b/drivers
Hi folks,
This is the third version of the RFC set to fix referencing in media
devices.
The lifetime of the media device (and media devnode) is now bound to that
of struct device embedded in it and its memory is only released once the
last reference is gone: unregistering is simply unregistering,
lude/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index 724f43e69d03..d1ac0250a966 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -143,6 +143,7 @@ enum v4l2_buf_type {
> V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE = 10,
>
The clock may be provided by a driver which is yet to probe.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/smiapp/smiapp-core.c
b/drivers/media/i2c/smiapp/smiapp-core.c
index 92a6859
This is really configuration to the driver originating from DT or
elsewhere. Do not call it platform data.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 140
drivers/media/i2c/smiapp/smiapp-quirk.c | 4 +-
drivers/media/i2c/smiapp
Switch from the old gpio API to the new descriptor based gpiod API.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 28 +++-
drivers/media/i2c/smiapp/smiapp.h | 1 +
2 files changed, 16 insertions(+), 13 deletions(-)
diff --git a/drivers
From: Sakari Ailus
Unify enforced 8-bit read access with that based on actual need.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-regs.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/media/i2c/smiapp/smiapp-regs.c
b
Hi all,
These patches contain cleanups for the smiapp driver and return
-EPROBE_DEFER if getting the clock fails.
--
Kind regards,
Sakari
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http:
The data may now be const as well.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-quirk.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/media/i2c/smiapp/smiapp-quirk.c
b/drivers/media/i2c/smiapp/smiapp-quirk.c
index d7e22bc..cb128ea
Hi Sebastian,
Thanks for the review!
On 08/31/16 15:09, Sebastian Reichel wrote:
> Hi Sakari,
>
> On Wed, Aug 31, 2016 at 10:42:05AM +0300, Sakari Ailus wrote:
>> -if (gpio_is_valid(sensor->hwcfg->xshutdown)) {
>> +if (client->dev.of_node) {
>
The clock may be provided by a driver which is yet to probe. Print the
actual error code as well.
Signed-off-by: Sakari Ailus
---
since v1:
- Add printing of the original error code
drivers/media/i2c/smiapp/smiapp-core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a
tion of creating another format in that case.
>
> Or do I have to make a new NV16PAD format that allows such padding?
>
> I am in favor of extending the NV16 specification since I believe it
> makes sense, but I want to know what others think.
--
Regards,
Sakari Ailus
e-mail: sa
Switch from the old gpio API to the new descriptor based gpiod API.
Signed-off-by: Sakari Ailus
---
- Remove xshutdown field in smiapp_hwconfig, and SMIAPP_NO_XSHUTDOWN macro
drivers/media/i2c/smiapp/smiapp-core.c | 36 +++---
drivers/media/i2c/smiapp/smiapp.h
The clock framework is generally so well supported that there's no reason
to keep this one around.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 49 --
include/media/i2c/smiapp.h | 2 --
2 files changed, 17 inser
Switch from the old gpio API to the new descriptor based gpiod API.
Signed-off-by: Sakari Ailus
---
since v1.1:
- Return the error if devm_gpiod_get_optional() fails. NULL is returned if
there's no GPIO defined.
- No debug print is performed on lack of the GPIO. The GPIO framework
al
in the git repository at:
ssh://linuxtv.org/git/sailus/media_tree.git smiapp
for you to fetch changes up to e5523b3e420ea19172e364bb6f10ce6eeec61efc:
smiapp: Remove set_xclk() callback from hwconfig (2016-09-01 12:42:13 +0300)
--------
Sa
Huomenta!
On Fri, Sep 02, 2016 at 12:22:42AM +0300, Laurent Pinchart wrote:
> Hi Sakari,
>
> On Monday 29 Aug 2016 12:13:40 Sakari Ailus wrote:
> > On Wed, Aug 17, 2016 at 03:20:27PM +0300, Laurent Pinchart wrote:
> > > The metadata buffer type is used to transfer me
rmat` ioctls applications set the ``type`` of the
s/of/field of/
?
> :ref:`v4l2_format ` structure to ``V4L2_BUF_TYPE_META_CAPTURE``
> and use the :ref:`v4l2_meta_format ` ``meta`` member of the
> ``fmt`` union as needed per the desired operation. Both drivers and
> a
; Signed-off-by: Laurent Pinchart
> Tested-by: Guennadi Liakhovetski
Acked-by: Sakari Ailus
--
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vg
//linuxtv.org/git/sailus/media_tree.git media-ioctl-rework
for you to fetch changes up to 0412ff9e1e3ca06328e62366ac11c987a6869b46:
media: Add flags to tell whether to take graph mutex for an IOCTL (2016-09-05
10:03:55 +0300)
----
Sa
The driver used integers for what boolean would have been a better fit.
Use boolean instead.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/ad5820.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820
The number of high order bits in samples was documented to be 6 for 12-bit
data. This is clearly wrong, fix it.
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
---
Documentation/media/uapi/v4l/pixfmt-srggb12.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
The codes will be called:
MEDIA_BUS_FMT_SBGGR16_1X16
MEDIA_BUS_FMT_SGBRG16_1X16
MEDIA_BUS_FMT_SGRBG16_1X16
MEDIA_BUS_FMT_SRGGB16_1X16
Signed-off-by: Sakari Ailus
---
Documentation/media/uapi/v4l/subdev-formats.rst | 290 +++-
include/uapi
Hi folks,
Here's the fourth version of the new raw bayer format definition patchset.
On Mauro's request, I've dropped the patches adding the new pixel formats
as they're not being used in a driver now. I'm keeping these patches
around in order to later on merge them once needed:
https://git.linu
- Explicitly state that the most significant n bits are zeroed on 10 and
12 bpp formats.
- Remove extra comma from the last entry of the format list
- Add a missing colon before a list
- Use figures versus word numerals consistently
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
SMIA++ supports 14 and 16 bits per pixel formats as well. Add support to
these formats in the driver.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 8
drivers/media/i2c/smiapp/smiapp.h | 2 +-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a
From: Jouni Ukkonen
The codes will be called:
MEDIA_BUS_FMT_SBGGR14_1X14
MEDIA_BUS_FMT_SGBRG14_1X14
MEDIA_BUS_FMT_SGRBG14_1X14
MEDIA_BUS_FMT_SRGGB14_1X14
Signed-off-by: Jouni Ukkonen
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
---
Documentation/media
pixelformat currently. The sampling precision is
understood to be 16 bits in all current cases.
Remove the note on sampling precision.
Signed-off-by: Sakari Ailus
Acked-by: Lad, Prabhakar
---
Documentation/media/uapi/v4l/pixfmt-sbggr16.rst | 5 -
1 file changed, 5 deletions(-)
diff --git a
byte and third and fourth least significant bits and so on.
Signed-off-by: Sakari Ailus
Acked-by: Aviv Greenberg
Acked-by: Hans Verkuil
---
Documentation/media/uapi/v4l/pixfmt-srggb10p.rst | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/Documentation/media
The other raw bayer formats had a single sample depth dependent definition
whereas the 8-bit formats had one page for each. Unify the documentation
of the 8-bit formats.
Signed-off-by: Sakari Ailus
---
Documentation/media/uapi/v4l/pixfmt-rgb.rst| 3 -
Documentation/media/uapi/v4l/pixfmt
-06 14:46:36
+0300)
Jouni Ukkonen (1):
media: Add 1X14 14-bit raw bayer media bus code definitions
Sakari Ailus (7):
doc-rst: Correct the ordering of LSBs of the 10-bit raw packed formats
doc-rst: Fix number of
ice.h | 16
5 files changed, 33 insertions(+), 12 deletions(-)
--
Kind regards,
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@
repository at:
ssh://linuxtv.org/git/sailus/media_tree.git ad5820
for you to fetch changes up to 021a6d55696421194b72fbc3c6abc50b7f3f1dc4:
ad5820: Use bool for boolean values (2016-09-06 15:23:46 +0300)
Sakari Ailus (1):
ad5820
This allows determining the number of pads in the entity based on the
sensor.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/media/i2c/smiapp/smiapp-core.c
b/drivers/media/i2c/smiapp
Hi,
This set further cleans up the smiapp driver and prepares for later
changes.
--
Kind regards,
Sakari
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.
Instead, calculate how much is needed and then allocate the memory
dynamically.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 24 ++--
drivers/media/i2c/smiapp/smiapp.h | 8 ++--
2 files changed, 20 insertions(+), 12 deletions(-)
diff
The same pixel array size is required for the active format of each
sub-device sink pad and try format of each sink pad of each opened file
handle as well as for the native size rectangle.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 39
onger
exists.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 53 --
1 file changed, 19 insertions(+), 34 deletions(-)
diff --git a/drivers/media/i2c/smiapp/smiapp-core.c
b/drivers/media/i2c/smiapp/smiapp-core.c
index 7a25969..27b48f3 100644
Simplify smiapp_init() by moving the initialisation of individual
sub-devices to a separate function.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 108 +++--
1 file changed, 49 insertions(+), 59 deletions(-)
diff --git a/drivers/media/i2c
Remove the loop in sub-device registration and create each sub-device
explicitly instead.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 82 ++
1 file changed, 43 insertions(+), 39 deletions(-)
diff --git a/drivers/media/i2c/smiapp
Define the number of pads explicitly in initialising the sub-devices.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/media/i2c/smiapp/smiapp-core.c
b/drivers/media/i2c/smiapp
; Signed-off-by: Laurent Pinchart
> Tested-by: Kieran Bingham
Acked-by: Sakari Ailus
--
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kerne
The driver used integers for what boolean would have been a better fit.
Use boolean instead.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/ad5820.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820
On Wed, Sep 07, 2016 at 12:53:26PM +0300, Laurent Pinchart wrote:
> The function is defined in a header file when HAVE_DVBV5_REMOTE is not
> set. It needs to be marked as static inline.
>
> Signed-off-by: Laurent Pinchart
Applied. Thank you.
--
Sakari Ailus
e-mail: sakari.
Hi,
These patches add the ability to media-ctl to print information on a given
entity only. That's sometimes handy.
--
Regards,
Sakari
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://
Add an optional argument to the -p option that allows printing all
information related to a given entity. This may be handy sometimes if only
a single entity is of interest and there are many entities.
Signed-off-by: Sakari Ailus
---
utils/media-ctl/media-ctl.c | 26
As a result, a function that can be used to print information on a given
entity only is provided.
Signed-off-by: Sakari Ailus
---
utils/media-ctl/media-ctl.c | 93 -
1 file changed, 49 insertions(+), 44 deletions(-)
diff --git a/utils/media-ctl/media
with a __maybe_unused annotation that is
> > simpler and harder to get wrong, avoiding the warning.
> >
> > Signed-off-by: Arnd Bergmann
> > Fixes: bee3d5115611 ("[media] ad5820: Add driver for auto-focus
> coil")
>
> Thanks!
>
> Acked-by:
Hi Mauro,
On Tue, Sep 06, 2016 at 06:56:17AM -0300, Mauro Carvalho Chehab wrote:
> Em Thu, 11 Aug 2016 23:29:14 +0300
> Sakari Ailus escreveu:
>
> > Preparation for refactoring media IOCTL handling to unify common parts.
> >
> > Reviewed-by: Laurent Pinchart
>
Add an optional argument to the -p option that allows printing all
information related to a given entity. This may be handy sometimes if only
a single entity is of interest and there are many entities.
Signed-off-by: Sakari Ailus
---
utils/media-ctl/media-ctl.c | 33
Add a possibility to printing all information related to a given entity by
using both -p and -e options. This may be handy sometimes if only a single
entity is of interest and there are many entities.
Signed-off-by: Sakari Ailus
---
Fixed the commit message as well.
utils/media-ctl/media-ctl.c
On 09/15/16 01:05, Laurent Pinchart wrote:
> Hi Sakari,
>
> Thank you for the patch.
>
> On Wednesday 14 Sep 2016 17:29:39 Sakari Ailus wrote:
>> Add a possibility to printing all information related to a given entity by
>> using both -p and -e options. This may b
Add a possibility to printing all information related to a given entity by
using both -p and -e options. This may be handy sometimes if only a single
entity is of interest and there are many entities.
Signed-off-by: Sakari Ailus
---
utils/media-ctl/media-ctl.c | 32
On 09/15/16 11:10, Laurent Pinchart wrote:
> Reviewed-by: Laurent Pinchart
Thanks!
pushed to master.
--
Sakari Ailus
sakari.ai...@linux.intel.com
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More m
The initialisation of the source sub-device is somewhat different as it's
not created by the smiapp driver itself. Remove redundancy in initialising
the two kind of sub-devices.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 5 +
1 file changed, 1 insertion(
The media bus code obtained for try format may have been a code that the
sensor did not even support. Use a supported code with the current pixel
order.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a
The first time the sensor is powered on, the information is not yet
available.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/media/i2c/smiapp/smiapp-core.c
b/drivers/media/i2c/smiapp/smiapp-core.c
index
The code probably has been unindented at some point but rewrapping has not
been done. Do it now.
Also remove a useless memory allocation failure message.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 33 +
1 file changed, 13 insertions
The information gathered during frame format reading will be required
earlier in the initialisation when it was available. Also return an error
if frame format cannot be obtained.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 8 ++--
1 file changed, 6 insertions
Simplify smiapp_init() by moving the initialisation of individual
sub-devices to a separate function.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 108 +++--
1 file changed, 49 insertions(+), 59 deletions(-)
diff --git a/drivers/media/i2c
The smiapp_probe() is the sole caller of smiapp_init(). Unify the two.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 425 -
1 file changed, 205 insertions(+), 220 deletions(-)
diff --git a/drivers/media/i2c/smiapp/smiapp-core.c
b
Remove the loop in sub-device registration and create each sub-device
explicitly instead.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 82 +++---
1 file changed, 45 insertions(+), 37 deletions(-)
diff --git a/drivers/media/i2c/smiapp
Replace plain value 2 with SMIAPP_PADS when referring to the number of
pads.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/smiapp/smiapp.h
b/drivers/media/i2c/smiapp/smiapp.h
index
rally does not happen. Use dev_dbg() instead.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp-pll.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/smiapp-pll.c b/drivers/media/i2c/smiapp-pll.c
index e3348db..771db56 100644
--- a/drivers/media/i2c/s
This allows determining the number of pads in the entity based on the
sensor.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/media/i2c/smiapp/smiapp-core.c
b/drivers/media/i2c/smiapp
Hi all,
This set further cleans up the smiapp driver and prepares for later
changes.
More fixes and cleanups since v1.
--
Kind regards,
Sakari
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
onger
exists.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 53 --
1 file changed, 19 insertions(+), 34 deletions(-)
diff --git a/drivers/media/i2c/smiapp/smiapp-core.c
b/drivers/media/i2c/smiapp/smiapp-core.c
index 5d251b4..13322f3 100644
Besides the image data, SMIA++ compliant sensors also provide embedded
data in form of registers used to capture the image. Store this
information for later use in frame descriptor and routing.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 44
Provide more debugging information on reading the frame layout.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 21 +
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/drivers/media/i2c/smiapp/smiapp-core.c
b/drivers/media/i2c/smiapp
Instead, calculate how much is needed and then allocate the memory
dynamically.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 24 ++--
drivers/media/i2c/smiapp/smiapp.h | 8 ++--
2 files changed, 20 insertions(+), 12 deletions(-)
diff
The same pixel array size is required for the active format of each
sub-device sink pad and try format of each sink pad of each opened file
handle as well as for the native size rectangle.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 39
Define the number of pads explicitly in initialising the sub-devices.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/media/i2c/smiapp/smiapp-core.c
b/drivers/media/i2c/smiapp
1 - 100 of 6671 matches
Mail list logo
