Re: [PATCH/RFC 1/4] ipu_idmac: code clean-up and robustness improvements

2009-03-02 Thread Agustin
--- On 28/2/09, Guennadi Liakhovetski wrote: On Sat, 28 Feb 2009, Agustin wrote: Hi Guennadi, I am having trouble while probing ipu idmac: At boot: ipu-core: probe of ipu-core failed with error -22 Which is apparently happening at ipu_idmac:1706: 1695 static int __init

Re: [PATCH/RFC 1/4] ipu_idmac: code clean-up and robustness improvements

2009-02-28 Thread Agustin
Hi Guennadi, I am having trouble while probing ipu idmac: At boot: ipu-core: probe of ipu-core failed with error -22 Which is apparently happening at ipu_idmac:1706: 1695 static int __init ipu_probe(struct platform_device *pdev) ... 1703 mem_ipu = platform_get_resource(pdev,

Re: [PATCH/RFC 1/4] ipu_idmac: code clean-up and robustness improvements

2009-02-28 Thread Guennadi Liakhovetski
On Sat, 28 Feb 2009, Agustin wrote: Hi Guennadi, I am having trouble while probing ipu idmac: At boot: ipu-core: probe of ipu-core failed with error -22 Which is apparently happening at ipu_idmac:1706: 1695 static int __init ipu_probe(struct platform_device *pdev) ...

Re: [PATCH/RFC 1/4] ipu_idmac: code clean-up and robustness improvements

2009-02-18 Thread Agustin
Guennadi, Guennadi Liakhovetski wrote: From: Guennadi Liakhovetski General code clean-up: remove superfluous semicolons, update comments. Robustness improvements: add DMA error handling to the ISR, move common code fragments to functions, fix scatter-gather element queuing in the ISR,

Re: [PATCH/RFC 1/4] ipu_idmac: code clean-up and robustness improvements

2009-02-18 Thread Guennadi Liakhovetski
On Wed, 18 Feb 2009, Agustin wrote: I am having some stoopid trouble while trying to apply this patch to 'mxc-master': $ patch -p1 --dry-run p1 patching file drivers/dma/ipu/ipu_idmac.c patch: malformed patch at line 29: /* Looks like your patches lost their format while on their

Re: [PATCH/RFC 1/4] ipu_idmac: code clean-up and robustness improvements

2009-02-18 Thread Russell King - ARM Linux
On Wed, Feb 18, 2009 at 07:09:55AM -0800, Agustin wrote: Guennadi, Guennadi Liakhovetski wrote: diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c index 1f154d0..91e6e4e 100644 --- a/drivers/dma/ipu/ipu_idmac.c +++ b/drivers/dma/ipu/ipu_idmac.c @@ -28,6 +28,9 @@

Re: [PATCH/RFC 1/4] ipu_idmac: code clean-up and robustness improvements

2009-02-18 Thread Agustin
--- On 18/2/09, Russell King -wrote: On Wed, Feb 18, 2009 at 07:09:55AM -0800, Agustin wrote: $ patch -p1 --dry-run p1 patching file drivers/dma/ipu/ipu_idmac.c patch: malformed patch at line 29: /* Looks like your patches lost their format while on their way, specially every