Re: [PATCH 15/17] media: st_rc: Don't stay on an IRQ handler forever

2018-04-13 Thread Mauro Carvalho Chehab
Em Fri, 13 Apr 2018 14:20:52 +0100 Sean Young escreveu: > On Fri, Apr 13, 2018 at 07:00:50AM -0300, Mauro Carvalho Chehab wrote: > > Yeah, we could limit it to run only 512 times (or some other reasonable > > quantity), but in order to do that, we need to be sure that, on each read(), > > the FIF

Re: [PATCH 15/17] media: st_rc: Don't stay on an IRQ handler forever

2018-04-13 Thread Sean Young
On Fri, Apr 13, 2018 at 07:00:50AM -0300, Mauro Carvalho Chehab wrote: > Yeah, we could limit it to run only 512 times (or some other reasonable > quantity), but in order to do that, we need to be sure that, on each read(), > the FIFO will shift - e. g. no risk of needing to do more than one read >

Re: [PATCH 15/17] media: st_rc: Don't stay on an IRQ handler forever

2018-04-13 Thread Mauro Carvalho Chehab
Em Fri, 13 Apr 2018 10:40:05 +0100 Sean Young escreveu: > On Fri, Apr 13, 2018 at 06:06:46AM -0300, Mauro Carvalho Chehab wrote: > > Hi Sean, > > > > Em Thu, 12 Apr 2018 23:21:32 +0100 > > Sean Young escreveu: > > > > > On Thu, Apr 12, 2018 at 11:24:07AM -0400, Mauro Carvalho Chehab wrote:

Re: [PATCH 15/17] media: st_rc: Don't stay on an IRQ handler forever

2018-04-13 Thread Mauro Carvalho Chehab
Em Fri, 13 Apr 2018 11:36:56 +0200 Mason escreveu: > On 13/04/2018 11:25, Mauro Carvalho Chehab wrote: > > Em Fri, 13 Apr 2018 11:15:16 +0200 > > Mason escreveu: > > > >> On 12/04/2018 17:24, Mauro Carvalho Chehab wrote: > >> > >>> As warned by smatch: > >>> drivers/media/rc/st_rc.c:110 s

Re: [PATCH 15/17] media: st_rc: Don't stay on an IRQ handler forever

2018-04-13 Thread Sean Young
On Fri, Apr 13, 2018 at 06:06:46AM -0300, Mauro Carvalho Chehab wrote: > Hi Sean, > > Em Thu, 12 Apr 2018 23:21:32 +0100 > Sean Young escreveu: > > > On Thu, Apr 12, 2018 at 11:24:07AM -0400, Mauro Carvalho Chehab wrote: > > > As warned by smatch: > > > drivers/media/rc/st_rc.c:110 st_rc_rx_in

Re: [PATCH 15/17] media: st_rc: Don't stay on an IRQ handler forever

2018-04-13 Thread Mason
On 13/04/2018 11:25, Mauro Carvalho Chehab wrote: > Em Fri, 13 Apr 2018 11:15:16 +0200 > Mason escreveu: > >> On 12/04/2018 17:24, Mauro Carvalho Chehab wrote: >> >>> As warned by smatch: >>> drivers/media/rc/st_rc.c:110 st_rc_rx_interrupt() warn: this loop >>> depends on readl() succeeding

Re: [PATCH 15/17] media: st_rc: Don't stay on an IRQ handler forever

2018-04-13 Thread Mauro Carvalho Chehab
Em Fri, 13 Apr 2018 11:15:16 +0200 Mason escreveu: > On 12/04/2018 17:24, Mauro Carvalho Chehab wrote: > > > As warned by smatch: > > drivers/media/rc/st_rc.c:110 st_rc_rx_interrupt() warn: this loop > > depends on readl() succeeding > > > > If something goes wrong at readl(), the logic wi

Re: [PATCH 15/17] media: st_rc: Don't stay on an IRQ handler forever

2018-04-13 Thread Mason
On 12/04/2018 17:24, Mauro Carvalho Chehab wrote: > As warned by smatch: > drivers/media/rc/st_rc.c:110 st_rc_rx_interrupt() warn: this loop > depends on readl() succeeding > > If something goes wrong at readl(), the logic will stay there > inside an IRQ code forever. This is not the nices

Re: [PATCH 15/17] media: st_rc: Don't stay on an IRQ handler forever

2018-04-13 Thread Mauro Carvalho Chehab
Hi Sean, Em Thu, 12 Apr 2018 23:21:32 +0100 Sean Young escreveu: > On Thu, Apr 12, 2018 at 11:24:07AM -0400, Mauro Carvalho Chehab wrote: > > As warned by smatch: > > drivers/media/rc/st_rc.c:110 st_rc_rx_interrupt() warn: this loop > > depends on readl() succeeding > > > > If something go

Re: [PATCH 15/17] media: st_rc: Don't stay on an IRQ handler forever

2018-04-13 Thread Patrice CHOTARD
Hi Mauro On 04/12/2018 05:24 PM, Mauro Carvalho Chehab wrote: > As warned by smatch: > drivers/media/rc/st_rc.c:110 st_rc_rx_interrupt() warn: this loop > depends on readl() succeeding > > If something goes wrong at readl(), the logic will stay there > inside an IRQ code forever. This is n

Re: [PATCH 15/17] media: st_rc: Don't stay on an IRQ handler forever

2018-04-13 Thread Patrice CHOTARD
Hi Mauro, Sean On 04/13/2018 12:21 AM, Sean Young wrote: > On Thu, Apr 12, 2018 at 11:24:07AM -0400, Mauro Carvalho Chehab wrote: >> As warned by smatch: >> drivers/media/rc/st_rc.c:110 st_rc_rx_interrupt() warn: this loop >> depends on readl() succeeding >> >> If something goes wrong at rea

Re: [PATCH 15/17] media: st_rc: Don't stay on an IRQ handler forever

2018-04-12 Thread Sean Young
On Thu, Apr 12, 2018 at 11:24:07AM -0400, Mauro Carvalho Chehab wrote: > As warned by smatch: > drivers/media/rc/st_rc.c:110 st_rc_rx_interrupt() warn: this loop > depends on readl() succeeding > > If something goes wrong at readl(), the logic will stay there > inside an IRQ code forever. T