Re: [PATCH 2/2] media: ov5640: add support of module orientation

2018-06-13 Thread Sakari Ailus
On Wed, Jun 13, 2018 at 10:09:58AM +, Hugues FRUCHET wrote: > Hi Sakari, Rob, > > Find a new proposal below: > > On 06/13/2018 10:24 AM, Sakari Ailus wrote: > > On Wed, Jun 13, 2018 at 08:10:02AM +, Hugues FRUCHET wrote: > >> Hi Rob, thanks for review, > >> > >> On 06/13/2018 12:06 AM, Ro

Re: [PATCH 2/2] media: ov5640: add support of module orientation

2018-06-13 Thread Hugues FRUCHET
Hi Sakari, Rob, Find a new proposal below: On 06/13/2018 10:24 AM, Sakari Ailus wrote: > On Wed, Jun 13, 2018 at 08:10:02AM +, Hugues FRUCHET wrote: >> Hi Rob, thanks for review, >> >> On 06/13/2018 12:06 AM, Rob Herring wrote: >>> On Mon, Jun 11, 2018 at 11:29:17AM +0200, Hugues Fruchet wrot

Re: [PATCH 2/2] media: ov5640: add support of module orientation

2018-06-13 Thread Sakari Ailus
On Wed, Jun 13, 2018 at 08:10:02AM +, Hugues FRUCHET wrote: > Hi Rob, thanks for review, > > On 06/13/2018 12:06 AM, Rob Herring wrote: > > On Mon, Jun 11, 2018 at 11:29:17AM +0200, Hugues Fruchet wrote: > >> Add support of module being physically mounted upside down. > >> In this case, mirror

Re: [PATCH 2/2] media: ov5640: add support of module orientation

2018-06-13 Thread Hugues FRUCHET
Hi Rob, thanks for review, On 06/13/2018 12:06 AM, Rob Herring wrote: > On Mon, Jun 11, 2018 at 11:29:17AM +0200, Hugues Fruchet wrote: >> Add support of module being physically mounted upside down. >> In this case, mirror and flip are enabled to fix captured images >> orientation. >> >> Signed-of

Re: [PATCH 2/2] media: ov5640: add support of module orientation

2018-06-13 Thread Sakari Ailus
Hi Rob, Hugues, On Tue, Jun 12, 2018 at 04:06:28PM -0600, Rob Herring wrote: > On Mon, Jun 11, 2018 at 11:29:17AM +0200, Hugues Fruchet wrote: > > Add support of module being physically mounted upside down. > > In this case, mirror and flip are enabled to fix captured images > > orientation. > >

Re: [PATCH 2/2] media: ov5640: add support of module orientation

2018-06-12 Thread Rob Herring
On Mon, Jun 11, 2018 at 11:29:17AM +0200, Hugues Fruchet wrote: > Add support of module being physically mounted upside down. > In this case, mirror and flip are enabled to fix captured images > orientation. > > Signed-off-by: Hugues Fruchet > --- > .../devicetree/bindings/media/i2c/ov5640.txt

Re: [PATCH 2/2] media: ov5640: add support of module orientation

2018-06-11 Thread Hugues FRUCHET
Hi Sakari, I'm fine with the change to dev_fwnode(&client->dev). Many thanks Sakari, Hugues. On 06/11/2018 12:10 PM, Sakari Ailus wrote: > On Mon, Jun 11, 2018 at 11:29:17AM +0200, Hugues Fruchet wrote: >> Add support of module being physically mounted upside down. >> In this case, mirror and f

Re: [PATCH 2/2] media: ov5640: add support of module orientation

2018-06-11 Thread Sakari Ailus
On Mon, Jun 11, 2018 at 11:29:17AM +0200, Hugues Fruchet wrote: > Add support of module being physically mounted upside down. > In this case, mirror and flip are enabled to fix captured images > orientation. > > Signed-off-by: Hugues Fruchet > --- > .../devicetree/bindings/media/i2c/ov5640.txt