Hi Arun,
On 09/11/2013 07:10 AM, Arun Kumar K wrote:
> If I name it to reset-gpios, the function of_get_gpio_flags() in the driver
> fails. This function searches for the entry with name "gpios". Is it still
> recommended to use a custom name and parse it explicitly?
I guess so, you could just us
Hi Sylwester,
On Fri, Sep 6, 2013 at 1:32 AM, Sylwester Nawrocki
wrote:
> On 08/21/2013 08:34 AM, Arun Kumar K wrote:
>>
>> This patch adds subdev driver for Samsung S5K4E5 raw image sensor.
>> Like s5k6a3, it is also another fimc-is firmware controlled
>> sensor. This minimal sensor driver doesn
Hi Sylwester,
Will make the changes you suggested.
Will re-spin this entire series with some more minor fixes after more
rigorous testing.
Regards
Arun
On Fri, Sep 6, 2013 at 1:32 AM, Sylwester Nawrocki
wrote:
> On 08/21/2013 08:34 AM, Arun Kumar K wrote:
>>
>> This patch adds subdev driver for
On 08/21/2013 08:34 AM, Arun Kumar K wrote:
This patch adds subdev driver for Samsung S5K4E5 raw image sensor.
Like s5k6a3, it is also another fimc-is firmware controlled
sensor. This minimal sensor driver doesn't do any I2C communications
as its done by ISP firmware. It can be updated if needed
On 08/21/2013 11:13 AM, Sylwester Nawrocki wrote:
> On 08/21/2013 10:24 AM, Hans Verkuil wrote:
> +static const char * const s5k4e5_supply_names[] = {
> + "svdda",
> + "svddio"
> +};
I'm no regulator expert, but shouldn't this list come from the DT or
platform_data? O
On 08/21/2013 10:24 AM, Hans Verkuil wrote:
+static const char * const s5k4e5_supply_names[] = {
+ "svdda",
+ "svddio"
+};
>>>
>>> I'm no regulator expert, but shouldn't this list come from the DT or
>>> platform_data? Or are these names specific to this sensor?
>>
>> This is
Hi Hans,
On Wed, Aug 21, 2013 at 1:54 PM, Hans Verkuil wrote:
> On Wed 21 August 2013 09:58:28 Tomasz Figa wrote:
>> Hi Hans,
>>
>> On Wednesday 21 of August 2013 08:53:55 Hans Verkuil wrote:
>> > On 08/21/2013 08:34 AM, Arun Kumar K wrote:
>> > > This patch adds subdev driver for Samsung S5K4E5
On Wed 21 August 2013 09:58:28 Tomasz Figa wrote:
> Hi Hans,
>
> On Wednesday 21 of August 2013 08:53:55 Hans Verkuil wrote:
> > On 08/21/2013 08:34 AM, Arun Kumar K wrote:
> > > This patch adds subdev driver for Samsung S5K4E5 raw image sensor.
> > > Like s5k6a3, it is also another fimc-is firmwa
Hi Hans,
On Wednesday 21 of August 2013 08:53:55 Hans Verkuil wrote:
> On 08/21/2013 08:34 AM, Arun Kumar K wrote:
> > This patch adds subdev driver for Samsung S5K4E5 raw image sensor.
> > Like s5k6a3, it is also another fimc-is firmware controlled
> > sensor. This minimal sensor driver doesn't d
On 08/21/2013 08:34 AM, Arun Kumar K wrote:
> This patch adds subdev driver for Samsung S5K4E5 raw image sensor.
> Like s5k6a3, it is also another fimc-is firmware controlled
> sensor. This minimal sensor driver doesn't do any I2C communications
> as its done by ISP firmware. It can be updated if n
10 matches
Mail list logo