Re: [PATCH 0/5] [v5] Allow persistent memory to be used like normal RAM

2019-02-27 Thread Dan Williams
[ add Stephen and Juergen ] On Mon, Feb 25, 2019 at 11:02 AM Dave Hansen wrote: > > This is a relatively small delta from v4. The review comments seem > to be settling down, so it seems like we should start thinking about > how this might get merged. Are there any objections to taking it in >

Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-02-27 Thread Brendan Higgins
On Tue, Feb 19, 2019 at 10:44 PM Frank Rowand wrote: > > On 2/19/19 7:39 PM, Brendan Higgins wrote: > > On Mon, Feb 18, 2019 at 11:52 AM Frank Rowand > > wrote: > >> > >> On 2/14/19 1:37 PM, Brendan Higgins wrote: > >>> Add support for aborting/bailing out of test cases. Needed for > >>>

Re: [RFC v4 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-02-27 Thread Brendan Higgins
On Fri, Feb 22, 2019 at 12:53 PM Thiago Jung Bauermann wrote: > > > Frank Rowand writes: > > > On 2/19/19 10:34 PM, Brendan Higgins wrote: > >> On Mon, Feb 18, 2019 at 12:02 PM Frank Rowand > >> wrote: > >> > >>> I have not read through the patches in any detail. I have read some of > >>>

Re: [RFC v4 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-02-27 Thread Brendan Higgins
On Tue, Feb 19, 2019 at 10:46 PM Frank Rowand wrote: > > On 2/19/19 10:34 PM, Brendan Higgins wrote: > > On Mon, Feb 18, 2019 at 12:02 PM Frank Rowand > > wrote: > > > >> I have not read through the patches in any detail. I have read some of > >> the code to try to understand the patches to

Re: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest

2019-02-27 Thread Brendan Higgins
On Wed, Feb 20, 2019 at 12:45 PM Frank Rowand wrote: > > On 2/18/19 2:25 PM, Frank Rowand wrote: > > On 2/15/19 2:56 AM, Brendan Higgins wrote: > >> On Thu, Feb 14, 2019 at 6:05 PM Frank Rowand > >> wrote: > >>> > >>> On 2/14/19 4:56 PM, Brendan Higgins wrote: > On Thu, Feb 14, 2019 at

[no subject]

2019-02-27 Thread Post Office
This Message was undeliverable due to the following reason: Your message was not delivered because the destination computer was not reachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likely

Re: [RFC v3 17/19] of: unittest: migrate tests to run on KUnit

2019-02-27 Thread Brendan Higgins
On Mon, Feb 18, 2019 at 2:56 PM Frank Rowand wrote: > > On 2/12/19 5:44 PM, Brendan Higgins wrote: > > On Wed, Nov 28, 2018 at 12:56 PM Rob Herring wrote: > >> > >> On Wed, Nov 28, 2018 at 1:38 PM Brendan Higgins > >> wrote: > >>> --- > >>> drivers/of/Kconfig|1 + > >>>

[PATCH v5 2/2] nvdimm, btt: fix LBA masking during 'free list' population

2019-02-27 Thread Vishal Verma
The Linux BTT implementation assumes that log entries will never have the 'zero' flag set, and indeed it never sets that flag for log entries itself. However, the UEFI spec is ambiguous on the exact format of the LBA field of a log entry, specifically as to whether it should include the

[PATCH v5 1/2] nvdimm, btt: remove unnecessary code in btt_freelist_init

2019-02-27 Thread Vishal Verma
We call btt_log_read() twice, once to get the 'old' log entry, and again to get the 'new' entry. However, we have no use for the 'old' entry, so remove it. Cc: Dan Williams Signed-off-by: Vishal Verma --- drivers/nvdimm/btt.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) v5:

Re: [PATCH v4] nvdimm, btt: fix LBA masking during 'free list' population

2019-02-27 Thread Verma, Vishal L
On Wed, 2019-02-27 at 21:06 +, Dexuan Cui wrote: > > From: Verma, Vishal L > > Sent: Wednesday, February 27, 2019 10:13 AM > > ... > > > I suppose the new line should not be added, and the line > > > if (ent_e_flag(log_new.old_map)) { > > > should be changed to > > >

RE: [PATCH v4] nvdimm, btt: fix LBA masking during 'free list' population

2019-02-27 Thread Dexuan Cui
> From: Verma, Vishal L > Sent: Wednesday, February 27, 2019 10:13 AM > ... > > I suppose the new line should not be added, and the line > > if (ent_e_flag(log_new.old_map)) { > > should be changed to > > if (ent_e_flag(log_new.old_map) && ! > ent_z_flag(log_new.old_map))

Re: find_get_entries_tag regression bisected

2019-02-27 Thread Dan Williams
On Sat, Feb 16, 2019 at 9:29 AM Matthew Wilcox wrote: > > On Sat, Feb 16, 2019 at 07:35:11AM -0800, Matthew Wilcox wrote: > > Another way to fix this would be to mask the address in dax_entry_mkclean(), > > but I think this is cleaner. > > That's clearly rubbish, dax_entry_mkclean() can't