Re: [PATCH] dax: Flush partial PMDs correctly

2019-03-01 Thread Dan Williams
On Fri, Mar 1, 2019 at 11:12 AM Matthew Wilcox wrote: > > The radix tree would rewind the index in an iterator to the lowest index > of a multi-slot entry. The XArray iterators instead leave the index > unchanged, but I overlooked that when converting DAX from the radix tree > to the XArray. Adj

Re: [PATCH] update NFIT flags error message

2019-03-01 Thread Dan Williams
On Thu, Feb 28, 2019 at 12:14 PM Toshi Kani wrote: > > ACPI NFIT flags field reports major errors on NVDIMM, which need > user's attention. > > Update the current log to a proper error message with dev_err(). > The current message string is kept for grep-compatibility. > Looks good, applied.

error

2019-03-01 Thread Mail Administrator
Óxv›Vië'Æq²‘.s$¦1 Q1ۘOÅÉ5ÙèŸ9mY'жÒqƒµæ?Ì*Ÿ× >œ6·_ìþ{>D`‰á  %9½u#›s:Zéì«Î"p}]Ä_0ƒpsæ¼Èl¯\Œ`nän4àÑâq„F-ƒ:Eß.ªÜÜp¿½"bR›³ß6¼¾!ãapïâ%jd¦ÇŸ‘‡ÇêÅx®^“ËËÀiS°\¥ÛÊø(Œ½*áš2›í«Iڜû‚œy¢0¯Z¥°{»olöänN ®ˆú5ª´"˜ÏîõGK>ov4ŒGͯoÊT\ça˜Vô_c<¸x‰ |–Õ¡¼­Y D”’…ß‘Ktk²ˆ À5/zꖑXLü±m´àËÖÖÁ˛…Šm_¤ iðþÜd8¡[àòj›Ñ¯n^ÞP„²

Re: [PATCH] dax: Flush partial PMDs correctly

2019-03-01 Thread Matthew Wilcox
On Fri, Mar 01, 2019 at 02:49:54PM +0100, Jan Kara wrote: > > pfn = dax_to_pfn(entry); > > - size = PAGE_SIZE << dax_entry_order(entry); > > + count = 1UL << dax_entry_order(entry); > > + index = xas->xa_index &~ (count - 1); > > Hum, why do you compute 'index' here when you actually nev

[PATCH] dax: Flush partial PMDs correctly

2019-03-01 Thread Matthew Wilcox
The radix tree would rewind the index in an iterator to the lowest index of a multi-slot entry. The XArray iterators instead leave the index unchanged, but I overlooked that when converting DAX from the radix tree to the XArray. Adjust the index that we use for flushing to the start of the PMD ra

Re: [PATCH] dax: Flush partial PMDs correctly

2019-03-01 Thread Jan Kara
On Thu 28-02-19 20:24:48, Matthew Wilcox wrote: > The radix tree would rewind the index in an iterator to the lowest index > of a multi-slot entry. The XArray iterators instead leave the index > unchanged, but I overlooked that when converting DAX from the radix tree > to the XArray. Adjust the i