Re: [PATCH v3 12/27] powerpc/powernv/pmem: Add register addresses & status values to the header

2020-02-26 Thread Alastair D'Silva
On Thu, 2020-02-27 at 16:08 +1100, Andrew Donnellan wrote: > On 21/2/20 2:27 pm, Alastair D'Silva wrote: > > From: Alastair D'Silva > > > > These values have been taken from the device specifications. > > > > Signed-off-by: Alastair D'Silva > > I've compared these values against the internal v

Re: [PATCH v3 12/27] powerpc/powernv/pmem: Add register addresses & status values to the header

2020-02-26 Thread Andrew Donnellan
On 21/2/20 2:27 pm, Alastair D'Silva wrote: From: Alastair D'Silva These values have been taken from the device specifications. Signed-off-by: Alastair D'Silva I've compared these values against the internal version of the device specifications that I have access to, and they appear to mat

Re: [PATCH v5 2/8] drivers/pmem: Allow pmem_clear_poison() to accept arbitrary offset and len

2020-02-26 Thread Dan Williams
On Wed, Feb 26, 2020 at 7:03 PM Dave Chinner wrote: > > On Mon, Feb 24, 2020 at 10:38:44AM -0500, Vivek Goyal wrote: > > On Mon, Feb 24, 2020 at 10:03:30AM +1100, Dave Chinner wrote: > > > > [..] > > > > > > Hi Jeff, > > > > > > > > > > > > New dax zeroing interface (dax_zero_page_range()) can tec

Re: [PATCH v3 13/27] powerpc/powernv/pmem: Read the capability registers & wait for device ready

2020-02-26 Thread Alastair D'Silva
On Thu, 2020-02-27 at 14:54 +1100, Andrew Donnellan wrote: > On 21/2/20 2:27 pm, Alastair D'Silva wrote: > > +/** > > + * read_device_metadata() - Retrieve config information from the > > AFU and save it for future use > > + * @ocxlpmem: the device metadata > > + * Return: 0 on success, negative on

Re: [PATCH v3 13/27] powerpc/powernv/pmem: Read the capability registers & wait for device ready

2020-02-26 Thread Andrew Donnellan
On 21/2/20 2:27 pm, Alastair D'Silva wrote: +/** + * read_device_metadata() - Retrieve config information from the AFU and save it for future use + * @ocxlpmem: the device metadata + * Return: 0 on success, negative on failure + */ +static int read_device_metadata(struct ocxlpmem *ocxlpmem) +{ +

Re: [PATCH v5 2/8] drivers/pmem: Allow pmem_clear_poison() to accept arbitrary offset and len

2020-02-26 Thread Dave Chinner
On Wed, Feb 26, 2020 at 11:57:56AM -0500, Vivek Goyal wrote: > On Tue, Feb 25, 2020 at 02:49:30PM -0800, Dan Williams wrote: > [..] > > > > I'm ok with replacing blkdev_issue_zeroout() with a dax operation > > > > callback that deals with page aligned entries. That change at least > > > > makes the

Re: [PATCH v5 2/8] drivers/pmem: Allow pmem_clear_poison() to accept arbitrary offset and len

2020-02-26 Thread Dave Chinner
On Mon, Feb 24, 2020 at 10:38:44AM -0500, Vivek Goyal wrote: > On Mon, Feb 24, 2020 at 10:03:30AM +1100, Dave Chinner wrote: > > [..] > > > > > Hi Jeff, > > > > > > > > > > New dax zeroing interface (dax_zero_page_range()) can technically pass > > > > > a range which is less than a sector. Or whic

Re: [ndctl PATCH 1/2] ndctl/region: Support ndctl_region_{get, set}_align()

2020-02-26 Thread Jeff Moyer
Dan Williams writes: > On Wed, Feb 26, 2020 at 1:52 PM Jeff Moyer wrote: >> >> Dan Williams writes: >> >> >> Missing doctext. Specifically, there should be a big, fat warning >> >> against changing the region alignment. >> > >> > I don't mind adding one, but is this the right place to document

Re: [ndctl PATCH 1/2] ndctl/region: Support ndctl_region_{get, set}_align()

2020-02-26 Thread Dan Williams
On Wed, Feb 26, 2020 at 1:52 PM Jeff Moyer wrote: > > Dan Williams writes: > > >> Missing doctext. Specifically, there should be a big, fat warning > >> against changing the region alignment. > > > > I don't mind adding one, but is this the right place to document an > > API warning? If the audi

Re: [ndctl PATCH 1/2] ndctl/region: Support ndctl_region_{get, set}_align()

2020-02-26 Thread Jeff Moyer
Dan Williams writes: >> Missing doctext. Specifically, there should be a big, fat warning >> against changing the region alignment. > > I don't mind adding one, but is this the right place to document an > API warning? If the audience is future ndctl developers that should be > warned to keep th

Re: [ndctl PATCH 1/2] ndctl/region: Support ndctl_region_{get, set}_align()

2020-02-26 Thread Dan Williams
On Tue, Feb 25, 2020 at 3:23 PM Dan Williams wrote: > > On Wed, Feb 19, 2020 at 10:04 AM Jeff Moyer wrote: > > > > Dan Williams writes: > > > > > > > > +NDCTL_EXPORT unsigned long ndctl_region_get_align(struct ndctl_region > > > *region) > > > +{ > > > + return region->align; > > > +} > > >

Re: [PATCH v5 2/8] drivers/pmem: Allow pmem_clear_poison() to accept arbitrary offset and len

2020-02-26 Thread Vivek Goyal
On Tue, Feb 25, 2020 at 02:49:30PM -0800, Dan Williams wrote: [..] > > > I'm ok with replacing blkdev_issue_zeroout() with a dax operation > > > callback that deals with page aligned entries. That change at least > > > makes the error boundary symmetric across copy_from_iter() and the > > > zeroing

Re: [PATCH v3 04/27] ocxl: Remove unnecessary externs

2020-02-26 Thread 'Baoquan He'
On 02/26/20 at 03:20pm, Greg Kurz wrote: > On Wed, 26 Feb 2020 22:15:23 +0800 > 'Baoquan He' wrote: > > > On 02/26/20 at 10:01am, Greg Kurz wrote: > > > On Wed, 26 Feb 2020 19:26:34 +1100 > > > "Alastair D'Silva" wrote: > > > > > > > > -Original Message- > > > > > From: Baoquan He > >

Re: [PATCH v3 04/27] ocxl: Remove unnecessary externs

2020-02-26 Thread Greg Kurz
On Wed, 26 Feb 2020 22:15:23 +0800 'Baoquan He' wrote: > On 02/26/20 at 10:01am, Greg Kurz wrote: > > On Wed, 26 Feb 2020 19:26:34 +1100 > > "Alastair D'Silva" wrote: > > > > > > -Original Message- > > > > From: Baoquan He > > > > Sent: Wednesday, 26 February 2020 7:15 PM > > > > To: A

Re: [PATCH v3 04/27] ocxl: Remove unnecessary externs

2020-02-26 Thread 'Baoquan He'
On 02/26/20 at 10:01am, Greg Kurz wrote: > On Wed, 26 Feb 2020 19:26:34 +1100 > "Alastair D'Silva" wrote: > > > > -Original Message- > > > From: Baoquan He > > > Sent: Wednesday, 26 February 2020 7:15 PM > > > To: Alastair D'Silva > > > Cc: alast...@d-silva.org; Aneesh Kumar K . V > > >

Re: [PATCH v5 2/8] drivers/pmem: Allow pmem_clear_poison() to accept arbitrary offset and len

2020-02-26 Thread Vivek Goyal
On Tue, Feb 25, 2020 at 02:49:30PM -0800, Dan Williams wrote: [..] > > > > Hi Dan, > > > > > > > > IIUC, block aligned hole punch don't go through __dax_zero_page_range() > > > > path. Instead they call blkdev_issue_zeroout() at later point of time. > > > > > > > > Only partial block zeroing path i

Re: [PATCH v3 04/27] ocxl: Remove unnecessary externs

2020-02-26 Thread Greg Kurz
On Wed, 26 Feb 2020 19:26:34 +1100 "Alastair D'Silva" wrote: > > -Original Message- > > From: Baoquan He > > Sent: Wednesday, 26 February 2020 7:15 PM > > To: Alastair D'Silva > > Cc: alast...@d-silva.org; Aneesh Kumar K . V > > ; Oliver O'Halloran ; > > Benjamin Herrenschmidt ; Paul Ma

RE: [PATCH v3 04/27] ocxl: Remove unnecessary externs

2020-02-26 Thread Alastair D'Silva
> -Original Message- > From: Baoquan He > Sent: Wednesday, 26 February 2020 7:15 PM > To: Alastair D'Silva > Cc: alast...@d-silva.org; Aneesh Kumar K . V > ; Oliver O'Halloran ; > Benjamin Herrenschmidt ; Paul Mackerras > ; Michael Ellerman ; Frederic > Barrat ; Andrew Donnellan ; > Arnd

Re: [PATCH v3 04/27] ocxl: Remove unnecessary externs

2020-02-26 Thread Baoquan He
On 02/21/20 at 02:26pm, Alastair D'Silva wrote: > From: Alastair D'Silva > > Function declarations don't need externs, remove the existing ones > so they are consistent with newer code > > Signed-off-by: Alastair D'Silva > --- > arch/powerpc/include/asm/pnv-ocxl.h | 32 ++--