Re: [EXT] Re: [PATCH 04/14] cxl/mem: Implement polled mode mailbox

2021-02-04 Thread Ben Widawsky
roves (jgroves) > , Kelley, Sean V >Subject: [EXT] Re: [PATCH 04/14] cxl/mem: Implement polled mode mailbox > >CAUTION: EXTERNAL EMAIL. Do not click links or open attachments unless >you recognize the sender and were expecting this message. >On Mon, Feb 1, 20

Re: [EXT] Re: [PATCH 04/14] cxl/mem: Implement polled mode mailbox

2021-02-04 Thread John Groves (jgroves)
Masters , Jonathan Cameron , Rafael Wysocki , Randy Dunlap , Vishal Verma , daniel@alibaba-inc.com , John Groves (jgroves) , Kelley, Sean V Subject: [EXT] Re: [PATCH 04/14] cxl/mem: Implement polled mode mailbox CAUTION: EXTERNAL EMAIL. Do not click links or open attachments unless you

Re: [PATCH 04/14] cxl/mem: Implement polled mode mailbox

2021-02-02 Thread Ben Widawsky
On 21-02-02 15:54:03, Dan Williams wrote: > On Tue, Feb 2, 2021 at 2:57 PM Ben Widawsky wrote: > > > > On 21-02-01 12:00:18, Dan Williams wrote: > > > On Sat, Jan 30, 2021 at 3:52 PM David Rientjes > > > wrote: > > > > > > > > On Fri, 29 Jan 2021, Ben Widawsky wrote: > > > > > > > > > Provide

Re: [PATCH 04/14] cxl/mem: Implement polled mode mailbox

2021-02-02 Thread Dan Williams
On Tue, Feb 2, 2021 at 2:57 PM Ben Widawsky wrote: > > On 21-02-01 12:00:18, Dan Williams wrote: > > On Sat, Jan 30, 2021 at 3:52 PM David Rientjes wrote: > > > > > > On Fri, 29 Jan 2021, Ben Widawsky wrote: > > > > > > > Provide enough functionality to utilize the mailbox of a memory device. >

Re: [PATCH 04/14] cxl/mem: Implement polled mode mailbox

2021-02-02 Thread Ben Widawsky
On 21-02-01 12:00:18, Dan Williams wrote: > On Sat, Jan 30, 2021 at 3:52 PM David Rientjes wrote: > > > > On Fri, 29 Jan 2021, Ben Widawsky wrote: > > > > > Provide enough functionality to utilize the mailbox of a memory device. > > > The mailbox is used to interact with the firmware running on

Re: [PATCH 04/14] cxl/mem: Implement polled mode mailbox

2021-02-02 Thread Ben Widawsky
On 21-01-30 15:51:57, David Rientjes wrote: > On Fri, 29 Jan 2021, Ben Widawsky wrote: > [snip] > > +/** > > + * cxl_mem_mbox_send_cmd() - Send a mailbox command to a memory device. > > + * @cxlm: The CXL memory device to communicate with. > > + * @mbox_cmd: Command to send to the memory

Re: [PATCH 04/14] cxl/mem: Implement polled mode mailbox

2021-02-01 Thread Dan Williams
On Sat, Jan 30, 2021 at 3:52 PM David Rientjes wrote: > > On Fri, 29 Jan 2021, Ben Widawsky wrote: > > > Provide enough functionality to utilize the mailbox of a memory device. > > The mailbox is used to interact with the firmware running on the memory > > device. > > > > The CXL specification

Re: [PATCH 04/14] cxl/mem: Implement polled mode mailbox

2021-02-01 Thread Dan Williams
On Mon, Feb 1, 2021 at 11:13 AM Ben Widawsky wrote: > > On 21-02-01 12:54:00, Konrad Rzeszutek Wilk wrote: > > > +#define cxl_doorbell_busy(cxlm) > > > \ > > > + (cxl_read_mbox_reg32(cxlm, CXLDEV_MB_CTRL_OFFSET) & > > > \ > > >

Re: [PATCH 04/14] cxl/mem: Implement polled mode mailbox

2021-02-01 Thread Ben Widawsky
On 21-02-01 12:54:00, Konrad Rzeszutek Wilk wrote: > > +#define cxl_doorbell_busy(cxlm) > > \ > > + (cxl_read_mbox_reg32(cxlm, CXLDEV_MB_CTRL_OFFSET) &\ > > +CXLDEV_MB_CTRL_DOORBELL) > > + > > +#define CXL_MAILBOX_TIMEOUT_US

Re: [PATCH 04/14] cxl/mem: Implement polled mode mailbox

2021-02-01 Thread Konrad Rzeszutek Wilk
> +#define cxl_doorbell_busy(cxlm) > \ > + (cxl_read_mbox_reg32(cxlm, CXLDEV_MB_CTRL_OFFSET) &\ > + CXLDEV_MB_CTRL_DOORBELL) > + > +#define CXL_MAILBOX_TIMEOUT_US 2000 You been using the spec for the values. Is that

Re: [PATCH 04/14] cxl/mem: Implement polled mode mailbox

2021-01-30 Thread David Rientjes
On Fri, 29 Jan 2021, Ben Widawsky wrote: > Provide enough functionality to utilize the mailbox of a memory device. > The mailbox is used to interact with the firmware running on the memory > device. > > The CXL specification defines separate capabilities for the mailbox and > the memory device.