Re: [PATCH v2 5/7] dm: remove DM_TYPE_DAX_BIO_BASED dm_queue_mode

On Mon, 2018-06-04 at 17:24 -0600, Ross Zwisler wrote: > On Fri, Jun 01, 2018 at 06:04:43PM -0400, Mike Snitzer wrote: > > On Tue, May 29 2018 at 3:51pm -0400, > > Ross Zwisler wrote: : > > For example, the following transition will currently fail: > > > > dm-linear: [fsdax pmem][fsdax pmem]

Re: [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode

On Tue, 2018-06-26 at 15:13 -0400, Mike Snitzer wrote: > On Tue, Jun 26 2018 at 3:07pm -0400, > Dan Williams wrote: > > > On Tue, Jun 26, 2018 at 11:58 AM, Mike Snitzer wrote: > > > On Tue, Jun 26 2018 at 2:52pm -0400, > > > Dan Williams wrote: > > > > > > > On Tue, Jun 26, 2018 at 10:59

Re: [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode

On Tue, 2018-06-26 at 14:02 -0700, Dan Williams wrote: > On Tue, Jun 26, 2018 at 1:54 PM, Kani, Toshi wrote: > > On Tue, 2018-06-26 at 15:13 -0400, Mike Snitzer wrote: > > > On Tue, Jun 26 2018 at 3:07pm -0400, > > > Dan Williams wrote: > > > > >

Re: [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode

On Tue, 2018-06-26 at 14:28 -0700, Dan Williams wrote: > On Tue, Jun 26, 2018 at 2:23 PM, Kani, Toshi wrote: > > On Tue, 2018-06-26 at 14:02 -0700, Dan Williams wrote: > > > On Tue, Jun 26, 2018 at 1:54 PM, Kani, Toshi wrote: > > [..] > > > > When this

DAX 2MB mappings for XFS

Hello, I noticed that DAX 2MB mmap no longer works on XFS. I used the following steps on a 4.15-rc7 kernel. Am I missing something, or is there a problem in XFS? # mkfs.xfs -f -d su=2m,sw=1 /dev/pmem0 # mount -o dax /dev/pmem0 /mnt/pmem0 # xfs_io -c "extsize 2m" /mnt/pmem0 fio with libpmem

Re: DAX 2MB mappings for XFS

On Fri, 2018-01-12 at 15:52 -0800, Darrick J. Wong wrote: > On Fri, Jan 12, 2018 at 11:15:00PM +0000, Kani, Toshi wrote: : > > > > ext4 creates multiple smaller extents for the same request. > > > > > > Yes, because it has much, much smaller block groups so &q

Re: DAX 2MB mappings for XFS

On Sat, 2018-01-13 at 09:27 +1100, Dave Chinner wrote: > On Fri, Jan 12, 2018 at 09:38:22PM +0000, Kani, Toshi wrote: > > On Sat, 2018-01-13 at 08:19 +1100, Dave Chinner wrote: > > : > > > IOWs, what you are seeing is trying to do a very large allocation on > > >

Re: DAX 2MB mappings for XFS

On Sat, 2018-01-13 at 08:19 +1100, Dave Chinner wrote: : > IOWs, what you are seeing is trying to do a very large allocation on > a very small (8GB) XFS filesystem. It's rare someone asks to > allocate >25% of the filesystem space in one allocation, so it's not > surprising it triggers

Re: [PATCH] acpi, nfit: fix register dimm error handling

On Fri, 2018-02-02 at 12:31 -0800, Dan Williams wrote: > On Fri, Feb 2, 2018 at 1:00 PM, Toshi Kani wrote: > > A NULL pointer reference kernel bug was observed when > > acpi_nfit_add_dimm() called in acpi_nfit_register_dimms() > > failed. This error path does not set

Re: Snapshot target and DAX-capable devices

On Tue, 2018-08-28 at 13:56 -0400, Mike Snitzer wrote: > On Tue, Aug 28 2018 at 3:50am -0400, > Jan Kara wrote: > > > On Mon 27-08-18 16:43:28, Kani, Toshi wrote: > > > On Mon, 2018-08-27 at 18:07 +0200, Jan Kara wrote: > > > > Hi, > > > > &g

Re: Snapshot target and DAX-capable devices

On Mon, 2018-08-27 at 18:07 +0200, Jan Kara wrote: > Hi, > > I've been analyzing why fstest generic/081 fails when the backing device is > capable of DAX. The problem boils down to the failure of: > > lvm vgcreate -f vg0 /dev/pmem0 > lvm lvcreate -L 128M -n lv0 vg0 > lvm lvcreate -s -L 4M -n

Re: open sets ext4_da_aops for DAX existing files

On Mon, 2018-09-10 at 08:54 -0400, Jeff Moyer wrote: > "Kani, Toshi" writes: > > > I noticed that both ext4_da_aops and ext4_dax_aops are used on DAX > > mounted ext4 files. Looking at open() path: > > Eek. How did you notice this? I tested sync path

Re: [ndctl PATCH v2 2/3] nfit, address-range-scrub: rework and simplify ARS state machine

On Thu, 2018-04-05 at 21:19 -0700, Dan Williams wrote: > ARS is an operation that can take 10s to 100s of seconds to find media > errors that should rarely be present. If the platform crashes due to > media errors in persistent memory, the expectation is that the BIOS will > report those known

Re: [ndctl PATCH v2 2/3] nfit, address-range-scrub: rework and simplify ARS state machine

On Fri, 2018-04-06 at 15:13 -0700, Dan Williams wrote: > On Fri, Apr 6, 2018 at 3:06 PM, Kani, Toshi <toshi.k...@hpe.com> wrote: > > On Thu, 2018-04-05 at 21:19 -0700, Dan Williams wrote: > > > ARS is an operation that can take 10s to 100s of seconds to find media > &g

Re: [PATCH 5/6] nfit, address-range-scrub: rework and simplify ARS state machine

On Mon, 2018-04-02 at 21:46 -0700, Dan Williams wrote: : > +static int init_ars(struct acpi_nfit_desc *acpi_desc, struct nfit_spa > *nfit_spa, > + int query_rc) > { > - struct acpi_nfit_system_address *spa = nfit_spa->spa; > - unsigned int overflow_retry =

Re: Write through caching on NVDIMM

On Thu, 2018-04-19 at 16:12 -0700, Brian Stark wrote: > I was comparing different caching techniques using MTRR entries and I > found something strange. Note the output is from a basic utility that > uses mmap. > > NV Memory: > > Write-back > > Writes took 2075.993408 Megabytes per second >

Re: [PATCH 0/4] Adding support to parse BERT for libnvdimm

On Thu, 2018-03-29 at 15:37 -0700, Dave Jiang wrote: > The following series implements support for parsing of the BERT records > and adding the error memory ranges to nvdimm badblocks in order for the > kernel to avoid prevent the kernel from accessing those areas. And with > the addition of this

Re: [PATCH 0/4] Adding support to parse BERT for libnvdimm

On Fri, 2018-03-30 at 09:49 -0700, Dave Jiang wrote: > > On 03/30/2018 09:45 AM, Kani, Toshi wrote: > > On Fri, 2018-03-30 at 09:38 -0700, Dan Williams wrote: > > > On Fri, Mar 30, 2018 at 8:04 AM, Kani, Toshi <toshi.k...@hpe.com> wrote: > > > > On Thu, 2018

Re: [PATCH 0/4] Adding support to parse BERT for libnvdimm

On Fri, 2018-03-30 at 09:38 -0700, Dan Williams wrote: > On Fri, Mar 30, 2018 at 8:04 AM, Kani, Toshi <toshi.k...@hpe.com> wrote: > > On Thu, 2018-03-29 at 15:37 -0700, Dave Jiang wrote: > > > The following series implements support for parsing of the BERT records > >

Re: [PATCH] acpi, numa: fix pxm to online numa node associations

On Thu, 2018-03-15 at 20:08 -0700, Dan Williams wrote: > Commit 99759869faf1 "acpi: Add acpi_map_pxm_to_online_node()" added > support for mapping a given proximity to its nearest, by SLIT distance, > online node. However, it sometimes returns unexpected results due to the > fact that it switches

Re: [PATCH] nfit: skip region registration for incomplete control regions

On Wed, 2018-03-21 at 21:42 -0700, Dan Williams wrote: > Per the ACPI specification the only functional purpose for a DIMM > Control Region to be mapped into the system physical address space, from > an OSPM perspective, is to support block-apertures. However, there are > some BIOSen that publish

Re: [PATCH v2 00/10] Copy Offload in NVMe Fabrics with P2P PCI Memory

On Fri, 2018-03-02 at 09:34 +1100, Benjamin Herrenschmidt wrote: > On Thu, 2018-03-01 at 14:31 -0800, Linus Torvalds wrote: > > On Thu, Mar 1, 2018 at 2:06 PM, Benjamin Herrenschmidt > > wrote: > > > > > > Could be that x86 has the smarts to do the right thing, still trying to

Re: [PATCH v2 00/10] Copy Offload in NVMe Fabrics with P2P PCI Memory

On Fri, 2018-03-02 at 08:57 -0800, Linus Torvalds wrote: > On Fri, Mar 2, 2018 at 8:22 AM, Kani, Toshi <toshi.k...@hpe.com> wrote: > > > > FWIW, this thing is called MTRRs on x86, which are initialized by BIOS. > > No. > > Or rather, that's simply ju

Re: [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode

On Thu, 2018-06-28 at 13:04 -0600, Ross Zwisler wrote: > On Thu, Jun 28, 2018 at 05:42:34PM +0000, Kani, Toshi wrote: > > On Tue, 2018-06-26 at 16:04 -0600, Ross Zwisler wrote: > > > On Tue, Jun 26, 2018 at 02:51:52PM -0700, Dan Williams wrote: > > > > On Tue, Jun 26

Re: [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode

On Thu, 2018-06-28 at 13:48 -0400, Mike Snitzer wrote: > On Thu, Jun 28 2018 at 1:42pm -0400, > Kani, Toshi wrote: > > > On Tue, 2018-06-26 at 16:04 -0600, Ross Zwisler wrote: > > > On Tue, Jun 26, 2018 at 02:51:52PM -0700, Dan Williams wrote: > > > > O

Re: [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode

On Tue, 2018-06-26 at 16:04 -0600, Ross Zwisler wrote: > On Tue, Jun 26, 2018 at 02:51:52PM -0700, Dan Williams wrote: > > On Tue, Jun 26, 2018 at 2:31 PM, Kani, Toshi wrote: > > > On Tue, 2018-06-26 at 14:28 -0700, Dan Williams wrote: > > > > On Tue, Jun 26, 2018

Re: [nvdimm PATCH 0/6] Label initialization time optimizations

On Wed, 2018-10-10 at 16:36 -0700, Alexander Duyck wrote: > This patch set is intended to improve NVDIMM label read times by first > increasing the upper limit on the label read/write size, and then > reducing the number of reads by making use of the free label bitmap in > the index to determine

Re: [PATCH] libnvdimm: Fix __nd_ioctl() to check error in cmd_rc

On Wed, 2018-11-07 at 11:34 -0800, Dan Williams wrote: > On Wed, Nov 7, 2018 at 10:52 AM Toshi Kani wrote: > > > > ndctl zero-labels completes with a large number of zeroed nmems when > > it fails to do zeroing on a protected NVDIMM. > > > > # ndctl zero-labels nmem1 > > zeroed 65504 nmems

Re: Snapshot target and DAX-capable devices

On Wed, 2018-12-12 at 12:50 -0500, Mike Snitzer wrote: > On Wed, Dec 12 2018 at 11:12am -0500, > Christoph Hellwig wrote: > > > Does it really make sense to enhance dm-snapshot? I thought all serious > > users of snapshots had moved on to dm-thinp? > > There are cases where dm-snapshot is

Re: [PATCH 1/2] ext4, dax: update dax check to skip journal inode

On Wed, 2018-09-12 at 11:24 +0200, Jan Kara wrote: > On Tue 11-09-18 09:42:45, Toshi Kani wrote: > > Ext4 mount path calls ext4_iget() to obtain the journal inode. This > > inode does not support DAX, and 'ext4_da_aops' needs to be set. It > > currently works for the DAX mount case because

Re: [PATCH 1/2] ext4, dax: update dax check to skip journal inode

On Wed, 2018-09-12 at 18:20 +0200, Jan Kara wrote: > On Wed 12-09-18 15:47:12, Kani, Toshi wrote: > > On Wed, 2018-09-12 at 11:24 +0200, Jan Kara wrote: > > > On Tue 11-09-18 09:42:45, Toshi Kani wrote: > > > > Ext4 mount path calls ext4_iget() to obtain the journal i

Re: [PATCH 2/2] ext4, dax: set ext4_dax_aops for dax files

On Wed, 2018-09-12 at 11:31 +0200, Jan Kara wrote: > On Tue 11-09-18 11:15:18, Dan Williams wrote: > > On Tue, Sep 11, 2018 at 8:42 AM, Toshi Kani wrote: > > > Sync syscall to an existing DAX file needs to flush processor cache, > > > but it does not currently. This is because 'ext4_da_aops' is

Re: open sets ext4_da_aops for DAX existing files

On Tue, 2018-09-11 at 17:27 +0200, Jan Kara wrote: > On Mon 10-09-18 17:58:10, Elliott, Robert (Persistent Memory) wrote: > > > > > > > -Original Message- > > > From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf > > > Of Ka

Re: [PATCH 2/2] ext4, dax: set ext4_dax_aops for dax files

On Tue, 2018-09-11 at 11:15 -0700, Dan Williams wrote: > On Tue, Sep 11, 2018 at 8:42 AM, Toshi Kani wrote: > > Sync syscall to an existing DAX file needs to flush processor cache, > > but it does not currently. This is because 'ext4_da_aops' is set to > > address_space_operations of existing

Re: [PATCH 1/2] ext4, dax: update dax check to skip journal inode

On Tue, 2018-09-11 at 10:59 -0700, Dan Williams wrote: > On Tue, Sep 11, 2018 at 8:42 AM, Toshi Kani wrote: > > Ext4 mount path calls ext4_iget() to obtain the journal inode. This > > inode does not support DAX, and 'ext4_da_aops' needs to be set. It > > currently works for the DAX mount case

Re: [LSF/MM TOPIC] The end of the DAX experiment

On Wed, 2019-02-06 at 13:12 -0800, Dan Williams wrote: > Before people get too excited this isn't a proposal to kill DAX. The > topic proposal is a discussion to resolve lingering open questions > that currently motivate ext4 and xfs to scream "EXPERIMENTAL" when the > current DAX facilities are

Re: [PATCH v2 0/6] nfit/ars: Improve polling and short-ARS execution

On Fri, 2019-02-15 at 11:43 -0800, Dan Williams wrote: > Changes since v1: [1] > * Fix the root poll interval support to avoid a infinite loop condition > when the polling is faster than the ARS completion. > * Move the introduction of scrub_flags earlier in the series and > introduce ARS_POLL

Re: [PATCH] uapi: Add the BSD-2-Clause license to ndctl.h

On Fri, 2019-10-25 at 22:56 +, Verma, Vishal L wrote: > On Fri, 2019-10-25 at 15:45 -0700, Dan Williams wrote: > > On Fri, Oct 25, 2019 at 10:55 AM D Scott Phillips > > wrote: > > > Allow ndctl.h to be licensed with BSD-2-Clause so that other > > > operating systems can provide the same user