On Thu, 2021-05-13 at 11:42 +0530, Santosh Sivaraj wrote:
> The alignment sizes passed to ndctl in the tests are all hardcoded to 4k,
> the default page size on x86. Change those to the default page size on that
> architecture (sysconf/getconf). No functional changes otherwise.
>
> Signed-off-by:
On Wed, 2021-05-12 at 21:00 +, Verma, Vishal L wrote:
>
> Did you mean for the errno check to be if (errno != ENOENT) ?
> This is what was causing the unit test failure for me. This patch on
> top fixes it for me:
>
> diff --git a/test/core.c b/test/core.c
> index 44
On Sat, 2021-05-01 at 11:57 +0530, Santosh Sivaraj wrote:
> "Verma, Vishal L" writes:
>
> Hi Vishal,
>
> > On Sun, 2021-03-28 at 07:39 +0530, Santosh Sivaraj wrote:
> > > For NFIT to be available ACPI is a must, so don't fail when nfit modules
> &g
On Sun, 2021-03-28 at 07:39 +0530, Santosh Sivaraj wrote:
> For NFIT to be available ACPI is a must, so don't fail when nfit modules
> are missing on a platform that doesn't support ACPI.
>
> Signed-off-by: Santosh Sivaraj
> ---
> test.h| 2 +-
>
On Fri, 2021-03-19 at 11:20 +0530, Santosh Sivaraj wrote:
> "Verma, Vishal L" writes:
[..]
> >
> > fix multi line comment to the right formatting:
> > /*
> > * line 1, etc
> > */
> >
>
> Will fix that.
>
> > > + i
On Thu, 2021-03-11 at 13:16 +0530, Santosh Sivaraj wrote:
> This will help in getting the dimm fail tests to run on papr family too.
> Also add nvdimm_test compatibility string for recognizing the test module.
>
> Signed-off-by: Santosh Sivaraj
> ---
> ndctl/lib/libndctl.c | 5 -
> 1 file
On Thu, 2021-03-11 at 13:16 +0530, Santosh Sivaraj wrote:
> For NFIT to be available ACPI is a must, so don't fail when nfit modules
> are missing on a platform that doesn't support ACPI.
>
> Signed-off-by: Santosh Sivaraj
> ---
> test.h| 2 +-
>
On Thu, 2021-03-11 at 13:16 +0530, Santosh Sivaraj wrote:
> Unify adding dimms for papr and nfit families, this will help in adding
Minor nit, but it seems like the subject line and the first sentence in
the body should be swapped. The one-line description of what's happening
in this patch is
On Tue, 2021-03-09 at 17:43 -0800, Dan Williams wrote:
> Previous kernels allowed the BLKROSET to override the disk's read-only
> status. With that situation fixed the pmem driver needs to rely on
> notification events to reevaluate the disk read-only status after the
> host region has been marked
On Tue, 2021-03-02 at 02:25 +0900, QI Fuli wrote:
> Add checking jq command since it is needed to validate tests
>
> Cc: Santosh Sivaraj
> Signed-off-by: QI Fuli
> Link: https://github.com/pmem/ndctl/issues/141
> ---
> configure.ac | 6 ++
> 1 file changed, 6 insertions(+)
Hm, I think I
Basically move ndctl_bus_nfit_translate_spa declaration from private.h
> to libndctl.h.
>
> Changes from V1:
> - Group function declaration in libndctl.h with other ndctl_bus_* functions.
>
> Reviewed-by: Dan Williams
> Reviewed-by: Verma, Vishal L
Hi Erwin,
I forgot to mention this for v1 but you'
On Wed, 2021-02-24 at 15:48 -0800, Tsaur, Erwin wrote:
> The motivation is to allow access to ACPI defined NVDIMM Root Device _DSM
> Function Index 5(Translate SPA). The rest of the _DSM functions, which are
> mostly ARS related, are already public.
>
> Basically move
On Mon, 2021-02-22 at 13:36 -0800, Ben Widawsky wrote:
[..]
>
> > +SYNOPSIS
> > +
> > +[verse]
> > +'cxl list' []
> > +
> > +Walk the CXL capable device hierarchy in the system and list all device
> > +instances along with some of their major attributes.
>
> This doesn't seem to match
On Tue, 2021-01-05 at 13:03 -0800, Dan Williams wrote:
> Julia and 0day report:
>
> Zero-length and one-element arrays are deprecated, see
> Documentation/process/deprecated.rst
> Flexible-array members should be used instead.
>
> However, a straight conversion to flexible arrays
A new ndctl release is available[1].
Highlights include support for the new device-dax subdivision
functionality added in Linux in v5.10, including ways to create smaller
devdax devices using daxctl/libdaxctl, as well as creating, listing, and
restoring from a config dump, 'mappings' on these
On Fri, 2020-12-18 at 02:14 +, Joao Martins wrote:
> Hey,
>
> This series adds support for:
>
> 1) Listing mappings when passing -M to ´daxctl list´. These are ommited
> by default.
>
> 2) Iteration APIs for the mappings.
>
> 3) Allow passing an input JSON file with the manually
On Thu, 2020-12-17 at 11:23 +, Joao Martins wrote:
>
> The provisioning flow additions has some questions open about the daxctl
> user interface. To summarize:
>
> 1) Should we always list mappings, or only list them with a -v option? Or
> maybe instead of -v to use instead a new -M option
On Wed, 2020-11-25 at 09:00 +0800, Zhiqiang Liu wrote:
> Changes: V1->V2
> - add one empty line in 1/8 patch as suggested by Jeff Moyer
> .
>
>
> Recently, we use Coverity to analysis the ndctl package.
> Several issues should be resolved to make Coverity happy.
>
> Zhiqiang Liu (8):
>
On Fri, 2020-11-06 at 17:27 +0800, Zhiqiang Liu wrote:
> ndctl_bus_cmd_new_ars_cp() is called to create cmd,
> which may return NULL. We need to check whether it
> is NULL in callers, such as ndctl_namespace_get_clear_uint
> and ndctl_namespace_injection_status.
>
> Signed-off-by: Zhiqiang Liu
>
On Wed, 2020-12-16 at 22:48 +, Joao Martins wrote:
> Hey,
>
> This series adds support for:
>
> 1) {create,reconfigure}-device for selecting @align (hugepage size).
> Here we add a '-a|--align 4K|2M|1G' option to the existing commands;
>
> 2) Listing now displays align (if supported).
>
On Wed, 2020-12-16 at 11:39 +, Joao Martins wrote:
> On 7/16/20 7:46 PM, Joao Martins wrote:
> > Hey,
> >
> > This series builds on top of this one[0] and does the following improvements
> > to the Soft-Reserved subdivision:
> >
> > 1) Support for {create,reconfigure}-device for selecting
On Thu, 2020-12-10 at 15:01 +, Joao Martins wrote:
> On 7/21/20 5:49 PM, Joao Martins wrote:
> > On 7/13/20 5:08 PM, Joao Martins wrote:
> > > Add a couple tests which exercise the new sysfs based
> > > interface for Soft-Reserved regions (by EFI/HMAT, or
> > > efi_fake_mem).
> > >
> > > The
On Thu, 2020-12-10 at 15:01 +, Joao Martins wrote:
> On 7/21/20 5:49 PM, Joao Martins wrote:
> > On 7/13/20 5:08 PM, Joao Martins wrote:
> > > Add a couple tests which exercise the new sysfs based
> > > interface for Soft-Reserved regions (by EFI/HMAT, or
> > > efi_fake_mem).
> > >
> > > The
On Fri, 2020-11-20 at 10:45 +0800, Zhiqiang Liu wrote:
> Friendly ping...
>
> I just wonder if this kind of patches will not be reviewed
> and processed.
>
> I`d be very happy to receive any feedback.
Hi Zhiqiang,
These are definitely on my list to look at, I've just not had the time
to do so
On Wed, 2020-11-18 at 16:41 +0800, Zhen Lei wrote:
> The badrange to be reported should always cover mce->addr.
>
> Signed-off-by: Zhen Lei
> ---
> drivers/acpi/nfit/mce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Ah good find, agreed with Dan that this is stable material.
Minor
On Tue, 2020-10-27 at 21:49 +0800, Zhang Qilong wrote:
> Initial value of rc is '-ENXIO', and we should
> use the initial value to check it.
>
> Signed-off-by: Zhang Qilong
> ---
> drivers/acpi/nfit/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Looks good,
Reviewed-by: Vishal
On Thu, 2020-10-08 at 20:33 +0100, Matthew Wilcox wrote:
> On Thu, Aug 06, 2020 at 08:16:02PM +0000, Verma, Vishal L wrote:
> > On Thu, 2020-08-06 at 19:44 +0000, Verma, Vishal L wrote:
> > > > I'm running xfstests on this patchset right now. If one of the DAX
> >
On Fri, 2020-10-09 at 17:30 +0530, Vaibhav Jain wrote:
> commit 107a24ff429f ("ndctl/list: Add firmware activation
> enumeration") introduced changes in add_dimm() to enumerate the status
> of firmware activation. However a branch added in that commit broke
> the probe for non-nfit nvdimms like
On Tue, 2020-10-06 at 17:15 -0700, Dan Williams wrote:
> Until RHEL moves to asciidoctor fallback to the old asciidoc for RHEL
> builds.
>
> Signed-off-by: Dan Williams
> ---
> ndctl.spec.in |7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
Thanks Dan - looks good!
I applied
A new release of ndctl is available [1].
Highlights include support for the new firmware activation facility, a
new 'split-acpi' command in 'daxctl'to aid testing and debugging, and
other minor fixes.
A shortlog is appended below.
[1]: https://github.com/pmem/ndctl/releases/tag/v70
Dan
On Tue, 2020-09-15 at 10:01 +0200, Jan Kara wrote:
> Hi!
>
> On Tue 15-09-20 11:03:29, col...@suse.de wrote:
> > Could you please to take a look? I am offline in the next two weeks.
>
> I just had a look into this. IMHO the justification in 6180bb446a "dax: fix
> detection of dax support for
Hi Linus, please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git
tags/libnvdimm-fix-v5.9-rc5
...to receive another fix for detection of DAX support for block
devices. The previous fix in this area (merged in -rc3) was incomplete,
and this should finally address all the
On Thu, 2020-09-03 at 00:40 +0800, Coly Li wrote:
> On 2020/9/3 00:04, Mike Snitzer wrote:
> > 5.9 commit 231609785cbfb ("dax: print error message by pr_info() in
> > __generic_fsdax_supported()") switched from pr_debug() to pr_info().
> >
> > The justification in the commit header is really
Hi Linus, please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git
tags/libnvdimm-fix-v5.9-rc3
...to receive a couple of minor fixes for things merged in 5.9-rc1. One
is an out-of-bounds access caught by KASAN, and the second is a tweak to
some overzealous logging about
On Wed, 2020-08-19 at 03:23 +, Zhang, Qiang wrote:
> cc: Dan Williams
> Please review.
Hi Qiang,
I've got this queued up, I'll submit it for -rc2.
Thanks,
-Vishal
>
>
> 发件人: linux-kernel-ow...@vger.kernel.org
> 代表 qiang.zh...@windriver.com
>
On Fri, 2020-08-14 at 10:10 -0700, Ira Weiny wrote:
> On Fri, Aug 14, 2020 at 08:35:09PM +0530, Vaibhav Jain wrote:
> > We recently discovered a kernel oops with 'papr_scm' module while
> > booting ppc64 phyp guest with following back-trace:
> >
> > BUG: Kernel NULL pointer dereference on write
On Fri, 2020-08-14 at 17:28 +0200, Rafael J. Wysocki wrote:
> On Thu, Aug 13, 2020 at 4:54 AM Wang Qing wrote:
> > Use kobj_to_dev() instead of container_of()
> >
> > Signed-off-by: Wang Qing
>
> LGTM
>
> Dan, any objections?
Looks good to me - you can add:
Acked-by: Vishal Verma
>
> > ---
Hi Linus, please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git/
tags/libnvdimm-for-5.9
...to receive a new feature in libnvdimm - 'Runtime Firmware
Activation', and a few small cleanups and fixes in libnvdimm and DAX.
You'd normally receive this pull request from
On Thu, 2020-08-06 at 19:44 +, Verma, Vishal L wrote:
> >
> > I'm running xfstests on this patchset right now. If one of the DAX
> > people could try it out, that'd be fantastic.
> >
> > Matthew Wilcox (Oracle) (4):
> > mm: Introduce and use page_c
On Tue, 2020-08-04 at 17:17 +0100, Matthew Wilcox (Oracle) wrote:
> We actually use nrexceptional for very little these days. It's a
> constant
> source of pain with the THP patches because we don't know how large a
> shadow entry is, so either we have to ask the xarray how many indices
> it
A new ndctl release is available[1].
Highlights include support for 'PAPR' NVDIMMs, a build fix for
zero-length array warnings in GCC10, a new option for ndctl-monitor
allowing for a timeout for epoll, and misc unit test and documentation
fixes.
A shortlog is appended below.
[1]:
On Wed, 2020-07-22 at 07:29 +0530, Vaibhav Jain wrote:
> Vishal Verma writes:
>
>
> > > static int papr_xlat_firmware_status(struct ndctl_cmd *cmd)
> > > {
> > > - const struct nd_pkg_pdsm *pcmd = to_pdsm(cmd);
> > > -
> > > - return pcmd->cmd_status;
> > > + return (cmd->type == ND_CMD_CALL)
On Fri, 2020-07-17 at 20:24 +0200, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't
On Mon, 2020-06-29 at 18:33 +0200, Rafael J. Wysocki wrote:
> From: "Rafael J. Wysocki"
>
> The ACPICA's strategy with respect to the handling of memory mappings
> associated with memory operation regions is to avoid mapping the
> entire region at once which may be problematic at least in
On Wed, 2020-06-17 at 22:12 +0530, Vaibhav Jain wrote:
> Hi Vishal,
>
> Thanks for reviewing this patch. I will be addressing your review
> comments in v7 of this patch series.
>
> ~ Vaibhav
>
Thanks Vaibhav. The rest of the series looks good to me, so once you
send the update, I'll queue it up
On Tue, 2020-06-16 at 11:00 +0530, Vaibhav Jain wrote:
> Add necessary scaffolding in libndctl for dimms that support papr_scm
support /the/ papr_scm specification
> specification[1]. Since there can be platforms that support
> Open-Firmware[2] but not the papr_scm specification, hence the
On Tue, 2020-06-16 at 11:00 +0530, Vaibhav Jain wrote:
> Presently add_dimm() only probes dimms that support NFIT/ACPI. Hence
"...probes NVDIMMs for platforms that support the ACPI NFIT"
The NFIT is a platform firmware thing, not directly related to the DIMMs
themselves.
> this patch refactors
On Sat, 2020-05-30 at 03:35 +0530, Vaibhav Jain wrote:
> There are scenarios when a dimm-provider need to allocate some
> per-dimm data that can be quickly retrieved. This data can be used to
> cache data that spans multiple 'struct ndctl_cmd' submissions.
>
> Unfortunately currently in libnvdimm
On Wed, 2020-06-03 at 15:27 +0530, Vaibhav Jain wrote:
> >
> > Two things here:
> > 1. Why not use the new ndctl_bus_has_of_node helper here? and
> > 2. This looks redundant. add_papr_dimm() is only called if
> > ndctl_bus_has_of_node() during add_dimm.
> Presently we have two different nvdimm
On Sat, 2020-05-30 at 03:35 +0530, Vaibhav Jain wrote:
> diff --git a/ndctl/lib/libndctl.c b/ndctl/lib/libndctl.c
> index d76dbf7e17de..a52c2e208fbe 100644
> --- a/ndctl/lib/libndctl.c
> +++ b/ndctl/lib/libndctl.c
> @@ -799,6 +799,28 @@ static void parse_nfit_mem_flags(struct ndctl_dimm
> *dimm,
On Sat, 2020-05-30 at 03:35 +0530, Vaibhav Jain wrote:
> Presently add_dimm() only probes dimms that support NFIT/ACPI. Hence
> this patch refactors this functionality into two functions namely
> add_dimm() and add_nfit_dimm(). Function add_dimm() performs
> allocation and common 'struct
On Fri, 2020-04-17 at 08:38 +0200, Michal Hocko wrote:
> On Thu 16-04-20 16:54:38, Vishal Verma wrote:
> > A misbehaving qemu created a situation where the ACPI SRAT table
> > advertised one fewer proximity domains than intended. The NFIT table did
> > describe all the expected proximity domains.
On Thu, 2020-04-16 at 19:53 +0200, David Hildenbrand wrote:
> > > >
> > > Hm, I'm happy to make the changes, but EINVAL to me suggests there is a
> > > problem in the way this was called by the user. And in this case there
> > > really might not be much the user can change in case fo buggy
On Thu, 2020-04-16 at 19:12 +0200, David Hildenbrand wrote:
> On 16.04.20 19:10, Vishal Verma wrote:
> >
> > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> > index 0a54ffac8c68..ddd3347edd54 100644
> > --- a/mm/memory_hotplug.c
> > +++ b/mm/memory_hotplug.c
> > @@ -1005,6 +1005,11 @@
On Thu, 2020-04-16 at 18:16 +0200, David Hildenbrand wrote:
> > >
> > > Doing that papers over something that is clearly a FW issue and makes
> > > it "my performance is suboptimal" deal with it OS problem. Really, is
> > > this something we have to care about. Your changelog talks about a Qemu
On Thu, 2020-04-16 at 08:19 +0200, Michal Hocko wrote:
> On Wed 15-04-20 20:32:00, Verma, Vishal L wrote:
> > >
> > > I really do not like this. Why should we try to be clever and change the
> > > node id requested by the caller? I would just stick with node_po
On Wed, 2020-04-15 at 12:43 +0200, Michal Hocko wrote:
> On Tue 14-04-20 17:58:12, Vishal Verma wrote:
> [...]
> > +static int check_hotplug_node(int nid)
> > +{
> > + int alt_nid;
> > +
> > + if (node_possible(nid))
> > + return nid;
> > +
> > + alt_nid =
On Thu, 2020-03-26 at 09:25 +, Dorau, Lukasz wrote:
> Add a missing config setting to README.md:
> CONFIG_DEV_DAX_PMEM_COMPAT=m
>
> Cc: Williams, Dan J
> Cc: Verma, Vishal L
> Signed-off-by: Lukasz Dorau
> ---
> README.md | 1 +
> 1 file changed, 1 insertion(+)
This release incorporates functionality up to the 5.6 kernel.
Highlights for this release include new commands to read-infoblock and
write-infoblock, improvements and tests related to alignment
constraints, misc build/compilation related fixes, and misc usability
and documentation fixes.
The
On Sat, 2020-02-29 at 12:20 -0800, Dan Williams wrote:
> Changes from review:
> - Add NDCTL_LIST_LINT to not regress list output (Jeff)
> - Add kernel-doc description for ndctl_region_set_align() (Jeff)
>
> ---
>
> About half of these have been posted previously, but have been reworked
> and
On Wed, 2020-02-19 at 12:09 -0800, Dan Williams wrote:
> > >
> > > Let's do a compromise, because users also hate nonsensical legacy that
> > > they can't avoid. How about an environment variable,
> > > "NDCTL_LIST_LINT", that users can set to opt into the latest /
> > > cleanest output format
On Wed, 2020-02-19 at 10:53 -0800, Dan Williams wrote:
>
> > > > Will this break existing code that parses the javascript output?
> > >
> > > Always a potential for that. That said, I'd rather attempt to make it
> > > symmetric and replace it if someone screams, rather than let this
> > > quirk
On Thu, 2020-01-30 at 11:03 -0800, Dan Williams wrote:
> On Thu, Jan 30, 2020 at 10:56 AM Vishal Verma
> wrote:
> > A toolchain update in Fedora 32 caused new compile errors due to
> > multiple definitions of dimm_ops structures. The declarations in
> > 'private.h' for the various NFIT families
On Tue, 2019-11-05 at 10:27 -0700, Vishal Verma wrote:
> Add detection of 'seed' namespaces
> (ndctl_namespace_is_configuration_idle()) to the enable-namespace
> operatiuon and libndctl API. In libndctl, return a '1' for seed
> namespaces. In namespace.c, reinterpret a '1' based on a check for a
On Mon, 2019-11-04 at 13:08 -0700, Vishal Verma wrote:
>
> diff --git a/util/sysfs.c b/util/sysfs.c
> index 9f7bc1f..81cd055 100644
> --- a/util/sysfs.c
> +++ b/util/sysfs.c
> @@ -20,6 +20,7 @@
> #include
> #include
> #include
> +#include
These are stray lines from the previous version,
On Mon, 2019-11-04 at 10:58 -0800, Dan Williams wrote:
> >
> > > Also, how about
> > > s/ndctl_namespace_is_configurable/ndctl_namespace_is_configuration_idle/?
> > > Because to me all namespaces are always "configurable", but some may
> > > have active non-default properties set.
> >
> >
On Mon, 2019-11-04 at 08:35 -0800, Dan Williams wrote:
> On Fri, Nov 1, 2019 at 1:27 PM Vishal Verma wrote:
> > The motivation for this change is that we want to refrain from
> > (re)configuring what appear to be partially configured namespaces.
> > Namespaces may end up in a state that looks
On Thu, 2019-10-31 at 17:31 -0700, Dan Williams wrote:
> The entire point of nd-core.h is to hide functionality that no leaf
> driver should touch. In fact, the commit that added it had no need to
> include it.
>
> Fixes: 06e8ccdab15f ("acpi: nfit: Add support for detect platform...")
> Cc: Ira
On Thu, 2019-10-31 at 10:05 -0400, Qian Cai wrote:
> drivers/nvdimm/btt.c: In function 'btt_read_pg':
> drivers/nvdimm/btt.c:1264:8: warning: variable 'rc' set but not used
> [-Wunused-but-set-variable]
> int rc;
> ^~
>
> Add a ratelimited message in case a storm of errors is
On Thu, 2019-10-17 at 08:35 +0530, Aneesh Kumar K.V wrote:
>
> > > ---
> > > ndctl/namespace.c | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/ndctl/namespace.c b/ndctl/namespace.c
> > > index 58a9e3c53474..1f212a2b3a9b 100644
> > > ---
On Wed, 2019-10-30 at 17:28 -0400, Qian Cai wrote:
> drivers/nvdimm/btt.c: In function 'btt_read_pg':
> drivers/nvdimm/btt.c:1264:8: warning: variable 'rc' set but not used
> [-Wunused-but-set-variable]
> int rc;
> ^~
>
> Add a ratelimited message in case a storm of errors is
On Tue, 2019-10-29 at 10:56 -0700, Dan Williams wrote:
> Text that follows a list tends to continue the list indentation. Use a
> bare "::" to end the list indentation.
>
> Signed-off-by: Dan Williams
> ---
> Documentation/ndctl/ndctl-create-namespace.txt |2 +-
> 1 file changed, 1
This release incorporates functionality up to the 5.4 kernel, and adds a
number of bug fixes, and improvements.
Highlights include small changes for PowerPC compatibility, improvements
to the dax.sh unit test to detect failures in mapping huge pages,
support for the 'security frozen' attribute,
On Fri, 2019-10-25 at 15:21 -0700, Ira Weiny wrote:
> How about this patch instead? Untested.
>
> Ira
Not a big deal, but just a quick note - if you include a scissors line
here, I can easily apply it via git am --scissors
--8<--
Otherwise this looks good in principle.
I've already got
On Fri, 2019-10-25 at 15:45 -0700, Dan Williams wrote:
> On Fri, Oct 25, 2019 at 10:55 AM D Scott Phillips
> wrote:
> > Allow ndctl.h to be licensed with BSD-2-Clause so that other
> > operating systems can provide the same user level interface.
> > ---
> >
> > I've been working on nvdimm
> On Wed, 2019-10-23 at 19:33 +0000, Verma, Vishal L wrote:
> > > @@ -91,4 +111,4 @@ json=$($NDCTL create-namespace -m raw -f -e $dev)
> > > eval $(json2var <<< "$json")
> > > [ $mode != "fsdax" ] && echo "fail: $LINENO&qu
On Wed, 2019-10-23 at 22:28 +, Verma, Vishal L wrote:
> On Fri, 2019-10-18 at 17:06 -0400, Jeff Moyer wrote:
> > Ira Weiny writes:
> > > On Fri, Oct 18, 2019 at 04:23:01PM -0400, Jeff Moyer wrote:
> > > > The 'done' variable only adds confusion.
> > &g
On Fri, 2019-10-18 at 17:06 -0400, Jeff Moyer wrote:
> Ira Weiny writes:
> > On Fri, Oct 18, 2019 at 04:23:01PM -0400, Jeff Moyer wrote:
> > > The 'done' variable only adds confusion.
> > >
> > > Signed-off-by: Jeff Moyer
> > > ---
> > > ndctl/dimm.c | 7 +--
> > > 1 file changed, 1
On Wed, 2019-10-23 at 19:33 +, Verma, Vishal L wrote:
>
> > @@ -91,4 +111,4 @@ json=$($NDCTL create-namespace -m raw -f -e $dev)
> > eval $(json2var <<< "$json")
> > [ $mode != "fsdax" ] && echo "fail: $LINENO" &
On Sat, 2019-10-19 at 09:39 -0700, Dan Williams wrote:
> Using trace-cmd to validate the expectations of the huge page faults
> generated by the dax-pmd.c test.
>
> Signed-off-by: Dan Williams
> ---
> test/dax.sh | 24 ++--
> 1 file changed, 22 insertions(+), 2
On Fri, 2019-10-18 at 13:58 -0700, Dan Williams wrote:
>
> > +++ b/Documentation/daxctl/movable-options.txt
> > @@ -0,0 +1,10 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +
> > +-M::
> > +--no-movable::
>
> If --movable is the default I would expect -M to be associated with
> --movable. Don't
On Fri, 2019-10-18 at 13:46 -0700, Dan Williams wrote:
>
> > +'daxctl-reconfigure-device' nominally expects that it will online new
> > memory
> > +blocks as 'movable', so that kernel data doesn't make it into this memory.
> > +However, there are other potential agents that may be configured to
>
On Fri, 2019-10-18 at 15:55 +0530, Aneesh Kumar K.V wrote:
> Aneesh Kumar K.V writes:
>
> > "Verma, Vishal L" writes:
> >
> > > On Wed, 2019-08-07 at 10:14 +0530, Aneesh Kumar K.V wrote:
> > > > When using reconfigure command to add a `
On Tue, 2019-10-01 at 16:19 -0700, Ira Weiny wrote:
>
> > diff --git a/daxctl/lib/libdaxctl.c b/daxctl/lib/libdaxctl.c
> > index 8abfd64..639224c 100644
> > --- a/daxctl/lib/libdaxctl.c
> > +++ b/daxctl/lib/libdaxctl.c
> > @@ -204,8 +204,9 @@ DAXCTL_EXPORT void daxctl_region_get_uuid(struct
> >
On Wed, 2019-09-25 at 11:10 -0700, ira.we...@intel.com wrote:
> From: Ira Weiny
>
> Don't leave claim_class set to an invalid value if an error occurs in
> btt_claim_class().
>
> While we are here change the return type of __holder_class_store() to be
> clear about the values it is returning.
>
On Wed, 2019-09-25 at 11:25 -0600, Weiny, Ira wrote:
> > On Wed, 2019-09-25 at 14:00 +0300, Dan Carpenter wrote:
> > > The "ndns->claim_class" variable is an enum but in this case GCC will
> > > treat it as an unsigned int so the error handling is never triggered.
> > >
> > > Fixes: 14e494542636
On Wed, 2019-09-25 at 14:00 +0300, Dan Carpenter wrote:
> The "ndns->claim_class" variable is an enum but in this case GCC will
> treat it as an unsigned int so the error handling is never triggered.
>
> Fixes: 14e494542636 ("libnvdimm, btt: BTT updates for UEFI 2.7 format")
> Signed-off-by: Dan
On Wed, 2019-09-11 at 19:54 -0700, Joe Perches wrote:
> Avoid using uncommon logic testing styles to make the code a
> bit more like other kernel code.
>
> e.g.:
> if (foo) {
> ;
> } else {
>
> }
>
> is typically written
>
> if (!foo) {
>
On Wed, 2019-09-11 at 08:48 -0700, Dan Williams wrote:
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3f171339df53..e5d111a86e61 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -98,6 +98,10 @@ Descriptions of section entries:
> Obsolete:Old code. Something tagged obsolete
On Wed, 2019-09-04 at 14:01 -0700, Dan Williams wrote:
> On Wed, Sep 4, 2019 at 1:27 PM Verma, Vishal L
> wrote:
> > On Tue, 2019-09-03 at 19:20 -0700, Dan Williams wrote:
> > >
> > > Hmm, why wait until now to check if this list is NULL. How about fall
> >
On Tue, 2019-09-03 at 19:20 -0700, Dan Williams wrote:
>
> > +static int try_kmod_builtin(struct daxctl_dev *dev, const char *mod_name)
> > +{
> > + const char *devname = daxctl_dev_get_devname(dev);
> > + struct daxctl_ctx *ctx = daxctl_dev_get_ctx(dev);
> > + struct
On Tue, 2019-09-03 at 23:20 +0200, Brice Goglin wrote:
> Hello
>
> It looks like daxctl fails to reconfigure to system-ram when
> DAX modules are built-in the kernel:
>
> $ daxctl reconfigure-device --mode=system-ram dax1.0 -v
> libdaxctl: daxctl_insert_kmod_for_mode: dax1.0: a modalias lookup
On Thu, 2019-08-29 at 10:38 -0700, jane@oracle.com wrote:
> Hi, Vishal,
>
>
> On 8/28/19 5:17 PM, Vishal Verma wrote:
> > Add a --continue option to ndctl-create-namespaces to allow the creation
> > of as many namespaces as possible, that meet the given filter
> > restrictions.
> >
> > The
On Wed, 2019-08-28 at 19:34 -0700, Dan Williams wrote:
> On Wed, Aug 28, 2019 at 5:17 PM Vishal Verma wrote:
> > Add a --continue option to ndctl-create-namespaces to allow the creation
> > of as many namespaces as possible, that meet the given filter
> > restrictions.
> >
> > The creation loop
On Wed, 2019-08-28 at 15:38 -0700, Scargall, Steve wrote:
> Thanks for the clarification. I have a much better understanding
> now.
>
> Updating the ndctl-create-namespace man page to clarify what '
> --region=all' does and does not do in combination with other arguments
> and options would be
On Wed, 2019-08-28 at 21:16 +, Verma, Vishal L wrote:
> On Wed, 2019-08-28 at 13:47 -0700, Scargall, Steve wrote:
> > Hi Jeff,
> >
> > The issue is more of repetition. On an 8-socket system, should a
> > user really be expected to type 'ndctl create-namespace'
On Wed, 2019-08-28 at 13:47 -0700, Scargall, Steve wrote:
> Hi Jeff,
>
> The issue is more of repetition. On an 8-socket system, should a
> user really be expected to type 'ndctl create-namespace' eight times
> vs. running 'ndctl create-namespace --region=all' once? SAP HANA is
> an example
On Wed, 2019-08-28 at 14:36 -0500, Gustavo A. R. Silva wrote:
> struct_size() does not apply to those scenarios. See below...
>
> > [1]:
> > https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git/tree/drivers/nvdimm/region_devs.c#n1030
>
> struct_size() only applies to structures of
On Mon, 2019-06-10 at 16:06 -0500, Gustavo A. R. Silva wrote:
> One of the more common cases of allocation size calculations is
> finding
> the size of a structure that has a zero-sized array at the end, along
> with memory for some number of elements for that array. For example:
>
> struct
On Tue, 2019-08-27 at 11:58 -0700, Dan Williams wrote:
> Erwin reports:
> The current implementation of ndctl clear-errors takes a very long time,
> because a full scrub happens for every namespace.
>
> Doing a full system ARS scrub is obviously not necessary, it just needs
> to
1 - 100 of 390 matches
Mail list logo
