Re: [ndctl PATCH] ndctl, test: Disable poison tests for now

2018-07-02 Thread Jane Chu
On 6/28/2018 1:37 PM, Dan Williams wrote: On Thu, Jun 28, 2018 at 12:28 PM, wrote: Hi, Dan, I'm concerned about this check + if (!ndctl_test_attempt(test, KERNEL_VERSION(4, 19, 0))) I read it as: this ndctl test only works for upstream kernel 4.19 and above. For Linux distributors,

Re: [ndctl PATCH] ndctl, test: Disable poison tests for now

2018-06-28 Thread Dan Williams
On Thu, Jun 28, 2018 at 12:28 PM, wrote: > Hi, Dan, > > I'm concerned about this check > > + if (!ndctl_test_attempt(test, KERNEL_VERSION(4, 19, 0))) > > I read it as: this ndctl test only works for upstream kernel 4.19 and above. > > For Linux distributors, such as us, we pick a major

Re: [ndctl PATCH] ndctl, test: Disable poison tests for now

2018-06-28 Thread jane . chu
Hi, Dan, I'm concerned about this check + if (!ndctl_test_attempt(test, KERNEL_VERSION(4, 19, 0))) I read it as: this ndctl test only works for upstream kernel 4.19 and above. For Linux distributors, such as us, we pick a major upstream release as the base OS, then painstakingly

[ndctl PATCH] ndctl, test: Disable poison tests for now

2018-06-14 Thread Dan Williams
Given that poison injection crashes the kernel, disable the test by default until 4.19. Signed-off-by: Dan Williams --- test.h|8 test/Makefile.am |4 +++- test/dax-pmd.c| 14 ++ test/dax-poison.c |8 ++-- test/dax.sh | 19