[RFC] nvdimm: Unitialized variable used in DSM calls

would be known. The size of the buffer allocated in would always be ND_IOCTL_MAX_BUFLEN. Signed-off-by: Jerry Hoemann --- drivers/nvdimm/bus.c | 30 -- 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c index 2

Re: [RFC] nvdimm: Unitialized variable used in DSM calls

On Mon, Apr 24, 2017 at 03:56:50PM -0700, Dan Williams wrote: > On Mon, Apr 24, 2017 at 3:36 PM, Jerry Hoemann wrote: > > nd_cmd_out_size is called by __nd_ioctl to size the buffer passed to > > acpi_nfit_ctl. If the DSM function being called has a variable > > sized output,

Re: [RFC] nvdimm: Unitialized variable used in DSM calls

On Mon, Apr 24, 2017 at 05:30:32PM -0600, Jerry Hoemann wrote: > On Mon, Apr 24, 2017 at 03:56:50PM -0700, Dan Williams wrote: > > On Mon, Apr 24, 2017 at 3:36 PM, Jerry Hoemann > > wrote: > > > nd_cmd_out_size is called by __nd_ioctl to size the buffer passed to > >

[PATCH 3/3] libnvdimm: New ACPI 6.2 DSM functions

ACPI 6.2 added new NVDIMM root DSM functions. Define their data structures. Update the definition of nd_cmd_ars_cap to match the 6.2 spec. Add the new 6.2 functions names to nvdimm_bus_cmd_name. Signed-off-by: Jerry Hoemann --- include/uapi/linux/ndctl.h | 44

[PATCH 0/3] Enable DSM pass thru for root functions

. acpi_nfit_init_dsms: Set additional bits in cmd_mask for new functions. ndctl.h: Define data structure for the new 6.2 functions. Add new function names to nvdimm_bus_cmd_name. Jerry Hoemann (3): libnvdimm: passthru functions clear to send acpi, nfit: Enable DSM pass thru for root functions. libnvdimm: New

[PATCH 1/3] libnvdimm: passthru functions clear to send

Have dsm functions called via the pass thru mechanism also be checked against clear to send. Signed-off-by: Jerry Hoemann --- drivers/nvdimm/bus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c index e9361bf..e16427d 100644

[PATCH 2/3] acpi, nfit: Enable DSM pass thru for root functions.

Set ND_CMD_CALL in the cmd_mask to enable calling root functions via the pass trhu mechanism. Signed-off-by: Jerry Hoemann --- drivers/acpi/nfit/core.c | 3 ++- include/uapi/linux/ndctl.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/nfit/core.c b/drivers

Re: [PATCH 3/3] libnvdimm: New ACPI 6.2 DSM functions

On Thu, Jun 08, 2017 at 10:28:51PM -0700, Dan Williams wrote: > On Thu, Jun 8, 2017 at 1:02 AM, Johannes Thumshirn wrote: > > On 06/07/2017 07:04 PM, Jerry Hoemann wrote: > >> @@ -179,6 +217,10 @@ static inline const char > >> *nvdim

[PATCH v2 3/7] libnvdimm: Add bus level dsm mask.

Add a bus level dsm_mask to nvdimm_bus_descriptor to allow the passthru calling mechanism to specify a different mask from the cmd_mask. Signed-off-by: Jerry Hoemann --- include/linux/libnvdimm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/libnvdimm.h b/include/linux

[PATCH v2 0/7] Enable DSM pass thru for root functions

the new 6.2 functions. Add new function names to nvdimm_bus_cmd_name. Jerry Hoemann (7): libnvdimm: passthru functions clear to send acpi, nfit: Enable DSM pass thru for root functions. libnvdimm: Add bus level dsm mask. acpi, nfit: Use bus_dsm_mask for passthru acpi, nfit: Show

[PATCH v2 5/7] acpi, nfit: Show bus_dsm_mask

Add bus_dsm_mask to sysfs display under /sys/bus/nd/devices/ndbusX/nfit. Signed-off-by: Jerry Hoemann --- drivers/acpi/nfit/core.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c index 9d281a4..f133b3e 100644 --- a/drivers/acpi

[PATCH v2 1/7] libnvdimm: passthru functions clear to send

Have dsm functions called via the pass thru mechanism also be checked against clear to send. Signed-off-by: Jerry Hoemann --- drivers/nvdimm/bus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c index e9361bf..e16427d 100644

[PATCH v2 7/7] acpi, nfit: override mask

Add module parameter override_dsm_mask_root for overriding the dsm_mask like we do for non-root dsm calls. Signed-off-by: Jerry Hoemann --- drivers/acpi/nfit/core.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c

[PATCH v2 4/7] acpi, nfit: Use bus_dsm_mask for passthru

Populate bus_dsm_mask and use it to filter dsm calls that user can make through the pass thru interface. Signed-off-by: Jerry Hoemann --- drivers/acpi/nfit/core.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c index b46fca2..9d281a4

[PATCH v2 6/7] libnvdimm: New ACPI 6.2 DSM functions

ACPI 6.2 added new NVDIMM root DSM functions. Define their data structures. Update the definition of nd_cmd_ars_cap to match the 6.2 spec. Add the new 6.2 functions names to nvdimm_bus_cmd_name. Signed-off-by: Jerry Hoemann --- include/uapi/linux/ndctl.h | 40

[PATCH v2 2/7] acpi, nfit: Enable DSM pass thru for root functions.

Set ND_CMD_CALL in the cmd_mask to enable calling root functions via the pass trhu mechanism. Signed-off-by: Jerry Hoemann --- drivers/acpi/nfit/core.c | 1 + include/uapi/linux/ndctl.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c

Re: [PATCH v2 0/7] Enable DSM pass thru for root functions

On Tue, Jun 20, 2017 at 10:51:19AM -0600, Jerry Hoemann wrote: > The new ACPI 6.2 spec has added new NVDIMM root DSM functions > that managibility and test software needs to call. > > This patch set enables the calling root functions DSM via the > pass thru mechanism.

Re: [PATCH v2 5/7] acpi, nfit: Show bus_dsm_mask

On Wed, Jun 28, 2017 at 02:07:20PM -0700, Dan Williams wrote: > On Tue, Jun 20, 2017 at 9:51 AM, Jerry Hoemann wrote: > > Add bus_dsm_mask to sysfs display under /sys/bus/nd/devices/ndbusX/nfit. > > > > Signed-off-by: Jerry Hoemann > > --- > > drivers/acpi/n

[PATCH v3 5/7] acpi, nfit: Show bus_dsm_mask in sysfs

Display bus_dsm_mask in sysfs as /sys/bus/nd/devices/ndbusX/nfit/dsm_mask. Signed-off-by: Jerry Hoemann --- drivers/acpi/nfit/core.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c index 971002b..7d2f1a0 100644 --- a/drivers

[PATCH v3 2/7] acpi, nfit: Enable DSM pass thru for root functions.

Set ND_CMD_CALL in the cmd_mask to enable calling root functions via the pass thru mechanism. Signed-off-by: Jerry Hoemann --- drivers/acpi/nfit/core.c | 1 + include/uapi/linux/ndctl.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c

[PATCH v3 1/7] libnvdimm: passthru functions clear to send

Have dsm functions called via the pass thru mechanism also be checked against clear to send. Signed-off-by: Jerry Hoemann --- drivers/nvdimm/bus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c index e9361bf..e16427d 100644

[PATCH v3 4/7] acpi, nfit: Use bus_dsm_mask for passthru

Populate bus_dsm_mask and use it to filter dsm calls that user can make through the pass thru interface. Signed-off-by: Jerry Hoemann --- drivers/acpi/nfit/core.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c index b46fca2..971002b

[PATCH v3 0/7] Enable DSM pass thru for root functions

functions against nd_cmd_clear_to_send. acpi_nfit_init_dsms: Set additional bits in cmd_mask for new functions. ndctl.h: Define data structure for the new 6.2 functions. Jerry Hoemann (7): libnvdimm: passthru functions clear to send acpi, nfit: Enable DSM pass thru for root functions.

[PATCH v3 6/7] libnvdimm: New ACPI 6.2 DSM functions

ACPI 6.2 added new NVDIMM root DSM functions. Define their data structures. Signed-off-by: Jerry Hoemann --- include/uapi/linux/ndctl.h | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/ndctl.h b/include/uapi/linux

[PATCH v3 7/7] acpi, nfit: override mask

Have module parameter override_dsm_mask override the dsm_mask for root calls like it does for non-root dsm calls. Signed-off-by: Jerry Hoemann --- drivers/acpi/nfit/core.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit

[PATCH v3 3/7] libnvdimm: Add bus level dsm mask.

Add a bus level dsm_mask to nvdimm_bus_descriptor to allow the passthru calling mechanism to specify a different mask from the cmd_mask. Signed-off-by: Jerry Hoemann --- include/linux/libnvdimm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/libnvdimm.h b/include/linux

Re: [PATCH v3 4/7] acpi, nfit: Use bus_dsm_mask for passthru

On Thu, Jun 29, 2017 at 02:35:14PM -0700, Dan Williams wrote: > On Thu, Jun 29, 2017 at 9:56 AM, Jerry Hoemann wrote: > > Populate bus_dsm_mask and use it to filter dsm calls that user can > > make through the pass thru interface. > > > > Signed-off-by: Jerry Hoemann

Re: [PATCH v3 7/7] acpi, nfit: override mask

On Thu, Jun 29, 2017 at 02:16:17PM -0700, Dan Williams wrote: > On Thu, Jun 29, 2017 at 9:56 AM, Jerry Hoemann wrote: > > Have module parameter override_dsm_mask override the dsm_mask for > > root calls like it does for non-root dsm calls. > > > > S

Re: [PATCH v3 4/7] acpi, nfit: Use bus_dsm_mask for passthru

On Thu, Jun 29, 2017 at 02:55:55PM -0700, Dan Williams wrote: > On Thu, Jun 29, 2017 at 2:47 PM, Jerry Hoemann wrote: > > On Thu, Jun 29, 2017 at 02:35:14PM -0700, Dan Williams wrote: > >> On Thu, Jun 29, 2017 at 9:56 AM, Jerry Hoemann > >> wrote: > >> &

[PATCH v4 2/6] acpi, nfit: Enable DSM pass thru for root functions.

Set ND_CMD_CALL in the cmd_mask to enable calling root functions via the pass thru mechanism. Signed-off-by: Jerry Hoemann --- drivers/acpi/nfit/core.c | 1 + include/uapi/linux/ndctl.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c

[PATCH v4 4/6] acpi, nfit: Show bus_dsm_mask in sysfs

Display bus_dsm_mask in sysfs as /sys/bus/nd/devices/ndbusX/nfit/dsm_mask. Signed-off-by: Jerry Hoemann --- drivers/acpi/nfit/core.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c index 5e4c137..4e24d69 100644 --- a/drivers

[PATCH v4 6/6] nfit allow override of root dsm mask

Have module parameter override_dsm_mask override the dsm_mask for root calls like it does for non-root dsm calls. Signed-off-by: Jerry Hoemann --- drivers/acpi/nfit/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c index 4e24d69

[PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

Add a bus level dsm_mask to nvdimm_bus_descriptor to allow the passthru calling mechanism to specify a different mask from the cmd_mask. Populate bus_dsm_mask and use it to filter dsm calls that user can make through the pass thru interface. Signed-off-by: Jerry Hoemann --- drivers/acpi/nfit

[PATCH v3 0/7] Enable DSM pass thru for root functions

_mask also. Details v1 -- __nd_ioctl: Check pass thru functions against nd_cmd_clear_to_send. acpi_nfit_init_dsms: Set additional bits in cmd_mask for new functions. ndctl.h: Define data structure for the new 6.2 functions. Jerry Hoemann (6): libnvdimm: passthru functions clear to s

[PATCH v4 5/6] libnvdimm: New ACPI 6.2 DSM functions

ACPI 6.2 added new NVDIMM root DSM functions. Define their data structures. Signed-off-by: Jerry Hoemann --- include/uapi/linux/ndctl.h | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/ndctl.h b/include/uapi/linux

[PATCH v4 1/6] libnvdimm: passthru functions clear to send

Have dsm functions called via the pass thru mechanism also be checked against clear to send. Signed-off-by: Jerry Hoemann --- drivers/nvdimm/bus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c index e9361bf..e16427d 100644

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

On Fri, Jun 30, 2017 at 08:55:22PM -0700, Dan Williams wrote: ... > On Fri, Jun 30, 2017 at 9:09 AM, Jerry Hoemann wrote: > > + if (cmd == ND_CMD_CALL) > > + dsm_mask = nd_desc->bus_dsm_mask; > > de

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

On Sat, Jul 01, 2017 at 01:10:31PM -0700, Dan Williams wrote: > On Sat, Jul 1, 2017 at 1:08 PM, Dan Williams wrote: > > On Sat, Jul 1, 2017 at 12:58 PM, Jerry Hoemann > > wrote: > >> On Fri, Jun 30, 2017 at 08:55:22PM -0700, Dan Williams wrote: > >> > >>

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

On Sat, Jul 01, 2017 at 01:46:03PM -0700, Dan Williams wrote: > On Sat, Jul 1, 2017 at 1:38 PM, Jerry Hoemann wrote: > > On Sat, Jul 01, 2017 at 01:10:31PM -0700, Dan Williams wrote: > >> On Sat, Jul 1, 2017 at 1:08 PM, Dan Williams > >> wrote: > >> >

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

On Tue, Jul 04, 2017 at 01:37:43PM -0700, Dan Williams wrote: > On Tue, Jul 4, 2017 at 1:08 PM, Jerry Hoemann wrote: > > On Sat, Jul 01, 2017 at 01:46:03PM -0700, Dan Williams wrote: > >> On Sat, Jul 1, 2017 at 1:38 PM, Jerry Hoemann > >> wrote: > >> > O

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

On Wed, Jul 05, 2017 at 09:35:48AM -0700, Dan Williams wrote: > On Wed, Jul 5, 2017 at 9:24 AM, Jerry Hoemann wrote: > > On Tue, Jul 04, 2017 at 01:37:43PM -0700, Dan Williams wrote: > >> On Tue, Jul 4, 2017 at 1:08 PM, Jerry Hoemann > >> wrote: > >> > O

[PATCH] ndctl: New structure definitions.

Add structure definitions newly published/modified in v0.85: https://github.com/HewlettPackard/hpe-nvm/blob/master/Documentation/NFIT_DSM_DDR4_NVDIMM-N_v85.pdf Signed-off-by: Jerry Hoemann --- ndctl/lib/ndctl-hpe1.h | 50 +- 1 file changed, 49

Re: [PATCH] ndctl: New structure definitions.

On Thu, Aug 10, 2017 at 05:47:10PM -0700, Dan Williams wrote: > On Thu, Aug 10, 2017 at 5:00 PM, Jerry Hoemann wrote: > > Add structure definitions newly published/modified in v0.85: > > > > https://github.com/HewlettPackard/hpe-nvm/blob/master/Documentation/NFIT_DSM_

Re: [PATCH] ndctl: New structure definitions.

On Thu, Aug 10, 2017 at 07:27:58PM -0700, Dan Williams wrote: > On Thu, Aug 10, 2017 at 7:12 PM, Jerry Hoemann wrote: > > On Thu, Aug 10, 2017 at 05:47:10PM -0700, Dan Williams wrote: > >> On Thu, Aug 10, 2017 at 5:00 PM, Jerry Hoemann > >> wrote: > >&g

Re: [PATCH] libnvdimm: clean up command definitions

mand? > > Cc: Jerry Hoemann > Reported-by: Yasunori Goto > Signed-off-by: Dan Williams > --- > include/uapi/linux/ndctl.h | 37 - > 1 file changed, 37 deletions(-) > > diff --git a/include/uapi/linux/ndctl.h b/include/uapi/linux/

Re: [PATCH] nvdimm: fix potential double-fetch bug

ay, I've been away. I'm okay with moving the test to the beginning of acpi_nfit_ctl. If/When the reserved fields are defined/used, we may need to tweak that. But we can cross that bridge when it comes. However, I do have a question. There are two for loops in __nd_ioctl that proce

Re: [PATCH] libnvdimm: add smart payload fields added in DSM 1.6

nction 2, Get Smart Threshold, in v1.6 is also different from what Linux implemented in ndctl.h. But, these changes don't appear to be backward compatible. Do you have plans for this? Jerry -- --------- Jerry Hoemann

Re: [PATCH v2 2/2] acpi, nfit: add support for NVDIMM_FAMILY_INTEL v1.6 DSMs

RY_FWUPDATE = 16, > + NVDIMM_INTEL_SET_THRESHOLD = 17, > + NVDIMM_INTEL_INJECT_ERROR = 18, > +}; > + > +#define NVDIMM_INTEL_CMDMASK \ > +(NVDIMM_STANDARD_CMDMASK | 1 << NVDIMM_INTEL_GET_MODES \ > + | 1 << NVDIMM_INTEL_GET_FWINFO | 1 << NVDIMM_INTEL_START_FWUPDATE \

Re: [PATCH v2 2/2] acpi, nfit: add support for NVDIMM_FAMILY_INTEL v1.6 DSMs

On Tue, Oct 31, 2017 at 02:42:01PM -0700, Dan Williams wrote: > On Tue, Oct 31, 2017 at 2:27 PM, Jerry Hoemann wrote: > > On Mon, Oct 30, 2017 at 01:47:08PM -0700, Dan Williams wrote: > >> Per v1.6 of the NVDIMM_FAMILY_INTEL command set [1] some of the new > >> co

Re: [PATCH v2 2/2] acpi, nfit: add support for NVDIMM_FAMILY_INTEL v1.6 DSMs

On Tue, Oct 31, 2017 at 04:19:32PM -0700, Dan Williams wrote: > On Tue, Oct 31, 2017 at 3:05 PM, Jerry Hoemann wrote: > > On Tue, Oct 31, 2017 at 02:42:01PM -0700, Dan Williams wrote: > [..] > >> Yes, this can happen. However, for the kernel implementation it can > >>

Re: [PATCH] acpi, nfit: fix acpi_check_dsm() vs zero functions implemented

gt; > > > > If they advertise a _DSM, I think they have to support function 0. > > > > They should, but didn't. Kernel v4.6 works with qemu 2.6, kernel v4.7 > > does not, so the kernel n

Re: [PATCH] acpi, nfit: print command names instead of numbers

_CALL] = "cmd_call", The change was to display string version of cmd which should be in the table. -- - Jerry Hoemann Software Engineer Hewlett Packard Enterprise -

Re: [PATCH] acpi, nfit: fix acpi_check_dsm() vs zero functions implemented

outine should be limited to the > probing done by the nfit driver. > > Cc: "Rafael J. Wysocki" > Cc: Len Brown > Cc: Jerry Hoemann > Fixes: 31eca76ba2fc ("nfit, libnvdimm: limited/whitelisted dimm command > marshaling mechanism") > Reported-by: Xiao

Re: [PATCH] acpi, nfit: fix acpi_check_dsm() vs zero functions implemented

On Tue, Jul 19, 2016 at 11:52:53AM -0700, Dan Williams wrote: > On Tue, Jul 19, 2016 at 11:50 AM, Linda Knippers > wrote: > > > > > > On 7/19/2016 1:11 PM, Jerry Hoemann wrote: > >> On Fri, Jun 24, 2016 at 10:44:25AM -0700, Dan Williams wrote: > >>> Q

Re: [PATCH] acpi, nfit: fix acpi_check_dsm() vs zero functions implemented

On Tue, Jul 19, 2016 at 01:01:16PM -0700, Dan Williams wrote: > On Tue, Jul 19, 2016 at 11:52 AM, Dan Williams > wrote: > > On Tue, Jul 19, 2016 at 11:50 AM, Linda Knippers > > wrote: > >> On 7/19/2016 1:11 PM, Jerry Hoemann wrote: > [..] > >

Re: [PATCH] uapi: Add the BSD-2-Clause license to ndctl.h

let's take the opportunity to > > > let SPDX do its job and drop the full license text. > > > > This is fine by me too, barring the full license text vs.