Re: Errors on boot with 2.6.27-rc5 on omap3

2008-09-04 Thread Steve Sakoman
On Wed, Sep 3, 2008 at 10:27 PM, Steve Sakoman [EMAIL PROTECTED] wrote: On Wed, Sep 3, 2008 at 10:10 PM, David Brownell [EMAIL PROTECTED] wrote: On Wednesday 03 September 2008, Steve Sakoman wrote: I get similar results for both Beagle and Overo, so the error occurs for both nand and onenand.

[PATCH] MUSB: Set INDEX register to 0 before accessing CONFIGDATA

2008-09-04 Thread Gadiyar, Anand
From: Anand Gadiyar [EMAIL PROTECTED] The Index register needs to be zero to access CONFIGDATA. musb_ep_select()will not set the MUSB_INDEX register unless INDEXED mode addressing is used. This change will set the register correctly in INDEXED as well as FLAT mode. Signed-off-by: Anand Gadiyar

Re: FOR COMMENT: void __iomem * and similar casts are Bad News

2008-09-04 Thread Arun KS
Hi Russel, Sorry for late reply. I applied the patch and tested, but it didn't resolves my problem. I found that code hangs at this point. File : arch/arm/plat-omap/mcbsp.c Function: omap_mcbsp_request if (mcbsp-pdata mcbsp-pdata-ops mcbsp-pdata-ops-request)

RE: [PATCH] ARM: OMAP: Kconfig support HW ECC for nand driver on OMAP3

2008-09-04 Thread Singh, Vimal
Hi, This stuff should be all going to the MTD list now. If we still have some MTD drivers that are not included in the MTD tree, we should prepare them for merging and send them to the MTD list. Thanks. Ok, I will be taking it to mtd after few weeks. Thanks, Tony-- To unsubscribe from this list:

Re: [PATCH 02/12] serial context save/restore

2008-09-04 Thread Kevin Hilman
Rajendra Nayak [EMAIL PROTECTED] writes: This patch adds the context save restore functions for UART Signed-off-by: Rajendra Nayak [EMAIL PROTECTED] --- arch/arm/mach-omap2/serial.c | 55 +++ arch/arm/plat-omap/include/mach/serial.h | 13

[PATCH] The clockdomain of clkout2_src_ck fixed

2008-09-04 Thread Tomi Valkeinen
The clockdomain of clkout2_src_ck was set to core_clkdm, which does not exist. Signed-off-by: Tomi Valkeinen [EMAIL PROTECTED] --- arch/arm/mach-omap2/clock34xx.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/clock34xx.h

Re: [PATCH 03/12] GPIO context save/restore

2008-09-04 Thread Kevin Hilman
Rajendra Nayak [EMAIL PROTECTED] writes: This patch adds the context save restore functions for GPIO Signed-off-by: Rajendra Nayak [EMAIL PROTECTED] --- arch/arm/plat-omap/gpio.c | 77 + arch/arm/plat-omap/include/mach/gpio.h | 19 +++-

Re: [PATCH 05/12] PRCM context save/restore

2008-09-04 Thread Kevin Hilman
Rajendra Nayak [EMAIL PROTECTED] writes: This patch adds the context save restore functions for PRCM module Signed-off-by: Rajendra Nayak [EMAIL PROTECTED] --- arch/arm/mach-omap2/prcm.c| 291 ++ arch/arm/mach-omap2/prm.h |

Re: [PATCH 06/12] Interrupt Controller context save/restore

2008-09-04 Thread Kevin Hilman
Rajendra Nayak [EMAIL PROTECTED] writes: This patch adds the Intrpt controller context save/restore Signed-off-by: Rajendra Nayak [EMAIL PROTECTED] --- + |binary arch/arm/mach-omap2/.irq.c.swp |0 arch/arm/mach-omap2/irq.c |

Re: [PATCH 07/12] System Control Module context save/restore

2008-09-04 Thread Kevin Hilman
Rajendra Nayak [EMAIL PROTECTED] writes: This patch adds the System control module context save/restore Signed-off-by: Rajendra Nayak [EMAIL PROTECTED] --- arch/arm/mach-omap2/control.c | 105 ++ arch/arm/plat-omap/include/mach/control.h | 61

Re: [PATCH 08/12] update sram restore function

2008-09-04 Thread Kevin Hilman
Rajendra Nayak [EMAIL PROTECTED] writes: This patch updates the context restore function for sram Signed-off-by: Rajendra Nayak [EMAIL PROTECTED] --- arch/arm/mach-omap2/pm34xx.c | 12 arch/arm/plat-omap/sram.c| 10 +++--- 2 files changed, 15 insertions(+), 7

Re: FOR COMMENT: void __iomem * and similar casts are Bad News

2008-09-04 Thread Russell King - ARM Linux
On Wed, Sep 03, 2008 at 11:33:51AM -0400, Eduardo Valentin wrote: @@ -159,7 +159,7 @@ static struct omap_mcbsp_platform_data omap730_mcbsp_pdata[] = { #ifdef CONFIG_ARCH_OMAP15XX static struct omap_mcbsp_platform_data omap15xx_mcbsp_pdata[] = { { - .virt_base

Re: [PATCH 3/5] SOUND: SOC: CODECS: Add support for the TWL4030 audio codec

2008-09-04 Thread Jarkko Nikula
On Wed, 3 Sep 2008 22:01:58 -0700 ext [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: From: Steve Sakoman [EMAIL PROTECTED] --- sound/soc/codecs/Kconfig |5 + sound/soc/codecs/Makefile |2 + sound/soc/codecs/twl4030.c | 628 +++ ... +static void

[PATCH] MUSB: Removes compilation warning in gadget mode

2008-09-04 Thread Ajay Kumar Gupta
Fixes compilation warning when musb is configured in gadget mode. Signed-off-by: Ajay Kumar Gupta [EMAIL PROTECTED] --- drivers/usb/musb/omap2430.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index

Re: [PATCH 4/5] SOUND: SOC: OMAP: Add support for Gumstix Overo

2008-09-04 Thread Jarkko Nikula
On Wed, 3 Sep 2008 22:01:59 -0700 ext [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: From: Steve Sakoman [EMAIL PROTECTED] --- sound/soc/omap/Kconfig |9 +++ sound/soc/omap/Makefile |3 + sound/soc/omap/overo.c | 149 ++ + 3 files

Re: [alsa-devel] [PATCH 3/5] SOUND: SOC: CODECS: Add support for the TWL4030 audio codec

2008-09-04 Thread Mark Brown
On Wed, Sep 03, 2008 at 10:01:58PM -0700, [EMAIL PROTECTED] wrote: +static void twl4030_power_up(struct snd_soc_codec *codec) +{ + u8 mode, byte, popn, hsgain; + + /* set CODECPDZ to turn on codec */ + mode = twl4030_read_reg_cache(codec, REG_CODEC_MODE); +

Re: [alsa-devel] [PATCH 3/5] SOUND: SOC: CODECS: Add support for the TWL4030 audio codec

2008-09-04 Thread Mark Brown
On Thu, Sep 04, 2008 at 01:26:32PM +0300, Jarkko Nikula wrote: +static void twl4030_dump_registers(void) +{ This is not needed since there is already nice function for it: sound/soc/soc-core.c: codec_reg_show. It's doing something slighly different and dumping the chip registers rather

Re: [alsa-devel] [PATCH 4/5] SOUND: SOC: OMAP: Add support for Gumstix Overo

2008-09-04 Thread Mark Brown
On Wed, Sep 03, 2008 at 10:01:59PM -0700, [EMAIL PROTECTED] wrote: From: Steve Sakoman [EMAIL PROTECTED] You should sign it off too. Anyway, it looks good: Acked-by: Mark Brown [EMAIL PROTECTED] -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to

Re: [PATCH 4/5] SOUND: SOC: OMAP: Add support for Gumstix Overo

2008-09-04 Thread Steve Sakoman
On Thu, Sep 4, 2008 at 3:40 AM, Jarkko Nikula [EMAIL PROTECTED] wrote: Just advertisement that Overo (+ Beagle and SDP) needs two patches from me in order to work. One for McBSP low-level driver and one for McBSP DAI driver. This is correct! I unfortunately left that out of my cover letter.

Re: Doubts about patching

2008-09-04 Thread Ramón Finger Lilienthal
Diego and Felipe, Thanks for your attention and for the informations. Regards, Eng. Ramon F. Lilienthal Project Engineer Instramed Ltda. - www.instramed.com.br +55 (51) 33344199 ext. 213 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL

Re: [PATCH 21/33] add OMAP HighSpeed mmc controller driver

2008-09-04 Thread Madhusudhan Chikkature
Hi Dave, OK, this one may need cleanup ... but I don't disagree that it should go upstream. I had fixed several comments provided by Pierre and Russell before Tony merged this patch. But then we have further added several fixes on top of the driver. Do you have any specific comments when you

Re: [PATCH 3/5] SOUND: SOC: CODECS: Add support for the TWL4030 audio codec

2008-09-04 Thread Steve Sakoman
On Thu, Sep 4, 2008 at 3:26 AM, Jarkko Nikula [EMAIL PROTECTED] wrote: On Wed, 3 Sep 2008 22:01:58 -0700 ext [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: +static void twl4030_dump_registers(void) +{ This is not needed since there is already nice function for it: sound/soc/soc-core.c:

Re: [alsa-devel] [PATCH 3/5] SOUND: SOC: CODECS: Add support for the TWL4030 audio codec

2008-09-04 Thread Steve Sakoman
On Thu, Sep 4, 2008 at 5:04 AM, Mark Brown [EMAIL PROTECTED] wrote: On Wed, Sep 03, 2008 at 10:01:58PM -0700, [EMAIL PROTECTED] wrote: + /* initiate offset cancellation */ + twl4030_write(codec, REG_ANAMICL, + twl4030_reg[REG_ANAMICL] | CNCL_OFFSET_START); It looks a bit

Re: Reset unused clocks during boot causing problem on 5912 OSK

2008-09-04 Thread Arun KS
On 9/4/08, Russell King - ARM Linux [EMAIL PROTECTED] wrote: On Wed, Sep 03, 2008 at 07:32:51PM +0530, Arun KS wrote: I am trying to write an ASOC driver for tlv320aic23 on 5912osk. 5912osk is OMAP1, yes ? Uses arch/arm/mach-omap1/mcbsp.c ? Which is the file I pointed out passing physical

Re: FOR COMMENT: void __iomem * and similar casts are Bad News

2008-09-04 Thread Tony Lindgren
* Russell King - ARM Linux [EMAIL PROTECTED] [080904 02:47]: On Wed, Sep 03, 2008 at 11:33:51AM -0400, Eduardo Valentin wrote: @@ -159,7 +159,7 @@ static struct omap_mcbsp_platform_data omap730_mcbsp_pdata[] = { #ifdef CONFIG_ARCH_OMAP15XX static struct omap_mcbsp_platform_data

Re: FOR COMMENT: void __iomem * and similar casts are Bad News

2008-09-04 Thread Russell King - ARM Linux
On Thu, Sep 04, 2008 at 09:10:34AM -0700, Tony Lindgren wrote: * Russell King - ARM Linux [EMAIL PROTECTED] [080904 02:47]: On Wed, Sep 03, 2008 at 11:33:51AM -0400, Eduardo Valentin wrote: @@ -159,7 +159,7 @@ static struct omap_mcbsp_platform_data omap730_mcbsp_pdata[] = { #ifdef

Re: FOR COMMENT: void __iomem * and similar casts are Bad News

2008-09-04 Thread Tony Lindgren
* Russell King - ARM Linux [EMAIL PROTECTED] [080904 09:13]: On Thu, Sep 04, 2008 at 09:10:34AM -0700, Tony Lindgren wrote: * Russell King - ARM Linux [EMAIL PROTECTED] [080904 02:47]: On Wed, Sep 03, 2008 at 11:33:51AM -0400, Eduardo Valentin wrote: @@ -159,7 +159,7 @@ static struct

Re: [PATCH 2/3] power off on state counter infrastructure

2008-09-04 Thread Paul Walmsley
Hello Peter, a few minor comments: On Thu, 24 Jul 2008, Peter 'p2' De Schrijver wrote: Signed-off-by: Peter 'p2' De Schrijver [EMAIL PROTECTED] --- arch/arm/mach-omap2/powerdomain.c | 48 +- include/asm-arm/arch-omap/powerdomain.h |9 +- 2

Re: FOR COMMENT: void __iomem * and similar casts are Bad News

2008-09-04 Thread Russell King - ARM Linux
On Thu, Sep 04, 2008 at 09:29:19AM -0700, Tony Lindgren wrote: That was fast :) Sounds we'll have a patch to test soon. Of course. In my tree. The master branch contains the minimal fixes, and the devel branch contains everything. If you want the individual patches, either pull the tree or

[patch 2.6.27-rc5-omap1] rtc-twl4030 cleanup

2008-09-04 Thread David Brownell
From: David Brownell [EMAIL PROTECTED] Some rtc-twl4030 cleanup, which among other things adds up to using about 10% less object code: - Remove: * broken/unfixable periodic IRQ support (2^N Hz) * duplicated constants in the header file * pointless stuff: + support for

Re: FOR COMMENT: void __iomem * and similar casts are Bad News

2008-09-04 Thread Tony Lindgren
* Russell King - ARM Linux [EMAIL PROTECTED] [080904 10:07]: On Thu, Sep 04, 2008 at 09:29:19AM -0700, Tony Lindgren wrote: That was fast :) Sounds we'll have a patch to test soon. Of course. In my tree. The master branch contains the minimal fixes, and the devel branch contains

Working with Linux-Omap GIT Tree

2008-09-04 Thread Ashwin Bihari
Greetings, I've been tasked with taking all of the code for our OMAP based board currently based on the 2.6.22.18 Kernel to the latest version and so I decided that I would do things in a way that not allowed me to move our code forward but also allow me to take any new changes made to the

Re: Working with Linux-Omap GIT Tree

2008-09-04 Thread Ashwin Bihari
On Thu, Sep 4, 2008 at 2:44 PM, Aguirre Rodriguez, Sergio Alberto [EMAIL PROTECTED] wrote: Hi Ashwin, The folder you're looking for has been moved to arch/arm/plat-omap/include/ This has to have the same contents you had in that version + the following changes to them. Hope this helped

RE: Working with Linux-Omap GIT Tree

2008-09-04 Thread Aguirre Rodriguez, Sergio Alberto
And one more thing... If you have a driver which was previously including a header like this: #include arch/arm/clock.h You have to change it to: #include mach/clock.h To point to the new location. Regards, Sergio -Original Message- From: Ashwin Bihari [mailto:[EMAIL PROTECTED]

Re: [PATCH 1/3] Power off on state counter debugging

2008-09-04 Thread Kevin Hilman
Peter 'p2' De Schrijver wrote: Signed-off-by: Peter 'p2' De Schrijver [EMAIL PROTECTED] --- arch/arm/mach-omap2/Makefile |2 +- arch/arm/mach-omap2/off-state-counter-debug.c | 50 + 2 files changed, 51 insertions(+), 1 deletions(-) create mode

OMAP3EVM : Doesn't resume after suspend

2008-09-04 Thread Premi, Sanjeev
Hi all, I am building off the tag v2.6.26-omap2. While trying the suspend/resume, i noticed that suspend succeeds; but the resume doesn't happen. Did anyone else notice this behavior? Best regards, Sanjeev-- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a

Re: FOR COMMENT: void __iomem * and similar casts are Bad News

2008-09-04 Thread Russell King - ARM Linux
On Thu, Sep 04, 2008 at 10:58:13AM -0700, Tony Lindgren wrote: * Russell King - ARM Linux [EMAIL PROTECTED] [080904 10:07]: On Thu, Sep 04, 2008 at 09:29:19AM -0700, Tony Lindgren wrote: That was fast :) Sounds we'll have a patch to test soon. Of course. In my tree. The master branch

cpu_is_omap15xx() doesn't get set for OMAP310

2008-09-04 Thread Russell King - ARM Linux
While trying out some of the changes in qemu (which emulates an OMAP310) I found that cpu_is_omap15xx() returns false. The comment says: * Macros to group OMAP into cpu classes. * These can be used in most places. * cpu_is_omap7xx():True for OMAP730 * cpu_is_omap15xx(): True for

Re: FOR COMMENT: void __iomem * and similar casts are Bad News

2008-09-04 Thread Tony Lindgren
* Russell King - ARM Linux [EMAIL PROTECTED] [080904 14:01]: On Thu, Sep 04, 2008 at 10:58:13AM -0700, Tony Lindgren wrote: * Russell King - ARM Linux [EMAIL PROTECTED] [080904 10:07]: On Thu, Sep 04, 2008 at 09:29:19AM -0700, Tony Lindgren wrote: That was fast :) Sounds we'll have a

[PATCH] BRIDGE OMAP PM Bug softlockup fix

2008-09-04 Thread Ramirez Luna, Omar
From: Ramesh Gupta [EMAIL PROTECTED] Date: Thu, 4 Sep 2008 00:31:04 -0500 Subject: [PATCH] BRIDGE OMAP PM Bug softlockup fix Fix BUG# soft lockup issue with the Open Source Power Management. Signed-off-by: Ramesh Gupta [EMAIL PROTECTED] --- drivers/dsp/bridge/wmd/tiomap3430.c |9 ++---

Re: cpu_is_omap15xx() doesn't get set for OMAP310

2008-09-04 Thread Tony Lindgren
* Russell King - ARM Linux [EMAIL PROTECTED] [080904 14:10]: While trying out some of the changes in qemu (which emulates an OMAP310) I found that cpu_is_omap15xx() returns false. The comment says: * Macros to group OMAP into cpu classes. * These can be used in most places. *

cam_mclk clock not responding properly in OMAP3430

2008-09-04 Thread Aguirre Rodriguez, Sergio Alberto
Hi Paul, I'm working on camera implementation, and I want to debug why the cam_mclk clock is returning me a count exceeded message, although seems to be properly taken. (i.e. MT9P012 + ISP sensor works fine) I'm having this message when trying to acquire it: Clock cam_mclk didn't enable in

Re: Git tree updated to v2.6.27-rc5, some USB diffs still lurking

2008-09-04 Thread David Brownell
Breaking this up into digestible chunks ... This one for USB gadget. I'll send parts of this upstream now, that seems simplest. I'll review the patch for ehci-omap separately, when it's submitted. ISTR already commenting that the Kconfig stuff should become a platform_data issue. Until that's

Russell's ioremap patches pushed, please test and update drivers

2008-09-04 Thread Tony Lindgren
Hi all, I've pushed the ioremap patches from Russell. This means drivers need to be converted to use ioremap instead of io_p2v or XXX_IO_ADDRESS. After Russell's patches, ioremap does not remap areas that already have a static mapping. Tested on n810, 5912osk and omap3430sdp so far. Please test

Re: Git tree updated to v2.6.27-rc5, some USB diffs still lurking

2008-09-04 Thread Tony Lindgren
* David Brownell [EMAIL PROTECTED] [080904 17:35]: Breaking this up into digestible chunks ... This one for USB gadget. I'll send parts of this upstream now, that seems simplest. I'll review the patch for ehci-omap separately, when it's submitted. ISTR already commenting that the Kconfig

Re: FOR COMMENT: void __iomem * and similar casts are Bad News

2008-09-04 Thread Tony Lindgren
* Tony Lindgren [EMAIL PROTECTED] [080904 14:20]: * Russell King - ARM Linux [EMAIL PROTECTED] [080904 14:01]: On Thu, Sep 04, 2008 at 10:58:13AM -0700, Tony Lindgren wrote: * Russell King - ARM Linux [EMAIL PROTECTED] [080904 10:07]: On Thu, Sep 04, 2008 at 09:29:19AM -0700, Tony

Re: [RFC 0/2] McBSP and ASoC OMAP update patches for 2430 and 34xx

2008-09-04 Thread Tony Lindgren
* Jarkko Nikula [EMAIL PROTECTED] [080821 04:58]: Here are two patches adding support for OMAP2430 in McBSP driver and adding support for 2430 and 34xx in ASoC OMAP McBSP DAI driver. These are generated from top of currect l-o head but they apply also on top of Hiroshi's virtual clock

Re: [PATCH 00/06] OMAP3 CPUidle patches - supports C0-C5

2008-09-04 Thread Paul Walmsley
Hello Rajendra, On Tue, 26 Aug 2008, Rajendra Nayak wrote: This is an updated set of CPUidle patches for OMAP3 with a few more comment fixes, cleanup, 2.6.27-rc3 migration. Thanks - here are a few more review comments: Bugs 1. In patch 3/6, control.c:omap3_save_scratchpad_contents()

[PATCH] OMAP2xxx EAC: fix build breakage due to recent IO changes

2008-09-04 Thread Paul Walmsley
Commit f228a725b975832ac5771ab2fc86d06bd694cdb3 breaks the build for this driver; fix by using OMAP2_IO_ADDRESS. Compile-tested only. Signed-off-by: Paul Walmsley [EMAIL PROTECTED] --- sound/arm/omap/eac.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git

Re: cam_mclk clock not responding properly in OMAP3430

2008-09-04 Thread Paul Walmsley
Hello Sergio, On Thu, 4 Sep 2008, Aguirre Rodriguez, Sergio Alberto wrote: I'm working on camera implementation, and I want to debug why the cam_mclk clock is returning me a count exceeded message, although seems to be properly taken. (i.e. MT9P012 + ISP sensor works fine) I'm having

Re: FOR COMMENT: void __iomem * and similar casts are Bad News

2008-09-04 Thread Paul Walmsley
Hello Russell, Tony, in arch/arm/plat-omap/include/mach/io.h, shouldn't these casts be __force void __iomem * ? #define IO_ADDRESS(pa) ((void __iomem *)__IO_ADDRESS(pa)) #define OMAP1_IO_ADDRESS(pa)((void __iomem *)__OMAP1_IO_ADDRESS(pa)) #define OMAP2_IO_ADDRESS(pa)((void

Re: [PATCH] OMAP2xxx EAC: fix build breakage due to recent IO changes

2008-09-04 Thread Paul Walmsley
On Thu, 4 Sep 2008, Paul Walmsley wrote: Commit f228a725b975832ac5771ab2fc86d06bd694cdb3 breaks the build for this driver; fix by using OMAP2_IO_ADDRESS. eh, never mind this patch, this is the wrong way to fix it. Updated patch coming shortly. - Paul -- To unsubscribe from this list: send

[PATCH 0/2] OMAP2xxx EAC build fix and sparse cleanup

2008-09-04 Thread Paul Walmsley
This series fixes a build bug in the EAC driver after the recent IO address changes, and resolves some sparse warnings. Compile-tested only. Signed-off-by: Paul Walmsley [EMAIL PROTECTED] --- sound/arm/omap/eac.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) -- To

[PATCH 1/2] OMAP2xxx EAC: update per recent IO address changes

2008-09-04 Thread Paul Walmsley
Commit f228a725b975832ac5771ab2fc86d06bd694cdb3 breaks the build for this driver; fix by using OMAP2_IO_ADDRESS. Signed-off-by: Paul Walmsley [EMAIL PROTECTED] --- sound/arm/omap/eac.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/arm/omap/eac.c

[PATCH 2/2] OMAP2xxx EAC: fix sparse warnings

2008-09-04 Thread Paul Walmsley
This patch resolves the following two sparse warnings: sound/arm/omap/eac.c:788:12: warning: symbol 'eac_init' was not declared. Should it be static? sound/arm/omap/eac.c:793:13: warning: symbol 'eac_exit' was not declared. Should it be static? Signed-off-by: Paul Walmsley [EMAIL PROTECTED]

Re: [PATCH 1/2] OMAP2xxx EAC: update per recent IO address changes

2008-09-04 Thread Paul Walmsley
On Thu, 4 Sep 2008, Paul Walmsley wrote: Commit f228a725b975832ac5771ab2fc86d06bd694cdb3 breaks the build for this driver; fix by using OMAP2_IO_ADDRESS. Hmmm. I should be using ioremap(). New version coming. - Paul -- To unsubscribe from this list: send the line unsubscribe linux-omap in

Re: FOR COMMENT: void __iomem * and similar casts are Bad News

2008-09-04 Thread Paul Walmsley
On Thu, 4 Sep 2008, Paul Walmsley wrote: Hello Russell, Tony, in arch/arm/plat-omap/include/mach/io.h, shouldn't these casts be __force void __iomem * ? #define IO_ADDRESS(pa)((void __iomem *)__IO_ADDRESS(pa)) #define OMAP1_IO_ADDRESS(pa) ((void __iomem

[PATCH v2 0/2] OMAP2xxx EAC build fix and sparse cleanup

2008-09-04 Thread Paul Walmsley
This series fixes a build bug in the EAC driver after the recent IO address changes, and resolves some sparse warnings. Updated to use ioremap(). Compile-tested only. Signed-off-by: Paul Walmsley [EMAIL PROTECTED] --- arch/arm/mach-omap2/devices.c |4 ++-- sound/arm/omap/eac.c |

[PATCH v2 1/2] OMAP2xxx EAC: update per recent IO address changes

2008-09-04 Thread Paul Walmsley
Commit f228a725b975832ac5771ab2fc86d06bd694cdb3 breaks the build for this driver; fix by using ioremap(). Signed-off-by: Paul Walmsley [EMAIL PROTECTED] --- arch/arm/mach-omap2/devices.c |4 ++-- sound/arm/omap/eac.c |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH v2 2/2] OMAP2xxx EAC: fix sparse warnings

2008-09-04 Thread Paul Walmsley
This patch resolves the following two sparse warnings: sound/arm/omap/eac.c:788:12: warning: symbol 'eac_init' was not declared. Should it be static? sound/arm/omap/eac.c:793:13: warning: symbol 'eac_exit' was not declared. Should it be static? Signed-off-by: Paul Walmsley [EMAIL PROTECTED]