Re: [PATCH 2 01/18] I2C: OMAP2+: Set hwmod flags to only allow 16-bit accesses to i2c

2011-03-08 Thread Cousson, Benoit
Just nitpicking on the subject: Since that patch is changing only some OMAP sub-arch files, it should be: OMAP2+: hwmod data: Set hwmod flags to only allow 16-bit accesses to i2c To highlight the fact than an OMAP maintainer need to ack them. On 3/8/2011 12:07 PM, Andy Green wrote: Peter

Re: [PATCH 2 04/18] I2C: OMAP2+: Tag all OMAP2+ hwmod defintions with I2C IP revision

2011-03-08 Thread Cousson, Benoit
Same minor comment than before about the subject + typo. Should be: OMAP2+: hwmod data: Tag all OMAP2+ hwmod definitions with I2C IP revision On 3/8/2011 12:07 PM, Andy Green wrote: Since we cannot trust (or even reliably find) the OMAP I2C peripheral unit's own revision register, we must

Re: [PATCH 0/2] omap_wdt: fix interface clock handling

2011-03-08 Thread Paul Walmsley
Hi, On Tue, 8 Mar 2011, Kevin Hilman wrote: Kalle Jokiniemi kalle.jokini...@nokia.com writes: The runtime PM does not offer enough granularity to control individual clocks separately as needed. Current pm implementation of omap_wdt blocks the CORE power domain from idling in OMAP SoC,

Re: [PATCH] cbus-retu-wdt: Remove unused nonstandard interfaces

2011-03-08 Thread Tony Lindgren
* Michael Büsch m...@bu3sch.de [110303 06:16]: On Thu, 2011-03-03 at 11:42 +0200, Felipe Balbi wrote: On Wed, Mar 02, 2011 at 05:11:58PM +0100, Michael Buesch wrote: @@ -175,9 +124,9 @@ static int retu_wdt_release(struct inode struct retu_wdt_dev *wdev = file-private_data;

Re: [PATCH 2/2] Watchdog: omap_wdt: fix interface clock handling

2011-03-08 Thread Paul Walmsley
On Tue, 8 Mar 2011, Kalle Jokiniemi wrote: Keeping the omap watchdog interface clock always enabled blocks OMAP CORE power domain from sleeping. Introduce fine grain clock control to fix the issue. This patch is based on a patch created by Atal Shargorodsky:

Re: [PATCH 0/2] omap_wdt: fix interface clock handling

2011-03-08 Thread Paul Walmsley
Hi On Tue, 8 Mar 2011, Paul Walmsley wrote: On Tue, 8 Mar 2011, Kevin Hilman wrote: Kalle Jokiniemi kalle.jokini...@nokia.com writes: The runtime PM does not offer enough granularity to control individual clocks separately as needed. Current pm implementation of omap_wdt blocks

Re: [PATCH] OMAP1: McBSP: fix build break for non-multi-OMAP1 configs

2011-03-08 Thread Tony Lindgren
* Paul Walmsley p...@pwsan.com [110307 18:32]: On Mon, 7 Mar 2011, Jarkko Nikula wrote: omapxxx_mcbsp_res_0 doesn't look the best here in readability point of view but provides the smallest fix as no need to rename array and modify the _RES_SZ and _COUNT macros. So this fix is needed here

Re: [PATCH 2 01/18] I2C: OMAP2+: Set hwmod flags to only allow 16-bit accesses to i2c

2011-03-08 Thread Paul Walmsley
On Tue, 8 Mar 2011, Andy Green wrote: Peter Maydell noticed when running under QEMU he was getting errors reporting 32-bit access to I2C peripheral unit registers that are documented to be 8 or 16-bit only[1][2] The I2C driver is blameless as it wraps its accesses in a function using

Re: [PATCH] omap: overo: Add regulator for ads7846

2011-03-08 Thread Tony Lindgren
* Steve Sakoman st...@sakoman.com [110305 08:10]: The ads7846 driver now requires a regulator. This patch adds the necessary regulator to the overo board file. Without it, the following error occurs (and the touchscreen will not function): ads7846 spi1.0: unable to get regulator: -19

Re: [PATCH v2 2/4] OMAP4: hwmod data: add mmu hwmod for ipu and dsp

2011-03-08 Thread Ramirez Luna, Omar
Hi Benoit, On Tue, Mar 8, 2011 at 3:29 PM, Cousson, Benoit b-cous...@ti.com wrote: What I meant is that the mmu does not have any explicit PRCM module enable control. The PRCM does control only the DSP as a whole. Since hwmods are generated with a PRCM granularity, any sub module will not be

Re: [PATCH] audio : AM3517 : Adding i2c info for AIC23 codec

2011-03-08 Thread Tony Lindgren
* Abhilash K V abhilash...@ti.com [110308 07:11]: From: Abhilash Vadakkepat Koyamangalath x0151...@psplinux051.india.ti.com The i2c_board_info entry supporting AIC23 codec was added into the i2c2 bus. Signed-off-by: Abhilash K V abhilash...@ti.com Acked-by: Jarkko Nikula

Re: [PATCH] OMAP4: PM: Set static dependency between MPUSS and EMIF

2011-03-08 Thread Paul Walmsley
On Tue, 8 Mar 2011, Santosh Shilimkar wrote: As per OMAP4430 TRM, the dynamic dependency between MEMIF and MPUSS clockdomains is enable by default. Refer register CM_MPU_DYNAMICDEP description for details. But it doesn't seems to work as expected and MPUSS doesn't wakeup from off-mode if

Re: [PATCH 2 00/18] I2C: OMAP: Fixes and removal of cpu_... from driver

2011-03-08 Thread Tony Lindgren
* Cousson, Benoit b-cous...@ti.com [110308 13:34]: Hi Andy, Thanks for that really fast update. That looks pretty good at first glance. I still have to review in details. Yes nice job! And we need to find some volunteers for OMAP1 2 testing. I gave it a quick try on osk5912, seems to

[PATCH v12 0/9] dmtimer adaptation to platform_driver

2011-03-08 Thread Tarun Kanti DebBarma
dmtimer adaptation to platform_driver. This patch series is adaptation of dmtimer code to platform driver using omap_device and omap_hwmod abstraction. Baseline: git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git Branch: omap-for-linus Test Info: * OMAP3, OMAP4 testing:

[PATCH v12 1/9] OMAP2+: dmtimer: add device names to flck nodes

2011-03-08 Thread Tarun Kanti DebBarma
From: Thara Gopinath th...@ti.com Add device name to OMAP2 dmtimer fclk nodes so that the fclk nodes can be retrieved by doing a clk_get with the corresponding device pointers or device names. NOTE: gpt1_fck is modified in patch-10 when we switch to platform device driver. This is to make sure

[PATCH v12 7/9] OMAP: dmtimer: pm_runtime support

2011-03-08 Thread Tarun Kanti DebBarma
Add pm_runtime feature to dmtimer whereby _get_sync() is called within omap_dm_timer_enable(), _put_sync() is called in omap_dm_timer_disable(). As part of this, I am getting rid of the 'enabled' flag since this is no longer needed. This has been replaced by pm_runtime_suspended() check.

[PATCH v12 2/9] OMAP4: hwmod data: add dmtimer version information

2011-03-08 Thread Tarun Kanti DebBarma
OMAP4 has two groups of timers: version 1 timers are 1, 2, 10, while the rest of the timers, 3-9, 11 are version 2 timers. The version information is required by the driver so that they could be handled correctly by it. Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com Acked-by: Cousson,

[PATCH v12 8/9] OMAP: dmtimer: add timeout to low-level routines

2011-03-08 Thread Tarun Kanti DebBarma
The low-level read and write access routines wait on write-pending register in posted mode to make sure that previous write is complete on respective registers. This waiting is done in an infinite while loop. Now it is being modified to use timeout instead. Signed-off-by: Tarun Kanti DebBarma

[PATCH v12 9/9] OMAP: dmtimer: use mutex instead of spinlock

2011-03-08 Thread Tarun Kanti DebBarma
Since the spinlock is not used in any interrupt context we can replace it with mutex instead. Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com --- arch/arm/plat-omap/dmtimer.c | 27 +++ 1 files changed, 11 insertions(+), 16 deletions(-) diff --git

[PATCH v12 5/9] OMAP: dmtimer: platform driver

2011-03-08 Thread Tarun Kanti DebBarma
Add dmtimer platform driver functions which include: (1) platform driver initialization (2) driver probe function (3) driver remove function Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com Signed-off-by: Thara Gopinath th...@ti.com Acked-by: Cousson, Benoit b-cous...@ti.com ---

[PATCH v12 3/9] OMAP1: dmtimer: conversion to platform devices

2011-03-08 Thread Tarun Kanti DebBarma
From: Thara Gopinath th...@ti.com Convert OMAP1 dmtimers into a platform devices and then registers with device model framework so that it can be bound to corresponding driver. Signed-off-by: Thara Gopinath th...@ti.com Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com Acked-by: Cousson,

[PATCH v12 4/9] OMAP2+: dmtimer: convert to platform devices

2011-03-08 Thread Tarun Kanti DebBarma
Add routines to converts dmtimers to platform devices. The device data is obtained from hwmod database of respective platform and is registered to device model after successful binding to driver. It also provides provision to access timers during early boot when pm_runtime framework is not

[PATCH] OMAP2+: clockdomain: add flag that will block autodeps from being added for a clockdomain

2011-03-08 Thread Paul Walmsley
Add a new clockdomain flag, CLKDM_NO_AUTODEPS, which, when marked on a clockdomain, will prevent autodeps from being associated with the clockdomain. (Autodeps are sleep dependencies and wakeup dependencies from/to processor modules that are automatically added to a clockdomain when it is in

RE: [PATCH 1/2] OMAP3: cpuidle: prevent CORE power domain from going to RET or OFF when DSS is on

2011-03-08 Thread Paul Walmsley
Hi, On Fri, 4 Mar 2011, tero.kri...@nokia.com wrote: What is the reason for having the sleepdep for DSS powerdomain anyway? At least I can't see any reason why the sleepdep for DSS should be set. In my opinion it should be perfectly okay for DSS domain to idle independently of MPU/CORE,

Re: [PATCH] omap: overo: Add regulator for ads7846

2011-03-08 Thread Steve Sakoman
On Tue, Mar 8, 2011 at 3:16 PM, Tony Lindgren t...@atomide.com wrote: * Steve Sakoman st...@sakoman.com [110305 08:10]: The ads7846 driver now requires a regulator.  This patch adds the necessary regulator to the overo board file.  Without it, the following error occurs (and the touchscreen

Re: [PATCH 5/5] OMAP: GPIO: use PM runtime framework

2011-03-08 Thread Varadarajan, Charulatha
Kevin, On Tue, Mar 8, 2011 at 13:23, Kevin Hilman khil...@ti.com wrote: Varadarajan, Charulatha ch...@ti.com writes: Kevin, On Tue, Mar 8, 2011 at 00:25, Kevin Hilman khil...@ti.com wrote: Varadarajan, Charulatha ch...@ti.com writes: [...] GPIO driver is modified to use dev_pm_ops

Re: [PATCH 3/3] OMAP2+: powerdomain: add pwrdm_can_ever_lose_context()

2011-03-08 Thread Varadarajan, Charulatha
On Tue, Mar 8, 2011 at 13:10, Paul Walmsley p...@pwsan.com wrote: On Tue, 8 Mar 2011, Varadarajan, Charulatha wrote: Do you really want to return 1 in case of invalid powerdomain pointer? Sure, that's why I wrote it that way.  It seems less risky than returning 0.  Do you have a proposal

Re: [PATCH 5/7] Serial: OMAP: add runtime pm support for omap-serial driver

2011-03-08 Thread Kevin Hilman
Govindraj govindraj...@gmail.com writes: [...] This function should not be needed. The timer should be replaced by the auto-suspend feature of runtime PM. If I use autosuspend based on timer runtime framework will disable clocks based on autosuspend timeout. But if I cut clocks outside

Re: [PATCH 5/7] Serial: OMAP: add runtime pm support for omap-serial driver

2011-03-08 Thread Paul Walmsley
Hi Govindraj, what also would be good to find out is why the UART is apparently sending asynchronous wakeups even when the driver doesn't set SCR_REG.RX_CTS_WU_EN. This seems contrary to the expectation that 34xx TRM vZH section 17.4.4.1.4.1 Wake-up Interrupt sets. Could you please clarify

Re: [PATCH] OMAP4: clockdomain: Follow recommended enable sequence

2011-03-08 Thread Paul Walmsley
Hi Rajendra, A few questions... On Fri, 4 Mar 2011, Rajendra Nayak wrote: On OMAP4, the PRCM recommended sequence for enabling a module after power-on-reset is -1- Force clkdm to SW_WKUP -2- Configure desired module mode to enable or auto -3- Wait for the desired module idle status to be

RE: [PATCH] OMAP4: PM: Set static dependency between MPUSS and EMIF

2011-03-08 Thread Santosh Shilimkar
-Original Message- From: Kevin Hilman [mailto:khil...@ti.com] Sent: Wednesday, March 09, 2011 5:42 AM To: Paul Walmsley Cc: Rajendra Nayak; Santosh Shilimkar; linux-omap@vger.kernel.org Subject: Re: [PATCH] OMAP4: PM: Set static dependency between MPUSS and EMIF Paul Walmsley

RE: Integration branch base switchover to Tony's omap-for-linus branch

2011-03-08 Thread Santosh Shilimkar
-Original Message- From: Cousson, Benoit [mailto:b-cous...@ti.com] Sent: Tuesday, March 08, 2011 9:58 PM To: Shilimkar, Santosh Cc: Paul Walmsley; linux-omap@vger.kernel.org; Nayak, Rajendra; Hilman, Kevin Subject: Re: Integration branch base switchover to Tony's omap-for- linus

Re: [PATCH] omap: overo: Add regulator for ads7846

2011-03-08 Thread Tomi Valkeinen
On Tue, 2011-03-08 at 17:16 -0600, Tony Lindgren wrote: * Steve Sakoman st...@sakoman.com [110305 08:10]: The ads7846 driver now requires a regulator. This patch adds the necessary regulator to the overo board file. Without it, the following error occurs (and the touchscreen will not

[PATCH v2] OMAP4: PM: Set static dependency between MPUSS and EMIF

2011-03-08 Thread Santosh Shilimkar
As per OMAP4430 TRM, the dynamic dependency between MEMIF and MPUSS clockdomains is enable by default. Refer register CM_MPU_DYNAMICDEP description for details. But it doesn't seems to work as expected and MPUSS doesn't wakeup from off-mode if the static dependency is not set between MPUSS and

RE: [PATCH 0/2] omap_wdt: fix interface clock handling

2011-03-08 Thread kalle.jokiniemi
-Original Message- From: ext Paul Walmsley [mailto:p...@pwsan.com] Sent: 9. maaliskuuta 2011 1:02 To: Jokiniemi Kalle (Nokia-MS/Tampere) Cc: Kevin Hilman; linux-omap@vger.kernel.org; t...@atomide.com; b- cous...@ti.com; Koskinen Ilkka (Nokia-MS/Tampere); Charulatha Varadarajan;

[PATCH 0/6] OMAP: DSS2: DSI: IRQ restructuring

2011-03-08 Thread Tomi Valkeinen
Hi, In the future we will have more features using the DSI interrupts, like ULPS handling, and making use-case specific hooks into the main IRQ handler would become burdensome. This patch set cleans up the DSI IRQ handling a bit by implementing a generic way to register/unregister interrupt

[PATCH 1/6] OMAP: DSS2: DSI: Restructure IRQ handler

2011-03-08 Thread Tomi Valkeinen
Clean up the IRQ handler a bit by separating collection of IRQ stats and handling of IRQ errors to separate functions. Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com --- drivers/video/omap2/dss/dsi.c | 123 - 1 files changed, 73 insertions(+), 50

[PATCH 2/6] OMAP: DSS2: DSI: Add ISR support

2011-03-08 Thread Tomi Valkeinen
Add generic ISR support for DSI interrupts. ISRs can be used instead of custom hooks in the interrupt handler. Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com --- drivers/video/omap2/dss/dsi.c | 325 ++--- 1 files changed, 301 insertions(+), 24

[PATCH 3/6] OMAP: DSS2: DSI: use ISR in send_bta_sync

2011-03-08 Thread Tomi Valkeinen
Remove bta_completion handling from the interrupt handler, and use ISR support instead. Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com --- drivers/video/omap2/dss/dsi.c | 32 ++-- 1 files changed, 18 insertions(+), 14 deletions(-) diff --git

[PATCH 4/6] OMAP: DSS2: DSI: use ISR for BTA in framedone

2011-03-08 Thread Tomi Valkeinen
Remove bta_callback from the interrupt handler, and use ISR support instead. Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com --- drivers/video/omap2/dss/dsi.c | 57 +++-- 1 files changed, 15 insertions(+), 42 deletions(-) diff --git

[PATCH 5/6] OMAP: DSS2: DSI: catch DSI errors in send_bta_sync

2011-03-08 Thread Tomi Valkeinen
dsi_vc_send_bta_sync() waits for BTA interrupt with a 500ms timeout. If a DSI error happens, no BTA is received and the timeout triggers. This could be handled much faster by listening to DSI errors also. This patch uses the ISR support to notice DSI errors while waiting for the BTA, thus

[PATCH 6/6] OMAP: DSS2: DSI: fix IRQ debug prints

2011-03-08 Thread Tomi Valkeinen
print_irq_status functions can be called with empty irq status when full irq debugging is enabled. This patch makes print_irq_status functions return immediately when given an empty irq status to lessen the debug spam slightly. Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com ---

Re: [PATCH v2 2/3] omap3: change ISP's IOMMU da_start address

2011-03-08 Thread Sakari Ailus
David Cohen wrote: ISP doesn't consider 0x0 as a valid address, so it should explicitly exclude first page from allowed 'da' range. Signed-off-by: David Cohen daco...@gmail.com --- arch/arm/mach-omap2/omap-iommu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH] omap2+: mux: Remove the use of IDLE flag.

2011-03-08 Thread sricharan
Currently OMAP_DEVICE_PAD_IDLE flag is used to mux pins dynamically. This can be simplified by using the enabled state variable of each pad. This also fixes the issue of the static pads not getting muxed after idling and disable/enable state transitions. Signed-off-by: sricharan

RE: [PATCH] omap2+: mux: Remove the use of IDLE flag.

2011-03-08 Thread Sricharan R
Tony, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Tony Lindgren Sent: Tuesday, March 08, 2011 10:11 PM To: sricharan Cc: linux-omap@vger.kernel.org; b-cous...@ti.com; santosh.shilim...@ti.com; p...@pswan.com Subject: Re:

Re: [PATCH] omap: iommu: disallow mapping NULL address

2011-03-08 Thread Sakari Ailus
David Cohen wrote: On Tue, Mar 8, 2011 at 10:31 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi David, On Monday 07 March 2011 22:35:31 David Cohen wrote: On Mon, Mar 7, 2011 at 11:19 PM, Laurent Pinchart wrote: On Monday 07 March 2011 20:41:21 David Cohen wrote: On Mon,

Re: [PATCH v2 1/3] omap: iovmm: disallow mapping NULL address when IOVMF_DA_ANON is set

2011-03-08 Thread Michael Jones
On 03/08/2011 09:31 PM, Guzman Lugo, Fernando wrote: On Tue, Mar 8, 2011 at 2:15 PM, David Cohen daco...@gmail.com wrote: From: Michael Jones michael.jo...@matrix-vision.de commit c7f4ab26e3bcdaeb3e19ec658e3ad9092f1a6ceb allowed mapping the NULL address if da_start==0, which would then not

<    1   2