On Tuesday 22 November 2011 16:01:05 Mark Brown wrote:
On Tue, Nov 22, 2011 at 04:01:57PM +0200, Peter Ujfalusi wrote:
+ switch (params_rate(params)) {
+ case 96000:
+ case 192000:
+ break;
Why doesn't the driver need to tell the hardware what sample rate to run
at?
On Tuesday 22 November 2011 02:51 PM, Tomi Valkeinen wrote:
dss_cache struct contains a spinlock used to protect the struct. A more
logical place for the spinlock is outside the struct that it is
protecting. So move it there.
Signed-off-by: Tomi Valkeinentomi.valkei...@ti.com
---
On Wednesday 23 November 2011 02:55 PM, Archit Taneja wrote:
snip
Minor comment: The name 'data_lock' doesn't tell much that its
protecting the dss_cache struct. Probably 'cache_lock' or
'priv_data_lock' or something like that may be more informative.
Archit
Ah, just saw the next patch,
Hi,
On Tuesday 22 November 2011 02:51 PM, Tomi Valkeinen wrote:
The functions in apply.c, called mostly via function pointers in overlay
and overlay_manager structs, will be divided into two groups. The other
group will not sleep and can be called from interrupts, and the other
group may sleep.
On Tue, Nov 22, 2011 at 04:06:09PM +0100, jean.pi...@newoldbits.com wrote:
+config POWER_AVS_OMAP_V1
+ tristate AVS support for the OMAP IP version 1
+ depends on ARCH_OMAP3 PM
+ help
+ Say Y to enable AVS support on OMAP containing the version 1 of
+ the SmartReflex
On Tuesday 22 November 2011 02:51 PM, Tomi Valkeinen wrote:
The functions in apply.c, called mostly via function pointers in overlay
and overlay_manager structs, will be divided into two groups. The other
group will not sleep and can be called from interrupts, and the other
group may sleep.
The
On Wed, Nov 23, 2011 at 3:33 AM, Rusty Russell ru...@rustcorp.com.au wrote:
That would imply that I'd done more than glance over them, and
unfortunately I haven't :(
Np, thanks for glancing :)
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to
Hi Afzal,
On 23 November 2011 05:31, Mohammed, Afzal af...@ti.com wrote:
Hi Liam,
On Tue, Nov 08, 2011 at 21:26:39, Mark Brown wrote:
On Tue, Nov 08, 2011 at 06:54:10PM +0530, Afzal Mohammed wrote:
Count of selector voltage is required for regulator_set_voltage
to work via
On Tuesday 22 November 2011 02:51 PM, Tomi Valkeinen wrote:
The current code uses dsi_video_mode_enable/disable functions to
enable/disable DISPC output for video mode displays. For command mode
displays we have no notion in the DISPC side of whether the panel is
enabled, except when a
On Wed, 2011-11-23 at 15:26 +0530, Archit Taneja wrote:
On Tuesday 22 November 2011 02:51 PM, Tomi Valkeinen wrote:
int dss_mgr_set_device(struct omap_overlay_manager *mgr,
@@ -745,16 +762,28 @@ err:
int dss_ovl_set_info(struct omap_overlay *ovl,
struct omap_overlay_info
On Wed, 2011-11-23 at 15:18 +0530, Archit Taneja wrote:
Hi,
On Tuesday 22 November 2011 02:51 PM, Tomi Valkeinen wrote:
The functions in apply.c, called mostly via function pointers in overlay
and overlay_manager structs, will be divided into two groups. The other
group will not sleep
Hi Felipe,
On Wed, Nov 23, 2011 at 10:51 AM, Felipe Balbi ba...@ti.com wrote:
On Tue, Nov 22, 2011 at 04:06:09PM +0100, jean.pi...@newoldbits.com wrote:
+config POWER_AVS_OMAP_V1
+ tristate AVS support for the OMAP IP version 1
+ depends on ARCH_OMAP3 PM
+ help
+ Say Y to
On Wed, Nov 23, 2011 at 5:25 AM, Saravana Kannan skan...@codeaurora.org wrote:
Sorry for the rant, this naming just rubs me the wrong way. I definitely
appreciate the idea behind these patches.
I don't share the same naming concerns you have (if any, then
confusion with the bluetooth AMP
On 11/22/2011 11:21 AM, Tomi Valkeinen wrote:
dss_cache struct contains a spinlock used to protect the struct. A more
logical place for the spinlock is outside the struct that it is
protecting. So move it there.
a small question: isn't it clearer to keep lock inside struct, so it would be
On Wed, 2011-11-23 at 15:40 +0530, Archit Taneja wrote:
On Tuesday 22 November 2011 02:51 PM, Tomi Valkeinen wrote:
The current code uses dsi_video_mode_enable/disable functions to
enable/disable DISPC output for video mode displays. For command mode
displays we have no notion in the DISPC
On Wed, 2011-11-23 at 12:29 +0200, Sergey Kibrik wrote:
On 11/22/2011 11:21 AM, Tomi Valkeinen wrote:
dss_cache struct contains a spinlock used to protect the struct. A more
logical place for the spinlock is outside the struct that it is
protecting. So move it there.
a small question:
On 16:28 Tue 22 Nov , Stephen Warren wrote:
Tony Lindgren wrote at Tuesday, November 22, 2011 10:54 AM:
* Linus Walleij linus.wall...@linaro.org [22 03:30]:
On Tue, Nov 22, 2011 at 12:09 PM, Thomas Abraham
thomas.abra...@linaro.org wrote:
On 17 November 2011 19:27, Linus
On Wed, Nov 23, 2011 at 10:48:24AM +0200, Péter Ujfalusi wrote:
On Tuesday 22 November 2011 16:01:05 Mark Brown wrote:
+ dmic_clk = clk_get(dmic-dev, dmic_fck);
+ if (IS_ERR(dmic_clk)) {
+ dev_err(dmic-dev, cant get dmic_fck\n);
+ return -ENODEV;
+ }
Why aren't
On Wed, Nov 23, 2011 at 11:22:42AM +0100, Jean Pihet wrote:
Hi Felipe,
On Wed, Nov 23, 2011 at 10:51 AM, Felipe Balbi ba...@ti.com wrote:
On Tue, Nov 22, 2011 at 04:06:09PM +0100, jean.pi...@newoldbits.com wrote:
+config POWER_AVS_OMAP_V1
+ tristate AVS support for the OMAP IP
On Wednesday 23 November 2011 04:12 PM, Tomi Valkeinen wrote:
On Wed, 2011-11-23 at 15:40 +0530, Archit Taneja wrote:
On Tuesday 22 November 2011 02:51 PM, Tomi Valkeinen wrote:
The current code uses dsi_video_mode_enable/disable functions to
enable/disable DISPC output for video mode
On Wed, 2011-11-23 at 16:38 +0530, Archit Taneja wrote:
I think it would be best to stuff the 'video mode enabling and
manager
enabling' functionality in omapdss_dsi_display_enable() itself, the
panel driver shouldn't need to call a function separately to enable
video mode for the panel.
Felipe,
On Wed, Nov 23, 2011 at 12:04 PM, Felipe Balbi ba...@ti.com wrote:
On Wed, Nov 23, 2011 at 11:22:42AM +0100, Jean Pihet wrote:
Hi Felipe,
On Wed, Nov 23, 2011 at 10:51 AM, Felipe Balbi ba...@ti.com wrote:
On Tue, Nov 22, 2011 at 04:06:09PM +0100, jean.pi...@newoldbits.com wrote:
Hi,
On Wed, Nov 23, 2011 at 12:30:54PM +0100, Jean Pihet wrote:
On Wed, Nov 23, 2011 at 10:51 AM, Felipe Balbi ba...@ti.com wrote:
On Tue, Nov 22, 2011 at 04:06:09PM +0100, jean.pi...@newoldbits.com
wrote:
+config POWER_AVS_OMAP_V1
+ tristate AVS support for the OMAP IP version
Hi,
On Tue, 2011-11-22 at 20:53 +0530, Jassi Brar wrote:
Signed-off-by: Jassi Brar jaswinder.si...@linaro.org
---
Please write proper commit messages. For example, check
http://who-t.blogspot.com/2009/12/on-commit-messages.html
Tomi
signature.asc
Description: This is a digitally signed
On Wednesday 23 November 2011 04:57 PM, Tomi Valkeinen wrote:
On Wed, 2011-11-23 at 16:38 +0530, Archit Taneja wrote:
I think it would be best to stuff the 'video mode enabling and
manager
enabling' functionality in omapdss_dsi_display_enable() itself, the
panel driver shouldn't need to call a
On Mon, Nov 7, 2011 at 5:35 PM, DebBarma, Tarun Kanti
tarun.ka...@ti.com wrote:
On Fri, Nov 4, 2011 at 10:23 PM, Kevin Hilman khil...@ti.com wrote:
Tarun Kanti DebBarma tarun.ka...@ti.com writes:
From: Nishanth Menon n...@ti.com
GPIO IP revisions such as those used in OMAP4 have a
On Mon, Nov 21, 2011 at 10:12 PM, Ramirez Luna, Omar
omar.rami...@ti.com wrote:
Hi,
On Tue, Nov 8, 2011 at 12:00 AM, Tarun Kanti DebBarma
tarun.ka...@ti.com wrote:
Since omap_dm_timer_write_reg/__omap_dm_timer_write is now modified
to use timer-func_base OCP_CFG should not use this wrapper
You have been awarded $100,000,000.00 among the 5 beneficiaries from the
Vittorio Foundation.Qualification numbers (P-333-7858,B-011-67)
Email:{vittoriofoundati...@hotmail.com}
Mr. Jennifer David
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message
On Wednesday 23 November 2011 10:58:07 Mark Brown wrote:
This just seems like it's making the code needlessly complex - there's
no harm in holding the reference if you don't enable/disable the clock
and it makes this function much simpler.
OK.
We enable the clocks at dai_startup for the
Hi Tony,
here are a few fixes for CBUS and friends plus an RFC
of irq_domain conversion for retu.c. Untested, compile
tested only.
Felipe Balbi (6):
cbus: fix compile breakage
cbus: move the module_platform_driver where possible
cbus: fix very old compile warning
cbus: retu: move
we need to include linux/export.h and linux/module.h
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/cbus/cbus.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/cbus/cbus.c b/drivers/cbus/cbus.c
index 486254d..52eab4a 100644
--- a/drivers/cbus/cbus.c
+++
this allows us to delete a bunch of boilerplate code
from the drivers. While at that, also add missing
MODULE_ALIAS().
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/cbus/cbus.c | 19 +--
drivers/cbus/retu-headset.c | 21 ++---
in theory, we could have many retu devices connected
to different CBUS buses. The only thing preventing
that is the poweroff() function pointer which we need
to set.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/cbus/retu.c | 22 +-
1 files changed, 13 insertions(+),
in theory, we could have many tahvo devices connected
to different CBUS buses. Let's allow that to happen.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/cbus/tahvo.c | 21 -
1 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/drivers/cbus/tahvo.c
platform_driver.remove returns an 'int'.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/cbus/cbus.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/cbus/cbus.c b/drivers/cbus/cbus.c
index c7ed881..45b01fd 100644
--- a/drivers/cbus/cbus.c
+++
Then, when moving to devicetree, we can list
IRQs as 1, 2, 3. It's the only way to have a
sane devicetree actually.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/cbus/retu.c | 42 +++---
1 files changed, 27 insertions(+), 15 deletions(-)
diff --git
On Wed, Nov 23, 2011 at 04:00:23PM +0200, Péter Ujfalusi wrote:
On Wednesday 23 November 2011 10:58:07 Mark Brown wrote:
We enable the clocks at dai_startup for the DMIC (and disable them on
dai_shutdown). We can not reparent while the clocks are enabled.
This is the reason for this
Op 22 nov. 2011, om 18:54 heeft Tony Lindgren het volgende geschreven:
* Linus Walleij linus.wall...@linaro.org [22 03:30]:
On Tue, Nov 22, 2011 at 12:09 PM, Thomas Abraham
thomas.abra...@linaro.org wrote:
On 17 November 2011 19:27, Linus Walleij linus.wall...@linaro.org wrote:
Maybe
On Wednesday 23 November 2011 14:30:50 Mark Brown wrote:
Meh, I guess. It's hard to love code-wise.
So you would prefer me to enable the OMAP DMIC's clocks at pcm_trigger:start
time, and disable them on pcm_trigger:stop?
I have seen cases when the driver did not received the pcm_trigger:stop
On Wed, Nov 23, 2011 at 05:24:41PM +0200, Péter Ujfalusi wrote:
On Wednesday 23 November 2011 14:30:50 Mark Brown wrote:
Meh, I guess. It's hard to love code-wise.
So you would prefer me to enable the OMAP DMIC's clocks at pcm_trigger:start
time, and disable them on pcm_trigger:stop?
I
Hi Stephen,
Thanks for the review !
On Wed, Nov 23, 2011 at 5:27 AM, Stephen Boyd sb...@codeaurora.org wrote:
How big are the images you're loading? I had to split the memcpy up into
megabyte chunks because I was running out of virtual memory to map in
two huge chunks (one for the firmware
On Wed, Nov 23, 2011 at 12:27:31PM +0200, Ohad Ben-Cohen wrote:
On Wed, Nov 23, 2011 at 5:25 AM, Saravana Kannan skan...@codeaurora.org
wrote:
Sorry for the rant, this naming just rubs me the wrong way. I definitely
appreciate the idea behind these patches.
I don't share the same naming
Hi,
On Wed, Nov 23, 2011 at 04:00:48PM +0200, Felipe Balbi wrote:
Then, when moving to devicetree, we can list
IRQs as 1, 2, 3. It's the only way to have a
sane devicetree actually.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/cbus/retu.c | 42
Hi Mike,
* Greg KH g...@kroah.com [22 10:51]:
On Tue, Nov 22, 2011 at 09:57:41AM -0800, Mike Turquette wrote:
Ah, comments like this warm my heart.
Come on, no abusing the kobject code please, if have problems with how
the kernel core works, and it doesn't do things you want it
On Wed, Nov 09, 2011 at 08:51:40AM +1100, Stephen Rothwell wrote:
Hi Carlos,
On Fri, 28 Oct 2011 12:27:46 +0300 Carlos Chinea carlos.chi...@nokia.com
wrote:
...
Right, so -rc1 has been released so I can consider this. Just a couple of
things:
Linus (and the rest of us) is
On Mon, Oct 24, 2011 at 20:15, ming@canonical.com wrote:
static struct platform_device* __init omap4_init_pmu(void)
{
int id = -1;
@@ -420,6 +472,10 @@ static struct platform_device* __init
omap4_init_pmu(void)
return NULL;
}
+
On Wed, Nov 23, 2011 at 08:59:04AM -0800, Tony Lindgren wrote:
..let's plan on getting rid of the early usage of clocks instead so
you don't have the issue of deferring stuff.
No - we have too many platforms already using them early to do a change
like this - and to do such a change will force
On Fri, Nov 18, 2011 at 04:47:20PM +0530, Rajendra Nayak wrote:
+ struct device_node *regnode = NULL;
+ char prop_name[32]; /* 32 is max size of property name */
There ought to be a #define for that though I can't see one right now -
this can't be the only place where we need to do
* Russell King - ARM Linux li...@arm.linux.org.uk [23 09:31]:
On Wed, Nov 23, 2011 at 08:59:04AM -0800, Tony Lindgren wrote:
..let's plan on getting rid of the early usage of clocks instead so
you don't have the issue of deferring stuff.
No - we have too many platforms already using
On Fri, Nov 18, 2011 at 04:47:16PM +0530, Rajendra Nayak wrote:
For the first 2 patches (1/4 and 2/4) I have dropped
Acks from Mark, since they have changed to some extent
from the last post and retained the Acks recieved on the
last 2 patches (3/4 and 4/4) as they remain unchanged.
Looks
On Wed, Nov 23, 2011 at 10:55:19AM -0800, Tony Lindgren wrote:
* Russell King - ARM Linux li...@arm.linux.org.uk [23 09:31]:
Keep the clk API as a fundamental thing which should be initialized early
so we don't have to invent new clk APIs to get around its unavailability.
What else are
* Mark Brown broo...@opensource.wolfsonmicro.com [23 10:34]:
On Wed, Nov 23, 2011 at 10:55:19AM -0800, Tony Lindgren wrote:
* Russell King - ARM Linux li...@arm.linux.org.uk [23 09:31]:
Keep the clk API as a fundamental thing which should be initialized early
so we don't have to
Jean Pihet jean.pi...@newoldbits.com writes:
On Thu, Nov 17, 2011 at 10:24 PM, Kevin Hilman khil...@ti.com wrote:
jean.pi...@newoldbits.com writes:
From: Jean Pihet j-pi...@ti.com
Implement the devices wake-up latency constraints using the global
device PM QoS notification handler which
Jean Pihet jean.pi...@newoldbits.com writes:
On Thu, Nov 17, 2011 at 10:29 PM, Kevin Hilman khil...@ti.com wrote:
jean.pi...@newoldbits.com writes:
From: Jean Pihet j-pi...@ti.com
The MPU latency figures for cpuidle include the MPU itself and also
the peripherals needed for the MPU to
DebBarma, Tarun Kanti tarun.ka...@ti.com writes:
On Mon, Nov 7, 2011 at 5:35 PM, DebBarma, Tarun Kanti
tarun.ka...@ti.com wrote:
On Fri, Nov 4, 2011 at 10:23 PM, Kevin Hilman khil...@ti.com wrote:
Tarun Kanti DebBarma tarun.ka...@ti.com writes:
From: Nishanth Menon n...@ti.com
GPIO IP
Menon, Nishanth n...@ti.com writes:
On Wed, Nov 16, 2011 at 18:02, Kevin Hilman khil...@ti.com wrote:
Felipe Balbi ba...@ti.com writes:
From: Nishanth Menon n...@ti.com
SmartReflex should be disabled while entering low power mode due to
the following reasons:
[...]
Nishanth, in the end,
On 11/23/2011 08:10 AM, Mark Brown wrote:
On Wed, Nov 23, 2011 at 12:27:31PM +0200, Ohad Ben-Cohen wrote:
On Wed, Nov 23, 2011 at 5:25 AM, Saravana Kannanskan...@codeaurora.org wrote:
Sorry for the rant, this naming just rubs me the wrong way. I definitely
appreciate the idea behind these
On Tue, Nov 22, 2011 at 6:03 PM, Saravana Kannan skan...@codeaurora.org wrote:
On 11/21/2011 05:40 PM, Mike Turquette wrote:
+Below is the common struct clk definition from include/linux.clk.h. It
Typo
Will fix in V4.
+is modified slightly for brevity:
+
+struct clk {
+ const
On Tue, Nov 22, 2011 at 7:48 PM, Saravana Kannan skan...@codeaurora.org wrote:
On 11/22/2011 11:13 AM, Greg KH wrote:
On Tue, Nov 22, 2011 at 09:57:41AM -0800, Mike Turquette wrote:
Ah, comments like this warm my heart.
Come on, no abusing the kobject code please, if have problems with how
On Tue, Nov 22, 2011 at 7:12 PM, Saravana Kannan skan...@codeaurora.org wrote:
On 11/21/2011 05:40 PM, Mike Turquette wrote:
+void __clk_unprepare(struct clk *clk)
+{
+ if (!clk)
+ return;
+
+ if (WARN_ON(clk-prepare_count == 0))
+ return;
+
+
* Arnd Bergmann a...@arndb.de [23 12:40]:
On Saturday 19 November 2011, Tony Lindgren wrote:
Please pull omap fixes from:
git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap fixes
Most of this pull request are fixes needed by Tomi for the
display driver clocking.
Hi Carlos,
On Fri, 28 Oct 2011 12:27:46 +0300 Carlos Chinea carlos.chi...@nokia.com
wrote:
I have been working in an HSI framework for linux:
https://lkml.org/lkml/2011/6/10/280
The framework is in good shape and is currently being used for some
people so we would like it to see it
On Wednesday 23 November 2011 14:03:58 Tony Lindgren wrote:
The earlier patches are based on the earlier fixes (while waiting
for them to get merged). So that's certainly not a random commit.
Or at least was not at that time I can rebase those too anyways
now that the earlier fixes are
On Wed, Nov 23, 2011 at 10:55:19AM -0800, Tony Lindgren wrote:
What else are you aware of that is really needed early for clocks other
than clockevent?
TWD will lose its auto-calibration. Then there's various clock source
and clock event implementations. These all call for the clk API to be
* Arnd Bergmann a...@arndb.de [23 13:47]:
On Wednesday 23 November 2011 14:03:58 Tony Lindgren wrote:
The earlier patches are based on the earlier fixes (while waiting
for them to get merged). So that's certainly not a random commit.
Or at least was not at that time I can rebase
...
+int sr_configure_errgen(struct smartreflex *sr)
+{
+ struct smartreflex_platform_data *pdata = sr-pdev-dev.platform_data;
+ u32 sr_config, sr_errconfig;
+
+ if (IS_ERR_OR_NULL(sr))
+ return -EINVAL;
+
+ if (!sr_calculate_clk_length(sr))
+
Hi Arnd,
This one has the DSS patches left out, some patches sent to
stable, and based on -rc2.
Regards,
Tony
The following changes since commit cfcfc9eca2bcbd26a8e206baeb005b055dbf8e37:
Linus Torvalds (1):
Linux 3.2-rc2
are available in the git repository at:
Hi Arnd,
This one has been separated out from the rest of the fixes.
If some of these need to go to stable, then Tomi should
do the rebasing and send them to sta...@vger.kernel.org
as they don't apply cleanly on v3.1.
Regards,
Tony
The following changes since commit
* Tony Lindgren t...@atomide.com [23 14:36]:
* Arnd Bergmann a...@arndb.de [23 13:47]:
On Wednesday 23 November 2011 14:03:58 Tony Lindgren wrote:
The earlier patches are based on the earlier fixes (while waiting
for them to get merged). So that's certainly not a random
* Russell King - ARM Linux li...@arm.linux.org.uk [23 14:07]:
On Wed, Nov 23, 2011 at 10:55:19AM -0800, Tony Lindgren wrote:
What else are you aware of that is really needed early for clocks other
than clockevent?
TWD will lose its auto-calibration. Then there's various clock source
-Original Message-
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
ow...@vger.kernel.org] On Behalf Of Koen Kooi
Sent: Wednesday, November 23, 2011 8:51 PM
To: Tony Lindgren
Cc: Linus Walleij; Thomas Abraham; Nayak, Rajendra; linux-
o...@vger.kernel.org;
On Thu, Nov 24, 2011 at 1:24 AM, Kevin Hilman khil...@ti.com wrote:
DebBarma, Tarun Kanti tarun.ka...@ti.com writes:
On Mon, Nov 7, 2011 at 5:35 PM, DebBarma, Tarun Kanti
tarun.ka...@ti.com wrote:
On Fri, Nov 4, 2011 at 10:23 PM, Kevin Hilman khil...@ti.com wrote:
Tarun Kanti DebBarma
72 matches
Mail list logo