Re: [PATCH 5/6] ARM: OMAP4: MPUSS PM: remove unnecessary shim functions for powerdomain control

2012-11-23 Thread Santosh Shilimkar
On Saturday 24 November 2012 09:12 AM, Paul Walmsley wrote: The OMAP4 MPU subsystem power management code contains several unnecessary shim functions for powerdomain control; remove them. Signed-off-by: Paul Walmsley Cc: Santosh Shilimkar Cc: Kevin Hilman --- Most of them are inline function

[PATCH 6/6] ARM: OMAP2+: powerdomain: fix powerdomain trace integration

2012-11-23 Thread Paul Walmsley
From: Jean Pihet Fix the trace in the case a power domain did not hit the desired state, as reported by Paul Walmsley. Reported-by: Paul Walmsley Signed-off-by: Jean Pihet [p...@pwsan.com: split this fix off from the patch "ARM: OMAP2+: PM debug: trace the functional power domains states"] Si

[PATCH 5/6] ARM: OMAP4: MPUSS PM: remove unnecessary shim functions for powerdomain control

2012-11-23 Thread Paul Walmsley
The OMAP4 MPU subsystem power management code contains several unnecessary shim functions for powerdomain control; remove them. Signed-off-by: Paul Walmsley Cc: Santosh Shilimkar Cc: Kevin Hilman --- arch/arm/mach-omap2/omap-mpuss-lowpower.c | 43 + 1 file changed

[PATCH 3/6] ARM: OMAP3xxx: CPUIdle: simplify the PER next-state code

2012-11-23 Thread Paul Walmsley
The OMAP3xxx CPUIdle driver contains some code to place a lower bound on the PER powerdomain's power state. Convert this code to a data-driven implementation to remove branches and to improve readability. Signed-off-by: Paul Walmsley Cc: Kevin Hilman --- arch/arm/mach-omap2/cpuidle34xx.c | 4

[PATCH 4/6] ARM: OMAP3xxx: CPUIdle: optimize __omap3_enter_idle()

2012-11-23 Thread Paul Walmsley
Avoid programming the MPU and CORE powerdomain next-power-state registers if those powerdomains will never enter low-power states (e.g., the state that people refer to as "C1"). To avoid making assumptions about CPUIdle states based on their order in the list, use a flag to mark CPUIdle states tha

[PATCH 2/6] ARM: OMAP2/3: PRM: fix bogus OMAP2xxx powerstate return values

2012-11-23 Thread Paul Walmsley
On OMAP2xxx chips, the register bitfields for the PM_PWSTCTRL_*.POWERSTATE and PM_PWSTST_*.LASTSTATEENTERED are different than those used on OMAP3/4. The order is reversed. So, for example, on OMAP2xxx, 0x0 indicates 'ON'; but on OMAP3/4, 0x0 indicates 'OFF'. Similarly, on OMAP2xxx, 0x3 indicate

[PATCH 1/6] ARM: OMAP2xxx: powerdomain: core powerdomain missing logic retention states

2012-11-23 Thread Paul Walmsley
Add the possible logic retention states for the 24xx CORE powerdomain. Subsequent patches use this data to avoid returning incorrect data, by skipping reads from register bitfields that don't actually exist. Signed-off-by: Paul Walmsley --- arch/arm/mach-omap2/powerdomains2xxx_data.c |1 + 1

[PATCH 0/6] ARM: OMAP2+: some PM fixes and cleanup for 3.9

2012-11-23 Thread Paul Walmsley
Several OMAP2+ power management fixes, optimizations, and cleanup, intended for 3.9. This series is a prerequisite for the functional powerdomain conversion series. - Paul --- vmlinux object size (delta in bytes from TEST_cleanup-prcm_c9d501e5_v3.7-rc (c9d501e5cb0238910337213e12a09127221c35d8

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-23 Thread Andy Green
On 11/24/12 00:25, the mail apparently from Alan Stern included: On Fri, 23 Nov 2012, Felipe Balbi wrote: Thanks for the example. The only problem is, how do we associate a regulator to a specific port in the system. heh, that's the 1 million dollar question, isn't it ? :-) that's what we ne

Re: [PATCH v2 2/2] ARM: OMAP4+: HDMI: Rearrange platform devices for ASoC drivers

2012-11-23 Thread Ricardo Neri
On 11/22/2012 08:12 PM, Mark Brown wrote: On Thu, Nov 22, 2012 at 08:03:53PM -0600, Ricardo Neri wrote: On 11/21/2012 07:03 PM, Mark Brown wrote: instantiation infrastructure in there which is rather Linux specific. But the board files are only for Linux, right? The ASoC drivers will alw

Re: [PATCH 0/5] remaining omap multiplatform patches for v3.8 merge window

2012-11-23 Thread Russell King - ARM Linux
On Fri, Nov 23, 2012 at 08:54:15AM -0800, Tony Lindgren wrote: > * Russell King - ARM Linux [121122 12:26]: > > On Wed, Nov 21, 2012 at 09:42:19AM -0800, Tony Lindgren wrote: > > > There are few drivers still breaking because of their > > > use of plat/cpu.h and cpu_is_omap macros. The following >

Re: [PATCH v3 5/5] ARM: OMAP2+: omap2plus_defconfig: Enable RTC support

2012-11-23 Thread Igor Mazanov
AnilKumar Ch wrote: AM33XX family of devices uses RTC module, one has to manually enable this support to use RTC features. So this patch enable RTC driver in omap2plus_defconfig. Signed-off-by: AnilKumar Ch --- arch/arm/configs/omap2plus_defconfig |1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH 0/5] remaining omap multiplatform patches for v3.8 merge window

2012-11-23 Thread Tony Lindgren
* Russell King - ARM Linux [121122 12:26]: > On Wed, Nov 21, 2012 at 09:42:19AM -0800, Tony Lindgren wrote: > > There are few drivers still breaking because of their > > use of plat/cpu.h and cpu_is_omap macros. The following > > already have patches queued in linux next: > > > > - drivers/stagin

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-23 Thread Alan Stern
On Fri, 23 Nov 2012, Felipe Balbi wrote: > > And maybe the same sort of scheme could be used for clocks, although I > > don't know how to do it in a generic way that will work on all > > platforms. > > perhaps making use of pm_clk_add() and letting PM layer do the rest for > us ? If that doesn'

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-23 Thread Alan Stern
On Fri, 23 Nov 2012, Felipe Balbi wrote: > > Thanks for the example. The only problem is, how do we associate a > > regulator to a specific port in the system. > > heh, that's the 1 million dollar question, isn't it ? :-) > > that's what we need to figure out now. Luckily we have Alan Stern > he

Re: omap DSS fails with tft410 driver panel?

2012-11-23 Thread Steve Sakoman
On Fri, Nov 23, 2012 at 12:46 AM, Tomi Valkeinen wrote: > Ok, so hmm... So the overlay is disabled, and the paddr is zero. Can you > put a printk at dss/apply.c:dss_olv_set_info, and print ovl->id and > info->paddr? And perhaps also to omapfb-main.c:omapfb_setup_overlay, at > the point where it

Re: [PATCH v3 1/3] pwm: Remove pwm-twl6030 driver

2012-11-23 Thread Thierry Reding
On Tue, Nov 20, 2012 at 10:56:20AM +0100, Peter Ujfalusi wrote: > This driver only supported the Charging indicator LED. > New set of drivers going to provide support for both PWMs and LEDs for twl4030 > and twl6030 series of PMICs. > > Signed-off-by: Peter Ujfalusi > --- > drivers/pwm/Kconfig

Re: [PATCH v3 3/3] pwm: New driver to support PWM driven LEDs on TWL4030/6030 series of PMICs

2012-11-23 Thread Thierry Reding
On Tue, Nov 20, 2012 at 10:56:22AM +0100, Peter Ujfalusi wrote: > The driver supports the following LED outputs as generic PWM driver: > TWL4030 LEDA and LEDB (PWMA and PWMB) > TWL6030 Charging indicator LED (PWM LED) > > On TWL6030 when the PWM requested LED is configured to be controlled by SW.

Re: [PATCH v3 2/3] pwm: New driver to support PWMs on TWL4030/6030 series of PMICs

2012-11-23 Thread Thierry Reding
On Tue, Nov 20, 2012 at 10:56:21AM +0100, Peter Ujfalusi wrote: > The driver supports the following PWM outputs: > TWL4030 PWM0 and PWM1 > TWL6030 PWM1 and PWM2 > > On TWL4030 the PWM signals are muxed. Upon requesting the PWM the driver > will select the correct mux so the PWM can be used. When t

Re: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support

2012-11-23 Thread Peter Korsgaard
> "Thierry" == Thierry Reding writes: Hi, Thierry> Everybody seems to be doing it with a warning, so I guess Thierry> that's fine for now. I just find it strange that if you Thierry> request the default pin group to be selected when in fact the Thierry> hardware doesn't support pinctrl a

[GIT PULL] OMAPDSS fixes for 3.7-rc

2012-11-23 Thread Tomi Valkeinen
Hi Linus, Here are a few OMAPDSS fixes for the next -rc. I'm sending these directly to you, and quite late, as the fbdev tree maintainer (Florian) has been busy with his work and hasn't had time to manage the fb patches. Tomi The following changes since commit ddffeb8c4d0331609ef2581d84de4d7636

Re: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support

2012-11-23 Thread Thierry Reding
On Fri, Nov 23, 2012 at 11:12:15AM +, Philip, Avinash wrote: > On Fri, Nov 23, 2012 at 16:21:10, Thierry Reding wrote: > > On Fri, Nov 23, 2012 at 10:34:02AM +, Philip, Avinash wrote: > > > On Fri, Nov 23, 2012 at 02:29:44, Thierry Reding wrote: > > > > On Wed, Nov 21, 2012 at 06:41:02PM +0

RE: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support

2012-11-23 Thread Philip, Avinash
On Fri, Nov 23, 2012 at 16:21:10, Thierry Reding wrote: > On Fri, Nov 23, 2012 at 10:34:02AM +, Philip, Avinash wrote: > > On Fri, Nov 23, 2012 at 02:29:44, Thierry Reding wrote: > > > On Wed, Nov 21, 2012 at 06:41:02PM +0530, Philip, Avinash wrote: > > > [...] > > > > + pinctrl = devm_pi

Re: [PATCH v4 3/3] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-23 Thread Peter Korsgaard
> "Daniel" == Daniel Mack writes: Hi, >> The other comment was about hw-romcode not being a very good >> name, as it apparently means the 1bit hamming code and ECC layout used >> on the older omap3, and not E.G. the bch8/elm layout used by >> E.G. am335x. Daniel> So which name would yo

RE: [PATCH v3 03/10] ARM: OMAP: AM33xx hwmod: Add parent-child relationship for PWM subsystem

2012-11-23 Thread Philip, Avinash
On Tue, Nov 20, 2012 at 10:33:44, Philip, Avinash wrote: > As part of PWM subsystem integration, PWM subsystem are sharing > resources like clock across submodules (ECAP, EQEP & EHRPWM). > To handle resource sharing & IP integration > 1. Rework on parent child relation between PWMSS and >ECAP,

RE: [PATCH v3 02/10] ARM: am33xx: clk: Add optional clock for EHRPWM

2012-11-23 Thread Philip, Avinash
On Tue, Nov 20, 2012 at 10:33:43, Philip, Avinash wrote: > EHRPWM module requires explicit clock gating from control module. > Hence add clock node in clock tree for EHRPWM modules. > Is there any review on this patch? This patch depends on EHRPWM to work in am335x. Thanks Avinash > Signed-off-b

Re: [PATCH v4 3/3] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-23 Thread Daniel Mack
On 23.11.2012 11:47, Peter Korsgaard wrote: >> "Daniel" == Daniel Mack writes: > > Hi, > > D> + Layouts for 1-bit ecc: stored at beginning of spare area as romcode: > D> + > D> + "hw-romcode"gpmc method & romcode layout > D> + "bch4" 4-bit BCH ecc code > D>

Re: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support

2012-11-23 Thread Thierry Reding
On Fri, Nov 23, 2012 at 10:34:02AM +, Philip, Avinash wrote: > On Fri, Nov 23, 2012 at 02:29:44, Thierry Reding wrote: > > On Wed, Nov 21, 2012 at 06:41:02PM +0530, Philip, Avinash wrote: > > [...] > > > + pinctrl = devm_pinctrl_get_select_default(&pdev->dev); > > > + if (IS_ERR(pinctrl)) > > >

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-23 Thread Felipe Balbi
On Fri, Nov 23, 2012 at 12:23:52PM +0200, Roger Quadros wrote: > On 11/22/2012 06:12 PM, Felipe Balbi wrote: > > Hi, > > > > On Thu, Nov 22, 2012 at 05:00:45PM +0200, Roger Quadros wrote: > >> On 11/22/2012 03:56 PM, Felipe Balbi wrote: > >>> Hi, > >>> > >>> On Thu, Nov 22, 2012 at 09:49:05PM +080

RE: [PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-23 Thread Philip, Avinash
On Wed, Nov 21, 2012 at 15:45:23, Daniel Mack wrote: > On 20.11.2012 16:59, Peter Korsgaard wrote: > >> "Daniel" == Daniel Mack writes: > > > > Hi, > > > > In omap2 driver NAND_ECC_HW ecc mode supports 3 ecc layout > > OMAP_ECC_HAMMING_CODE_HW_ROMCODE > > OMAP_ECC_BCH4_CODE

Re: [PATCH v4 3/3] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-23 Thread Peter Korsgaard
> "Daniel" == Daniel Mack writes: Hi, D> + Layouts for 1-bit ecc: stored at beginning of spare area as romcode: D> + D> + "hw-romcode"gpmc method & romcode layout D> + "bch4" 4-bit BCH ecc code D> + "bch8" 8-bit BCH ecc code D> + >

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-23 Thread Felipe Balbi
Hi, On Thu, Nov 22, 2012 at 09:35:06PM -0500, Alan Stern wrote: > On Thu, 22 Nov 2012, Felipe Balbi wrote: > > > > The latter, more or less. For example, maybe we can tell usbcore > > > somehow that regulator X is in control of a device attached to host > > > controller Y (not sure how we would

RE: [PATCH v4 00/11] Support for AM33xx PWM Subsystem

2012-11-23 Thread Philip, Avinash
On Fri, Nov 23, 2012 at 02:46:16, Thierry Reding wrote: > On Wed, Nov 21, 2012 at 06:40:57PM +0530, Philip, Avinash wrote: > > In AM33xx PWM sub modules like ECAP, EHRPWM & EQEP are integrated to > > PWM subsystem. All these submodules shares the resources (clock) & has > > a clock gating register

RE: [PATCH v4 09/11] ARM: dts: AM33XX: Add PWMSS device tree nodes

2012-11-23 Thread Philip, Avinash
On Fri, Nov 23, 2012 at 02:38:57, Thierry Reding wrote: > On Wed, Nov 21, 2012 at 06:41:06PM +0530, Philip, Avinash wrote: > > Add PWMSS device tree nodes in relation with ECAP & EHRPWM DT nodes to > > AM33XX SoC family. Also populates device tree nodes for ECAP & EHRPWM by > > adding necessary pro

RE: [PATCH v4 06/11] pwm: pwm-tiehrpwm: Add device-tree binding support for EHRPWM driver

2012-11-23 Thread Philip, Avinash
On Fri, Nov 23, 2012 at 02:33:47, Thierry Reding wrote: > On Wed, Nov 21, 2012 at 06:41:03PM +0530, Philip, Avinash wrote: > [...] > > +static const struct of_device_id ehrpwm_of_match[] = { > > + { > > + .compatible = "ti,am33xx-ehrpwm", > > + }, > > Same comment as for patch 4.

Re: [PATCH v4 3/3] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-23 Thread Daniel Mack
Hi Peter, On 19.11.2012 21:52, Peter Korsgaard wrote: >> "D" == Daniel Mack writes: > > Hi, > > D> This patch adds basic DT bindings for OMAP GPMC. > D> The actual peripherals are instanciated from child nodes within the GPMC > > s/instanciated/instantiated/ Thanks, fixed. > > D> nod

RE: [PATCH v4 10/11] ARM: dts: AM33XX: Add PWM backlight DT data to am335x-evm

2012-11-23 Thread Philip, Avinash
On Fri, Nov 23, 2012 at 02:41:47, Thierry Reding wrote: > On Wed, Nov 21, 2012 at 06:41:07PM +0530, Philip, Avinash wrote: > [...] > > diff --git a/arch/arm/boot/dts/am335x-evm.dts > > b/arch/arm/boot/dts/am335x-evm.dts > > index 9f65f17..4178ba4 100644 > > --- a/arch/arm/boot/dts/am335x-evm.dts >

RE: [PATCH v4 11/11] ARM: dts: AM33XX: Add PWM backlight DT data to am335x-evmsk

2012-11-23 Thread Philip, Avinash
On Fri, Nov 23, 2012 at 02:42:45, Thierry Reding wrote: > On Wed, Nov 21, 2012 at 06:41:08PM +0530, Philip, Avinash wrote: > > PWM output from ecap2 uses as backlight source. Also adds low threshold > > value to have a uniform divisions in brightness-levels scales with > > inverse polarity. > > >

RE: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support

2012-11-23 Thread Philip, Avinash
On Fri, Nov 23, 2012 at 02:29:44, Thierry Reding wrote: > On Wed, Nov 21, 2012 at 06:41:02PM +0530, Philip, Avinash wrote: > [...] > > + pinctrl = devm_pinctrl_get_select_default(&pdev->dev); > > + if (IS_ERR(pinctrl)) > > + dev_warn(&pdev->dev, "failed to configure pins from driver\n

RE: [PATCH v4 04/11] pwm: pwm-tiecap: Add device-tree binding support for APWM driver

2012-11-23 Thread Philip, Avinash
On Fri, Nov 23, 2012 at 02:27:33, Thierry Reding wrote: > On Wed, Nov 21, 2012 at 06:41:01PM +0530, Philip, Avinash wrote: > [...] > > +static const struct of_device_id ecap_of_match[] = { > > + { > > + .compatible = "ti,am33xx-ecap", > > + }, > > Same here, can be shorter by put

RE: [PATCH v4 01/11] PWMSS: Add PWM Subsystem driver for parent<->child relationship

2012-11-23 Thread Philip, Avinash
On Fri, Nov 23, 2012 at 02:17:04, Thierry Reding wrote: > On Wed, Nov 21, 2012 at 06:40:58PM +0530, Philip, Avinash wrote: > [...] > > +static const struct of_device_id pwmss_of_match[] = { > > + { > > + .compatible = "ti,am33xx-pwmss", > > + }, > > For consistency with other dri

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-23 Thread Roger Quadros
On 11/22/2012 06:12 PM, Felipe Balbi wrote: > Hi, > > On Thu, Nov 22, 2012 at 05:00:45PM +0200, Roger Quadros wrote: >> On 11/22/2012 03:56 PM, Felipe Balbi wrote: >>> Hi, >>> >>> On Thu, Nov 22, 2012 at 09:49:05PM +0800, Andy Green wrote: > Again it sounds like something that should be done a

Re: [PATCH v3 3/3] pwm: New driver to support PWM driven LEDs on TWL4030/6030 series of PMICs

2012-11-23 Thread Peter Ujfalusi
Hi Thierry, On 11/20/2012 12:58 PM, Thierry Reding wrote: >> Oh, I missed to save the updated comment before I commited the change. >> Can I just send and update patch instead of the whole series again? > > Sure. > > Sorry for taking so long to review this. I'm rather busy with other > things bu

Re: [PATCH] gpio: New driver for GPO emulation using PWM generators

2012-11-23 Thread Peter Ujfalusi
Hi Grant, On 11/23/2012 10:13 AM, Peter Ujfalusi wrote: > Hi Grant, > > On 11/23/2012 08:55 AM, Grant Likely wrote: >> Ugh. and this is why I wanted the PWM and GPIO subsystems to use the >> same namespace and binding. But that's not your fault. >> >> It's pretty horrible to have a separate tran

Re: OMAP4430 produces boot warnings

2012-11-23 Thread Tero Kristo
On Thu, 2012-11-22 at 16:44 +0200, Tomi Valkeinen wrote: > On 2012-11-22 16:34, Tero Kristo wrote: > > > I guess you checked that DSS pwrdm is switching between RET and ON in > > your setup? > > Yes: > > # cat /debug/pm_debug/count |grep dss > [ 35.356567] pwrdm state mismatch(l3init_pwrdm) 3

Re: [PATCH] gpio: New driver for GPO emulation using PWM generators

2012-11-23 Thread Peter Ujfalusi
Hi Grant, On 11/23/2012 08:55 AM, Grant Likely wrote: > Ugh. and this is why I wanted the PWM and GPIO subsystems to use the > same namespace and binding. But that's not your fault. > > It's pretty horrible to have a separate translator node to convert a PWM > into a GPIO (with output only of co

Re: omap DSS fails with tft410 driver panel?

2012-11-23 Thread Tomi Valkeinen
On 2012-11-23 08:14, Steve Sakoman wrote: > On Thu, Nov 22, 2012 at 12:47 AM, Tomi Valkeinen > wrote: > >>> I'll add the printk's to omapfb_setup_plane() that were requested by >>> Tomi and report back. > > Today was a holiday, so family obligations didn't allow much time to > look at this. >

[PATCH 1/1] ARM: dts: am335x-evmsk: Add cpsw phy_id

2012-11-23 Thread Mugunthan V N
Add phy id for CPSW Signed-off-by: Mugunthan V N --- The patch is verified with CPSW patches present in the following git repo git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git arch/arm/boot/dts/am335x-evmsk.dts |8 1 files changed, 8 insertions(+), 0 deletions(-) d

Re: [PATCH] gpio: New driver for GPO emulation using PWM generators

2012-11-23 Thread Grant Likely
On Thu, 22 Nov 2012 14:42:03 +0100, Peter Ujfalusi wrote: > There seams to be board designs using PWM generators as enable/disable > signals. > For these boards we used to have custom code as hacks to deal with such a > situations. > With the gpio-pwm driver we can emulate the GPIO functionality