Re: [PATCH 0/8] memory: emif: miscellaneous bug fixes for EMIF driver

2013-03-16 Thread Lokesh Vutla
On Friday 15 March 2013 11:38 PM, Greg KH wrote: On Mon, Mar 11, 2013 at 10:35:57AM +0530, Lokesh Vutla wrote: This series resolves a few minor issues for EMIF driver. Tested all patches on OMAP4430-sdp. Patch : memory: emif: setup LP settings on freq update is tested on a local tree, since

[PATCH V2 0/8] memory: emif: miscellaneous bug fixes for EMIF driver

2013-03-16 Thread Lokesh Vutla
This series resolves a few minor issues for EMIF driver. Tested all patches on OMAP4430-sdp. Patch : memory: emif: setup LP settings on freq update is tested on a local tree, since freq update cannot be tested on mainline. Ambresh K (1): memory: emif: setup LP settings on freq update Grygorii

[PATCH V2 6/8] memory: emif: Fix the incorrect 'size' parameter in memcpy

2013-03-16 Thread Lokesh Vutla
From: Oleksandr Dmytryshyn oleksandr.dmytrys...@ti.com The issue was that only the first timings table was added to the emif platform data at the emif driver registration. All other timings tables was filled with zeros. Now all emif timings table are added to the platform data. Signed-off-by:

[PATCH V2 7/8] memory: emif: errata i743: Prohibit usage of Power-Down mode

2013-03-16 Thread Lokesh Vutla
From: Grygorii Strashko grygorii.stras...@ti.com ERRATA DESCRIPTION : The EMIF supports power-down state for low power. The EMIF automatically puts the SDRAM into power-down after the memory is not accessed for a defined number of cycles and the EMIF_PWR_MGMT_CTRL[10:8] REG_LP_MODE bit field is

[PATCH V2 8/8] memory: emif: Load the correct custom config values from dt

2013-03-16 Thread Lokesh Vutla
of_get_property returns value in Big Endian format. Before using this value it should be converted to little endian using be32_to_cpup(). Custom configs of emif are read from dt using of_get_property, but these are not converted to litte endian format. Correcting the same here. Signed-off-by:

[PATCH V2 3/8] memory: emif: handle overflow for timing for LP mode

2013-03-16 Thread Lokesh Vutla
From: Nishanth Menon n...@ti.com In case the custom timings provide values which overflow the maximum possible field value, warn and use maximum permissible value. Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Lokesh Vutla lokeshvu...@ti.com Acked-by: Santosh Shilimkar

[PATCH V2 5/8] memory: emif: use restart if power_off not present when out of spec

2013-03-16 Thread Lokesh Vutla
From: Nishanth Menon n...@ti.com Some machine or kernel variants might have missed implementation of power off handlers. We DONOT want to let the system be in out of spec state in this condition. So, WARN and attempt a machine restart in the hopes of clearing the out-of-spec temperature

[PATCH V2 4/8] memory: emif: Handle devices which are not rated for 85C

2013-03-16 Thread Lokesh Vutla
From: Nishanth Menon n...@ti.com As per JESD209-2E specification for LPDDR2, http://www.jedec.org/standards-documents/results/jesd209-2E Table 73, LPDDR2 memories come in two flavors - Standard and Extended. The Standard types can operate from -25C to +85C However, beyond that and upto

[PATCH V2 1/8] memory: emif: Fix the lpmode timeout calculation

2013-03-16 Thread Lokesh Vutla
The driver tries to round up the specified timeout cycles to the next power of 2 value. This should be done defore updating timeout variable. Correcting this here. Reported-by: Nishanth Menon n...@ti.com Signed-off-by: Lokesh Vutla lokeshvu...@ti.com Acked-by: Santosh Shilimkar

[PATCH V2 2/8] memory: emif: setup LP settings on freq update

2013-03-16 Thread Lokesh Vutla
From: Ambresh K ambr...@ti.com Program the power management shadow register on freq update Else the concept of threshold frequencies dont really matter as the system always uses the performance mode timing for LP which is programmed in at init time. Signed-off-by: Nishanth Menon n...@ti.com

Re: [net PATCH 1/1] drivers: net: ethernet: ti: davinci_emac: fix usage of cpdma_check_free_tx_desc()

2013-03-16 Thread Prabhakar Lad
Hi Mugunthan Thanks for the patch! On Fri, Mar 15, 2013 at 7:40 PM, Mugunthan V N mugunthan...@ti.com wrote: Fix which was done in the following commit in cpsw driver has to be taken forward to davinci emac driver as well. commit d35162f89b8f00537d7b240b76d2d0e8b8d29aa0 Author: Daniel Mack

Re: [PATCH 22/50] staging: omap-thermal: rewrite omap_bandgap_adc_to_mcelsius on kernel coding style

2013-03-16 Thread Dan Carpenter
On Fri, Mar 15, 2013 at 09:00:10AM -0400, Eduardo Valentin wrote: Follow Documentation/CodingStyle while doing omap_bandgap_adc_to_mcelsius. Someone should probably fix CodingStyle to be more clear. That's not what was intended at all... :/ regards, dan carpenter -- To unsubscribe from this

Re: [PATCH 25/50] staging: omap-thermal: rewrite omap_bandgap_mcelsius_to_adc on kernel coding style

2013-03-16 Thread Dan Carpenter
On Fri, Mar 15, 2013 at 09:00:13AM -0400, Eduardo Valentin wrote: Follow Documentation/CodingStyle while doing omap_bandgap_mcelsius_to_adc I have the same response for all these bunny hop patches. When you're reading the code and you see a goto then you assume that it's there for a reason so

Re: [PATCH 33/50] staging: omap-thermal: refactor APIs handling threshold values

2013-03-16 Thread Dan Carpenter
On Fri, Mar 15, 2013 at 09:00:21AM -0400, Eduardo Valentin wrote: if (ret) { dev_err(bg_ptr-dev, failed to read thot\n); - return -EIO; + ret = -EIO; + goto exit; } - *thot = temp; + *val = temp; +exit:

Re: [PATCH 47/50] staging: omap-thermal: switch mutex to spinlock inside omap-bandgap

2013-03-16 Thread Dan Carpenter
On Fri, Mar 15, 2013 at 09:00:35AM -0400, Eduardo Valentin wrote: Because there is a need to lock inside IRQ handler, this patch changes the locking mechanism inside the omap-bandgap.[c,h] to spinlocks. Now this lock is used to protect omap_bandgap struct during APIs exposed (possibly used in

Re: [PATCH 00/50] staging: omap-thermal: several code refactoring

2013-03-16 Thread Dan Carpenter
I've reviewed this set. I hate to make people redo whole patchset sets, and I hate re-reviewing code. Obviously, I don't really like the bunny hop patches and I'm trying to discourage that going forward. ;P But I wouldn't say it's a Redo the whole thing kind of problem. Could just resend

Re: Getting kernel uImage build issue on omap2+

2013-03-16 Thread Javier Martinez Canillas
On Sat, Mar 16, 2013 at 5:44 AM, Anil Kumar anilk...@gmail.com wrote: Hi, I am getting kernel uImage build issue on omap2+ log[1] Taken kernel branch for_3.10/dts from https://git.kernel.org/pub/scm/linux/kernel/git/bcousson/linux-omap-dt.git Taking reference from

Re: [PATCH 5/6] OF: Introduce Device Tree resolve support.

2013-03-16 Thread Grant Likely
On Wed, 23 Jan 2013 12:58:02 +0200, Pantelis Antoniou pa...@antoniou-consulting.com wrote: Hi David, On Jan 23, 2013, at 6:40 AM, David Gibson wrote: Ok. Nonetheless it's not hard to avoid a recursive approach here. How can I find the maximum phandle value of a subtree without using

Re: [PATCH 3/6] OF: Export all DT proc update functions

2013-03-16 Thread Grant Likely
On Fri, 4 Jan 2013 21:31:07 +0200, Pantelis Antoniou pa...@antoniou-consulting.com wrote: There are other users for the proc DT functions. Export them. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com Actually, I cannot find the user of this patch. Why is it needed? g. -- To

Re: [PATCH 3/6] OF: Export all DT proc update functions

2013-03-16 Thread Grant Likely
On Fri, 4 Jan 2013 21:31:07 +0200, Pantelis Antoniou pa...@antoniou-consulting.com wrote: There are other users for the proc DT functions. Export them. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com Hi Pantelis. Patches 1 2 look good. No comments there. This patch

Re: Getting kernel uImage build issue on omap2+

2013-03-16 Thread Anil Kumar
Hi Javier, On Sat, Mar 16, 2013 at 2:53 PM, Javier Martinez Canillas jav...@dowhile0.org wrote: On Sat, Mar 16, 2013 at 5:44 AM, Anil Kumar anilk...@gmail.com wrote: Hi, I am getting kernel uImage build issue on omap2+ log[1] Taken kernel branch for_3.10/dts from

Re: [PATCH 07/50] staging: omap-thermal: introduce RMW_BITS macro

2013-03-16 Thread Eduardo Valentin
Hello Dan, On 15-03-2013 17:09, Dan Carpenter wrote: On Fri, Mar 15, 2013 at 08:59:55AM -0400, Eduardo Valentin wrote: This patch introduce a macro to read, update, write bitfields. It will be specific to bandgap data structures. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com ---

Re: [PATCH 09/50] staging: omap-thermal: make a omap_bandgap_power with only one exit point

2013-03-16 Thread Eduardo Valentin
Hey Dan, On 15-03-2013 17:22, Dan Carpenter wrote: On Fri, Mar 15, 2013 at 08:59:57AM -0400, Eduardo Valentin wrote: Change the way the omap_bandgap_power is written so that it has only one exit entry (Documentation/CodingStyle). It's only if there is an unlock or something that you should

Re: [PATCH 47/50] staging: omap-thermal: switch mutex to spinlock inside omap-bandgap

2013-03-16 Thread Eduardo Valentin
On 16-03-2013 04:59, Dan Carpenter wrote: On Fri, Mar 15, 2013 at 09:00:35AM -0400, Eduardo Valentin wrote: Because there is a need to lock inside IRQ handler, this patch changes the locking mechanism inside the omap-bandgap.[c,h] to spinlocks. Now this lock is used to protect omap_bandgap

Re: [PATCH 00/50] staging: omap-thermal: several code refactoring

2013-03-16 Thread Eduardo Valentin
Hello Dan, On 16-03-2013 05:05, Dan Carpenter wrote: I've reviewed this set. I hate to make people redo whole patchset sets, and I hate re-reviewing code. Obviously, I don't really like the bunny hop patches and I'm trying to discourage that going forward. ;P But I wouldn't say it's a Redo

Re: [PATCH 33/50] staging: omap-thermal: refactor APIs handling threshold values

2013-03-16 Thread Eduardo Valentin
On 16-03-2013 04:39, Dan Carpenter wrote: On Fri, Mar 15, 2013 at 09:00:21AM -0400, Eduardo Valentin wrote: if (ret) { dev_err(bg_ptr-dev, failed to read thot\n); - return -EIO; + ret = -EIO; + goto exit; } - *thot

Re: [PATCH 09/50] staging: omap-thermal: make a omap_bandgap_power with only one exit point

2013-03-16 Thread Dan Carpenter
On Sat, Mar 16, 2013 at 08:39:11AM -0400, Eduardo Valentin wrote: Hey Dan, On 15-03-2013 17:22, Dan Carpenter wrote: On Fri, Mar 15, 2013 at 08:59:57AM -0400, Eduardo Valentin wrote: Change the way the omap_bandgap_power is written so that it has only one exit entry

Re: [PATCH 33/50] staging: omap-thermal: refactor APIs handling threshold values

2013-03-16 Thread Dan Carpenter
On Sat, Mar 16, 2013 at 08:49:20AM -0400, Eduardo Valentin wrote: On 16-03-2013 04:39, Dan Carpenter wrote: On Fri, Mar 15, 2013 at 09:00:21AM -0400, Eduardo Valentin wrote: if (ret) { dev_err(bg_ptr-dev, failed to read thot\n); - return -EIO; + ret =

Re: [PATCH 07/50] staging: omap-thermal: introduce RMW_BITS macro

2013-03-16 Thread Dan Carpenter
On Sat, Mar 16, 2013 at 08:36:51AM -0400, Eduardo Valentin wrote: But that said, I don't care for the RMW_BITS() very much as a long term thing. If we just used pointers instead of passing the offset into the bg_ptr-conf-sensors[] array then everything would be a lot cleaner. In other

Re: [PATCH 47/50] staging: omap-thermal: switch mutex to spinlock inside omap-bandgap

2013-03-16 Thread Dan Carpenter
On Sat, Mar 16, 2013 at 08:41:30AM -0400, Eduardo Valentin wrote: On 16-03-2013 04:59, Dan Carpenter wrote: On Fri, Mar 15, 2013 at 09:00:35AM -0400, Eduardo Valentin wrote: @@ -502,9 +504,9 @@ int _omap_bandgap_write_threshold(struct omap_bandgap *bg_ptr, int id, int val, if (ret 0)

Re: [PATCH 00/50] staging: omap-thermal: several code refactoring

2013-03-16 Thread Greg KH
On Sat, Mar 16, 2013 at 08:46:03AM -0400, Eduardo Valentin wrote: Hello Dan, On 16-03-2013 05:05, Dan Carpenter wrote: I've reviewed this set. I hate to make people redo whole patchset sets, and I hate re-reviewing code. Obviously, I don't really like the bunny hop patches and I'm

commit 6797b4f causes boot hangs with nfsroot

2013-03-16 Thread Paul Walmsley
Hi Jon, Looks like commit 6797b4fe0e554ce71f47038fd929c9ca929a9f3c (ARM: OMAP2+: Prevent potential crash if GPMC probe fails) causes hangs on boot. I suspect it may only occur when the root filesystem is on NFS over GPMC-based Ethernet. Here's the current state of affairs at v3.9-rc1 on the

Re: [PATCH V3 02/18] ARM: OMAP2+: Add variable to store number of GPMC waitpins

2013-03-16 Thread Ezequiel Garcia
Hi Jon, On Fri, Mar 15, 2013 at 10:21:00AM -0500, Jon Hunter wrote: The GPMC has wait-pin signals that can be assigned to a chip-select to monitor the ready signal of an external device. Add a variable to indicate the total number of wait-pins for a given device. This will allow us to detect

Re: [PATCH V4] ARM: dts: add minimal DT support for DevKit8000.

2013-03-16 Thread Anil Kumar
Hi Benoit, On Thu, Mar 7, 2013 at 12:21 PM, Benoit Cousson b-cous...@ti.com wrote: Hi, On 03/06/2013 06:53 PM, Tony Lindgren wrote: * Anil Kumar anilk...@gmail.com [130305 18:40]: Hi Tony, From: linux-arm-kernel [mailto:linux-arm-kernel- boun...@lists.infradead.org] On Behalf Of Anil

Re: [PATCH V3 10/18] ARM: OMAP2+: Add function to read GPMC settings from device-tree

2013-03-16 Thread Ezequiel Garcia
Hi Jon, I have some tiny nitpicks... On Fri, Mar 15, 2013 at 10:21:08AM -0500, Jon Hunter wrote: Adds a function to read the various GPMC chip-select settings from device-tree and store them in the gpmc_settings structure. Update the GPMC device-tree binding documentation to describe these

Re: [PATCH V3 00/18] ARM: OMAP2+: GPMC clean-up and DT update

2013-03-16 Thread Ezequiel Garcia
On Fri, Mar 15, 2013 at 10:20:58AM -0500, Jon Hunter wrote: While adding device-tree support for NOR memories, it became apparent that there is no common way for configuring various GPMC settings for devices that interface to the GPMC. These settings include bus-width, synchronous/asynchronous