Hi Benoit,
2013/9/18 Benoit Cousson bcous...@baylibre.com:
Hi Enric,
On 10/09/2013 17:38, Enric Balletbo Serra wrote:
2013/9/10 Enric Balletbo i Serra eballe...@gmail.com:
Add pinmux configuration for MCBSP2 connected to the TDM interface. With
this configuration the Headset modules
On 9/18/2013 11:06 PM, Felipe Balbi wrote:
Hi,
On Wed, Sep 18, 2013 at 07:18:04PM +0200, Laurent Pinchart wrote:
On Wednesday 18 September 2013 13:16:27 Linus Walleij wrote:
On Tue, Sep 17, 2013 at 9:07 PM, Felipe Balbi ba...@ti.com wrote:
has anyone ever successfully using gpio-pcf857x.c
Some omapdss panels are connected to outputs/encoders(HDMI/DSI/DPI) that require
regulators. The output's connect op tries to get a regulator which may not exist
yet because it might get registered later in the kernel boot.
omapdrm currently ignores those panels which return a non zero value when
omapdrm established connections for omap_dss_device devices when probed. It
should also be responsible to disconnect the devices. Keeping the devices
connected can prevent the panel driver modules from unloading, it can also
cause problems when omapdrm is re-inserted.
Signed-off-by: Archit Taneja
Hi!
I get:
CC arch/arm/kernel/machine_kexec.o
/tmp/ccCFXeXG.s: Assembler messages:
/tmp/ccCFXeXG.s:217: Error: garbage following instruction -- `dsb
nshst'
/tmp/ccCFXeXG.s:225: Error: garbage following instruction -- `dsb nsh'
make[1]: *** [arch/arm/kernel/suspend.o] Error 1
make[1]: ***
On Tuesday 17 September 2013 07:59 PM, Joel Fernandes wrote:
On 09/17/2013 01:05 AM, Sekhar Nori wrote:
[..]
mixed messages. In short, we aim for consistency with situation today,
not tomorrow.
What you're asking to do infact breaks consistency with the rest of the
code.
Well, ideally we
On Thu, Sep 19, 2013 at 10:30:02AM +0100, Pavel Machek wrote:
Hi!
I get:
CC arch/arm/kernel/machine_kexec.o
/tmp/ccCFXeXG.s: Assembler messages:
/tmp/ccCFXeXG.s:217: Error: garbage following instruction -- `dsb
nshst'
/tmp/ccCFXeXG.s:225: Error: garbage following instruction --
On Thu 2013-09-19 11:30:02, Pavel Machek wrote:
Hi!
I get:
CC arch/arm/kernel/machine_kexec.o
/tmp/ccCFXeXG.s: Assembler messages:
/tmp/ccCFXeXG.s:217: Error: garbage following instruction -- `dsb
nshst'
/tmp/ccCFXeXG.s:225: Error: garbage following instruction -- `dsb nsh'
On Thu 2013-09-19 10:36:28, Will Deacon wrote:
On Thu, Sep 19, 2013 at 10:30:02AM +0100, Pavel Machek wrote:
Hi!
I get:
CC arch/arm/kernel/machine_kexec.o
/tmp/ccCFXeXG.s: Assembler messages:
/tmp/ccCFXeXG.s:217: Error: garbage following instruction -- `dsb
nshst'
On 19/09/13 11:49, Archit Taneja wrote:
omapdrm established connections for omap_dss_device devices when probed. It
should also be responsible to disconnect the devices. Keeping the devices
connected can prevent the panel driver modules from unloading, it can also
cause problems when omapdrm
Hi,
On Thursday 19 September 2013 03:38 PM, Tomi Valkeinen wrote:
On 19/09/13 11:49, Archit Taneja wrote:
omapdrm established connections for omap_dss_device devices when probed. It
should also be responsible to disconnect the devices. Keeping the devices
connected can prevent the panel driver
Extract DMA channels directly from DT as they can not be found from
platform resources anymore. This is a work-around until davinci audio
driver is updated to use dmaengine.
Signed-off-by: Jyri Sarha jsa...@ti.com
---
.../bindings/sound/davinci-mcasp-audio.txt |5 +++
From: Hebbar, Gururaja gururaja.heb...@ti.com
Device tree support for Davinci Machine driver
When the board boots with device tree, the driver will receive card,
codec, dai interface details (like the card name, DAPM routing map,
phandle for the audio components described in the dts file, codec
Makes interrupts property optional as the interrupts are not currently
used by the driver and adds interrupt-names property to name listed
interrupts. Currently know interrupt names are tx and rx.
Signed-off-by: Jyri Sarha jsa...@ti.com
---
.../bindings/sound/davinci-mcasp-audio.txt |
The sysclk rate does not change runtime so it should be initialized at
init time.
Signed-off-by: Jyri Sarha jsa...@ti.com
---
sound/soc/davinci/davinci-evm.c | 64 +++
1 file changed, 44 insertions(+), 20 deletions(-)
diff --git
The RFC version of patches can been found here:
http://mailman.alsa-project.org/pipermail/alsa-devel/2013-September/066178.html
The v2 version of patches can be found here:
http://mailman.alsa-project.org/pipermail/alsa-devel/2013-September/066379.html
Changes since v2
[PATCH v2 01/11] ASoC:
This patch adds DMA register location to mcasp DT bindings. On am33xx
SoCs the McASP registers are mapped trough L4 interconnect, which is
not accessible by the DMA controller, so McASP data port is mapped
trough L3 to a different location.
Signed-off-by: Hebbar, Gururaja gururaja.heb...@ti.com
From: Pantelis Antoniou pa...@antoniou-consulting.com
Add missing mcasp entries in the am33xx.dtsi include file.
Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com
Signed-off-by: Darren Etheridge detheri...@ti.com
Signed-off-by: Jyri Sarha jsa...@ti.com
---
Add list of codec pins to tlv320aic3x DT bindings document.
Signed-off-by: Jyri Sarha jsa...@ti.com
---
.../devicetree/bindings/sound/tlv320aic3x.txt | 19 +++
1 file changed, 19 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/tlv320aic3x.txt
Add regulator properties to tlv320aic3x DT bindings document.
Signed-off-by: Jyri Sarha jsa...@ti.com
---
.../devicetree/bindings/sound/tlv320aic3x.txt |7 +++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/tlv320aic3x.txt
From: Hebbar, Gururaja gururaja.heb...@ti.com
AM33xx uses same McASP IP as the Davinci Platform. This patch updates
Kconfig and makefile to enable build for McASP, PCM Codec drivers.
Signed-off-by: Hebbar, Gururaja gururaja.heb...@ti.com
Signed-off-by: Darren Etheridge detheri...@ti.com
From: Darren Etheridge detheri...@ti.com
Adds sound, tlv320aic3x, mcasp1, and am335x_evm_audio_pin nodes.
Signed-off-by: Darren Etheridge detheri...@ti.com
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
Signed-off-by: Jyri Sarha jsa...@ti.com
---
arch/arm/boot/dts/am335x-evm.dts | 56
This patch adds an optional address range to reg property. The range
describes the register location for DMA controller on am33xx. The both
address ranges are named accordingly in the reg-names property.
Signed-off-by: Hebbar, Gururaja gururaja.heb...@ti.com
Signed-off-by: Darren Etheridge
On 09/19/2013 03:13 AM, George Cherian wrote:
On 9/18/2013 11:06 PM, Felipe Balbi wrote:
Hi,
On Wed, Sep 18, 2013 at 07:18:04PM +0200, Laurent Pinchart wrote:
On Wednesday 18 September 2013 13:16:27 Linus Walleij wrote:
On Tue, Sep 17, 2013 at 9:07 PM, Felipe Balbi ba...@ti.com wrote:
has
On 9/19/2013 5:37 PM, Nishanth Menon wrote:
On 09/19/2013 03:13 AM, George Cherian wrote:
On 9/18/2013 11:06 PM, Felipe Balbi wrote:
Hi,
On Wed, Sep 18, 2013 at 07:18:04PM +0200, Laurent Pinchart wrote:
On Wednesday 18 September 2013 13:16:27 Linus Walleij wrote:
On Tue, Sep 17, 2013 at
On 09/19/2013 07:20 AM, George Cherian wrote:
On 9/19/2013 5:37 PM, Nishanth Menon wrote:
On 09/19/2013 03:13 AM, George Cherian wrote:
On 9/18/2013 11:06 PM, Felipe Balbi wrote:
Hi,
On Wed, Sep 18, 2013 at 07:18:04PM +0200, Laurent Pinchart wrote:
On Wednesday 18 September 2013 13:16:27
On 19/09/13 13:20, George Cherian wrote:
On 9/19/2013 5:37 PM, Nishanth Menon wrote:
On 09/19/2013 03:13 AM, George Cherian wrote:
On 9/18/2013 11:06 PM, Felipe Balbi wrote:
Hi,
On Wed, Sep 18, 2013 at 07:18:04PM +0200, Laurent Pinchart wrote:
On Wednesday 18 September 2013 13:16:27 Linus
Hi,
On Thu, Sep 19, 2013 at 01:43:41PM +0530, George Cherian wrote:
On 9/18/2013 11:06 PM, Felipe Balbi wrote:
Hi,
On Wed, Sep 18, 2013 at 07:18:04PM +0200, Laurent Pinchart wrote:
On Wednesday 18 September 2013 13:16:27 Linus Walleij wrote:
On Tue, Sep 17, 2013 at 9:07 PM, Felipe Balbi
Hi,
On Thu, Sep 19, 2013 at 07:36:33AM -0500, Nishanth Menon wrote:
On 09/19/2013 07:20 AM, George Cherian wrote:
On 9/19/2013 5:37 PM, Nishanth Menon wrote:
On 09/19/2013 03:13 AM, George Cherian wrote:
On 9/18/2013 11:06 PM, Felipe Balbi wrote:
Hi,
On Wed, Sep 18, 2013 at
Improve compatibility string format to ti,phy-pipe3-type
where type can be usb3 or sata. Remove pcie type
as it is not yet supported due to missing DPLL data.
Signed-off-by: Roger Quadros rog...@ti.com
---
Documentation/devicetree/bindings/phy/omap-phy.txt |3 +--
Texas Instruments SoCs like OMAP5 and DRA7 contain a SATA wrapper
around the AHCI SATA core. This driver will manage that.
CC: Tejun Heo t...@kernel.org
Signed-off-by: Roger Quadros rog...@ti.com
---
Documentation/devicetree/bindings/ata/ti-sata.txt | 31
drivers/ata/Kconfig
From: Balaji T K balaj...@ti.com
Some platforms have a PHY hooked up to the
SATA controller. The PHY needs to be initialized
and powered up for SATA to work. We do that
using the PHY framework.
[Roger Q] Cleaned up.
CC: Tejun Heo t...@kernel.org
Signed-off-by: Balaji T K balaj...@ti.com
USB and SATA DPLLs need different settings. Provide
the SATA DPLL settings and use the proper DPLL settings
based on device tree compatible_id.
Signed-off-by: Roger Quadros rog...@ti.com
---
drivers/phy/phy-omap-pipe3.c | 82 ++--
Hi,
This series adds SATA controller support for the Texas Instruments
OMAP5 and DRA7 platforms.
As the SATA controller is compatible with AHCI, we use the ahci_platform
driver and just provide the glue logic.
The AHCI controller is enclosed within a TI specific Wrapper that controls
the
The pipe3-phy driver expects certain named clocks.
Provide the necessary clocks.
CC: Benoit Cousson bcous...@baylibre.com
Signed-off-by: Roger Quadros rog...@ti.com
---
arch/arm/boot/dts/omap5.dtsi |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git
From: Kishon Vijay Abraham I kis...@ti.com
As this driver is no longer USB specific use generic clock names.
[Roger Q]
- Fix PLL_SD_SHIFT from 9 to 10
- As optclk and wkupclk may not be always required, don't bail out
if they aren't available.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
Update compatibility string and DT binding document.
Signed-off-by: Roger Quadros rog...@ti.com
---
Documentation/devicetree/bindings/phy/omap-phy.txt | 23
Documentation/devicetree/bindings/usb/omap-usb.txt | 23
2 files changed, 23 insertions(+),
From: Kishon Vijay Abraham I kis...@ti.com
Rename struct omap_control_usb to struct omap_control_phy since it can
be used to control PHY of USB, SATA and PCIE. Also move the driver and
include files under *phy* and made the corresponding changes in the users
of phy-omap-control.
Signed-off-by:
Update compatible property for usb3phy node.
CC: Benoit Cousson bcous...@baylibre.com
Signed-off-by: Roger Quadros rog...@ti.com
---
arch/arm/boot/dts/omap5.dtsi |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
Hi,
On Thu, Sep 19, 2013 at 06:38:13PM +0530, George Cherian wrote:
On 9/19/2013 6:14 PM, Felipe Balbi wrote:
Hi,
On Thu, Sep 19, 2013 at 01:43:41PM +0530, George Cherian wrote:
On 9/18/2013 11:06 PM, Felipe Balbi wrote:
Hi,
On Wed, Sep 18, 2013 at 07:18:04PM +0200, Laurent Pinchart
From: Keshava Munegowda keshava_mgo...@ti.com
Create hwmods for ocp2scp3 and sata modules.
[Roger Q] Clean up.
CC: Benoit Cousson bcous...@baylibre.com
Signed-off-by: Balaji T K balaj...@ti.com
Signed-off-by: Roger Quadros rog...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 72
On Thu, Sep 19, 2013 at 02:29:34PM +0300, Jyri Sarha wrote:
The sysclk rate does not change runtime so it should be initialized at
init time.
Are there any updates from the version already applied (I only dropped
the patch to allow the extra builds, not this one).
signature.asc
Description:
From: Balaji T K balaj...@ti.com
Add support for sata controller.
[Roger Q] Clean up.
CC: Benoit Cousson bcous...@baylibre.com
Signed-off-by: Balaji T K balaj...@ti.com
Signed-off-by: Roger Quadros rog...@ti.com
---
arch/arm/boot/dts/dra7.dtsi | 49 +++
From: Balaji T K balaj...@ti.com
Add support for sata.
[Roger Q] Clean up.
CC: Benoit Cousson bcous...@baylibre.com
Signed-off-by: Balaji T K balaj...@ti.com
Signed-off-by: Roger Quadros rog...@ti.com
---
arch/arm/boot/dts/omap5.dtsi | 51 +-
1 files
Add OCP2SCP1 module address space.
CC: Benoit Cousson bcous...@baylibre.com
Signed-off-by: Roger Quadros rog...@ti.com
---
arch/arm/boot/dts/omap5.dtsi |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
index
From: Nikhil Devshatwar nikhil...@ti.com
Add hwmods for ocp2scp3 and sata modules.
[Roger Q] Clean up.
CC: Benoit Cousson bcous...@baylibre.com
Signed-off-by: Balaji T K balaj...@ti.com
Signed-off-by: Nikhil Devshatwar nikhil...@ti.com
Signed-off-by: Roger Quadros rog...@ti.com
---
From: Benoit Cousson bcous...@baylibre.com
without that hwmod data, USB3 will not in OMAP5 boards.
Signed-off-by: Benoit Cousson bcous...@baylibre.com
Signed-off-by: Felipe Balbi ba...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 45
1 files changed, 45
On Thu, Sep 19, 2013 at 02:29:40PM +0300, Jyri Sarha wrote:
Add regulator properties to tlv320aic3x DT bindings document.
Similarly for this and the other CODEC patch, are these changed?
signature.asc
Description: Digital signature
On Thu, Sep 19, 2013 at 02:29:33PM +0300, Jyri Sarha wrote:
The RFC version of patches can been found here:
http://mailman.alsa-project.org/pipermail/alsa-devel/2013-September/066178.html
This all looks fine to me, I'd like some review from the DT guys though.
signature.asc
Description:
As I described in cover letter on these patches did change:
[PATCH v2 05/11] ASoC: davinci-mcasp: Remove interrupt property from DT bindin
- restore binding but make it optional and add interrupt-names property
[PATCH v2 06/11] ASoC: davinci: Add support for AM33xx SoC Audio
-
No change here either.
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
From: devicetree-ow...@vger.kernel.org [devicetree-ow...@vger.kernel.org] on
behalf of Mark Brown
Hello.
On 09/19/2013 05:24 PM, Roger Quadros wrote:
From: Balaji T K balaj...@ti.com
Add support for sata controller.
[Roger Q] Clean up.
CC: Benoit Cousson bcous...@baylibre.com
Signed-off-by: Balaji T K balaj...@ti.com
Signed-off-by: Roger Quadros rog...@ti.com
---
On 19.09.2013 15:05, Roger Quadros wrote:
From: Kishon Vijay Abraham I kis...@ti.com
Rename struct omap_control_usb to struct omap_control_phy since it can
be used to control PHY of USB, SATA and PCIE. Also move the driver and
include files under *phy* and made the corresponding changes in
On 09/19/2013 05:23 PM, Roger Quadros wrote:
Add OCP2SCP1 module address space.
CC: Benoit Cousson bcous...@baylibre.com
Signed-off-by: Roger Quadros rog...@ti.com
---
arch/arm/boot/dts/omap5.dtsi |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git
On Wednesday 18 September 2013 02:32 AM, Kevyn-Alexandre Paré wrote:
Hi,
My question is related to the drivers/mmc/host/omap_hsmmc.c host
controller compatibility with SDXC for the OMAP35x?
Reading the TRM for OMAP35x:
http://www.ti.com/lit/ug/spruf98x/spruf98x.pdf
It's said that:
- Full
On 08/26/2013 08:53 AM, Balaji T K wrote:
Add mmc1, mmc2 dt node to dra7-evm
Balaji T K (2):
ARM: dts: dra7-evm: Add mmc1 node for micro-sd support
ARM: dts: dra7-evm: Add mmc2 node for eMMC support
arch/arm/boot/dts/dra7-evm.dts | 20
1 files changed, 20
* Luca Coelho l...@coelho.fi [130918 22:50]:
On Wed, 2013-09-18 at 16:47 -0700, Tony Lindgren wrote:
* Tony Lindgren t...@atomide.com [130918 11:00]:
* Benoit Cousson bcous...@baylibre.com [130918 02:12]:
Hi Tony,
On 18/09/2013 02:02, Tony Lindgren wrote:
* Luca Coelho
3.3V fixed regulator does not belong to TPS node - as a result
the fixed regulator is never probed and MMC is continually deferred due
to lack of regulator.
Move the fixed regulator to be at root of platform.
Signed-off-by: Nishanth Menon n...@ti.com
---
Based on: (benoit's for_3.13/dts branch)
On Thu, 2013-09-19 at 07:53 -0700, Tony Lindgren wrote:
* Luca Coelho l...@coelho.fi [130918 22:50]:
On Wed, 2013-09-18 at 16:47 -0700, Tony Lindgren wrote:
* Tony Lindgren t...@atomide.com [130918 11:00]:
* Benoit Cousson bcous...@baylibre.com [130918 02:12]:
Hi Tony,
On
Hello My Dear,
How are you today? I hope fine, I came across your contact today while browsing
looking for reliable friend and i became interested, My name is miss Famatta
Sando. I wish to have you as a friend, if you care. I have important reasons to
request your interest for a serious
Hi,
On Thu, Sep 19, 2013 at 11:44:02AM +0200, Pavel Machek wrote:
something in 3.12-rc1 broke display :-(. (dmesg diff attached at the
end, maybe someone knows...)
3.12-rc1 for N900 compiles and works (also display) here with binutils
2.23.2.
+ omapfb omapfb: no displays
[...]
- acx565akm
This allows the palmas pm_power_off to kick in on power off command
and switch off the board.
Signed-off-by: Nishanth Menon n...@ti.com
---
Based on: (benoit's for_3.13/dts branch)
https://git.kernel.org/cgit/linux/kernel/git/bcousson/linux-omap-dt.git/log/?h=for_3.13/dts
This uses the support
On Thursday 19 September 2013 00:26:43 Tony Lindgren wrote:
* Pali Rohár pali.ro...@gmail.com [130918 15:02]:
Without max_current data in board file lp5523 driver does
not change current.
Hmm is this a regression or are there other reasons to merge
this during the -rc cycle?
I think
On 16:03-20130919, Nishanth Menon wrote:
Hi,
Based on [1], Randy rightly pointed out that OPP functions and data
structures could be a bit specific to Power management.
So, the following series is based on v3.12-rc1 tag.
If folks like it broken in a different way, I am open
Hi,
Based on [1], Randy rightly pointed out that OPP functions and data
structures could be a bit specific to Power management.
So, the following series is based on v3.12-rc1 tag.
If folks like it broken in a different way, I am open to suggestions.
Nishanth Menon (3):
PM / OPP: rename
Since Operating Performance Points(OPP) functions are specific to
device specific power management, be specific and rename opp.h
to pm_opp.h
Reported-by: Randy Dunlap rdun...@infradead.org
Signed-off-by: Nishanth Menon n...@ti.com
---
Documentation/power/opp.txt |2 +-
Since Operating Performance Points(OPP) functions are specific to
device specific power management, be specific and rename opp_*
accessors in OPP library with dev_pm_opp_* equivalent.
Impacted functions are:
opp_get_voltage
opp_get_freq
opp_get_opp_count
opp_find_freq_exact
opp_find_freq_floor
Since Operating Performance Points(OPP) data structures are specific
to device specific power management, be specific and rename opp_* data
structures in OPP library with dev_pm_opp_* equivalent.
Impacted structures are:
struct opp
enum opp_event
Minor checkpatch warning fixes as a result of
* Pali Rohár pali.ro...@gmail.com [130919 14:10]:
On Thursday 19 September 2013 00:26:43 Tony Lindgren wrote:
* Pali Rohár pali.ro...@gmail.com [130918 15:02]:
Without max_current data in board file lp5523 driver does
not change current.
Hmm is this a regression or are there other
This started out as a request to look at the DMA mask situation, and how
to solve the issues which we have on ARM - notably how the DMA mask
should be setup.
However, I started off reviewing how the dma_mask and coherent_dma_mask
was being used, and what I found was rather messy, and in some
On Wednesday 18 September 2013 19:42:12 Tony Lindgren wrote:
* Pali Rohár pali.ro...@gmail.com [130918 09:08]:
On Wednesday 18 September 2013 15:16:44 Pavel Machek wrote:
On Sun 2013-09-08 02:02:52, Aaro Koskinen wrote:
Hi,
On Fri, Sep 06, 2013 at 10:34:05PM +0200, Pali Rohár
On Thursday 19 September 2013 23:29:22 Tony Lindgren wrote:
* Pali Rohár pali.ro...@gmail.com [130919 14:10]:
On Thursday 19 September 2013 00:26:43 Tony Lindgren wrote:
* Pali Rohár pali.ro...@gmail.com [130918 15:02]:
Without max_current data in board file lp5523 driver
does not
The fallback to 32-bit DMA mask is rather odd:
if (!dma_set_mask(pdev-dev, DMA_BIT_MASK(64))
!dma_set_coherent_mask(pdev-dev, DMA_BIT_MASK(64))) {
*using_dac = true;
} else {
err = dma_set_mask(pdev-dev, DMA_BIT_MASK(32));
The fallback to 32-bit DMA mask is rather odd:
err = dma_set_mask(pdev-dev, DMA_BIT_MASK(64));
if (!err) {
err = dma_set_coherent_mask(pdev-dev, DMA_BIT_MASK(64));
if (!err)
pci_using_dac = 1;
} else {
Provide a helper to set both the DMA and coherent DMA masks to the
same value - this avoids duplicated code in a number of drivers,
sometimes with buggy error handling, and also allows us identify
which drivers do things differently.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
The fallback to 32-bit DMA mask is rather odd:
err = dma_set_mask(pdev-dev, DMA_BIT_MASK(64));
if (!err) {
err = dma_set_coherent_mask(pdev-dev, DMA_BIT_MASK(64));
if (!err)
pci_using_dac = 1;
} else {
The fallback to 32-bit DMA mask is rather odd:
err = dma_set_mask(pdev-dev, DMA_BIT_MASK(64));
if (!err) {
err = dma_set_coherent_mask(pdev-dev, DMA_BIT_MASK(64));
if (!err)
pci_using_dac = 1;
} else {
The fallback to 32-bit DMA mask is rather odd:
err = dma_set_mask(pdev-dev, DMA_BIT_MASK(64));
if (!err) {
err = dma_set_coherent_mask(pdev-dev, DMA_BIT_MASK(64));
if (!err)
pci_using_dac = 1;
} else {
The fallback to 32-bit DMA mask is rather odd:
if (!dma_set_mask(pdev-dev, DMA_BIT_MASK(64))
!dma_set_coherent_mask(pdev-dev, DMA_BIT_MASK(64))) {
pci_using_dac = 1;
} else {
err = dma_set_mask(pdev-dev, DMA_BIT_MASK(32));
The fallback to 32-bit DMA mask is rather odd:
if (!dma_set_mask(pdev-dev, DMA_BIT_MASK(64))
!dma_set_coherent_mask(pdev-dev, DMA_BIT_MASK(64))) {
pci_using_dac = 1;
} else {
err = dma_set_mask(pdev-dev, DMA_BIT_MASK(32));
On Thu, 2013-09-19 at 22:25 +0100, Russell King wrote:
Provide a helper to set both the DMA and coherent DMA masks to the
same value - this avoids duplicated code in a number of drivers,
sometimes with buggy error handling, and also allows us identify
which drivers do things differently.
The code sequence:
dev-coherent_dma_mask = DMA_BIT_MASK(24);
dev-dma_mask = dev-coherent_dma_mask;
bypasses the architectures check on the DMA mask. It can be replaced
with dma_coerce_mask_and_coherent(), avoiding the direct initialization
of this mask.
Signed-off-by: Russell
register_platform_device_full() can setup the DMA mask provided the
appropriate member is set in struct platform_device_info. So lets
make that be the case. This avoids a direct reference to the DMA
masks by this driver.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
dcdbas was explicitly initializing DMA masks thusly:
dcdbas_pdev-dev.coherent_dma_mask = DMA_BIT_MASK(32);
dcdbas_pdev-dev.dma_mask = dcdbas_pdev-dev.coherent_dma_mask;
which bypasses the architecture check. Moreover, it is creating the
dcdbas_pdev device itself, and using the
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/crypto/ixp4xx_crypto.c | 13 -
1 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/crypto/ixp4xx_crypto.c b/drivers/crypto/ixp4xx_crypto.c
index 8306185..214357e 100644
---
Hi Greg,
On Tuesday 17 September 2013 09:11 PM, Felipe Balbi wrote:
On Wed, Sep 04, 2013 at 02:27:06PM +0530, Kishon Vijay Abraham I wrote:
On Tuesday 03 September 2013 09:20 PM, Greg KH wrote:
On Tue, Sep 03, 2013 at 08:55:23PM +0530, Kishon Vijay Abraham I wrote:
Hi Greg,
On Wednesday 28
86 matches
Mail list logo
