[PATCH 2/2] OMAP: Cleanup IOMMU error messages

2011-01-31 Thread David Cohen
IOMMU error messages are duplicated. They're printed on IOMMU specific layer for OMAP2,3 and once again on the above layer. With this patch, the error message is printed on the above layer only. Signed-off-by: David Cohen david.co...@nokia.com --- arch/arm/mach-omap2/iommu2.c| 33

[PATCH 1/2] OMAP: Add generic IOMMU errors code

2011-01-31 Thread David Cohen
Generic IOMMU errors code are necessary to handle errors on generic layer. Signed-off-by: David Cohen david.co...@nokia.com --- arch/arm/plat-omap/include/plat/iommu.h |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/arch/arm/plat-omap/include/plat/iommu.h b/arch

Re: [PATCHv3 01/11] staging: tidspbridge: replace iommu custom for opensource implementation

2010-10-06 Thread David Cohen
Hi Fernando, I have few comments below. diff --git a/drivers/staging/tidspbridge/core/io_sm.c b/drivers/staging/tidspbridge/core/io_sm.c index 5718645..842b8db 100644 --- a/drivers/staging/tidspbridge/core/io_sm.c +++ b/drivers/staging/tidspbridge/core/io_sm.c @@ -291,6 +291,7 @@ int

Re: [PATCHv3 1/6] omap3: Add external VBUS power switch and overcurrent detect on IGEP v2 board.

2010-10-05 Thread David Cohen
On Sat, Oct 02, 2010 at 12:12:32PM +0200, ext Enric Balletbò i Serra wrote: 2010/10/2 David Cohen david.co...@nokia.com: Hi, On Fri, Oct 01, 2010 at 11:09:04PM +0200, ext Enric Balletbo i Serra wrote: GPIO for various devices are missing from the board initialization. This patch adds

Re: [PATCH 2/4] iovmm: fix roundup for next area and end check for the last area

2010-10-04 Thread David Cohen
Hi, I have no access to my @nokia.com e-mail at this moment, so I'm replying using my personal one. On Mon, Oct 4, 2010 at 6:17 AM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: On Fri, Oct 01, 2010 at 09:21:36PM +0200, ext Guzman Lugo, Fernando wrote: On Fri, Oct 01, 2010 at

Re: [PATCH 2/4] iovmm: fix roundup for next area and end check for the last area

2010-10-04 Thread David Cohen
On Mon, Oct 04, 2010 at 05:37:04PM +0200, ext Guzman Lugo, Fernando wrote: -Original Message- From: David Cohen [mailto:daco...@gmail.com] Sent: Monday, October 04, 2010 7:11 AM To: Guzman Lugo, Fernando Cc: David Cohen; Doyu Hiroshi (Nokia-MS/Espoo); Contreras Felipe

Re: [PATCH 2/4] iovmm: fix roundup for next area and end check for the last area

2010-10-02 Thread David Cohen
On Fri, Oct 01, 2010 at 09:21:36PM +0200, ext Guzman Lugo, Fernando wrote: On Fri, Oct 01, 2010 at 06:10:30PM +0200, ext Guzman Lugo, Fernando wrote: [snip] arch/arm/plat-omap/iovmm.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff

Re: [PATCHv3 1/6] omap3: Add external VBUS power switch and overcurrent detect on IGEP v2 board.

2010-10-02 Thread David Cohen
Hi, On Fri, Oct 01, 2010 at 11:09:04PM +0200, ext Enric Balletbo i Serra wrote: GPIO for various devices are missing from the board initialization. This patch adds support for the VBUS and over current gpios. Without this patch, input/outputs from these two sources are ignored.

Re: [PATCH 2/4] iovmm: fix roundup for next area and end check for the last area

2010-10-01 Thread David Cohen
Hi, On Fri, Oct 01, 2010 at 05:08:53AM +0200, ext Fernando Guzman Lugo wrote: As da_end does not belongs to the area the roundup should be done to da_end and not to da_end + 1. Also the end check for the last area should be ULONG_MAX - start + 1 = bytes. Signed-off-by: Fernando Guzman Lugo

Re: [PATCH v2 2/2] OMAP3: DMA: Errata: sDMA FIFO draining does not finish

2010-10-01 Thread David Cohen
Hi, On Fri, Oct 01, 2010 at 01:04:55PM +0200, ext Peter Ujfalusi wrote: Implement the suggested workaround for OMAP3 regarding to sDMA draining issue, when the channel is disabled on the fly. This errata affects the following configuration: sDMA transfer is source synchronized Buffering is

Re: [PATCH v2 2/2] OMAP3: DMA: Errata: sDMA FIFO draining does not finish

2010-10-01 Thread David Cohen
On Fri, Oct 01, 2010 at 02:16:53PM +0200, Peter Ujfalusi wrote: On Friday 01 October 2010 14:50:37 David Cohen wrote: + l = sys_cf = dma_read(OCP_SYSCONFIG); Shouldn't it be avoided? I'm restoring the OCP_SYSCONFIG register later on, and reusing 'l' here to avoid

Re: [PATCH 2/4] iovmm: fix roundup for next area and end check for the last area

2010-10-01 Thread David Cohen
On Fri, Oct 01, 2010 at 06:10:30PM +0200, ext Guzman Lugo, Fernando wrote: [snip] arch/arm/plat-omap/iovmm.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c index 24ca9c4..fc6b109 100644

<    1   2