Re: [PATCH 2/2] usb: musb: Fix getting a generic phy for musb_dsps

2015-02-08 Thread George Cherian
Hi Tony, On 02/06/2015 10:53 PM, Tony Lindgren wrote: * George Cherian george.cher...@ti.com [150206 05:05]: Hi Tony, You also need to add similar things in dsps_musb_reset(); Otherwise you might not recover from a BABBLE condition. Thank I totally missed that, updated patch below. Do you

Re: [PATCH 2/2] usb: musb: Fix getting a generic phy for musb_dsps

2015-02-06 Thread George Cherian
Hi Tony, You also need to add similar things in dsps_musb_reset(); Otherwise you might not recover from a BABBLE condition. On 02/05/2015 10:05 PM, Tony Lindgren wrote: We still have a combination of legacy phys and generic phys in use so we need to support both types of phy for musb_dsps.c.

[PATCH 00/19] Add Support for USB DRD in AM437x

2014-11-25 Thread George Cherian
Felipe Balbi (2): usb: dwc3: core: Adapt to named interrupts arm: dts: am4372: Add named interrupt property for dwc3 George Cherian (17): usb: common: drd-lib: Add DRD lib for USB. usb: host xhci: fix up deallocation code usb: host: xhci-plat: Add support to pass XHCI_DRD_SUPPORT quirk

[PATCH 19/19] arm: dts: am43x evms: Make usb1 as OTG

2014-11-25 Thread George Cherian
USB1 of am43x EPOS EVM, am437x GP EVM and am437x SK EVM can be used as OTG. Enable the same. Signed-off-by: George Cherian george.cher...@ti.com --- arch/arm/boot/dts/am437x-gp-evm.dts | 2 +- arch/arm/boot/dts/am437x-sk-evm.dts | 2 +- arch/arm/boot/dts/am43x-epos-evm.dts | 2 +- 3 files

[PATCH 17/19] arm: dts: dra7: Add named interrupt property for dwc3

2014-11-25 Thread George Cherian
Add interrupt names so that the same can be used for OTG easily. Signed-off-by: George Cherian george.cher...@ti.com --- arch/arm/boot/dts/dra7.dtsi | 28 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts

[PATCH 18/19] arm: dts: exynos5250: Add named interrupt property for dwc3

2014-11-25 Thread George Cherian
Add interrupt names so that the same can be used for OTG easily. Signed-off-by: George Cherian george.cher...@ti.com --- arch/arm/boot/dts/exynos5250.dtsi | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250

[PATCH 16/19] arm: dts: omap5: Add named interrupt property for dwc3

2014-11-25 Thread George Cherian
Add interrupt names so that the same can be used for OTG easily. Signed-off-by: George Cherian george.cher...@ti.com --- arch/arm/boot/dts/omap5.dtsi | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi index

[PATCH 12/19] usb: dwc3: gadget: Adapt gadget to drd library

2014-11-25 Thread George Cherian
Adapt the dwc3 gadget to use drd library functions. In prepration to support DRD on dwc3. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/dwc3/gadget.c | 128 -- 1 file changed, 100 insertions(+), 28 deletions(-) diff --git

[PATCH 10/19] usb: dwc3: core: Adapt to named interrupts

2014-11-25 Thread George Cherian
From: Felipe Balbi ba...@ti.com Add support to use interrupt names, Following are the interrupt names Peripheral Interrupt - peripheral HOST Interrupt - host OTG Interrupt - otg Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/dwc3

[PATCH 14/19] usb: dwc3: otg: Add the initial otg driver for dwc3.

2014-11-25 Thread George Cherian
Add the Initial OTG driver for dwc3. Currently support only * ID based Role switching. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/dwc3/Makefile | 4 ++ drivers/usb/dwc3/core.c | 10 +--- drivers/usb/dwc3/core.h | 10 drivers/usb/dwc3/otg.c| 126

[PATCH 11/19] usb: dwc3: Add seperate dwc3_gadget object to support gadget release

2014-11-25 Thread George Cherian
switching roles between HOST and DEVICE modes. If the usb_gadget is not released during usb_del_gadget_udc, the subsequent usb_add_gadget_udc would try to initialize an already initialized kobject. To avoid this make sure we have an easily freeable object. Signed-off-by: George Cherian george.cher

[PATCH 13/19] usb: dwc3: core: Add DWC3 OTG specific register defines

2014-11-25 Thread George Cherian
Add OTG reggister defines to DWC3 core.h Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/dwc3/core.h | 68 + 1 file changed, 68 insertions(+) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index 7fbe736..eb2e970

[PATCH 15/19] arm: dts: am4372: Add named interrupt property for dwc3

2014-11-25 Thread George Cherian
From: Felipe Balbi ba...@ti.com Add interrupt names so that the same can be used for OTG easily. Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: George Cherian george.cher...@ti.com --- arch/arm/boot/dts/am4372.dtsi | 18 ++ 1 file changed, 14 insertions(+), 4 deletions

[PATCH 04/19] usb: host xhci: Add XHCI_NEEDS_LHC_RESET quirk

2014-11-25 Thread George Cherian
and Device modes, it's advbised to do a LIGHT HC reset else the already configured global registers of the DWC3 IP gets re-initialized. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/host/xhci.c | 5 +++-- drivers/usb/host/xhci.h | 1 + 2 files changed, 4 insertions(+), 2

[PATCH 08/19] usb: dwc3: core: Add dwc3_drd_helper function

2014-11-25 Thread George Cherian
to re-initialize the EVENT buffer registers for the Device mode to continue work properly. dwc3_event_buffers_setup() is exported out from core.c via wrapper dwc3_core_gadget_helper() which will be invoked from dwc3 otg driver. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/dwc3

[PATCH 06/19] usb: dwc3: host: Pass the XHCI_DRD_SUPPORT and XHCI_NEEDS_LHC_RESET quirk

2014-11-25 Thread George Cherian
-by: George Cherian george.cher...@ti.com --- drivers/usb/dwc3/host.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c index dcb8ca0..257b5b5 100644 --- a/drivers/usb/dwc3/host.c +++ b/drivers/usb/dwc3/host.c @@ -53,6 +53,8 @@ int dwc3_host_init

[PATCH 07/19] usb: host: xhci: Adapt xhci to use usb drd library

2014-11-25 Thread George Cherian
Adapt the xhci-plat driver to use drd library functions. In prepration to support DRD on dwc3. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/host/xhci-plat.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb

[PATCH 09/19] usb: dwc3: dwc3-omap: Make the wrapper interrupt shared

2014-11-25 Thread George Cherian
OTG interrupt and wrapper is shared Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/dwc3/dwc3-omap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c index 172d64e..f99e2ca 100644 --- a/drivers

[PATCH 05/19] usb: host: xhci-plat: Add support to pass XHCI_NEEDS_LHC_RESET quirk

2014-11-25 Thread George Cherian
Extend the platform data to pass XHCI_NEEDS_LHC_RESET quirk to the xhci driver. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/host/xhci-plat.c | 3 +++ include/linux/usb/xhci_pdriver.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/usb/host/xhci-plat.c b

[PATCH 01/19] usb: common: drd-lib: Add DRD lib for USB.

2014-11-25 Thread George Cherian
() or IP specific low level start/stop defined in ll_start/stop Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/Kconfig | 15 ++ drivers/usb/common/Makefile | 1 + drivers/usb/common/drd-lib.c | 346 +++ include/linux/usb/drd.h

[PATCH 03/19] usb: host: xhci-plat: Add support to pass XHCI_DRD_SUPPORT quirk

2014-11-25 Thread George Cherian
Extend the platform data to pass XHCI_DRD_SUPPORT quirk to the xhci driver. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/host/xhci-plat.c | 4 include/linux/usb/xhci_pdriver.h | 1 + 2 files changed, 5 insertions(+) diff --git a/drivers/usb/host/xhci-plat.c b

[PATCH 02/19] usb: host xhci: fix up deallocation code

2014-11-25 Thread George Cherian
to preserve the already allocated xhci struct for the subsequent call of usb_add_hcd() from the DRD library. A new quirk flag XHCI_DRD_SUPPORT is added to differentiate between normal usb_remove_hcd and drd specific call. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/host/xhci.c

Re: [PATCH 0/4] extcon: gpio: add DT support

2014-11-05 Thread George Cherian
On 11/04/2014 08:11 PM, Felipe Balbi wrote: On Tue, Nov 04, 2014 at 11:42:04AM +0530, George Cherian wrote: Hi Felipe et al. Another series was posted by removing the platform support. https://lkml.org/lkml/2014/10/14/244 I guess I forgot to copy linux-omap. you do too many things in patch

[RESEND PATCH 2/2] extcon: gpio: Add support for using cable names

2014-11-05 Thread George Cherian
Add support for using cable names. Enables other drivers to register interest and get notified using extcon provided notifier call backs. Signed-off-by: George Cherian george.cher...@ti.com --- Documentation/devicetree/bindings/extcon/extcon-gpio.txt | 2 ++ drivers/extcon/extcon-gpio.c

[RESEND PATCH 1/2] extcon: gpio: Add dt support for the driver

2014-11-05 Thread George Cherian
gpio_get_value_cansleep to get data. This fixes warning from gpiolib due to wrong API usage. Signed-off-by: George Cherian george.cher...@ti.com --- .../devicetree/bindings/extcon/extcon-gpio.txt | 21 ++ drivers/extcon/extcon-gpio.c | 83 +++--- include/linux

[RESEND PATCH 0/2] Add dt support for extcon gpio driver

2014-11-05 Thread George Cherian
This series - Adds dt support to extcon-gpio driver. - Add cable name support in case of dt. George Cherian (2): extcon: gpio: Add dt support for the driver extcon: gpio: Add support for using cable names drivers/extcon/extcon-gpio.c | 87

Re: [PATCH 0/4] extcon: gpio: add DT support

2014-11-03 Thread George Cherian
). That board is DT-only and we use extcon-gpio to decide which USB mode should be used (host or peripheral). George Cherian (4): extcon: gpio: Convert the driver to use gpio desc API's extcon: gpio: Add dt support for the driver. extcon: gpio: Always use gpio_get_value_cansleep extcon: gpio

Re: Gadget regression with enabling of MUSB babble interrupt handling

2014-06-19 Thread George Cherian
On 6/19/2014 4:54 PM, Tony Lindgren wrote: * Daniel Mack dan...@zonque.org [140619 03:51]: On 06/19/2014 12:43 PM, Tony Lindgren wrote: * Daniel Mack dan...@zonque.org [140619 03:38]: On 06/19/2014 12:31 PM, Tony Lindgren wrote: * Daniel Mack dan...@zonque.org [140619 03:10]: On 06/19/2014

[PATCH] ARM: dts: am43x-epos-evm: Add Missing cpsw-phy-sel for am43x-epos-evm

2014-06-06 Thread George Cherian
AM437x EPOS evm use external clock for RMII interface. Enable the same in DT. Signed-off-by: George Cherian george.cher...@ti.com Reported-by: Nishanth Menon n...@ti.com --- arch/arm/boot/dts/am43x-epos-evm.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/am43x-epos

Re: [PATCH] ARM: dts: am43x-epos-evm: Add Missing cpsw-phy-sel for am43x-epos-evm

2014-06-06 Thread George Cherian
On 6/6/2014 12:23 PM, Nishanth Menon wrote: On 06/06/2014 01:17 AM, George Cherian wrote: AM437x EPOS evm use external clock for RMII interface. Enable the same in DT. Signed-off-by: George Cherian george.cher...@ti.com Reported-by: Nishanth Menon n...@ti.com --- arch/arm/boot/dts/am43x-epos

Re: [PATCH] ARM: dts: am43x-epos-evm: Add Missing cpsw-phy-sel for am43x-epos-evm

2014-06-06 Thread George Cherian
On 6/6/2014 12:25 PM, Nishanth Menon wrote: On 06/06/2014 01:53 AM, Nishanth Menon wrote: On 06/06/2014 01:17 AM, George Cherian wrote: AM437x EPOS evm use external clock for RMII interface. Enable the same in DT. Signed-off-by: George Cherian george.cher...@ti.com Reported-by: Nishanth Menon

Re: [PATCH v4 1/6] usb: musb: core: Handle Babble condition only in HOST mode

2014-05-26 Thread George Cherian
On 5/23/2014 2:12 AM, Bin Liu wrote: Hi George, On Mon, May 19, 2014 at 11:32 PM, George Cherian george.cher...@ti.com wrote: Hi Bin, On 5/19/2014 9:24 PM, Bin Liu wrote: Hi, On Mon, May 19, 2014 at 8:39 AM, George Cherian george.cher...@ti.com wrote: BABBLE and RESET share the same

[PATCH v6 4/5] usb: musb: core: Convert the musb_platform_reset to have a return value.

2014-05-26 Thread George Cherian
resetting the IP block. In preperation to add that support its better to have a rest_done return for musb_platform_reset(). Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/musb/musb_core.c | 10 ++ drivers/usb/musb/musb_core.h | 10 ++ drivers/usb/musb/musb_dsps.c

[PATCH v6 5/5] usb: musb: dsps: Add the sw_babble_control() and Enable for newer silicon

2014-05-26 Thread George Cherian
register reads 0x4 by default in newer silicon as opposed to 0 in old versions of AM335x. Based on this enable the sw babble control logic. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/musb/musb_dsps.c | 89 +--- drivers/usb/musb

[PATCH v6 3/5] usb: musb: dsps: Call usb_phy(_shutdown/_init) during musb_platform_reset()

2014-05-26 Thread George Cherian
For DSPS platform usb_phy_vbus(_off/_on) are NOPs. So during musb_platform_reset() call usb_phy(_shutdown/_init) Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/musb/musb_dsps.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/usb/musb

[PATCH v6 0/5] Add support for SW babble Control

2014-05-26 Thread George Cherian
RESET should not be handled as a BABBLE. Added a check for the same.(Patch #1) Enable sw babble control properly (Patch #6) v2 - v3 : Modify musb_platform_reset() to return zero on success. George Cherian (5): usb: musb: core: Handle Babble condition only

[PATCH v6 1/5] usb: musb: core: Handle Babble condition only in HOST mode

2014-05-26 Thread George Cherian
BABBLE and RESET share the same interrupt. The interrupt is considered to be RESET if MUSB is in peripheral mode and as a BABBLE if MUSB is in HOST mode. Handle babble condition iff MUSB is in HOST mode. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/musb/musb_core.c | 2

[PATCH v6 2/5] usb: musb: core: Convert babble recover work to delayed work

2014-05-26 Thread George Cherian
-howto.txt Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/musb/musb_core.c | 15 --- drivers/usb/musb/musb_core.h | 2 +- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index 0ad9551..c0ce09f

[PATCH v5 1/6] usb: musb: core: Handle Babble condition only in HOST mode

2014-05-22 Thread George Cherian
BABBLE and RESET share the same interrupt. The interrupt is considered to be RESET if MUSB is in peripheral mode and as a BABBLE if MUSB is in HOST mode. Handle babble condition iff MUSB is in HOST mode. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/musb/musb_core.c | 2

[PATCH v5 3/6] usb: musb: dsps: Call usb_phy(_shutdown/_init) during musb_platform_reset()

2014-05-22 Thread George Cherian
For DSPS platform usb_phy_vbus(_off/_on) are NOPs. So during musb_platform_reset() call usb_phy(_shutdown/_init) Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/musb/musb_dsps.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/usb/musb

[PATCH v5 4/6] usb: musb: core: Convert the musb_platform_reset to have a return value.

2014-05-22 Thread George Cherian
resetting the IP block. In preperation to add that support its better to have a rest_done return for musb_platform_reset(). Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/musb/musb_core.c | 10 ++ drivers/usb/musb/musb_core.h | 10 ++ drivers/usb/musb/musb_dsps.c

[PATCH v5 5/6] usb: musb: dsps: Add the sw_babble_control()

2014-05-22 Thread George Cherian
Add sw_babble_control() logic to differentiate between transient babble and real babble condition. Also add the SW babble control register definitions. Babble control register logic is implemented in the latest revision of AM335x. Signed-off-by: George Cherian george.cher...@ti.com --- drivers

[PATCH v5 6/6] usb: musb: dsps: Enable sw babble control for newer silicon

2014-05-22 Thread George Cherian
Find whether we are running on newer silicon. The babble control register reads 0x4 by default in newer silicon as opposed to 0 in old versions of AM335x. Based on this enable the sw babble control logic. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/musb/musb_dsps.c | 38

[PATCH v5 0/6] Add support for SW babble Control

2014-05-22 Thread George Cherian
not be handled as a BABBLE. Added a check for the same.(Patch #1) Enable sw babble control properly (Patch #6) v2 - v3 : Modify musb_platform_reset() to return zero on success. George Cherian (6): usb: musb: core: Handle Babble condition only in HOST mode usb: musb: core

[PATCH v5 2/6] usb: musb: core: Convert babble recover work to delayed work

2014-05-22 Thread George Cherian
-howto.txt Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/musb/musb_core.c | 15 --- drivers/usb/musb/musb_core.h | 2 +- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index eff3c5c..8920b80

Re: [PATCH v5 6/6] usb: musb: dsps: Enable sw babble control for newer silicon

2014-05-22 Thread George Cherian
On 5/22/2014 5:28 PM, Sergei Shtylyov wrote: Hello. On 22-05-2014 10:29, George Cherian wrote: Find whether we are running on newer silicon. The babble control register reads 0x4 by default in newer silicon as opposed to 0 in old versions of AM335x. Based on this enable the sw babble control

[PATCH v3 0/6] Cleanup and fixes for dwc3-omap

2014-05-21 Thread George Cherian
system sleep. George Cherian (6): usb: dwc3: dwc3-omap: Remove x_major calculation from revision register usb: dwc3: dwc3-omap: Add dwc3_omap_map_offset() function usb: dwc3: dwc3-omap: Add dwc3_omap_set_utmi_mode() function usb: dwc3: dwc3-omap: Add dwc3_omap_extcon_register function

[PATCH v3 3/6] usb: dwc3: dwc3-omap: Add dwc3_omap_set_utmi_mode() function

2014-05-21 Thread George Cherian
Move find and set the utmi mode to its own seperate function. Improve code readability, decrease the dwc3_probe() size. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/dwc3/dwc3-omap.c | 44 +--- 1 file changed, 25 insertions(+), 19

[PATCH v3 5/6] usb: dwc3: dwc3-omap: Fix the crash on module removal

2014-05-21 Thread George Cherian
[c00a9e5c] (SyS_delete_module+0x10c/0x198) [c00a9e5c] (SyS_delete_module) from [c000e5e0] (ret_fast_syscall+0x0/0x48) Code: e1a04000 e59f0068 eb14505e e5943010 (e5932018) ---[ end trace 7e2a8746ff4fc811 ]--- Segmentation fault Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb

[PATCH v3 6/6] usb: dwc3: dwc3-omap: Disable/Enable only wrapper interrupts in prepare/complete

2014-05-21 Thread George Cherian
The dwc3 wrapper driver should not be fiddling with the core interrupts. Disabling the core interrupts in prepare stops xhci from proper operation. So remove disable/enable of core interrupts from prepare/complete. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/dwc3/dwc3

[PATCH v3 2/6] usb: dwc3: dwc3-omap: Add dwc3_omap_map_offset() function

2014-05-21 Thread George Cherian
Move map offset to its own seperate function. Improve code readability, decrease the dwc3_probe() size. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/dwc3/dwc3-omap.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git

[PATCH v3 4/6] usb: dwc3: dwc3-omap: Add dwc3_omap_extcon_register function

2014-05-21 Thread George Cherian
Move the extcon related code to its own function. Improve code readability, decrease the dwc3_probe() size. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/dwc3/dwc3-omap.c | 65 ++-- 1 file changed, 39 insertions(+), 26 deletions

[PATCH v3 1/6] usb: dwc3: dwc3-omap: Remove x_major calculation from revision register

2014-05-21 Thread George Cherian
Remove the x_major calculation logic from the wrapper revision register to differentiate between OMAP5 and AM437x. This was done to find the register offsets of wrapper register. Now that We do it using dt compatible, remove the whole logic. Signed-off-by: George Cherian george.cher...@ti.com

[PATCH v2 4/6] usb: dwc3: dwc3-omap: Add dwc3_omap_extcon_register function

2014-05-19 Thread George Cherian
Move the extcon related code to its own function. Improve code readability, decrease the dwc3_probe() size. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/dwc3/dwc3-omap.c | 65 ++-- 1 file changed, 39 insertions(+), 26 deletions

[PATCH v2 6/6] usb: dwc3: dwc3-omap: Disable/Enable only wrapper interrupts in prepare/complete

2014-05-19 Thread George Cherian
The dwc3 wrapper driver should not be fiddling with the core interrupts. Disabling the core interrupts in prepare stops xhci from proper operation. So remove disable/enable of core interrupts from prepare/complete. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/dwc3/dwc3

[PATCH v2 5/6] usb: dwc3: dwc3-omap: Fix the crash on module removal

2014-05-19 Thread George Cherian
[c00a9e5c] (SyS_delete_module+0x10c/0x198) [c00a9e5c] (SyS_delete_module) from [c000e5e0] (ret_fast_syscall+0x0/0x48) Code: e1a04000 e59f0068 eb14505e e5943010 (e5932018) ---[ end trace 7e2a8746ff4fc811 ]--- Segmentation fault Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb

[PATCH v2 2/6] usb: dwc3: dwc3-omap: Add dwc3_omap_map_offset() function

2014-05-19 Thread George Cherian
Move map offset to its own seperate function. Improve code readability, decrease the dwc3_probe() size. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/dwc3/dwc3-omap.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git

[PATCH v2 3/6] usb: dwc3: dwc3-omap: Add dwc3_omap_set_utmi_mode() function

2014-05-19 Thread George Cherian
Move find and set the utmi mode to its own seperate function. Improve code readability, decrease the dwc3_probe() size. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/dwc3/dwc3-omap.c | 44 +--- 1 file changed, 25 insertions(+), 19

[PATCH v2 1/6] usb: dwc3: dwc3-omap: Remove x_major calculation from revision register

2014-05-19 Thread George Cherian
Remove the x_major calculation logic from the wrapper revision register to differentiate between OMAP5 and AM437x. This was done to find the register offsets of wrapper register. Now that We do it using dt compatible, remove the whole logic. Signed-off-by: George Cherian george.cher...@ti.com

[PATCH v2 0/6] Cleanup and fixes for dwc3-omap

2014-05-19 Thread George Cherian
system sleep. George Cherian (6): usb: dwc3: dwc3-omap: Remove x_major calculation from revision register usb: dwc3: dwc3-omap: Add dwc3_omap_map_offset() function usb: dwc3: dwc3-omap: Add dwc3_omap_set_utmi_mode() function usb: dwc3: dwc3-omap: Add dwc3_omap_extcon_register function

Re: [PATCH v3 0/5] Add support for SW babble Control

2014-05-19 Thread George Cherian
Hi Bin, On 5/15/2014 8:49 PM, Bin Liu wrote: George, On Thu, May 15, 2014 at 1:28 AM, George Cherian george.cher...@ti.com wrote: Hi Bin, On 5/14/2014 10:13 PM, Bin Liu wrote: George, On Wed, May 14, 2014 at 9:34 AM, Bin Liu binml...@gmail.com wrote: George, On Wed, May 14, 2014 at 12

[PATCH v4 0/6] Add support for SW babble Control

2014-05-19 Thread George Cherian
) Enable sw babble control properly (Patch #6) v2 - v3 : Modify musb_platform_reset() to return zero on success. George Cherian (6): usb: musb: core: Handle Babble condition only in HOST mode usb: musb: core: Convert babble recover work to delayed work usb: musb: dsps: Call

[PATCH v4 6/6] usb: musb: dsps: Enable sw babble control for newer silicon

2014-05-19 Thread George Cherian
Find whether we are running on newer silicon. The babble control register reads 0x4 by default in newer silicon as opposed to 0 in old versions of AM335x. Based on this enable the sw babble control logic. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/musb/musb_dsps.c | 37

[PATCH v4 1/6] usb: musb: core: Handle Babble condition only in HOST mode

2014-05-19 Thread George Cherian
BABBLE and RESET share the same interrupt. The interrupt is considered to be RESET if MUSB is in peripheral mode and as a BABBLE if MUSB is in HOST mode. Handle babble condition iff MUSB is in HOST mode. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/musb/musb_core.c | 2

[PATCH v4 5/6] usb: musb: dsps: Add the sw_babble_control()

2014-05-19 Thread George Cherian
Add sw_babble_control() logic to differentiate between transient babble and real babble condition. Also add the SW babble control register definitions. Babble control register logic is implemented in the latest revision of AM335x. Signed-off-by: George Cherian george.cher...@ti.com --- drivers

[PATCH v4 4/6] usb: musb: core: Convert the musb_platform_reset to have a return value.

2014-05-19 Thread George Cherian
resetting the IP block. In preperation to add that support its better to have a rest_done return for musb_platform_reset(). Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/musb/musb_core.c | 38 +- drivers/usb/musb/musb_core.h | 10

[PATCH v4 3/6] usb: musb: dsps: Call usb_phy(_shutdown/_init) during musb_platform_reset()

2014-05-19 Thread George Cherian
For DSPS platform usb_phy_vbus(_off/_on) are NOPs. So during musb_platform_reset() call usb_phy(_shutdown/_init) Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/musb/musb_dsps.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/usb/musb

[PATCH v4 2/6] usb: musb: core: Convert babble recover work to delayed work

2014-05-19 Thread George Cherian
-howto.txt Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/musb/musb_core.c | 15 --- drivers/usb/musb/musb_core.h | 2 +- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index eff3c5c..8920b80

Re: [PATCH v4 1/6] usb: musb: core: Handle Babble condition only in HOST mode

2014-05-19 Thread George Cherian
Hi Bin, On 5/19/2014 9:24 PM, Bin Liu wrote: Hi, On Mon, May 19, 2014 at 8:39 AM, George Cherian george.cher...@ti.com wrote: BABBLE and RESET share the same interrupt. The interrupt is considered to be RESET if MUSB is in peripheral mode and as a BABBLE if MUSB is in HOST mode. Handle babble

Re: [RFC PATCH] ARM: dts: am33xx: Re-arrange the USB dt to reflect the h/w configuration

2014-05-15 Thread George Cherian
Hi Tony, On 5/15/2014 3:20 AM, Tony Lindgren wrote: * George Cherian george.cher...@ti.com [140508 23:34]: Re arrange the USB dt for AM33xx to take it a bit closer to the hardware configuration. The USBSS is designed as follows USB control Module 0x44e10_0620 USBSS

Re: [PATCH v3 0/5] Add support for SW babble Control

2014-05-15 Thread George Cherian
Hi Bin, On 5/14/2014 10:13 PM, Bin Liu wrote: George, On Wed, May 14, 2014 at 9:34 AM, Bin Liu binml...@gmail.com wrote: George, On Wed, May 14, 2014 at 12:37 AM, George Cherian george.cher...@ti.com wrote: On 5/14/2014 12:07 AM, Bin Liu wrote: Hi, On Tue, May 13, 2014 at 8:24 AM, George

Re: [PATCH 5/5] usb: dwc3: dwc3-omap: Disable/Enable core interrupts in Suspend/Resume

2014-05-14 Thread George Cherian
On 5/13/2014 9:20 PM, Felipe Balbi wrote: Hi, On Thu, May 08, 2014 at 03:03:07PM +0530, George Cherian wrote: Enabling the core interrupts in complete is too late for XHCI, and stops xhci from proper operation. So remove prepare and complete and disable/enable isn't this a bug in xhci ? I

[PATCH v3 5/5] usb: musb: dsps: Enable sw babble control for newer silicon

2014-05-13 Thread George Cherian
Find whether we are running on newer silicon. The babble control register reads 0x4 by default in newer silicon as opposed to 0 in old versions of AM335x. Based on this enable the sw babble control logic. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/musb/musb_dsps.c | 34

[PATCH v3 2/5] usb: musb: dsps: Call usb_phy(_shutdown/_init) during musb_platform_reset()

2014-05-13 Thread George Cherian
For DSPS platform usb_phy_vbus(_off/_on) are NOPs. So during musb_platform_reset() call usb_phy(_shutdown/_init) Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/musb/musb_dsps.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/usb/musb

[PATCH v3 0/5] Add support for SW babble Control

2014-05-13 Thread George Cherian
sw babble control for newer silicon v2 - v3 : Modify musb_platform_reset() to return zero on success. v1 - v2 : Fixed the issue with Patch 5. In v1 it was not calling sw_babble_control(). George Cherian (5): usb: musb: core: Convert babble recover work to delayed work usb

[PATCH v3 3/5] usb: musb: core: Convert the musb_platform_reset to have a return value.

2014-05-13 Thread George Cherian
resetting the IP block. In preperation to add that support its better to have a rest_done return for musb_platform_reset(). Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/musb/musb_core.c | 38 +- drivers/usb/musb/musb_core.h | 10

[PATCH v3 1/5] usb: musb: core: Convert babble recover work to delayed work

2014-05-13 Thread George Cherian
-howto.txt Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/musb/musb_core.c | 15 --- drivers/usb/musb/musb_core.h | 2 +- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index 61da471..dcadc62

Re: [PATCH v3 0/5] Add support for SW babble Control

2014-05-13 Thread George Cherian
On 5/13/2014 3:16 PM, Daniel Mack wrote: Hi George, On 05/13/2014 10:31 AM, George Cherian wrote: Series add support for SW babble control logic found in new silicon versions of AM335x. Runtime differentiation of silicon version is done by checking the BABBLE_CTL register. For newer silicon

Re: [PATCH v3 0/5] Add support for SW babble Control

2014-05-13 Thread George Cherian
On 5/13/2014 5:50 PM, Daniel Mack wrote: On 05/13/2014 01:57 PM, George Cherian wrote: On 5/13/2014 3:16 PM, Daniel Mack wrote: On 05/13/2014 10:31 AM, George Cherian wrote: Series add support for SW babble control logic found in new silicon versions of AM335x. Runtime differentiation

Re: [PATCH v3 0/5] Add support for SW babble Control

2014-05-13 Thread George Cherian
Hi Daniel, On 5/13/2014 6:44 PM, Daniel Mack wrote: Hi George, On 05/13/2014 02:57 PM, George Cherian wrote: I never enabled the MUSB_BABBLE_SW_SESSION_CTRL in the MUSB_BABBLE_CTL reg. can you try with the following patch. diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb

Re: [PATCH v3 0/5] Add support for SW babble Control

2014-05-13 Thread George Cherian
On 5/14/2014 12:07 AM, Bin Liu wrote: Hi, On Tue, May 13, 2014 at 8:24 AM, George Cherian george.cher...@ti.com wrote: Hi Daniel, On 5/13/2014 6:44 PM, Daniel Mack wrote: Hi George, On 05/13/2014 02:57 PM, George Cherian wrote: I never enabled the MUSB_BABBLE_SW_SESSION_CTRL

Re: [PATCH 1/5] usb: dwc3: dwc3-omap: Add dwc3_omap_map_offset function

2014-05-13 Thread George Cherian
On 5/13/2014 9:32 PM, Felipe Balbi wrote: Hi, On Thu, May 08, 2014 at 03:03:03PM +0530, George Cherian wrote: Calculate the wrapper register offsets in a seperate function. Improve code readability, decrease the dwc3_probe() size. Signed-off-by: George Cherian george.cher...@ti.com

Re: [RFC/PATCH] usb: musb: Prevent musb_am335x from being removed

2014-05-11 Thread George Cherian
] (ret_fast_syscall+0x0/0x48) Signed-off-by: Ezequiel Garcia ezequ...@vanguardiasur.com.ar Acked-by: George Cherian george.cher...@ti.com With this I think it make sense to take the following patch also, to avoid unnecessary probe deferral http://www.spinics.net/lists/linux-usb/msg106202.html

Re: [PATCH v2] ARM: dts: am33xx: Move the cppi41dma node so it's probed early

2014-05-11 Thread George Cherian
of the child list, so it's probed first. Signed-off-by: Ezequiel Garcia ezequ...@vanguardiasur.com.ar Acked-by: George Cherian george.cher...@ti.com -- v1-v2: * Added a comment to prevent a future clean-up based on the memory offset. arch/arm/boot/dts/am33xx.dtsi | 34

Re: [PATCH v2] ARM: dts: am33xx: Move the cppi41dma node so it's probed early

2014-05-09 Thread George Cherian
On 5/8/2014 10:30 PM, Ezequiel GarcĂ­a wrote: Hi George, On 29 April 2014 04:58, George Cherian george.cher...@ti.com wrote: On 4/29/2014 11:49 AM, Yegor Yefremov wrote: On Thu, Apr 24, 2014 at 11:11 PM, Ezequiel Garcia ezequ...@vanguardiasur.com.ar wrote: The DMA controller is needed

[RFC PATCH] ARM: dts: am33xx: Re-arrange the USB dt to reflect the h/w configuration

2014-05-09 Thread George Cherian
: { 0x44e10_0620 } usb0: { 0x4740_1000 0x4740_1400 } usb0_phy:{ 0x4740_1300 } usb1:{ 0x4740_1800 0x4740_1c00 } usb1_phy: { 0x4740_1b00 } cppi41dma: { 0x4740_2000 0x4740_3000 0x4740_4000 } } Signed-off-by: George Cherian george.cher

Re: [PATCH v2] ARM: dts: am33xx: Move the cppi41dma node so it's probed early

2014-05-09 Thread George Cherian
On 5/9/2014 12:55 PM, Sebastian Andrzej Siewior wrote: On 05/09/2014 08:22 AM, George Cherian wrote: Just by remodelling the dt the whole problem can be solved. I am still not convinced why we should not be doing it? Because neither ways its not the exact representation of the H/W. Ha. Now I

[PATCH 0/5] Cleanup and fixes for dwc3-omap

2014-05-08 Thread George Cherian
The series does some refactoring on dwc3_probe() Patch 1-3 - reduce the size of dwc3_probe() Patch 4 - Fix the crash on dwc3_omap removal Patch 5 - Addresses the issue of xhci hang while resuming from system sleep. George Cherian (5): usb: dwc3: dwc3-omap: Add dwc3_omap_map_offset function

[PATCH 4/5] usb: dwc3: dwc3-omap: Fix the crash on module removal

2014-05-08 Thread George Cherian
[c00a9e5c] (SyS_delete_module+0x10c/0x198) [c00a9e5c] (SyS_delete_module) from [c000e5e0] (ret_fast_syscall+0x0/0x48) Code: e1a04000 e59f0068 eb14505e e5943010 (e5932018) ---[ end trace 7e2a8746ff4fc811 ]--- Segmentation fault Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb

[PATCH 2/5] usb: dwc3: dwc3-omap: Add dwc3_omap_set_utmi_mode() function

2014-05-08 Thread George Cherian
Move find and set the utmi mode to its own seperate function. Improve code readability, decrease the dwc3_probe() size. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/dwc3/dwc3-omap.c | 44 +--- 1 file changed, 25 insertions(+), 19

[PATCH 5/5] usb: dwc3: dwc3-omap: Disable/Enable core interrupts in Suspend/Resume

2014-05-08 Thread George Cherian
Enabling the core interrupts in complete is too late for XHCI, and stops xhci from proper operation. So remove prepare and complete and disable/enable interrupts in suspend/resume Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/dwc3/dwc3-omap.c | 20 ++-- 1

[PATCH 3/5] usb: dwc3: dwc3-omap: Add dwc3_omap_extcon_register function

2014-05-08 Thread George Cherian
Move the extcon related code to its own function. Improve code readability, decrease the dwc3_probe() size. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/dwc3/dwc3-omap.c | 65 ++-- 1 file changed, 39 insertions(+), 26 deletions

[PATCH 1/5] usb: dwc3: dwc3-omap: Add dwc3_omap_map_offset function

2014-05-08 Thread George Cherian
Calculate the wrapper register offsets in a seperate function. Improve code readability, decrease the dwc3_probe() size. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/dwc3/dwc3-omap.c | 80 1 file changed, 44 insertions(+), 36

[PATCH v2 1/5] usb: musb: core: Convert babble recover work to delayed work

2014-05-08 Thread George Cherian
Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/musb/musb_core.c | 15 --- drivers/usb/musb/musb_core.h | 2 +- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index 61da471..dcadc62 100644

[PATCH v2 4/5] usb: musb: dsps: Add the sw_babble_control()

2014-05-08 Thread George Cherian
Add sw_babble_control() logic to differentiate between transient babble and real babble condition. Also add the SW babble control register definitions. Babble control register logic is implemented in the latest revision of AM335x. Signed-off-by: George Cherian george.cher...@ti.com --- drivers

[PATCH v2 3/5] usb: musb: core: Convert the musb_platform_reset to have a return value.

2014-05-08 Thread George Cherian
resetting the IP block. In preperation to add that support its better to have a rest_done return for musb_platform_reset(). Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/musb/musb_core.c | 38 +- drivers/usb/musb/musb_core.h | 10

[PATCH v2 5/5] usb: musb: dsps: Enable sw babble control for newer silicon

2014-05-08 Thread George Cherian
Find whether we are running on newer silicon. The babble control register reads 0x4 by default in newer silicon as opposed to 0 in old versions of AM335x. Based on this enable the sw babble control logic. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/musb/musb_dsps.c | 34

[PATCH v2 2/5] usb: musb: dsps: Call usb_phy(_shutdown/_init) during musb_platform_reset()

2014-05-08 Thread George Cherian
For DSPS platform usb_phy_vbus(_off/_on) are NOPs. So during musb_platform_reset() call usb_phy(_shutdown/_init) Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/musb/musb_dsps.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/usb/musb

[PATCH v2 0/5] Add support for SW babble Control

2014-05-08 Thread George Cherian
sw babble control for newer silicon v1 - v2 : Fixed the issue with Patch 5. In v1 it was not calling sw_babble_control(). George Cherian (5): usb: musb: core: Convert babble recover work to delayed work usb: musb: dsps: Call usb_phy(_shutdown/_init) during

Re: [PATCH v2 3/5] usb: musb: core: Convert the musb_platform_reset to have a return value.

2014-05-08 Thread George Cherian
On 5/8/2014 3:17 PM, Daniel Mack wrote: Hi Geroge, On 05/08/2014 11:35 AM, George Cherian wrote: -static inline void musb_platform_reset(struct musb *musb) +static inline int musb_platform_reset(struct musb *musb) { - if (musb-ops-reset) - musb-ops-reset(musb

  1   2   3   >