RE: [PATCH 9/9 v3] usb : musb: Offmode fix for idle path

2010-09-22 Thread Maulik
-Original Message- From: Hema HK [mailto:hem...@ti.com] Sent: Thursday, September 23, 2010 6:01 AM To: linux-omap@vger.kernel.org; linux-...@vger.kernel.org Cc: Hema HK; Maulik Mankad; Felipe Balbi; Tony Lindgren; Kevin Hilman; Cousson, Benoit; Paul Walmsley Subject: [PATCH 9/9 v3

Issue with file transfers to a mass storage device on SMP system

2010-07-27 Thread Maulik
back the memory, the memory seems to be updated. Has anyone seen such issue on a SMP system? Please comment on the need and the usage of a memory barrier in this case. Thanks, Maulik -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

RE: [PATCH 8/8] usb: musb: Fix suspend interrupt issue in device mode

2010-06-17 Thread Maulik
-Original Message- From: Sergei Shtylyov [mailto:sshtyl...@mvista.com] Sent: Thursday, June 17, 2010 4:57 PM To: Ajay Kumar Gupta Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; felipe.ba...@nokia.com; gre...@suse.de; Maulik Mankad; David Brownell Subject: Re: [PATCH 8

[PATCH] ARM: OMAP: Fix board data to support device only, host only and OTG roles.

2010-05-20 Thread Maulik Mankad
Fix board data to support device only, host only and OTG roles. The board data hardcodes the mode to OTG or Peripheral. This fix will allow to use Peripheral, Host and OTG roles independently. Signed-off-by: Maulik Mankad x0082...@ti.com Cc: Felipe Balbi felipe.ba...@nokia.com Cc: Tony Lindgren

RE: [PATCH] Add OHCI USB platform init

2010-04-11 Thread Maulik
); + omap_usb_init(sdp2430_usb_config); And here too. Maulik -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Problems with workqueue

2010-03-27 Thread Maulik Mankad
are you creating? If its only one I dont see a problem. But if the root cause is known a most appropriate solution can be thought. Thanks, Maulik -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: Problems with workqueue

2010-03-26 Thread Maulik Mankad
the default work queue or a dedeicated work queue for your touch screen driver? If you are using the default work queue you can try using a dedicated work queue in your touch screen driver and see if this resolves the issue. Then debug further to find a root cause. Regards, Maulik -- To unsubscribe

[PATCH v2 0/3] USB MUSB patches for OMAP4

2010-03-11 Thread Maulik Mankad
Greg, Here is a Version 2 of driver patches that enable MUSB driver support for OMAP4. Maulik Mankad(3) [PATCH v2 1/3] USB: MUSB: Set transceiver interface type [PATCH v2 2/3] USB: MUSB: Build MUSB driver for OMAP4 [PATCH v2 3/3] USB: MUSB: Add OMAP4 support in MUSB driver This version is re

[PATCH v2 1/3] USB: MUSB: Set transceiver interface type

2010-03-11 Thread Maulik Mankad
Program the OTG_INTERFSEL register based on transcevier type passed from board file. Adapt signature of musb_platform_init() function for davinci, blackfin and tusb6010. Signed-off-by: Maulik Mankad x0082...@ti.com Cc: Felipe Balbi felipe.ba...@nokia.com Cc: David Brownell davi...@pacbell.net Cc

[PATCH v2 2/3] USB: MUSB: Build MUSB driver for OMAP4

2010-03-11 Thread Maulik Mankad
This patch updates the Makefile to build the MUSB driver for OMAP4. It also sets the Kconfig options for OMAP4. Signed-off-by: Maulik Mankad x0082...@ti.com Cc: Felipe Balbi felipe.ba...@nokia.com Cc: Greg Kroah-Hartman gre...@suse.de Cc: David Brownell davi...@pacbell.net Cc: Sergei Shtylyov

[PATCH v2 3/3] USB: MUSB: Add OMAP4 support in MUSB driver

2010-03-11 Thread Maulik Mankad
This patch adds CONFIG_ARCH_OMAP4 macro within MUSB driver. Signed-off-by: Maulik Mankad x0082...@ti.com Cc: Felipe Balbi felipe.ba...@nokia.com Cc: Greg Kroah-Hartman gre...@suse.de Cc: David Brownell davi...@pacbell.net Cc: Sergei Shtylyov sshtyl...@mvista.com Cc: Olof Johansson o...@lixom.net

RE: [PATCH 2/4] USB: MUSB: Enable MUSB for OMAP4 in Kconfig

2010-03-10 Thread Maulik
believe the driver patches can go in independent of this enhancement. Regards, Maulik -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH 2/4] USB: MUSB: Enable MUSB for OMAP4 in Kconfig

2010-02-28 Thread Maulik
as the top MUSB one. So you should be able to switch to that instead of adding a check for OMAP4 there then? Olof, So you suggest adding something like below for OMAP4 and all others as well right? comment OMAP 44xx high speed USB support depends on USB_MUSB_HDRC USB_MUSB_SOC Regards, Maulik

RE: [PATCH 2/4] USB: MUSB: Enable MUSB for OMAP4 in Kconfig

2010-02-26 Thread Maulik
use Inventra DMA for e.g Davinci uses CPPI DMA. Thanks, Maulik -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH 3/4] USB: MUSB: Add OMAP4 support in MUSB driver

2010-02-26 Thread Maulik
Maulik Mankad wrote: This patch adds CONFIG_ARCH_OMAP4 macro within MUSB driver code and builds the MUSB driver for OMAP4. Signed-off-by: Maulik Mankad x0082...@ti.com Cc: Felipe Balbi felipe.ba...@nokia.com Cc: Greg Kroah-Hartman gre...@suse.de Cc: David Brownell davi...@pacbell.net

[PATCH 0/4] USB MUSB patches for OMAP4

2010-02-24 Thread Maulik Mankad
Greg, Here is a series of driver patches that enable MUSB driver support for OMAP4. Maulik Mankad(4) [PATCH 1/4] USB: MUSB: Set transceiver interface type [PATCH 2/4] USB: MUSB: Enable MUSB for OMAP4 in Kconfig [PATCH 3/4] USB: MUSB: Add OMAP4 support in MUSB driver [PATCH 4/4] OMAP: MUSB

[PATCH 1/4] USB: MUSB: Set transceiver interface type

2010-02-24 Thread Maulik Mankad
Program the OTG_INTERFSEL register based on transcevier type passed from board file. Adapt signature of musb_platform_init() function for davinci, blackfin and tusb6010. Signed-off-by: Maulik Mankad x0082...@ti.com Cc: Felipe Balbi felipe.ba...@nokia.com Cc: David Brownell davi...@pacbell.net Cc

[PATCH 2/4] USB: MUSB: Enable MUSB for OMAP4 in Kconfig

2010-02-24 Thread Maulik Mankad
This patch adds the OMAP4 Kconfig options for MUSB. Signed-off-by: Maulik Mankad x0082...@ti.com Cc: Felipe Balbi felipe.ba...@nokia.com Cc: Greg Kroah-Hartman gre...@suse.de Cc: David Brownell davi...@pacbell.net --- Index: mainline/drivers/usb/musb/Kconfig

[PATCH 3/4] USB: MUSB: Add OMAP4 support in MUSB driver

2010-02-24 Thread Maulik Mankad
This patch adds CONFIG_ARCH_OMAP4 macro within MUSB driver code and builds the MUSB driver for OMAP4. Signed-off-by: Maulik Mankad x0082...@ti.com Cc: Felipe Balbi felipe.ba...@nokia.com Cc: Greg Kroah-Hartman gre...@suse.de Cc: David Brownell davi...@pacbell.net --- Index: mainline/drivers/usb

[PATCH 4/4] OMAP: MUSB: Enable Mentor USB options in 4430 defconfig

2010-02-24 Thread Maulik Mankad
This patch enables Mentor USB peripheral mode options for OMAP4 SDP defconfig. Signed-off-by: Maulik Mankad x0082...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: Felipe Balbi felipe.ba...@nokia.com Cc: Greg Kroah-Hartman gre...@suse.de --- Index: mainline/arch/arm/configs/omap_4430sdp_defconfig

RE: [PATCH v3 2/2] ARM : OMAP4 : MUSB : Add USB support to 4430 SDP board file

2010-02-02 Thread Maulik
From: Tony Lindgren [mailto:t...@atomide.com] Sent: Tuesday, February 02, 2010 3:47 AM To: Felipe Balbi Cc: ext Maulik Mankad; linux-omap@vger.kernel.org; linux-u...@vger.kernel.org; David Brownell; Greg Kroah-Hartman; Sergei Shtylyov; Olof Johansson Subject: Re: [PATCH v3 2/2] ARM : OMAP4 : MUSB

[PATCH v4 0/4] OMAP USB patches

2010-02-02 Thread Maulik Mankad
Here is the 4 patch series based on top of 2.6.33-rc6. Maulik Mankad (4): [PATCH 1/4] USB : Add empty functions in otg.h [PATCH 2/4] ARM : OMAP : Remove #ifdef from board-omap3evm.c [PATCH 3/4] ARM : OMAP: MUSB : Pass board specific data using a structure [PATCH 4/4] ARM : OMAP4 : MUSB : Add USB

[PATCH v4 1/4] USB : Add empty functions in otg.h

2010-02-02 Thread Maulik Mankad
USB : Add empty functions in otg.h Add empty functions for usb_nop_xceiv_register() and usb_nop_xceiv_unregister() in otg.h so that these functions can be called even when CONFIG_NOP_USB_XCEIV is not enabled. It allows to remove ifdef's from board file. Signed-off-by: Maulik Mankad x0082

[PATCH v4 2/4] ARM : OMAP : Remove #ifdef from board-omap3evm.c

2010-02-02 Thread Maulik Mankad
ARM : OMAP : Remove #ifdef from board-omap3evm.c This patch removes #ifdef around usb_nop_xceiv_register() from board-omap3evm.c Signed-off-by: Maulik Mankad x0082...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: Felipe Balbi felipe.ba...@nokia.com Cc: Greg Kroah-Hartman gre...@suse.de Cc: Olof

[PATCH v4 3/4] ARM : OMAP : MUSB : Pass board specific data using a structure

2010-02-02 Thread Maulik Mankad
-off-by: Maulik Mankad x0082...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: Felipe Balbi felipe.ba...@nokia.com Cc: David Brownell davi...@pacbell.net Cc: Greg Kroah-Hartman gre...@suse.de Cc: Gupta Ajay Kumar ajay.gu...@ti.com --- arch/arm/mach-omap2/board-2430sdp.c |8 +++- arch

[PATCH v4 4/4] ARM : OMAP4 : MUSB : Add USB support to 4430 SDP board file

2010-02-02 Thread Maulik Mankad
ARM : OMAP4 : Add USB support to 4430 SDP board file This patch adds support for Mentor USB to 4430 SDP board file. It also defines the base address for HS USB OTG controller in OMAP4. Also updates platform specfic structure with base address and IRQ details. Signed-off-by: Maulik Mankad x0082

[PATCH v4 0/2] Get rid of ifdef in board file

2010-01-29 Thread Maulik Mankad
Here is the Version 4 of the 2 patch series based on top of Felipe's for-tony branch at [1]. [1] git://gitorious.org/usb/usb.git for-tony Maulik Mankad (2): [PATCH 1/2] USB : Add empty functions in otg.h [PATCH 2/2] ARM : OMAP : Remove #ifdef from board-omap3evm.c The Version 4 of the patch

[PATCH v4 1/2] USB: Add empty functions in otg.h

2010-01-29 Thread Maulik Mankad
USB : Add empty functions in otg.h Add empty functions for usb_nop_xceiv_register() and usb_nop_xceiv_unregister() in otg.h so that these functions can be called even when CONFIG_NOP_USB_XCEIV is not enabled. It allows to remove ifdef's from board file. Signed-off-by: Maulik Mankad x0082

[PATCH v4 2/2] ARM : OMAP : Remove #ifdef from board-omap3evm.c

2010-01-29 Thread Maulik Mankad
ARM : OMAP : Remove #ifdef from board-omap3evm.c This patch removes #ifdef around usb_nop_xceiv_register() from board-omap3evm.c Signed-off-by: Maulik Mankad x0082...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: Felipe Balbi felipe.ba...@nokia.com Cc: Greg Kroah-Hartman gre...@suse.de Cc: Olof

RE: [PATCH v3 0/2] ARM : OMAP patches

2010-01-07 Thread Maulik
functions in otg.h [PATCH 2/2] ARM : OMAP : Remove #ifdef from board-omap3evm.c http://marc.info/?l=linux-usbm=126268112828212w=2 Regards, Maulik -Original Message- From: Maulik Mankad [mailto:x0082...@ti.com] Sent: Thursday, December 31, 2009 6:52 PM To: linux-omap@vger.kernel.org Cc

RE: [PATCH v3 1/2] USB: Add empty functions in otg.h

2010-01-07 Thread Maulik
Greg, Are you going to include this patch in your queue? Thanks, Maulik -Original Message- From: Olof Johansson [mailto:o...@lixom.net] Sent: Tuesday, January 05, 2010 11:23 PM To: Felipe Balbi Cc: ext Maulik Mankad; linux-...@vger.kernel.org; linux-omap@vger.kernel.org; Tony Lindgren

[PATCH v3 0/2] Get rid of ifdef in board file

2010-01-05 Thread Maulik Mankad
Here is the Version 3 of the 2 patch series based on top of your for-tony branch at [1]. [1] git://gitorious.org/usb/usb.git for-tony Maulik Mankad (2): [PATCH 1/2] USB : Add empty functions in otg.h [PATCH 2/2] ARM : OMAP : Remove #ifdef from board-omap3evm.c The Version 3 of the patch set

[PATCH v3 1/2] USB: Add empty functions in otg.h

2010-01-05 Thread Maulik Mankad
USB : Add empty functions in otg.h Add empty functions for usb_nop_xceiv_register() and usb_nop_xceiv_unregister() in otg.h so that these functions can be called even when CONFIG_NOP_USB_XCEIV is not enabled. It allows to remove ifdef's from board file. Signed-off-by: Maulik Mankad x0082

[PATCH v3 2/2] ARM : OMAP : Remove #ifdef from board-omap3evm.c

2010-01-05 Thread Maulik Mankad
ARM : OMAP : Remove #ifdef from board-omap3evm.c Remove #ifdef around usb_nop_xceiv_register() from board-omap3evm.c Signed-off-by: Maulik Mankad x0082...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: Felipe Balbi felipe.ba...@nokia.com Cc: Greg Kroah-Hartman gre...@suse.de Cc: Olof Johansson o

RE: [PATCH v2 1/2] ARM : OMAP : Add empty functions in header file

2010-01-04 Thread Maulik
It needs to be static inline: [Maulik] Yes that's true. And you need to make sure that the actual body of the function in the C file is encapsulated with #ifdef too, since the very point of having it under a config option is to not include it if it's not selected and needed. [Maulik

[PATCH v2 1/2] ARM : OMAP : Add empty functions in header file

2010-01-04 Thread Maulik Mankad
ARM : OMAP : Add empty functions in header file Add empty functions for usb_nop_xceiv_register() and usb_nop_xceiv_unregister() so that these functions can be called even when CONFIG_NOP_USB_XCEIV is not enabled. It allows to remove ifdef's from board file. Signed-off-by: Maulik Mankad x0082

[PATCH v2 2/2] ARM : OMAP : Remove #ifdef from board-omap3evm.c

2010-01-04 Thread Maulik Mankad
ARM : OMAP : Remove #ifdef from board-omap3evm.c Remove #ifdef around usb_nop_xceiv_register()from board-omap3evm.c Signed-off-by: Maulik Mankad x0082...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: Felipe Balbi felipe.ba...@nokia.com Cc: Greg Kroah-Hartman gre...@suse.de Cc: Olof Johansson o

RE: [PATCH v2 1/2] ARM : OMAP : Add empty functions in header file

2010-01-04 Thread Maulik
not omap-specific. How about USB: instead ? [Maulik] Yes this can go through linux-usb. +#if defined(CONFIG_USB_NOP_XCEIV) /* sometimes transceivers are accessed only through e.g. ULPI */ extern void usb_nop_xceiv_register(void); extern void usb_nop_xceiv_unregister(void); +#else

[PATCH 0/2] ARM : OMAP : Get rid of ifdef

2009-12-31 Thread Maulik Mankad
Hi, Felipe, Here is the 2 patch series based on top of your for-tony branch at [1]. [1] git://gitorious.org/usb/usb.git for-tony Maulik Mankad (2): ARM : OMAP : Remove #ifdef from board-omap3evm.c ARM : OMAP : Add empty function in header file Basically the patch set address a comment from

[PATCH 1/2] ARM : OMAP : Remove #ifdef from board-omap3evm.c

2009-12-31 Thread Maulik Mankad
ARM : OMAP : Remove #ifdef from board-omap3evm.c This patch removes #ifdef around usb_nop_xceiv_register() from board-omap3evm.c Signed-off-by: Maulik Mankad x0082...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: Felipe Balbi felipe.ba...@nokia.com Cc: Greg Kroah-Hartman gre...@suse.de Cc: Olof

[PATCH 2/2] ARM : OMAP : Add empty function in header file

2009-12-31 Thread Maulik Mankad
ARM : OMAP : Add empty function in header file This patch adds empty functions for usb_nop_xceiv_register() and usb_nop_xceiv_unregister() so that these functions can be called even when CONFIG_NOP_USB_XCEIV is not enabled. It allows to remove ifdef's from board file. Signed-off-by: Maulik

[PATCH v3 0/2] ARM : OMAP patches

2009-12-31 Thread Maulik Mankad
=126226514430984w=2 Maulik Mankad (2): ARM : OMAP: MUSB : Pass board specific data using a structure. ARM : OMAP4 : MUSB : Add USB support to 4430 SDP board file The patches are compile tested and do not report any checkpatch warnings. The patch set addresses comments received for Version 2. Thanks, Maulik

[PATCH v3 1/2] ARM : OMAP: MUSB : Pass board specific data using a structure

2009-12-31 Thread Maulik Mankad
to the driver. Signed-off-by: Maulik Mankad x0082...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: Felipe Balbi felipe.ba...@nokia.com Cc: David Brownell davi...@pacbell.net Cc: Greg Kroah-Hartman gre...@suse.de Cc: Gupta Ajay Kumar ajay.gu...@ti.com --- arch/arm/mach-omap2/board-2430sdp.c

[PATCH v3 2/2] ARM : OMAP4 : MUSB : Add USB support to 4430 SDP board file

2009-12-31 Thread Maulik Mankad
ARM : OMAP4 : Add USB support to 4430 SDP board file This patch adds support for Mentor USB to 4430 SDP board file. It also defines the base address for HS USB OTG controller in OMAP4. Also updates platform specfic structure with base address and IRQ details. Signed-off-by: Maulik Mankad x0082

[PATCH 0/2] ARM : OMAP patches

2009-12-30 Thread Maulik Mankad
Hi, Felipe, Here is the 2 patch series based on top of your for-tony branch at [1]. [1] git://gitorious.org/usb/usb.git for-tony Maulik Mankad (2): ARM : OMAP: MUSB : Pass board specific data using a structure. ARM : OMAP4 : MUSB : Add USB support to 4430 SDP board file The patches

[PATCH 1/2] ARM : OMAP: MUSB : Pass board specific data using a structure

2009-12-30 Thread Maulik Mankad
to the driver. It addresses a comment from Felipe and thus help by preventing addition of too many fields in musb_platform_data. Signed-off-by: Maulik Mankad x0082...@ti.com Cc: Felipe Balbi felipe.ba...@nokia.com Cc: Tony Lindgren t...@atomide.com Cc: Greg Kroah-Hartman gre...@suse.de Index

[PATCH 2/2] ARM : OMAP4 : MUSB : Add USB support to 4430 SDP board file

2009-12-30 Thread Maulik Mankad
ARM : OMAP4 : Add USB support to 4430 SDP board file This patch adds support for Mentor USB to 4430 SDP board file. It also defines the base address for HS USB OTG controller in OMAP4. Also updates platform specfic structure with base address and IRQ details. Signed-off-by: Maulik Mankad x0082

RE: [PATCH 1/2] ARM : OMAP: MUSB : Pass board specific data using a structure

2009-12-30 Thread Maulik
Isn't it simpler to use same name across the boards like, 'musb_board_data' Instead of 'omap3430sdp_data'. [Maulik] Will change in the next version. -extern void usb_musb_init(enum musb_mode mode, unsigned power); +struct musb_omap_data { +u8 interface_type; +u8 mode; +u8 power

[PATCH v2 0/2] ARM : OMAP patches

2009-12-30 Thread Maulik Mankad
Hi, Felipe, Here is the Version 2 of the 2 patch series based on top of your for-tony branch at [1]. [1] git://gitorious.org/usb/usb.git for-tony Maulik Mankad (2): ARM : OMAP: MUSB : Pass board specific data using a structure. ARM : OMAP4 : MUSB : Add USB support to 4430 SDP board file

[PATCH v2 1/2] ARM : OMAP: MUSB : Pass board specific data using a structure

2009-12-30 Thread Maulik Mankad
to the driver. Signed-off-by: Maulik Mankad x0082...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: Felipe Balbi felipe.ba...@nokia.com Cc: David Brownell davi...@pacbell.net Cc: Greg Kroah-Hartman gre...@suse.de Cc: Gupta Ajay Kumar ajay.gu...@ti.com Index: felipe_musb/arch/arm/mach-omap2/board

[PATCH v2 2/2] ARM : OMAP4 : MUSB : Add USB support to 4430 SDP board file

2009-12-30 Thread Maulik Mankad
ARM : OMAP4 : Add USB support to 4430 SDP board file This patch adds support for Mentor USB to 4430 SDP board file. It also defines the base address for HS USB OTG controller in OMAP4. Also updates platform specfic structure with base address and IRQ details. Signed-off-by: Maulik Mankad x0082