Re: [PATCHv2] phy: omap-usb2: Enable runtime PM of omap-usb2 phy properly

2014-10-29 Thread Rabin Vincent
Unless I'm missing something, this patch appears to have still not been picked up. It would be nice if it can go in for 3.18 so that we have working USB on pandaboard again at least in that release. Tony, would you mind carrying it as OMAP maintainer since we haven't heard anything from Kishon

Re: RCU bug with v3.17-rc3 ?

2014-10-09 Thread Rabin Vincent
On Thu, Oct 09, 2014 at 11:26:56AM -0500, Felipe Balbi wrote: alright, it's pretty deterministic however. Always on the same test, no matter which USB controller, no matter if backing store is RAM or MMC. Those two undefined instructions on the disassembly caught my attention, perhaps I'm

Re: BUG (maybe) with find_get_entry()

2014-10-08 Thread Rabin Vincent
On Wed, Oct 08, 2014 at 11:57:14AM -0500, Felipe Balbi wrote: Hi, With today's linus/master and with greg/usb-next I keep getting random kernel oops from find_get_entry() (see below): [ 47.700065] Unable to handle kernel paging request at virtual address [ 47.707667] pgd =

Re: [PATCH 2/5] drivers: usb: otg: make twl6030_usb as a comparator driver to omap_usb2

2012-09-24 Thread Rabin Vincent
2012/9/24 ABRAHAM, KISHON VIJAY kis...@ti.com: On Sat, Sep 22, 2012 at 3:03 AM, Rabin Vincent ra...@rab.in wrote: USB doesn't work on pandaboard on linux-next, and bisection shows this patch. Unfortunately, I can't provide a dmesg log because USB is the only way I currently have to get one

Re: [PATCH 2/5] drivers: usb: otg: make twl6030_usb as a comparator driver to omap_usb2

2012-09-21 Thread Rabin Vincent
2012/9/6 Kishon Vijay Abraham I kis...@ti.com: All the PHY configuration other than VBUS, ID GND and OTG SRP are removed from twl6030. The phy configurations are taken care by the dedicated usb2 phy driver. So twl6030 is made as comparator driver for VBUS and ID detection. Signed-off-by:

Re: Bug in _und_usr on dual-core ARM?

2012-04-20 Thread Rabin Vincent
On Tue, Jun 21, 2011 at 14:45, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Jun 21, 2011 at 04:31:19PM +0800, TAO HU wrote: We got an issue on our OMAP4 SMP system. Looks like __und_user(), which was triggered by a user space exception, got a page fault hence lead to

Re: [PATCH v5 6/7] arm: omap4: support pmu

2011-11-23 Thread Rabin Vincent
On Mon, Oct 24, 2011 at 20:15, ming@canonical.com wrote:  static struct platform_device* __init omap4_init_pmu(void)  {        int id = -1; @@ -420,6 +472,10 @@ static struct platform_device* __init omap4_init_pmu(void)                return NULL;        } +      

Re: [PATCH] OMAP: don't trace functions called from sched_clock

2011-05-27 Thread Rabin Vincent
Tony, On Sun, May 8, 2011 at 14:51, Rabin Vincent ra...@rab.in wrote: omap_readl() is used from the sched_clock() implementations and so must be marked notrace to avoid recursion in ftrace.  Same thing with mpu_read() for OMAP1. Signed-off-by: Rabin Vincent ra...@rab.in Comments

Re: [PATCH] OMAP4: fix return value of omap4_l3_init

2011-05-18 Thread Rabin Vincent
On Sat, May 7, 2011 at 22:28, Rabin Vincent ra...@rab.in wrote: Don't PTR_ERR() a non-error pointer:  initcall omap4_l3_init+0x0/0xdc returned -544980480 after 0 usecs  initcall omap4_l3_init+0x0/0xdc returned with error code -544980480 Signed-off-by: Rabin Vincent ra...@rab.in Ping

Re: [patch v4 3/3] arm: omap4: support pmu

2011-05-14 Thread Rabin Vincent
On Tue, Mar 8, 2011 at 21:08, tom.leim...@gmail.com wrote: From: Ming Lei tom.leim...@gmail.com This patch supports pmu irq routed from CTI, so make pmu/perf working on OMAP4. The idea is from Woodruff Richard in the disscussion about Oprofile on Pandaboard / Omap4 on

[PATCH] OMAP: don't trace functions called from sched_clock

2011-05-08 Thread Rabin Vincent
omap_readl() is used from the sched_clock() implementations and so must be marked notrace to avoid recursion in ftrace. Same thing with mpu_read() for OMAP1. Signed-off-by: Rabin Vincent ra...@rab.in --- arch/arm/mach-omap1/io.c |2 +- arch/arm/mach-omap1/time.c |2 +- arch/arm/mach

!CONFIG_OMAP_32K_TIMER on OMAP4/panda

2011-05-07 Thread Rabin Vincent
On a linux-next kernel built for the Pandaboard, disabling CONFIG_OMAP_32K_TIMER makes the kernel use the gptimer as the clocksource, but this appears to be non-functional. Judging from the all-zeros printk timings and the fact the sleep 1 hangs indefinitely, it looks like the clocksource reads

[PATCH] OMAP4: fix return value of omap4_l3_init

2011-05-07 Thread Rabin Vincent
Don't PTR_ERR() a non-error pointer: initcall omap4_l3_init+0x0/0xdc returned -544980480 after 0 usecs initcall omap4_l3_init+0x0/0xdc returned with error code -544980480 Signed-off-by: Rabin Vincent ra...@rab.in --- arch/arm/mach-omap2/devices.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [PATCH] ARM: ensure all sched_clock() implementations are notrace marked

2010-12-16 Thread Rabin Vincent
On Thu, Dec 16, 2010 at 1:48 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: ftrace requires sched_clock() to be notrace.  Ensure that all implementations are so marked. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk It does seem better to have all of them explicity

Re: [PATCH] ARM: ensure all sched_clock() implementations are notrace marked

2010-12-16 Thread Rabin Vincent
On Thu, Dec 16, 2010 at 9:27 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Dec 16, 2010 at 08:42:23PM +0530, Rabin Vincent wrote: On Thu, Dec 16, 2010 at 1:48 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: ftrace requires sched_clock() to be notrace.  Ensure

[PATCH] ARM: omap: ensure sched_clock() is notrace

2010-11-19 Thread Rabin Vincent
Include sched.h to ensure sched_clock() has the notrace annotation, and mark any functions it calls as notrace too. Cc: Tony Lindgren t...@atomide.com Cc: linux-omap@vger.kernel.org Signed-off-by: Rabin Vincent ra...@rab.in --- arch/arm/plat-omap/counter_32k.c | 13 +++-- arch/arm/plat

Re: [PATCH 2/2] ftrace - add ftrace function_graph support on ARM

2010-10-11 Thread Rabin Vincent
On Mon, Oct 11, 2010 at 1:55 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: And now to go back to the original question I asked: What is __irq_entry used for? It's used to identify when we're inside the interrupt handling path. Depending upon the tracing options (funcgraph-irqs),

Re: [PATCH 2/2] ftrace - add ftrace function_graph support on ARM

2010-10-10 Thread Rabin Vincent
On Sat, Oct 09, 2010 at 08:37:57PM +0100, Russell King - ARM Linux wrote: On Sat, Oct 09, 2010 at 11:20:50PM +0530, Rabin Vincent wrote: It's used just for the C entry functions for interrupts: asm_do_IRQ() and the IPI and local timer functions. AFAICS __exception seems to be used only

Re: [PATCH 2/2] ftrace - add ftrace function_graph support on ARM

2010-10-09 Thread Rabin Vincent
On Sun, Mar 7, 2010 at 1:48 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Mar 05, 2010 at 04:36:47PM -0800, Tim Bird wrote: IRQENTRY_TEXT was added to vmlinux.lds.S (to eliminate a compiler error on kernel/trace/trace_functions_graph.c), although no routines were marked as

Re: [RFC] Initial attempt to make ARM use LMB

2010-04-10 Thread Rabin Vincent
On Sat, Apr 10, 2010 at 08:03:05AM +0100, Russell King - ARM Linux wrote: On Sat, Apr 10, 2010 at 09:12:24AM +0530, Rabin Vincent wrote: On Fri, Apr 09, 2010 at 12:11:05PM +0100, Russell King - ARM Linux wrote: Here's a revised version which should resolve the initrd problem. It does

Re: [RFC] Initial attempt to make ARM use LMB

2010-04-08 Thread Rabin Vincent
On Thu, Mar 25, 2010 at 11:32:48PM +, Russell King - ARM Linux wrote: The patch below is the combined patch; individual patches can be found in the arm:lmb patches on the website or the lmb branch of my git tree; this should be considered unstable. Something like the following is needed to

Re: Exception while handling MEM Hole on OMAP3 / ARM Cortex A8

2009-08-17 Thread Rabin Vincent
On Sat, Aug 15, 2009 at 07:17:11PM +0100, Russell King - ARM Linux wrote: +#ifndef CONFIG_SPARSEMEM +int pfn_valid(unsigned long pfn) +{ + struct meminfo *mi = meminfo; + unsigned int mid, left = 0, right = mi-nr_banks; + + while ((mid = (right - left) / 2) 0) { +

Re: Exception while handling MEM Hole on OMAP3 / ARM Cortex A8

2009-08-17 Thread Rabin Vincent
On Mon, Aug 17, 2009 at 06:47:18PM +0100, Russell King - ARM Linux wrote: On Mon, Aug 17, 2009 at 11:03:44PM +0530, Rabin Vincent wrote: On Sat, Aug 15, 2009 at 07:17:11PM +0100, Russell King - ARM Linux wrote: +#ifndef CONFIG_SPARSEMEM +int pfn_valid(unsigned long pfn) +{ + struct

Re: Exception while handling MEM Hole on OMAP3 / ARM Cortex A8

2009-08-17 Thread Rabin Vincent
On Mon, Aug 17, 2009 at 03:23:18PM -0500, Aguirre Rodriguez, Sergio Alberto wrote: #ifndef CONFIG_SPARSEMEM int pfn_valid(unsigned long pfn) { struct meminfo *mi = meminfo; unsigned int left = 0, right = mi-nr_banks; while (left = right) { This condition will cause the