Re: [PATCH 03/13] PM: QoS: extend the in-kernel API with per-device latency constraints

2011-08-02 Thread Rafael J. Wysocki
Hi, On Tuesday, August 02, 2011, Jean Pihet wrote: ... I will keep pm_qos_class if the rename brings in some confusion. The intention was to simplify the names of the fields in structs with explicit names. Please keep it for now. You can rename it later if there's a clear benefit, but I'm

Re: [PATCH 04/13] PM: QoS: implement the per-device latency constraints

2011-08-02 Thread Rafael J. Wysocki
Hi, On Tuesday, August 02, 2011, Jean Pihet wrote: ... -static inline void pm_qos_set_value(struct pm_qos_object *o, s32 value) +static inline void pm_qos_set_value(struct pm_qos_constraints *c, s32 value) { - o-target_value = value; + c-target_value = value; } Well,

Re: [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-02 Thread Rafael J. Wysocki
On Tuesday, August 02, 2011, Kevin Hilman wrote: [adding Mark Brown as we discussed similar topics a couple plumbers ago] Rafael J. Wysocki r...@sisk.pl writes: [...] The new class is only available from kernel drivers and so is not exported to user space. It should

Re: [linux-pm] Runtime PM discussion notes

2011-07-30 Thread Rafael J. Wysocki
On Saturday, July 30, 2011, Pavel Machek wrote: Hi! Well, auto suspending when screensaver is active would still be useful. (And IIRC some machines kept screen on when in S-state unless driver powered it down... but that might be S1. The reason why you can't enter ACPI

Re: [linux-pm] Runtime PM discussion notes

2011-07-30 Thread Rafael J. Wysocki
On Saturday, July 30, 2011, Rafael J. Wysocki wrote: On Saturday, July 30, 2011, Pavel Machek wrote: Hi! Well, auto suspending when screensaver is active would still be useful. (And IIRC some machines kept screen on when in S-state unless driver powered it down

Re: [linux-pm] Runtime PM discussion notes

2011-07-30 Thread Rafael J. Wysocki
On Saturday, July 30, 2011, Pavel Machek wrote: IIRC I solved it by just calling _PTS when sleepy Linux was enabled. It had side effect of lighting up moon icon, but otherwise seemed to work ok. I do not think ACPI says what can and can not be done after _PTS... Yes,

Re: [PATCH 04/13] PM: QoS: implement the per-device latency constraints

2011-07-30 Thread Rafael J. Wysocki
On Thursday, July 28, 2011, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com Re-design the PM QoS implementation to support the per-device constraints: Well, I guess I should have reviewed this patch before [03/13]. - Define a pm_qos_constraints struct for the storage of

Re: [PATCH 05/13] PM: QoS: support the dynamic insertion and removal of devices

2011-07-30 Thread Rafael J. Wysocki
On Thursday, July 28, 2011, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com The devices latency constraints class of PM QoS is storing the constraints list in the device dev_pm_info struct. This patch adds the init and de-init of the per-device constraints list in order

Re: [linux-pm] Runtime PM discussion notes

2011-07-30 Thread Rafael J. Wysocki
On Sunday, July 31, 2011, Pavel Machek wrote: Hi! IIRC I solved it by just calling _PTS when sleepy Linux was enabled. It had side effect of lighting up moon icon, but otherwise seemed to work ok. I do not think ACPI says what can and can not be done after _PTS... Yes, it

Re: [linux-pm] Runtime PM discussion notes

2011-07-29 Thread Rafael J. Wysocki
On Friday, July 29, 2011, Pavel Machek wrote: Hi! Actually, it just occurred to me that if we're waiting for a system timer and can hand that off to a suitable timer in the PMIC then we can do a suspend to RAM for the deep idle state from the hardware point of view. Yep.

Re: [RFC/PATCH v3 00/13] PM QoS: add a per-device latency constraints class

2011-07-29 Thread Rafael J. Wysocki
On Thursday, July 28, 2011, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com This patch set is in an RFC state, for review and comments. High level implementation: 1. Add a new PM QoS class for device wake-up constraints (PM_QOS_DEV_LATENCY). . Define a

Re: [RFC/PATCH v3 00/13] PM QoS: add a per-device latency constraints class

2011-07-29 Thread Rafael J. Wysocki
On Friday, July 29, 2011, mark gross wrote: On Fri, Jul 29, 2011 at 10:37:52AM +0200, Jean Pihet wrote: Mark, On Thu, Jul 28, 2011 at 3:14 PM, mark gross markgr...@thegnar.org wrote: On Thu, Jul 28, 2011 at 10:30:07AM +0200, jean.pi...@newoldbits.com wrote: From: Jean Pihet

Re: [PATCH 02/13] PM: add a per-device wake-up latency constraints plist

2011-07-29 Thread Rafael J. Wysocki
On Thursday, July 28, 2011, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com Add the field latency_constraints in the struct dev_pm_info and the initialization of the plist in device_pm_init. This enables the implementation of per-device constraints in PM QoS.

Re: [PATCH 01/13] PM: QoS: rename pm_qos_params files to pm_qos

2011-07-29 Thread Rafael J. Wysocki
On Thursday, July 28, 2011, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com The PM QoS implementation files are better named kernel/pm_qos.c and include/linux/pm_qos.h. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-msm/clock.c |2 +-

Re: [PATCH 03/13] PM: QoS: extend the in-kernel API with per-device latency constraints

2011-07-29 Thread Rafael J. Wysocki
On Thursday, July 28, 2011, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com Extend the PM QoS kernel API: - add a new PM QoS class PM_QOS_DEV_LATENCY for device wake-up latency constraints - make the pm_qos_add_request API more generic by using a parameter of type struct

Re: [linux-pm] [RFC/PATCH v2] PM / Runtime: allow _put_sync() from interrupts-disabled context

2011-07-27 Thread Rafael J. Wysocki
On Wednesday, July 27, 2011, Kevin Hilman wrote: Rafael J. Wysocki r...@sisk.pl writes: On Friday, July 22, 2011, Kevin Hilman wrote: Currently the use of pm_runtime_put_sync() is not safe from interrupts-disabled context because rpm_idle() will release the spinlock and enable

Re: [linux-pm] [RFC/PATCH v2] PM / Runtime: allow _put_sync() from interrupts-disabled context

2011-07-23 Thread Rafael J. Wysocki
On Friday, July 22, 2011, Kevin Hilman wrote: Currently the use of pm_runtime_put_sync() is not safe from interrupts-disabled context because rpm_idle() will release the spinlock and enable interrupts for the idle callbacks. This enables interrupts during a time where interrupts were expected

[GIT PULL] Power management updates for 3.1

2011-07-22 Thread Rafael J. Wysocki
.suspend_again() callback to suspend_ops Nishanth Menon (1): PM / OPP: Introduce function to free cpufreq table Rafael J. Wysocki (29): PM / Domains: Rename struct dev_power_domain to struct dev_pm_domain PM: subsys_data in struct dev_pm_info need not depend on RM_RUNTIME PM

Re: [linux-pm] Runtime PM discussion notes

2011-07-13 Thread Rafael J. Wysocki
On Wednesday, July 13, 2011, Paul Walmsley wrote: (cc'ing Len) Hi Mark, On Mon, 11 Jul 2011, Mark Brown wrote: The interesting bits are things like being able to kill lots of the SoC core supplies when the RAM is in retention mode - the CPU needs to go through its shutdown

Re: [PATCH] PM / Runtime: add new helper function: pm_runtime_status_suspended()

2011-07-12 Thread Rafael J. Wysocki
or not. Also add entry to Documentation/power/runtime.txt Suggested-by: Rafael J. Wysocki r...@sisk.pl Signed-off-by: Kevin Hilman khil...@ti.com Applied to suspend-2.6/pm-runtime, thanks! Rafael --- Documentation/power/runtime_pm.txt |3 +++ include/linux/pm_runtime.h |6 ++ 2

Re: [PATCH 0/4] OMAP: PM: omap_device: update PM domain support for v3.1

2011-07-12 Thread Rafael J. Wysocki
Hi, On Tuesday, July 12, 2011, Kevin Hilman wrote: For v3.1, the PM core has some changes that impact various assumptions made (by me) during the design and implementation of the PM domain support in the omap_device layer. This series is needed to update our PM domain layer to behave

Re: pm_runtime_suspended() can be false if RPM_SUSPENDED

2011-07-11 Thread Rafael J. Wysocki
On Monday, July 11, 2011, Kevin Hilman wrote: Rafael J. Wysocki r...@sisk.pl writes: Hi, On Saturday, July 09, 2011, Kevin Hilman wrote: Hi Rafael, Just curious why pm_runtime_suspended() requires the device to be enabled for it to return true: static inline bool

Re: pm_runtime_suspended() can be false if RPM_SUSPENDED

2011-07-11 Thread Rafael J. Wysocki
On Monday, July 11, 2011, Kevin Hilman wrote: Rafael J. Wysocki r...@sisk.pl writes: [...] However, based on the pm_runtime_set_active() problem you mentioned above, I'm not sure this will help either, since what the PM domain's noirq callback will want to do will be based

Re: pm_runtime_suspended() can be false if RPM_SUSPENDED

2011-07-11 Thread Rafael J. Wysocki
On Monday, July 11, 2011, Hilman, Kevin wrote: On Mon, Jul 11, 2011 at 1:22 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Monday, July 11, 2011, Kevin Hilman wrote: Rafael J. Wysocki r...@sisk.pl writes: [...] However, based on the pm_runtime_set_active() problem you mentioned

Re: pm_runtime_suspended() can be false if RPM_SUSPENDED

2011-07-09 Thread Rafael J. Wysocki
Hi, On Saturday, July 09, 2011, Kevin Hilman wrote: Hi Rafael, Just curious why pm_runtime_suspended() requires the device to be enabled for it to return true: static inline bool pm_runtime_suspended(struct device *dev) { return dev-power.runtime_status == RPM_SUSPENDED

Re: PM domain using _noirq methods to finish pending runtime PM transistions

2011-07-09 Thread Rafael J. Wysocki
Hi, On Saturday, July 09, 2011, Kevin Hilman wrote: Hi Rafael, So I'm now experimenting with your suggestion of using the noirq callbacks of the PM domain to ensure device low-power state transitions for the cases where runtime PM has been disabled from userspace (or a driver has used

Re: [PATCH 6/7] ARM / Samsung: Use struct syscore_ops for core power management

2011-07-08 Thread Rafael J. Wysocki
On Monday, March 28, 2011, Ben Dooks wrote: On Mon, Mar 28, 2011 at 01:29:49AM +0200, Rafael J. Wysocki wrote: From: Rafael J. Wysocki r...@sisk.pl Replace sysdev classes and struct sys_device objects used for core power management by Samsung platforms with struct syscore_ops objects

Re: [PATCH v2 00/11] PM QoS: add a per-device wake-up latency constraint class

2011-07-04 Thread Rafael J. Wysocki
On Monday, July 04, 2011, Vishwanath Sripathy wrote: -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Rafael J. Wysocki Sent: Sunday, July 03, 2011 12:51 AM To: jean.pi...@newoldbits.com Cc: Paul Walmsley; Kevin

Re: [PATCH v2 00/11] PM QoS: add a per-device wake-up latency constraint class

2011-07-02 Thread Rafael J. Wysocki
Hi, On Thursday, June 30, 2011, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com This patch set is in an RFC state, for review and comments. First off, I'm sorry I couldn't review the patchset earlier. In order to implement the new class in PM QoS the following changes have

Re: [PATCH 01/11] PM: add a per-device wake-up latency constraints plist

2011-07-02 Thread Rafael J. Wysocki
Hi, On Thursday, June 30, 2011, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com Add the field wakeup_lat_plist_head in the struct dev_pm_info and the initialization of the plist in device_pm_init. This enables the implementation of per-device constraints in PM QoS.

Re: [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-07-02 Thread Rafael J. Wysocki
Hi, On Thursday, June 30, 2011, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com - add a new PM QoS class PM_QOS_DEV_WAKEUP_LATENCY for device wake-up constraints. Due to the per-device nature of the new class the constraints list is stored inside the device dev_pm_info

Re: [PATCH 03/11] PM QoS: support the dynamic devices insertion and removal

2011-07-02 Thread Rafael J. Wysocki
Hi, On Thursday, June 30, 2011, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com The devices wake-up latency constraints class of PM QoS is storing the constraints list using the device pm_info struct. This patch adds the init and de-init of the per-device constraints

Re: [linux-pm] runtime PM usage_count during driver_probe_device()?

2011-07-01 Thread Rafael J. Wysocki
with the pm_runtime_put_sync() after drv-remove(dev) ... So the code in question was introduced by commit e1866b33b1e89f077b7132daae3dfd9a594e9a1a Author: Rafael J. Wysocki r...@sisk.pl Date: Fri Apr 29 00:33:45 2011 +0200 PM / Runtime: Rework runtime PM handling during driver removal with a long changelog

Re: [linux-pm] runtime PM usage_count during driver_probe_device()?

2011-07-01 Thread Rafael J. Wysocki
On Friday, July 01, 2011, Kevin Hilman wrote: Continuing on the theme of runtime PM interactions with other parts of the driver core... In drivers/base/dd.c:driver_probe_device(), the driver core increments the usage count around -probe(): [...]

Re: [linux-pm] runtime PM usage_count during driver_probe_device()?

2011-07-01 Thread Rafael J. Wysocki
On Friday, July 01, 2011, Alan Stern wrote: On Fri, 1 Jul 2011, Rafael J. Wysocki wrote: Hi, On Friday, July 01, 2011, Kevin Hilman wrote: Alan Stern st...@rowland.harvard.edu writes: On Fri, 1 Jul 2011, Kevin Hilman wrote: OK, so the -probe() part has been explained

[PATCH] PM / Runtime: Update documentation regarding driver removal

2011-07-01 Thread Rafael J. Wysocki
From: Rafael J. Wysocki r...@sisk.pl Commit e1866b33b1e89f077b7132daae3dfd9a594e9a1a (PM / Runtime: Rework runtime PM handling during driver removal) forgot to update the documentation in Documentation/power/runtime_pm.txt to match the new code in drivers/base/dd.c. Update that documentation

Re: [linux-pm] runtime PM usage_count during driver_probe_device()?

2011-06-30 Thread Rafael J. Wysocki
On Friday, July 01, 2011, Kevin Hilman wrote: Kevin Hilman khil...@ti.com writes: Continuing on the theme of runtime PM interactions with other parts of the driver core... In drivers/base/dd.c:driver_probe_device(), the driver core increments the usage count around -probe():

Re: [linux-pm] [PATCH] PM: export suspend_set_ops, suspend_valid_only_mem

2011-06-26 Thread Rafael J. Wysocki
On Sunday, June 26, 2011, Pavel Machek wrote: On Sun 2011-06-12 16:20:20, Rafael J. Wysocki wrote: On Saturday, May 28, 2011, Kevin Hilman wrote: Some platforms wish to implement their PM core suspend code as modules. To do so, these functions need to be exported to modules

Re: [linux-pm] Runtime PM discussion notes

2011-06-25 Thread Rafael J. Wysocki
Hi, On Friday, June 24, 2011, Paul Walmsley wrote: (Arve cc'ed, also adding Magnus and Kevin back to cc) Thanks, my mailer is playing tricks on me. :-) Hi Rafael, On Thu, 23 Jun 2011, Rafael J. Wysocki wrote: On Thursday, June 23, 2011, Alan Stern wrote: On Thu, 23 Jun 2011, Paul

Re: [linux-pm] Runtime PM discussion notes

2011-06-23 Thread Rafael J. Wysocki
Hi, On Thursday, June 23, 2011, Alan Stern wrote: On Thu, 23 Jun 2011, Paul Walmsley wrote: Hi a few thoughts here: On Wed, 15 Jun 2011, Rafael J. Wysocki wrote: On Tuesday, June 14, 2011, Magnus Damm wrote: As for freezing user space, yes, I agree. The other feature

Re: [linux-pm] calling runtime PM from system PM methods

2011-06-20 Thread Rafael J. Wysocki
On Monday, June 20, 2011, Alan Stern wrote: On Sun, 19 Jun 2011, Rafael J. Wysocki wrote: In the meantime I rethought the __pm_runtime_disable() part of my previous patch and I now think it's not necessary to complicate it any more. Of course, we need not check if runtime resume

Re: [linux-pm] calling runtime PM from system PM methods

2011-06-19 Thread Rafael J. Wysocki
On Sunday, June 19, 2011, Alan Stern wrote: On Sun, 19 Jun 2011, Rafael J. Wysocki wrote: On Saturday, June 18, 2011, Rafael J. Wysocki wrote: On Saturday, June 18, 2011, Alan Stern wrote: On Sat, 18 Jun 2011, Rafael J. Wysocki wrote: ... Well, assuming that https

Re: [linux-pm] calling runtime PM from system PM methods

2011-06-19 Thread Rafael J. Wysocki
On Sunday, June 19, 2011, Alan Stern wrote: On Sun, 19 Jun 2011, Rafael J. Wysocki wrote: Well, that was kind of difficult to debug, but not impossible. :-) The problem here turns out to be related to the SCSI subsystem. Namely, when the AHCI controller is suspended, it uses the SCSI

Re: [linux-pm] calling runtime PM from system PM methods

2011-06-18 Thread Rafael J. Wysocki
On Friday, June 17, 2011, Rafael J. Wysocki wrote: On Friday, June 17, 2011, Alan Stern wrote: On Fri, 17 Jun 2011, Rafael J. Wysocki wrote: Having considered that a bit more I see that, in fact, commit e8665002477f0278f84f898145b1f141ba26ee26 (PM: Allow pm_runtime_suspend

Re: [linux-pm] calling runtime PM from system PM methods

2011-06-18 Thread Rafael J. Wysocki
On Saturday, June 18, 2011, Alan Stern wrote: On Sat, 18 Jun 2011, Rafael J. Wysocki wrote: On Friday, June 17, 2011, Rafael J. Wysocki wrote: On Friday, June 17, 2011, Alan Stern wrote: On Fri, 17 Jun 2011, Rafael J. Wysocki wrote: Having considered that a bit more I see

Re: [linux-pm] calling runtime PM from system PM methods

2011-06-18 Thread Rafael J. Wysocki
On Saturday, June 18, 2011, Rafael J. Wysocki wrote: On Saturday, June 18, 2011, Alan Stern wrote: On Sat, 18 Jun 2011, Rafael J. Wysocki wrote: ... Well, assuming that https://patchwork.kernel.org/patch/893722/ is applied, which is going to be, I think we can put

Re: [linux-pm] calling runtime PM from system PM methods

2011-06-17 Thread Rafael J. Wysocki
On Friday, June 17, 2011, Rafael J. Wysocki wrote: On Thursday, June 16, 2011, Alan Stern wrote: On Wed, 15 Jun 2011, Kevin Hilman wrote: Rafael J. Wysocki r...@sisk.pl writes: On Wednesday, June 15, 2011, Kevin Hilman wrote: [...] From a device driver

Re: [linux-pm] calling runtime PM from system PM methods

2011-06-17 Thread Rafael J. Wysocki
On Friday, June 17, 2011, Alan Stern wrote: On Fri, 17 Jun 2011, Rafael J. Wysocki wrote: Having considered that a bit more I see that, in fact, commit e8665002477f0278f84f898145b1f141ba26ee26 (PM: Allow pm_runtime_suspend() to succeed during system suspend) has introduced at least one

Re: [linux-pm] calling runtime PM from system PM methods

2011-06-16 Thread Rafael J. Wysocki
On Thursday, June 16, 2011, Kevin Hilman wrote: Rafael J. Wysocki r...@sisk.pl writes: On Wednesday, June 15, 2011, Kevin Hilman wrote: [...] From a device driver perspective, system PM is just runtime PM where the idleness was forced and only a subset of possible wakeup sources

Re: [linux-pm] calling runtime PM from system PM methods

2011-06-16 Thread Rafael J. Wysocki
On Thursday, June 16, 2011, Alan Stern wrote: On Wed, 15 Jun 2011, Kevin Hilman wrote: Rafael J. Wysocki r...@sisk.pl writes: On Wednesday, June 15, 2011, Kevin Hilman wrote: [...] From a device driver perspective, system PM is just runtime PM where the idleness

Re: [linux-pm] [PATCH] PM: export suspend_set_ops, suspend_valid_only_mem

2011-06-12 Thread Rafael J. Wysocki
On Saturday, May 28, 2011, Kevin Hilman wrote: Some platforms wish to implement their PM core suspend code as modules. To do so, these functions need to be exported to modules. Reported-by: Jean Pihet j-pi...@ti.com Signed-off-by: Kevin Hilman khil...@ti.com Applied to

Re: [linux-pm] calling runtime PM from system PM methods

2011-06-12 Thread Rafael J. Wysocki
On Sunday, June 12, 2011, Alan Stern wrote: On Sun, 12 Jun 2011, Rafael J. Wysocki wrote: Basically, I think what Rafael was saying before referred to the general case, where you don't know anything about the subsystem and can't afford to make assumptions. But in the real world

Re: [linux-pm] calling runtime PM from system PM methods

2011-06-11 Thread Rafael J. Wysocki
On Saturday, June 11, 2011, Mark Brown wrote: On Fri, Jun 10, 2011 at 10:27:25PM +0200, Rafael J. Wysocki wrote: So, there are a few things to consider: * Can the device do things like DMA? * Does the driver use a workqueue? * Does it use timers? In all of the above cases your

Re: [linux-pm] calling runtime PM from system PM methods

2011-06-11 Thread Rafael J. Wysocki
On Saturday, June 11, 2011, Alan Stern wrote: On Fri, 10 Jun 2011, Kevin Hilman wrote: Alan Stern st...@rowland.harvard.edu writes: [...] If the wakeup setting is not correct, it has to be changed. That often implies going back to full power in order to change the wakeup

Re: [linux-pm] calling runtime PM from system PM methods

2011-06-11 Thread Rafael J. Wysocki
On Saturday, June 11, 2011, Kevin Hilman wrote: Rafael J. Wysocki r...@sisk.pl writes: [...] Whether or not user space has disabled runtime PM _doesn't_ _matter_ for system suspend, because _you_ _can't_ call pm_runtime_suspend(), or pm_runtime_put_sunc(), from a driver's .suspend

Re: [linux-pm] calling runtime PM from system PM methods

2011-06-10 Thread Rafael J. Wysocki
On Friday, June 10, 2011, Mark Brown wrote: On Fri, Jun 10, 2011 at 01:17:56PM -0400, Alan Stern wrote: On Fri, 10 Jun 2011, Mark Brown wrote: ignores that), it's noticably harder to reason about what's going on when I go outside there and when I think about what I'm doing it always

Re: [linux-pm] calling runtime PM from system PM methods

2011-06-10 Thread Rafael J. Wysocki
On Friday, June 10, 2011, Mark Brown wrote: On Thu, Jun 09, 2011 at 09:56:48AM -0400, Alan Stern wrote: On Wed, 8 Jun 2011, Kevin Hilman wrote: Runtime suspend 2. activity finishes system suspend [echo mem /sys/power/state] 2. prevent future activity, halt/wait for current

Re: [linux-pm] calling runtime PM from system PM methods

2011-06-10 Thread Rafael J. Wysocki
On Friday, June 10, 2011, Mark Brown wrote: On Fri, Jun 10, 2011 at 08:38:22PM +0200, Rafael J. Wysocki wrote: On Friday, June 10, 2011, Mark Brown wrote: I think from an interface point of view it's something like UNIVERSAL_DEV_PM_OPS() and friends, probably with some additional ops

Re: [linux-pm] calling runtime PM from system PM methods

2011-06-10 Thread Rafael J. Wysocki
On Friday, June 10, 2011, Mark Brown wrote: On Fri, Jun 10, 2011 at 08:49:03PM +0200, Rafael J. Wysocki wrote: On Friday, June 10, 2011, Mark Brown wrote: It seems like everyone's agreeing with each other here - from the user side the request seems to be largely for core infastructure

Re: [PATCH V2] PM: OPP: introduce function to free cpufreq table

2011-06-10 Thread Rafael J. Wysocki
On Wednesday, May 25, 2011, Kevin Hilman wrote: Nishanth Menon n...@ti.com writes: cpufreq table allocated by opp_init_cpufreq_table is better freed by OPP layer itself. This allows future modifications to the table handling to be transparent to the users. Signed-off-by: Nishanth

Re: [PATCH 3.0-rc1] PM / runtime: fix broken iteration over clock ids

2011-06-07 Thread Rafael J. Wysocki
On Monday, June 06, 2011, Janusz Krzysztofik wrote: On Mon 06 Jun 2011 at 19:47:36 Rafael J. Wysocki wrote: Hi, On Sunday, June 05, 2011, Janusz Krzysztofik wrote: In its current form, pm_runtime_clk_notify() iterates through sub- strings of pm_clk_notifier_block.con_ids[0] rather

Re: [linux-pm] calling runtime PM from system PM methods

2011-06-07 Thread Rafael J. Wysocki
On Tuesday, June 07, 2011, Kevin Hilman wrote: Rafael J. Wysocki r...@sisk.pl writes: [..] While it is tempting to try to get away with only two PM callbacks per driver instead of four (or even more), it generally is not doable, simply because driver callbacks are not executed directly

Re: [PATCH 3.0-rc1] PM / runtime: fix broken iteration over clock ids

2011-06-07 Thread Rafael J. Wysocki
On Tuesday, June 07, 2011, Janusz Krzysztofik wrote: On Tue 07 Jun 2011 at 21:29:25 Rafael J. Wysocki wrote: OK, below is an official version. Can you please double check if it fixes the problem for you? Hi, I've tested it successfully, but only the CONFIG_PM_RUNTIME=y case

Re: [PATCH 3.0-rc1] PM / runtime: fix broken iteration over clock ids

2011-06-06 Thread Rafael J. Wysocki
Hi, On Sunday, June 05, 2011, Janusz Krzysztofik wrote: In its current form, pm_runtime_clk_notify() iterates through sub- strings of pm_clk_notifier_block.con_ids[0] rather than consecutive pm_clk_notifier_block.con_ids[] elements. As a noticeable result, McBSP1 port no longer worked for

Re: calling runtime PM from system PM methods

2011-06-06 Thread Rafael J. Wysocki
On Thursday, June 02, 2011, Kevin Hilman wrote: Hi Rafael, Hi, Once again, I'm back to some problems with using runtime PM from system PM methods. On OMAP, many drivers don't need to do anything different for runtime PM compared to system PM, so the system PM methods can simply use runtime

Re: [linux-pm] calling runtime PM from system PM methods

2011-06-06 Thread Rafael J. Wysocki
Hi, Sorry for the delay. After returning from Japan I found my cable modem basically dead, so I have no Internet access from home at the moment, which is a bit inconvenient, so to speak. On Thursday, June 02, 2011, Kevin Hilman wrote: Alan Stern st...@rowland.harvard.edu writes: On Wed, 1

Re: [PATCH 4/4] mfd: global Suspend and resume support of ehci and ohci

2011-06-05 Thread Rafael J. Wysocki
On Wednesday, June 01, 2011, Felipe Balbi wrote: Hi, On Wed, Jun 01, 2011 at 03:54:38PM +0200, Rafael J. Wysocki wrote: +static const struct dev_pm_ops usbhsomap_dev_pm_ops = { + .suspend= usbhs_suspend, + .resume = usbhs_resume, +}; Please add .freeze()/.thaw

Re: [PATCH 4/4] mfd: global Suspend and resume support of ehci and ohci

2011-06-01 Thread Rafael J. Wysocki
On Wednesday, June 01, 2011, Keshava Munegowda wrote: From: Keshava Munegowda keshava_mgo...@ti.com The global suspend and resume functions for usbhs core driver are implemented.These routine are called when the global suspend and resume occurs. Before calling these functions, the bus

Re: [linux-pm] [PATCH] PM: export suspend_set_ops, suspend_valid_only_mem

2011-05-30 Thread Rafael J. Wysocki
On Monday, May 30, 2011, Jean Pihet wrote: Rafael, Hi, On Sat, May 28, 2011 at 11:01 AM, Rafael J. Wysocki r...@sisk.pl wrote: On Saturday, May 28, 2011, Kevin Hilman wrote: Some platforms wish to implement their PM core suspend code as modules. To do so, these functions need

Re: [linux-pm] [PATCH] PM: export suspend_set_ops, suspend_valid_only_mem

2011-05-28 Thread Rafael J. Wysocki
On Saturday, May 28, 2011, Kevin Hilman wrote: Some platforms wish to implement their PM core suspend code as modules. To do so, these functions need to be exported to modules. Hmm. What happens if the module is not loaded and the user attempts to suspend? Rafael Reported-by: Jean Pihet

Re: [PATCH] PM: OPP: introduce function to free cpufreq table

2011-05-24 Thread Rafael J. Wysocki
On Tuesday, May 24, 2011, Menon, Nishanth wrote: On Mon, May 23, 2011 at 19:05, Todd Poynor toddpoy...@google.com wrote: On Mon, May 23, 2011 at 06:12:15PM -0500, Nishanth Menon wrote: cpufreq table allocated by opp_init_cpufreq_table is better freed by OPP layer itself. This allows future

Re: [PATCH 11/14] PM / AVR32: Use struct syscore_ops instead of sysdevs for PM

2011-04-26 Thread Rafael J. Wysocki
On Tuesday, April 26, 2011, Hans-Christian Egtvedt wrote: On Sun, 2011-04-17 at 23:13 +0200, Rafael J. Wysocki wrote: From: Rafael J. Wysocki r...@sisk.pl Convert some AVR32 architecture's code to using struct syscore_ops objects for power management instead of sysdev classes and sysdevs

Re: [PATCH 10/14] PM / MIPS: Use struct syscore_ops instead of sysdevs for PM

2011-04-18 Thread Rafael J. Wysocki
On Monday, April 18, 2011, Ralf Baechle wrote: This patch breaks the Alchemy kernel compile; below patch on top of it fixes that again. Signed-off-by: Ralf Baechle r...@linux-mips.org Thanks! If you don't mind, I'd like to fold your patch into [10/14]. Rafael ---

Re: [PATCH 9/14] PM / Blackfin: Use struct syscore_ops instead of sysdevs for PM

2011-04-18 Thread Rafael J. Wysocki
On Monday, April 18, 2011, Mike Frysinger wrote: On Sun, Apr 17, 2011 at 17:11, Rafael J. Wysocki wrote: Convert some Blackfin architecture's code to using struct syscore_ops objects for power management instead of sysdev classes and sysdevs. This simplifies the code and reduces

[PATCH 0/14] Remove sysdev suspend/resume and shutdown operations

2011-04-17 Thread Rafael J. Wysocki
Hi, The following series of patches fixes bugs related to the introduction of struct syscore_ops later in this cycle, replaces sysdev suspend/resume operations in all of the architectures still using them with struct syscore_ops-based PM callbacks and finally removes the suspend/resume and

[PATCH 1/14] PM: Fix error code paths executed after failing syscore_suspend()

2011-04-17 Thread Rafael J. Wysocki
From: Rafael J. Wysocki r...@sisk.pl If syscore_suspend() fails in suspend_enter(), create_image() or resume_target_kernel(), it is necessary to call sysdev_resume(), because sysdev_suspend() has been called already and succeeded and we are going to abort the transition. Signed-off-by: Rafael J

[PATCH 2/14] PM: Add missing syscore_suspend() and syscore_resume() calls

2011-04-17 Thread Rafael J. Wysocki
From: Rafael J. Wysocki r...@sisk.pl Device suspend/resume infrastructure is used not only by the suspend and hibernate code in kernel/power, but also by , APM, Xen and the kexec jump feature. However, commit 40dc166cb5dddbd36aa4ad11c03915ea (PM / Core: Introduce struct syscore_ops for core

[PATCH 3/14] ARM: Use struct syscore_ops instead of sysdevs for PM in common code

2011-04-17 Thread Rafael J. Wysocki
From: Rafael J. Wysocki r...@sisk.pl Convert some ARM architecture's common code to using struct syscore_ops objects for power management instead of sysdev classes and sysdevs. This simplifies the code and reduces the kernel's memory footprint. It also is necessary for removing sysdevs from

[PATCH 5/14] ARM / Integrator: Use struct syscore_ops for core PM

2011-04-17 Thread Rafael J. Wysocki
From: Rafael J. Wysocki r...@sisk.pl Replace the sysdev class and struct sys_device used for power management by the Integrator interrupt-handling code with a struct syscore_ops object which is simpler. Signed-off-by: Rafael J. Wysocki r...@sisk.pl --- arch/arm/mach-integrator/integrator_ap.c

[PATCH 7/14] ARM / PXA: Use struct syscore_ops for core power management

2011-04-17 Thread Rafael J. Wysocki
From: Rafael J. Wysocki r...@sisk.pl Replace sysdev classes and struct sys_device objects used for core power management by the PXA platform code with struct syscore_ops objects that are simpler. This reduces the code size and the kernel memory footprint. It also is necessary for removing

[PATCH 12/14] PM / UNICORE32: Use struct syscore_ops instead of sysdevs for PM

2011-04-17 Thread Rafael J. Wysocki
From: Rafael J. Wysocki r...@sisk.pl Make some UNICORE32 architecture's code use struct syscore_ops objects for power management instead of sysdev classes and sysdevs. This simplifies the code and reduces the kernel's memory footprint. It also is necessary for removing sysdevs from the kernel

[PATCH 9/14] PM / Blackfin: Use struct syscore_ops instead of sysdevs for PM

2011-04-17 Thread Rafael J. Wysocki
From: Rafael J. Wysocki r...@sisk.pl Convert some Blackfin architecture's code to using struct syscore_ops objects for power management instead of sysdev classes and sysdevs. This simplifies the code and reduces the kernel's memory footprint. It also is necessary for removing sysdevs from

[PATCH 14/14] PM: Remove sysdev suspend, resume and shutdown operations

2011-04-17 Thread Rafael J. Wysocki
From: Rafael J. Wysocki r...@sisk.pl Since suspend, resume and shutdown operations in struct sysdev_class and struct sysdev_driver are not used any more, remove them. Also drop sysdev_suspend(), sysdev_resume() and sysdev_shutdown() used for executing those operations and modify all

[PATCH 13/14] PM / PowerPC: Use struct syscore_ops instead of sysdevs for PM

2011-04-17 Thread Rafael J. Wysocki
From: Rafael J. Wysocki r...@sisk.pl Make some PowerPC architecture's code use struct syscore_ops objects for power management instead of sysdev classes and sysdevs. This simplifies the code and reduces the kernel's memory footprint. It also is necessary for removing sysdevs from the kernel

[PATCH 10/14] PM / MIPS: Use struct syscore_ops instead of sysdevs for PM

2011-04-17 Thread Rafael J. Wysocki
From: Rafael J. Wysocki r...@sisk.pl Convert some MIPS architecture's code to using struct syscore_ops objects for power management instead of sysdev classes and sysdevs. This simplifies the code and reduces the kernel's memory footprint. It also is necessary for removing sysdevs from the kernel

[PATCH 4/14] ARM / OMAP: Use struct syscore_ops for core power management

2011-04-17 Thread Rafael J. Wysocki
From: Rafael J. Wysocki r...@sisk.pl Replace the sysdev class and struct sys_device used for power management in the OMAP's GPIO code with a struct syscore_ops object which is simpler. Signed-off-by: Rafael J. Wysocki r...@sisk.pl Acked-by: Kevin Hilman khil...@ti.com --- arch/arm/plat-omap

[PATCH 11/14] PM / AVR32: Use struct syscore_ops instead of sysdevs for PM

2011-04-17 Thread Rafael J. Wysocki
From: Rafael J. Wysocki r...@sisk.pl Convert some AVR32 architecture's code to using struct syscore_ops objects for power management instead of sysdev classes and sysdevs. This simplifies the code and reduces the kernel's memory footprint. It also is necessary for removing sysdevs from

[PATCH 6/14] ARM / SA1100: Use struct syscore_ops for core power management

2011-04-17 Thread Rafael J. Wysocki
From: Rafael J. Wysocki r...@sisk.pl Replace the sysdev class and struct sys_device used for power management by the SA1100 interrupt-handling code with a struct syscore_ops object which is simpler. Signed-off-by: Rafael J. Wysocki r...@sisk.pl --- arch/arm/mach-sa1100/irq.c | 19

[PATCH 8/14] ARM / Samsung: Use struct syscore_ops for core power management

2011-04-17 Thread Rafael J. Wysocki
From: Rafael J. Wysocki r...@sisk.pl Replace sysdev classes and struct sys_device objects used for core power management by Samsung platforms with struct syscore_ops objects that are simpler. This generally reduces the code size and the kernel memory footprint. It also is necessary for removing

Re: [PATCH/RFC 0/6] ARM: runtime PM: consolidate runtime PM implementations

2011-04-07 Thread Rafael J. Wysocki
On Thursday, April 07, 2011, Kevin Hilman wrote: Kevin Hilman khil...@ti.com writes: [...] Replacing the PM ops for all devices was done on OMAP and SH-mobile because that was the only approach we had. Now that we have device power domains (thanks Rafael!), we can be more selective

Re: [PATCH/RFC 4/6] ARM: move SH-mobile runtime PM to arm/common for sharing with other platforms

2011-04-07 Thread Rafael J. Wysocki
On Thursday, April 07, 2011, Kevin Hilman wrote: Paul Mundt let...@linux-sh.org writes: On Wed, Apr 06, 2011 at 05:02:47PM -0700, Kevin Hilman wrote: There is really nothing SH-mobile specific about this runtime PM implementation. Any platform wanting to implement runtime PM based on

Re: [PATCH/RFC 0/6] ARM: runtime PM: consolidate runtime PM implementations

2011-04-06 Thread Rafael J. Wysocki
On Thursday, April 07, 2011, Kevin Hilman wrote: This series aims to consolidate OMAP and SH-mobile runtime PM implementations around the new device power domains. In 2.6.39, device power domains were added (commit 7538e3db6e015e890825fbd9f8659952896ddd5b, PM: add support for device power

Re: [PATCH 6/7] ARM / Samsung: Use struct syscore_ops for core power management

2011-03-28 Thread Rafael J. Wysocki
On Monday, March 28, 2011, Ben Dooks wrote: On Mon, Mar 28, 2011 at 01:29:49AM +0200, Rafael J. Wysocki wrote: From: Rafael J. Wysocki r...@sisk.pl Replace sysdev classes and struct sys_device objects used for core power management by Samsung platforms with struct syscore_ops objects

[PATCH 3/7] ARM / Integrator: Use struct syscore_ops for core power management

2011-03-27 Thread Rafael J. Wysocki
From: Rafael J. Wysocki r...@sisk.pl Replace the sysdev class and struct sys_device used for power management by the Integrator interrupt-handling code with a struct syscore_ops object which is simpler. Signed-off-by: Rafael J. Wysocki r...@sisk.pl --- arch/arm/mach-integrator/integrator_ap.c

[PATCH 2/7] ARM / OMAP: Use struct syscore_ops for core power management

2011-03-27 Thread Rafael J. Wysocki
From: Rafael J. Wysocki r...@sisk.pl Replace the sysdev class and struct sys_device used for power management in the OMAP's GPIO code with a struct syscore_ops object which is simpler. Signed-off-by: Rafael J. Wysocki r...@sisk.pl --- arch/arm/plat-omap/gpio.c | 35

[PATCH 0/7] ARM: Use syscore_ops for core power management

2011-03-27 Thread Rafael J. Wysocki
Hi, There are multiple problems with sysdevs, or struct sys_device objects to be precise, that are so annoying that some people have started to think of removind them entirely from the kernel. To me, personally, the most obvious issue is the way sysdevs are used for defining suspend/resume

[PATCH 5/7] ARM / PXA: Use struct syscore_ops for core power management

2011-03-27 Thread Rafael J. Wysocki
From: Rafael J. Wysocki r...@sisk.pl Replace sysdev classes and struct sys_device objects used for core power management by the PXA platform code with struct syscore_ops objects that are simpler. This reduces the code size and the kernel memory footprint. It also is necessary for removing

[PATCH 7/7] ARM: Select CONFIG_ARCH_NO_SYSDEV_OPS

2011-03-27 Thread Rafael J. Wysocki
From: Rafael J. Wysocki r...@sisk.pl Make the ARM architecture select CONFIG_ARCH_NO_SYSDEV_OPS to indicate that sysdevs are not used for power management any more on this architecture. Signed-off-by: Rafael J. Wysocki r...@sisk.pl --- arch/arm/Kconfig |1 + 1 file changed, 1 insertion

[PATCH 6/7] ARM / Samsung: Use struct syscore_ops for core power management

2011-03-27 Thread Rafael J. Wysocki
From: Rafael J. Wysocki r...@sisk.pl Replace sysdev classes and struct sys_device objects used for core power management by Samsung platforms with struct syscore_ops objects that are simpler. This generally reduces the code size and the kernel memory footprint. It also is necessary for removing

[PATCH 1/7] ARM: Use struct syscore_ops instead of sysdevs for PM in common code

2011-03-27 Thread Rafael J. Wysocki
From: Rafael J. Wysocki r...@sisk.pl Convert some ARM architecture's common code to using struct syscore_ops objects for power management instead of sysdev classes and sysdevs. This simplifies the code and reduces the kernel's memory footprint. It also is necessary for removing sysdevs from

<    1   2   3   4   >