Re: [PATCH 5/5] iommu/omap: Fix map protection value handling

2014-03-13 Thread Suman Anna
-elsz should be set as MMU_RAM_ELSZ_NONE (I am not too familiar with the Camera usage, so you are probably in a better place than me). If you are good, then with the e-valid change, Acked-by: Suman Anna s-a...@ti.com regards Suman return iopgsz_to_bytes(e-pgsz); } @@ -1041,7 +1040,7

Re: [PATCH 0/5] OMAP IOMMU fixes and IOMMU architecture questions

2014-03-13 Thread Suman Anna
Hi Laurent, On 03/07/2014 06:46 PM, Laurent Pinchart wrote: Hello, This patch set fixes miscellaneous issues with the OMAP IOMMU driver, found when trying to port the OMAP3 ISP away from omap-iovmm to the ARM DMA API. The biggest issue is fixed by patch 5/5, while the other patches fix smaller

Re: [PATCH 1/5] iommu/omap: Use the cache cleaning API

2014-03-13 Thread Suman Anna
Hi Laurent, On 03/07/2014 06:46 PM, Laurent Pinchart wrote: The page table entries must be cleaned from the cache before being accessed by the IOMMU. Instead of implementing cache management manually (and ignoring L2 cache), use clean_dcache_area() to make sure the entries are visible to the

Re: [PATCH 00/10] arch/arm OMAP IOMMU patches for 3.15

2014-03-12 Thread Suman Anna
On 03/12/2014 12:04 PM, Tony Lindgren wrote: * Suman Anna s-a...@ti.com [140311 14:52]: Hi Paul, On 03/05/2014 06:24 PM, Suman Anna wrote: Hi Paul, Benoit, This is a repost as per Tony's request [3] of all the OMAP IOMMU DT support patches that are under arch/arm. The series just assimilates

Re: [PATCH 00/10] arch/arm OMAP IOMMU patches for 3.15

2014-03-11 Thread Suman Anna
Hi Paul, On 03/05/2014 06:24 PM, Suman Anna wrote: Hi Paul, Benoit, This is a repost as per Tony's request [3] of all the OMAP IOMMU DT support patches that are under arch/arm. The series just assimilates patches 8 through 13 from the v3 OMAP IOMMU DT adaptation for 3.15 series [1], and all

Re: [PATCHv3 00/13] OMAP IOMMU DT adaptation for 3.15

2014-03-05 Thread Suman Anna
Tony, On 03/05/2014 01:33 PM, Tony Lindgren wrote: * Suman Anna s-a...@ti.com [140304 09:03]: On 03/04/2014 10:04 AM, Joerg Roedel wrote: Applied patches 1-7 to my arm/omap branch. Tony, you can pull that branch into your tree if needed (when I pushed it, which will happen today or tomorrow

[PATCH 08/10] ARM: dts: OMAP3: Add IVA IOMMU node

2014-03-05 Thread Suman Anna
: split the entry and disable the node] Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/boot/dts/omap3.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi index f7a47e3..9574a9e 100644 --- a/arch/arm/boot/dts/omap3.dtsi

[PATCH 07/10] ARM: dts: OMAP3: Update ISP IOMMU node

2014-03-05 Thread Suman Anna
From: Florian Vaussard florian.vauss...@epfl.ch Update the IOMMU node for the camera subsystem as per the OMAP IOMMU bindings. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch [s-a...@ti.com: corrected interrupt number] Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/boot/dts/omap3

[PATCH 04/10] ARM: OMAP2+: use pdata quirks for iommu reset lines

2014-03-05 Thread Suman Anna
portions are decoupled from omap_hwmod/omap_device into a separate reset driver. This patch adds the pdata quirks for the reset management of iommus within the DSP (OMAP3 OMAP4) and IPU subsystems (OMAP4). Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/mach-omap2/pdata-quirks.c | 20

[PATCH 09/10] ARM: dts: OMAP4: Add IOMMU nodes

2014-03-05 Thread Suman Anna
back addition] Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/boot/dts/omap4.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi index d3f8a6e..2b88d97 100644 --- a/arch/arm/boot/dts/omap4.dtsi +++ b/arch/arm/boot

[PATCH 10/10] ARM: dts: OMAP5: Add IOMMU nodes

2014-03-05 Thread Suman Anna
The IOMMU DT nodes have been added for the DSP and IPU subsystems. The MMUs in OMAP5 are identical to those in OMAP4, including the bus error back capability on IPU. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/boot/dts/omap5.dtsi | 15 +++ 1 file changed, 15 insertions

[PATCH 02/10] ARM: OMAP3: fix iva mmu programming issues

2014-03-05 Thread Suman Anna
, and there is no automatic power domain switching to ON. Cc: Paul Walmsley p...@pwsan.com Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/mach-omap2/clockdomains3xxx_data.c | 2 +- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff

[PATCH 01/10] ARM: OMAP3: remove deprecated CONFIG_OMAP_IOMMU_IVA2

2014-03-05 Thread Suman Anna
. Cc: Paul Walmsley p...@pwsan.com Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch [s-a...@ti.com: revise commit log] Signed-off-by: Suman Anna s-a...@ti.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Tony Lindgren t...@atomide.com Acked-by: Paul Walmsley p

[PATCH 00/10] arch/arm OMAP IOMMU patches for 3.15

2014-03-05 Thread Suman Anna
://marc.info/?l=linux-omapm=139362062805816w=2 [3] http://marc.info/?l=linux-omapm=139404802021252w=2 Florian Vaussard (4): ARM: OMAP3: remove deprecated CONFIG_OMAP_IOMMU_IVA2 ARM: dts: OMAP3: Update ISP IOMMU node ARM: dts: OMAP3: Add IVA IOMMU node ARM: dts: OMAP4: Add IOMMU nodes Suman Anna (6

[PATCH 05/10] ARM: OMAP5: hwmod data: add mmu data for ipu dsp

2014-03-05 Thread Suman Anna
A new MMU hwmod class and data structures are created to represent the MMUs within the IPU and DSP processor subsystems in OMAP5. The MMUs in OMAP5 are identical to those in OMAP4. Cc: Paul Walmsley p...@pwsan.com Cc: Benoit Cousson bcous...@baylibre.com Signed-off-by: Suman Anna s-a...@ti.com

[PATCH 03/10] ARM: OMAP2+: change the ISP device archdata MMU name for DT

2014-03-05 Thread Suman Anna
users have been converted to DT nodes. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/mach-omap2/devices.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c index 0dd6398..e58609b 100644 --- a/arch/arm/mach-omap2/devices.c

[PATCH 06/10] ARM: OMAP2+: extend iommu pdata-quirks to OMAP5

2014-03-05 Thread Suman Anna
OMAP5 has the same iommus as OMAP4, so extend the OMAP4 iommu pdata quirks for OMAP5 as well. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/mach-omap2/pdata-quirks.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/mach-omap2/pdata-quirks.c b/arch/arm/mach-omap2/pdata

Re: [PATCHv3 00/13] OMAP IOMMU DT adaptation for 3.15

2014-03-04 Thread Suman Anna
On 03/04/2014 10:04 AM, Joerg Roedel wrote: On Fri, Feb 28, 2014 at 03:00:00PM -0800, Tony Lindgren wrote: * Suman Anna s-a...@ti.com [140228 12:46]: Hi Joerg, Tony, This is an updated series of the OMAP IOMMU DT adaptation intended for 3.15 merge window, addressing the comments from the v2

Re: [PATCHv3 00/13] OMAP IOMMU DT adaptation for 3.15

2014-03-04 Thread Suman Anna
On 03/04/2014 10:04 AM, Joerg Roedel wrote: On Fri, Feb 28, 2014 at 03:00:00PM -0800, Tony Lindgren wrote: * Suman Anna s-a...@ti.com [140228 12:46]: Hi Joerg, Tony, This is an updated series of the OMAP IOMMU DT adaptation intended for 3.15 merge window, addressing the comments from the v2

Re: [PATCHv4 4/7] hwspinlock/core: add common OF helpers

2014-03-04 Thread Suman Anna
Hi Ohad, On 03/02/2014 02:19 PM, Bjorn Andersson wrote: On Sat, Mar 1, 2014 at 9:14 PM, Ohad Ben-Cohen o...@wizery.com wrote: On Mon, Feb 10, 2014 at 9:14 PM, Suman Anna s-a...@ti.com wrote: On 02/07/2014 04:49 PM, Bjorn Andersson wrote: It seems to be standard practice to pass the error

Re: [PATCHv4 4/7] hwspinlock/core: add common OF helpers

2014-03-03 Thread Suman Anna
Ohad, On 03/02/2014 02:19 PM, Bjorn Andersson wrote: On Sat, Mar 1, 2014 at 9:14 PM, Ohad Ben-Cohen o...@wizery.com wrote: On Mon, Feb 10, 2014 at 9:14 PM, Suman Anna s-a...@ti.com wrote: On 02/07/2014 04:49 PM, Bjorn Andersson wrote: It seems to be standard practice to pass the error value

Re: [PATCHv3 00/13] OMAP IOMMU DT adaptation for 3.15

2014-03-02 Thread Suman Anna
Tony, On 02/28/2014 05:00 PM, Tony Lindgren wrote: * Suman Anna s-a...@ti.com [140228 12:46]: Hi Joerg, Tony, This is an updated series of the OMAP IOMMU DT adaptation intended for 3.15 merge window, addressing the comments from the v2 series. This series is rebased onto 3.14-rc4

Re: [PATCHv2 08/16] ARM: OMAP3: remove deprecated CONFIG_OMAP_IOMMU_IVA2

2014-02-28 Thread Suman Anna
Paul, On 02/28/2014 01:58 PM, Paul Walmsley wrote: On Thu, 13 Feb 2014, Suman Anna wrote: From: Florian Vaussard florian.vauss...@epfl.ch CONFIG_OMAP_IOMMU_IVA2 was defined originally to avoid conflicting usage by tidspbridge and other iommu users. The same can be achieved by marking the DT

[PATCHv3 01/13] iommu/omap: convert to devm_* interfaces

2014-02-28 Thread Suman Anna
Use the various devm_ interfaces to simplify the cleanup in probe and remove functions. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch Signed-off-by: Suman Anna s-a...@ti.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/iommu/omap-iommu.c | 52

[PATCHv3 00/13] OMAP IOMMU DT adaptation for 3.15

2014-02-28 Thread Suman Anna
deprecated CONFIG_OMAP_IOMMU_IVA2 Laurent Pinchart (1): iommu/omap: allocate archdata on the fly for DT-based devices Suman Anna (8): iommu/omap: convert to devm_* interfaces iommu/omap: fix error return paths in omap_iommu_attach() iommu/omap: enable bus-error back on supported iommus ARM

[PATCHv3 03/13] iommu/omap: allow enable/disable even without pdata

2014-02-28 Thread Suman Anna
-quirks as a transitional solution. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch Signed-off-by: Suman Anna s-a...@ti.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/iommu/omap-iommu.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff

[PATCHv3 02/13] iommu/omap: fix error return paths in omap_iommu_attach()

2014-02-28 Thread Suman Anna
-by: Suman Anna s-a...@ti.com --- drivers/iommu/omap-iommu.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c index fff2ffd..647e4ba 100644 --- a/drivers/iommu/omap-iommu.c +++ b/drivers/iommu/omap-iommu.c @@ -863,7 +863,7

[PATCHv3 04/13] Documentation: dt: add OMAP iommu bindings

2014-02-28 Thread Suman Anna
-err-back'. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch [s-a...@ti.com: split bindings document, add dra7 and bus error back] Signed-off-by: Suman Anna s-a...@ti.com --- .../devicetree/bindings/iommu/ti,omap-iommu.txt| 26 ++ 1 file changed, 26 insertions

[PATCHv3 06/13] iommu/omap: enable bus-error back on supported iommus

2014-02-28 Thread Suman Anna
it as a bus fault and provide additional debug information. This feature is turned on by default by the driver on iommus supporting it. Signed-off-by: Subramaniam Chanderashekarapuram subramaniam...@ti.com Signed-off-by: Suman Anna s-a...@ti.com --- drivers/iommu/omap-iommu.c | 2 ++ drivers/iommu/omap

[PATCHv3 05/13] iommu/omap: add devicetree support

2014-02-28 Thread Suman Anna
. Convert it! The legacy boot mode is still supported until OMAP3 is converted to DT-boot only. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch [s-a...@ti.com: dev_name adaptation and improved error checking] Signed-off-by: Suman Anna s-a...@ti.com [t...@atomide.com: Ack for arch/arm/*omap

[PATCHv3 10/13] ARM: OMAP2+: change the ISP device archdata MMU name for DT

2014-02-28 Thread Suman Anna
users have been converted to DT nodes. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/mach-omap2/devices.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c index 0dd6398..e58609b 100644 --- a/arch/arm/mach-omap2/devices.c

[PATCHv3 08/13] ARM: OMAP3: remove deprecated CONFIG_OMAP_IOMMU_IVA2

2014-02-28 Thread Suman Anna
. Cc: Paul Walmsley p...@pwsan.com Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch [s-a...@ti.com: revise commit log] Signed-off-by: Suman Anna s-a...@ti.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Tony Lindgren t...@atomide.com Acked-by: Paul Walmsley p

[PATCHv3 09/13] ARM: OMAP3: fix iva mmu programming issues

2014-02-28 Thread Suman Anna
, and there is no automatic power domain switching to ON. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/mach-omap2/clockdomains3xxx_data.c | 2 +- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2

[PATCHv3 13/13] ARM: OMAP2+: extend iommu pdata-quirks to OMAP5

2014-02-28 Thread Suman Anna
OMAP5 has the same iommus as OMAP4, so extend the OMAP4 iommu pdata quirks for OMAP5 as well. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/mach-omap2/pdata-quirks.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/mach-omap2/pdata-quirks.c b/arch/arm/mach-omap2/pdata

[PATCHv3 07/13] iommu/omap: allocate archdata on the fly for DT-based devices

2014-02-28 Thread Suman Anna
...@ideasonboard.com [s-a...@ti.com: updated to use device name instead of OF name] Signed-off-by: Suman Anna s-a...@ti.com --- drivers/iommu/omap-iommu.c | 45 + 1 file changed, 45 insertions(+) diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap

[PATCHv3 11/13] ARM: OMAP2+: use pdata quirks for iommu reset lines

2014-02-28 Thread Suman Anna
portions are decoupled from omap_hwmod/omap_device into a separate reset driver. This patch adds the pdata quirks for the reset management of iommus within the DSP (OMAP3 OMAP4) and IPU subsystems (OMAP4). Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/mach-omap2/pdata-quirks.c | 20

[PATCHv3 12/13] ARM: OMAP5: hwmod data: add mmu data for ipu dsp

2014-02-28 Thread Suman Anna
A new MMU hwmod class and data structures are created to represent the MMUs within the IPU and DSP processor subsystems in OMAP5. The MMUs in OMAP5 are identical to those in OMAP4. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 83

[PATCHv2 1/4] ARM: dts: OMAP3: Update ISP IOMMU node

2014-02-28 Thread Suman Anna
From: Florian Vaussard florian.vauss...@epfl.ch Update the IOMMU node for the camera subsystem as per the OMAP IOMMU bindings. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch [s-a...@ti.com: corrected interrupt number] Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/boot/dts/omap3

[PATCHv2 0/4] OMAP IOMMU DTS nodes

2014-02-28 Thread Suman Anna
of driver DT adaptation series. http://marc.info/?l=linux-omapm=139231582217147w=2 Florian Vaussard (3): ARM: dts: OMAP3: Update ISP IOMMU node ARM: dts: OMAP3: Add IVA IOMMU node ARM: dts: OMAP4: Add IOMMU nodes Suman Anna (1): ARM: dts: OMAP5: Add IOMMU nodes arch/arm/boot/dts/omap3.dtsi | 15

[PATCHv2 4/4] ARM: dts: OMAP5: Add IOMMU nodes

2014-02-28 Thread Suman Anna
The IOMMU DT nodes have been added for the DSP and IPU subsystems. The MMUs in OMAP5 are identical to those in OMAP4, including the bus error back capability on IPU. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/boot/dts/omap5.dtsi | 15 +++ 1 file changed, 15 insertions

[PATCHv2 2/4] ARM: dts: OMAP3: Add IVA IOMMU node

2014-02-28 Thread Suman Anna
: split the entry and disable the node] Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/boot/dts/omap3.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi index f7a47e3..9574a9e 100644 --- a/arch/arm/boot/dts/omap3.dtsi

[PATCHv2 3/4] ARM: dts: OMAP4: Add IOMMU nodes

2014-02-28 Thread Suman Anna
back addition] Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/boot/dts/omap4.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi index d3f8a6e..ab7be95 100644 --- a/arch/arm/boot/dts/omap4.dtsi +++ b/arch/arm/boot

Re: [PATCHv2 02/16] iommu/omap: omap_iommu_attach() should return ENODEV, not NULL

2014-02-26 Thread Suman Anna
Hi Laurent, On Tuesday 25 February 2014 16:32:03 Suman Anna wrote: On 02/25/2014 03:13 PM, Laurent Pinchart wrote: On Thursday 13 February 2014 12:15:33 Suman Anna wrote: From: Florian Vaussard florian.vauss...@epfl.ch omap_iommu_attach() returns NULL or ERR_PTR in case of error

Re: [PATCHv2 03/16] Documentation: dt: add OMAP iommu bindings

2014-02-26 Thread Suman Anna
Hi Laurent, On 02/25/2014 08:13 PM, Laurent Pinchart wrote: Hi Suman, On Tuesday 25 February 2014 17:02:35 Suman Anna wrote: On 02/25/2014 03:26 PM, Laurent Pinchart wrote: On Thursday 13 February 2014 12:15:34 Suman Anna wrote: From: Florian Vaussard florian.vauss...@epfl.ch This patch

Re: [PATCHv2 14/16] ARM: OMAP3: hwmod data: cleanup data for IOMMUs

2014-02-26 Thread Suman Anna
Tony, On 02/26/2014 11:18 AM, Tony Lindgren wrote: * Suman Anna s-a...@ti.com [140213 10:19]: From: Florian Vaussard florian.vauss...@epfl.ch The irq numbers, ocp address space and device attribute data have all been cleaned up for OMAP3 IOMMUs. All this data is populated via

Re: [PATCHv2 10/16] ARM: OMAP2+: use pdata quirks for iommu reset lines

2014-02-26 Thread Suman Anna
Hi Tony, On 02/26/2014 11:17 AM, Tony Lindgren wrote: * Suman Anna s-a...@ti.com [140213 10:19]: The OMAP iommu driver performs the reset management for the iommu instances in processor sub-systems using the omap_device API which are currently supplied as platform data ops. Use pdata quirks

Re: [PATCHv2 03/16] Documentation: dt: add OMAP iommu bindings

2014-02-26 Thread Suman Anna
Hi Laurent, On Wednesday 26 February 2014 11:02:24 Suman Anna wrote: On 02/25/2014 08:13 PM, Laurent Pinchart wrote: On Tuesday 25 February 2014 17:02:35 Suman Anna wrote: On 02/25/2014 03:26 PM, Laurent Pinchart wrote: On Thursday 13 February 2014 12:15:34 Suman Anna wrote: From: Florian

Re: [PATCH 3/4] ARM: dts: OMAP4: Add IOMMU nodes

2014-02-26 Thread Suman Anna
Hi Laurent, On 02/26/2014 03:05 PM, Laurent Pinchart wrote: Hi Suman, Thank you for the patch. On Thursday 13 February 2014 12:22:55 Suman Anna wrote: From: Florian Vaussard florian.vauss...@epfl.ch Add the IOMMU nodes for the DSP and IPU subsystems. The external address space for DSP

Re: [PATCHv2 03/16] Documentation: dt: add OMAP iommu bindings

2014-02-26 Thread Suman Anna
Hi Laurent, On 02/26/2014 02:36 PM, Laurent Pinchart wrote: Hi Suman, On Wednesday 26 February 2014 14:23:03 Suman Anna wrote: On Wednesday 26 February 2014 11:02:24 Suman Anna wrote: On 02/25/2014 08:13 PM, Laurent Pinchart wrote: On Tuesday 25 February 2014 17:02:35 Suman Anna wrote

Re: [PATCHv2 03/16] Documentation: dt: add OMAP iommu bindings

2014-02-26 Thread Suman Anna
On 02/26/2014 04:18 PM, Suman Anna wrote: Hi Laurent, On 02/26/2014 02:36 PM, Laurent Pinchart wrote: Hi Suman, On Wednesday 26 February 2014 14:23:03 Suman Anna wrote: On Wednesday 26 February 2014 11:02:24 Suman Anna wrote: On 02/25/2014 08:13 PM, Laurent Pinchart wrote: On Tuesday 25

Re: [PATCHv2 03/16] Documentation: dt: add OMAP iommu bindings

2014-02-26 Thread Suman Anna
Hi Laurent, On Wednesday 26 February 2014 16:28:08 Suman Anna wrote: On 02/26/2014 04:18 PM, Suman Anna wrote: On 02/26/2014 02:36 PM, Laurent Pinchart wrote: On Wednesday 26 February 2014 14:23:03 Suman Anna wrote: On Wednesday 26 February 2014 11:02:24 Suman Anna wrote: On 02/25/2014 08

Re: [PATCHv2 02/16] iommu/omap: omap_iommu_attach() should return ENODEV, not NULL

2014-02-25 Thread Suman Anna
Hi Laurent, On 02/25/2014 03:13 PM, Laurent Pinchart wrote: Hi Suman, Thank you for the patch. On Thursday 13 February 2014 12:15:33 Suman Anna wrote: From: Florian Vaussard florian.vauss...@epfl.ch omap_iommu_attach() returns NULL or ERR_PTR in case of error, but omap_iommu_attach_dev

Re: [PATCHv2 07/16] iommu/omap: allow enable/disable even without pdata

2014-02-25 Thread Suman Anna
Hi Laurent, On 02/25/2014 03:15 PM, Laurent Pinchart wrote: Hi Suman, Thank you for the patch. On Thursday 13 February 2014 12:15:38 Suman Anna wrote: From: Florian Vaussard florian.vauss...@epfl.ch When booting with a devicetree, no platform data is provided. Do not prematurely exit

Re: [PATCHv2 03/16] Documentation: dt: add OMAP iommu bindings

2014-02-25 Thread Suman Anna
Hi Laurent, On 02/25/2014 03:26 PM, Laurent Pinchart wrote: Hi Suman, Thank you for the patch. On Thursday 13 February 2014 12:15:34 Suman Anna wrote: From: Florian Vaussard florian.vauss...@epfl.ch This patch adds the iommu bindings for all OMAP2+ SoCs. Apart from the standard bindings

Re: [PATCH v2 0/2] ARM: OMAP4: Fix gpmc_fck clock

2014-02-25 Thread Suman Anna
Florian, On 02/25/2014 02:10 AM, Florian Vaussard wrote: On 02/25/2014 07:26 AM, Mike Turquette wrote: Quoting Florian Vaussard (2014-02-23 21:44:25) On 02/23/2014 10:23 PM, Mike Turquette wrote: Quoting Florian Vaussard (2014-02-19 11:26:43) On 02/19/2014 05:22 PM, Tero Kristo wrote: On

Re: [GIT PULL] ARM: OMAP2+: clock/PRCM/hwmod fixes for v3.14-rc

2014-02-24 Thread Suman Anna
: [...] - Illia Smyrnov (1): ARM: OMAP4: hwmod: Fix SOFTRESET logic for OMAP4 Suman Anna (1): ARM: DRA7: hwmod data: correct the sysc data for spinlock Tomi Valkeinen (1): ARM: OMAP2+: clock: fix clkoutx2 with CLK_SET_RATE_PARENT Vaibhav Bedia (1): ARM: OMAP5

Re: [PATCHv2 03/16] Documentation: dt: add OMAP iommu bindings

2014-02-24 Thread Suman Anna
Mark, Kumar, Rob, On 02/13/2014 07:15 PM, Suman Anna wrote: From: Florian Vaussard florian.vauss...@epfl.ch This patch adds the iommu bindings for all OMAP2+ SoCs. Apart from the standard bindings used by OMAP peripherals, this patch uses a 'dma-window' (already used by Tegra SMMU) and adds

Re: [PATCHv4 0/7] omap hwspinlock dt support

2014-02-24 Thread Suman Anna
Mark, Ohad, On 02/10/2014 01:27 PM, Suman Anna wrote: Mark, On 01/13/2014 06:19 PM, Suman Anna wrote: Hi, This is an updated series mainly addressing Mark Rutland's comments about hwlock specifier being always one-cell. The series adds the support for #hwlock-cells property and adds a simple

[PATCHv2 10/16] ARM: OMAP2+: use pdata quirks for iommu reset lines

2014-02-13 Thread Suman Anna
portions are decoupled from omap_hwmod/omap_device into a separate reset driver. This patch adds the pdata quirks for the reset management of iommus within the DSP (OMAP3 OMAP4) and IPU subsystems (OMAP4). Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/mach-omap2/pdata-quirks.c | 20

[PATCHv2 02/16] iommu/omap: omap_iommu_attach() should return ENODEV, not NULL

2014-02-13 Thread Suman Anna
the pointer. In such case, omap_iommu_attach() should return ENODEV, not NULL. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch Acked-by: Suman Anna s-a...@ti.com --- drivers/iommu/omap-iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/omap

[PATCHv2 12/16] ARM: OMAP5: hwmod data: add mmu data for ipu dsp

2014-02-13 Thread Suman Anna
A new MMU hwmod class and data structures are created to represent the MMUs within the IPU and DSP processor subsystems in OMAP5. The MMUs in OMAP5 are identical to those in OMAP4. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 83

[PATCHv2 06/16] iommu/omap: allocate archdata on the fly for DT-based devices

2014-02-13 Thread Suman Anna
...@ideasonboard.com [s-a...@ti.com: updated to use device name instead of OF name] Signed-off-by: Suman Anna s-a...@ti.com --- drivers/iommu/omap-iommu.c | 45 + 1 file changed, 45 insertions(+) diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap

[PATCHv2 07/16] iommu/omap: allow enable/disable even without pdata

2014-02-13 Thread Suman Anna
From: Florian Vaussard florian.vauss...@epfl.ch When booting with a devicetree, no platform data is provided. Do not prematurely exit iommu_enable() and iommu_disable() in such a case. Note: As OMAP do not yet has a proper reset controller driver, IOMMUs requiring a reset signal should use

[PATCHv2 03/16] Documentation: dt: add OMAP iommu bindings

2014-02-13 Thread Suman Anna
-err-back'. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch [s-a...@ti.com: split bindings document, add dra7 and bus error back] Signed-off-by: Suman Anna s-a...@ti.com --- .../devicetree/bindings/iommu/ti,omap-iommu.txt| 28 ++ 1 file changed, 28 insertions

[PATCHv2 00/16] OMAP IOMMU DT adaptation and cleanup

2014-02-13 Thread Suman Anna
Pinchart (1): iommu/omap: allocate archdata on the fly for DT-based devices Suman Anna (7): iommu/omap: convert to devm_* interfaces iommu/omap: enable bus-error back on supported iommus ARM: OMAP2+: change the ISP device archdata MMU name ARM: OMAP2+: use pdata quirks for iommu reset lines

[PATCHv2 01/16] iommu/omap: convert to devm_* interfaces

2014-02-13 Thread Suman Anna
Use the various devm_ interfaces to simplify the cleanup in probe and remove functions. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch Signed-off-by: Suman Anna s-a...@ti.com --- drivers/iommu/omap-iommu.c | 52 +- 1 file changed, 10

[PATCHv2 04/16] iommu/omap: add devicetree support

2014-02-13 Thread Suman Anna
. Convert it! Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch [s-a...@ti.com: dev_name adaptation and improved error checking] Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/mach-omap2/omap-iommu.c | 5 + drivers/iommu/omap-iommu.c | 41

[PATCHv2 15/16] ARM: OMAP4: hwmod data: cleanup data for IOMMUs

2014-02-13 Thread Suman Anna
From: Florian Vaussard florian.vauss...@epfl.ch The device attribute data and ocp address space have all been cleaned up for OMAP4 iommus. All this data is populated via the corresponding dt node. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch Signed-off-by: Suman Anna s-a...@ti.com

[PATCHv2 16/16] ARM: OMAP2+: Remove legacy omap-iommu.c

2014-02-13 Thread Suman Anna
From: Florian Vaussard florian.vauss...@epfl.ch With full DT boot, the legacy mode of platform device creation for OMAP IOMMUs is not needed anymore. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/mach-omap2/Makefile | 3 -- arch/arm/mach-omap2/omap-iommu.c | 79

[PATCHv2 11/16] ARM: OMAP3: fix iva mmu programming issues

2014-02-13 Thread Suman Anna
, and there is no automatic power domain switching to ON. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/mach-omap2/clockdomains3xxx_data.c | 2 +- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2

[PATCHv2 13/16] ARM: OMAP2+: extend iommu pdata-quirks to OMAP5

2014-02-13 Thread Suman Anna
OMAP5 has the same iommus as OMAP4, so extend the OMAP4 iommu pdata quirks for OMAP5 as well. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/mach-omap2/pdata-quirks.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/mach-omap2/pdata-quirks.c b/arch/arm/mach-omap2/pdata

[PATCHv2 08/16] ARM: OMAP3: remove deprecated CONFIG_OMAP_IOMMU_IVA2

2014-02-13 Thread Suman Anna
. Cc: Paul Walmsley p...@pwsan.com Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch [s-a...@ti.com: revise commit log] Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 8 arch/arm/plat-omap/Kconfig | 3 --- 2 files changed, 11

[PATCH 4/4] ARM: dts: OMAP5: Add IOMMU nodes

2014-02-13 Thread Suman Anna
The IOMMU DT nodes have been added for the DSP and IPU subsystems. The MMUs in OMAP5 are identical to those in OMAP4, including the bus error back capability on IPU. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/boot/dts/omap5.dtsi | 17 + 1 file changed, 17 insertions

[PATCH 3/4] ARM: dts: OMAP4: Add IOMMU nodes

2014-02-13 Thread Suman Anna
subsystem. The MMU within the IPU sub-system also supports a bus error back capability, not available on the DSP MMU. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch [s-a...@ti.com: dma-window updates and bus error back addition] Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/boot/dts

[PATCH 2/4] ARM: dts: OMAP3: Add IVA IOMMU node

2014-02-13 Thread Suman Anna
-by: Suman Anna s-a...@ti.com --- arch/arm/boot/dts/omap3.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi index ac91cc3..9607187 100644 --- a/arch/arm/boot/dts/omap3.dtsi +++ b/arch/arm/boot/dts/omap3.dtsi @@ -419,6 +419,15

[PATCH 0/4] OMAP IOMMU DTS nodes

2014-02-13 Thread Suman Anna
node ARM: dts: OMAP3: Add IVA IOMMU node ARM: dts: OMAP4: Add IOMMU nodes Suman Anna (1): ARM: dts: OMAP5: Add IOMMU nodes arch/arm/boot/dts/omap3.dtsi | 17 ++--- arch/arm/boot/dts/omap4.dtsi | 17 + arch/arm/boot/dts/omap5.dtsi | 17 + 3 files

[PATCHv2 09/16] ARM: OMAP2+: change the ISP device archdata MMU name

2014-02-13 Thread Suman Anna
forward. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/mach-omap2/devices.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c index 0dd6398..3bf0452 100644 --- a/arch/arm/mach-omap2/devices.c +++ b/arch/arm/mach

[PATCHv2 14/16] ARM: OMAP3: hwmod data: cleanup data for IOMMUs

2014-02-13 Thread Suman Anna
From: Florian Vaussard florian.vauss...@epfl.ch The irq numbers, ocp address space and device attribute data have all been cleaned up for OMAP3 IOMMUs. All this data is populated via the corresponding dt node. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch Signed-off-by: Suman Anna s

[PATCHv2 05/16] iommu/omap: enable bus-error back on supported iommus

2014-02-13 Thread Suman Anna
it as a bus fault and provide additional debug information. This feature is turned on by default by the driver on iommus supporting it. Signed-off-by: Subramaniam Chanderashekarapuram subramaniam...@ti.com Signed-off-by: Suman Anna s-a...@ti.com --- drivers/iommu/omap-iommu.c | 2 ++ drivers/iommu/omap

[PATCH 1/4] ARM: dts: OMAP3: Update ISP IOMMU node

2014-02-13 Thread Suman Anna
From: Florian Vaussard florian.vauss...@epfl.ch Update the IOMMU node for the camera subsystem as per the OMAP IOMMU bindings. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch [s-a...@ti.com: corrected interrupt number] Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/boot/dts/omap3

Re: [PATCHv4 4/7] hwspinlock/core: add common OF helpers

2014-02-10 Thread Suman Anna
Bjorn, On 02/07/2014 04:49 PM, Bjorn Andersson wrote: On Mon, Jan 13, 2014 at 4:19 PM, Suman Anna s-a...@ti.com wrote: This patch adds three new OF helper functions to use/request locks from a hwspinlock device instantiated through a device-tree blob. Nice, I ran in to the problem of needing

Re: [PATCHv4 0/7] omap hwspinlock dt support

2014-02-10 Thread Suman Anna
Mark, On 01/13/2014 06:19 PM, Suman Anna wrote: Hi, This is an updated series mainly addressing Mark Rutland's comments about hwlock specifier being always one-cell. The series adds the support for #hwlock-cells property and adds a simple default OF translate function. The DTS patches from

[UPDATED PATCHv4 6/7] hwspinlock/omap: enable module before reading SYSSTATUS register

2014-01-15 Thread Suman Anna
controlled, and it is disabled out of reset. Make sure the module is enabled and clocked before reading the SYSSTATUS register. Signed-off-by: Suman Anna s-a...@ti.com --- drivers/hwspinlock/omap_hwspinlock.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git

[PATCHv4 4/7] hwspinlock/core: add common OF helpers

2014-01-13 Thread Suman Anna
the phandle + args specifier. This function relies on the implementation providing back a relative hwlock id within the bank from the args specifier. Signed-off-by: Suman Anna s-a...@ti.com --- Documentation/hwspinlock.txt | 34 +- drivers/hwspinlock/hwspinlock_core.c

[PATCHv4 7/7] hwspinlock/omap: enable build for AM33xx, AM43xx DRA7xx

2014-01-13 Thread Suman Anna
. Signed-off-by: Suman Anna s-a...@ti.com --- drivers/hwspinlock/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwspinlock/Kconfig b/drivers/hwspinlock/Kconfig index 70637d2..3612cb5 100644 --- a/drivers/hwspinlock/Kconfig +++ b/drivers/hwspinlock/Kconfig @@ -10,7

[PATCHv4 5/7] hwspinlock/omap: add support for dt nodes

2014-01-13 Thread Suman Anna
HwSpinlock IP is present only on OMAP4 and other newer SoCs, which are all device-tree boot only. This patch adds the base support for parsing the DT nodes, and removes the code dealing with the traditional platform device instantiation. Signed-off-by: Suman Anna s-a...@ti.com [t...@atomide.com

[PATCHv4 6/7] hwspinlock/omap: enable module before reading SYSSTATUS register

2014-01-13 Thread Suman Anna
controlled, and it is disabled out of reset. Make sure the module is enabled and clocked before reading the SYSSTATUS register. Signed-off-by: Suman Anna s-a...@ti.com --- drivers/hwspinlock/omap_hwspinlock.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers

[PATCHv4 2/7] Documentation: dt: add the omap hwspinlock bindings document

2014-01-13 Thread Suman Anna
HwSpinlock IP is present only on OMAP4 and other newer SoCs, which are all device-tree boot only. This patch adds the DT bindings information for OMAP hwspinlock module. Cc: Rob Herring robh...@kernel.org Signed-off-by: Suman Anna s-a...@ti.com --- .../devicetree/bindings/hwlock/omap

[PATCHv4 1/7] Documentation: dt: add common bindings for hwspinlock

2014-01-13 Thread Suman Anna
the '#hwlock-cells' property. Note that the document is named hwlock.txt deliberately to keep it a bit more generic. Cc: Rob Herring robh...@kernel.org Signed-off-by: Suman Anna s-a...@ti.com --- .../devicetree/bindings/hwlock/hwlock.txt | 52 ++ 1 file changed, 52

[PATCHv4 3/7] hwspinlock/core: maintain a list of registered hwspinlock banks

2014-01-13 Thread Suman Anna
and a specific lock belonging to the device requested through a phandle + args approach. Signed-off-by: Suman Anna s-a...@ti.com --- Documentation/hwspinlock.txt | 2 ++ drivers/hwspinlock/hwspinlock_core.c | 51 drivers/hwspinlock/hwspinlock_internal.h | 2

[PATCHv4 0/7] omap hwspinlock dt support

2014-01-13 Thread Suman Anna
hwspinlock driver - Add OMAP4 DT node and bindings information http://marc.info/?l=linux-omapm=137823082308009w=2 Suman Anna (7): Documentation: dt: add common bindings for hwspinlock Documentation: dt: add the omap hwspinlock bindings document hwspinlock/core: maintain a list of registered

[PATCH 3/3] ARM: dts: AM4372: Add hwspinlock node

2014-01-13 Thread Suman Anna
Add the hwspinlock device tree node for AM43xx family of SoCs. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/boot/dts/am4372.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi index 974d103..81bf21f 100644

[PATCH 2/3] ARM: dts: DRA7: Add hwspinlock node

2014-01-13 Thread Suman Anna
Add the hwspinlock device tree node for DRA7 SoCs. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/boot/dts/dra7.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi index d0df4c4..672ffec 100644 --- a/arch/arm/boot/dts

[PATCH 1/3] ARM: dts: OMAP: Add #hwlock-cells property to hwspinlock nodes

2014-01-13 Thread Suman Anna
Add a new generic property #hwlock-cells to the hwspinlock DT nodes on OMAP4, OMAP5 and AM33xx. This common property allows different platform implementations to define the args specifier length. OMAP implementations will always use a value of 1. Signed-off-by: Suman Anna s-a...@ti.com --- arch

[PATCH 0/3] OMAP hwspinlock DT updates

2014-01-13 Thread Suman Anna
confusion. [1] http://marc.info/?l=linux-omapm=138433541420926w=2 [2] http://marc.info/?l=linux-omapm=138965904015225w=2 Suman Anna (3): ARM: dts: OMAP: Add #hwlock-cells property to hwspinlock nodes ARM: dts: DRA7: Add hwspinlock node ARM: dts: AM4372: Add hwspinlock node arch/arm/boot

[PATCH] ARM: DRA7: hwmod data: correct the sysc data for spinlock

2014-01-10 Thread Suman Anna
The spinlock module's SYSCONFIG register on DRA7xx does not support smart wakeup, and also does not have the CLKACTIVITY field. The sysc data for spinlock module has been appropriately fixed up to reflect the same. Cc: Ambresh K ambr...@ti.com Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm

[PATCH] ARM: AM43x: hwmod data: register spinlock OCP interface

2014-01-10 Thread Suman Anna
-off-by: Suman Anna s-a...@ti.com --- arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c index 9002fca..5c2cc80 100644 --- a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c

[PATCH] ARM: OMAP4: hwmod data: correct the idlemodes for spinlock

2013-12-23 Thread Suman Anna
The spinlock module's SYSCONFIG register does not support smart wakeup, so remove this flag from the idle modes in the spinlock hwmod definition. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH] ARM: OMAP2+: hwmod_data: fix missing OMAP_INTC_START in irq data

2013-12-23 Thread Suman Anna
of irqs in the OMAP2/3 hwmod data were misconfigured completely as they were missing this OMAP_INTC_START relative offset. Add this offset back to fix the incorrect irq data for the following modules: OMAP2 - GPMC, RNG OMAP3 - GPMC, ISP MMU IVA MMU Signed-off-by: Suman Anna s

[PATCH] ARM: dts: OMAP2: fix interrupt number for rng

2013-12-23 Thread Suman Anna
interrupt to the appropriate interrupt #52. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/boot/dts/omap2.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap2.dtsi b/arch/arm/boot/dts/omap2.dtsi index d0c5b37..5377ddf 100644 --- a/arch/arm/boot/dts

<    1   2   3   4   5   6   7   >