Re: [PATCH] watchdog: Fix omap watchdogs to enable the magic close bit

2015-02-02 Thread Wim Van Sebroeck
Hi Tony, > * Tony Lindgren [141014 12:27]: > > This allows testing the watchdog easily with distros just by > > doing pkill -9 watchdog. > > > > Reported-by: Thomas Dziedzic > > Signed-off-by: Tony Lindgren > > Wim, still not seeing this applied, did you forget about this one? I just applied

Re: [RFC 02/23] watchdog: omap_wdt: raw read and write endian fix

2013-11-17 Thread Wim Van Sebroeck
Hi Victor, Taras, > From: Victor Kamensky > > All OMAP IP blocks expect LE data, but CPU may operate in BE mode. > Need to use endian neutral functions to read/write h/w registers. > I.e instead of __raw_read[lw] and __raw_write[lw] functions code > need to use read[lw]_relaxed and write[lw]_rel

Re: [PATCH v5] watchdog: introduce retu_wdt driver

2013-02-07 Thread Wim Van Sebroeck
Hi Aaro, > Introduce Retu watchdog driver. > > Cc: linux-watch...@vger.kernel.org > Acked-by: Felipe Balbi > Acked-by: Tony Lindgren > Signed-off-by: Aaro Koskinen > Cc: Wim Van Sebroeck Added tolinux-watchdog-next. Kind regards, Wim. -- To unsubscribe from thi

Re: [PATCH 5/7] ARM: OMAP2+: WDT: move init; add read_reset_sources pdata function pointer (fwd)

2012-10-23 Thread Wim Van Sebroeck
Hi Paul, > When you have the opportunity, could you take a look at this patch, and > the subsequent patch 6/7, and ack them if you're okay with them? Signed them off, Acked-by would probably have been better :-). > We'd like to merge thse as part of a larger cleanup series through the > arm-so

Re: [PATCH 6/7] watchdog: OMAP: use standard GETBOOTSTATUS interface; use platform_data fn ptr

2012-10-23 Thread Wim Van Sebroeck
orted drivers from those functions directly. > At that point, the platform_data function pointer can be removed. > > In the short term, this patch is needed to allow the PRM code to be > removed from arch/arm/mach-omap2 (it is being moved to a driver). > > Signed-off-by: Paul Walmsley &

Re: [PATCH 5/7] ARM: OMAP2+: WDT: move init; add read_reset_sources pdata function pointer

2012-10-23 Thread Wim Van Sebroeck
gt; arch/arm/mach-omap2/devices.c. > > Signed-off-by: Paul Walmsley > Cc: Wim Van Sebroeck Signed-off-by: Wim Van Sebroeck Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH_v2] watchdog: Convert twl4030_wdt to watchdog core

2012-09-27 Thread Wim Van Sebroeck
Hi, > On 09/11/2012 09:01 AM, Jarkko Nikula wrote: > >Convert the twl4030_wdt watchdog driver to watchdog core. > > > >While at there use devm_kzalloc and set the default timeout in order to be > >able test this driver with a simple shell script. > > > >Signed-off-by: Jarkko Nikula > >Tested-by: A

Re: [PATCH 15/17] ARM: OMAP: Split plat/hardware.h, use local soc.h for omap2+

2012-09-11 Thread Wim Van Sebroeck
le at it, also sort some of the includes in the standard way. > > Cc: linux-watch...@vger.kernel.org > Cc: Wim Van Sebroeck Acked-by for the watchdog part. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv2 3/3] watchdog: omap_wdt: add device tree support

2012-07-07 Thread Wim Van Sebroeck
Hi Tony, > Hi Wim, > > * jgq...@gmail.com [120531 20:56]: > > From: Xiao Jiang > > > > Add device table for omap_wdt to support dt. > > Care to ack this patch in the series? Yep. Acked-by: Wim Van Sebroeck Kind regards, Wim. -- To unsubscribe from this

Re: [PATCH] Watchdog: OMAP: Fix the runtime pm code to avoid module getting stuck intransition state.

2012-07-07 Thread Wim Van Sebroeck
gt; > >> Watchdong is a special IP and it should not be disabled otherwise > >> purpose of it itself is defeated. Watchdog functional clock should > >> never be disabled. This patch updates the runtime PM handling in > >> driver so that runtime PM is limited only d

Re: [PATCH] watchdog: twl4030_wdt: Watchdog device registration issue fix

2011-03-28 Thread Wim Van Sebroeck
Hi All, > Hello All, > > Any comments on this patch? > > Regards, > Keerthy > > On Wed, Mar 2, 2011 at 2:17 AM, Keerthy wrote: > > twl4030_wdt driver and omap_wdt driver are registering as misc_device name > > as > > "watchdog" and the same minor number WATCHDOG_MINOR( value = 130). > > There

Re: [PATCH v2 0/2] OMAP3: wdtimer: Fix CORE idle

2011-03-10 Thread Wim Van Sebroeck
> Paul Walmsley (2): > Watchdog: omap_wdt: add fine grain runtime-pm > OMAP3: wdtimer: Fix CORE idle transition > > arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |1 + > drivers/watchdog/omap_wdt.c| 25 +++-- > 2 files changed, 24

Re: Handling multiple watchdogs

2011-02-22 Thread Wim Van Sebroeck
Hi Alan, > > 1) make sure that we have the new watchdog core infrastructure going in for > > 2.6.32. > > This new core integrates the common code that we use over and over again. I > > once > > wrote code for it and then Alan had different ideas and thoughts and wrote > > his updated > > code.

Re: [PATCH v5 6/6] OMAP: WDT: Use PM runtime APIs instead of clk FW APIs

2010-09-15 Thread Wim Van Sebroeck
Hi All, > Call runtime pm APIs pm_runtime_put_sync() and pm_runtime_get_sync() > for enabling/disabling the clocks, sysconfig settings instead of using > clock FW APIs. > > Signed-off-by: Charulatha V This is all omap specific code. So if Kevin and Tony are fine with the code then tou gave my

Re: [PATCH] twl4030_wdt: Disable watchdog while probing

2010-05-20 Thread Wim Van Sebroeck
Hi Timo, > It seems that in this patch, you disable the watchdog regardless whether > the registration fails or not. I wonder if this is a good thing to do. > What if the bootloader have already enabled the watchdog and then user > space booting fails for some reason before any process is able to

Re: [PATCH] twl4030_wdt: Disable watchdog while probing

2010-05-19 Thread Wim Van Sebroeck
Hi Ameya, > If we are not able to register then it is better to have watchdog in disabled > state than noticing a system reboot. > > Signed-off-by: Ameya Palande This was added in my linux-2.6-watchdog-next tree. Will be sent to Linus for mainline inclusion in a couple of days. Kind regards, W

Re: [RFC] [PATCH] watchdog_info separation and constify

2010-01-19 Thread Wim Van Sebroeck
Hi Alan, > > please comment on following patch. > > Why move them out - why not just make them const ? There's 2 options: 1) we only make them const now. And we move them out later when we do the conversion to the generic watchdog api (which means that we will rip out the code for the open, re

[RFC] [PATCH] watchdog_info separation and constify

2010-01-19 Thread Wim Van Sebroeck
Hi All, please comment on following patch. Kind regards, Wim. commit 88d0b1a9c071d26e7b4831320067c84b04ea04a8 Author: Wim Van Sebroeck Date: Sat Dec 26 18:55:22 2009 + [WATCHDOG] watchdog_info separation and constify make sure that the watchdog_info struct is seperated from

Re: Handling multiple watchdogs

2009-07-22 Thread Wim Van Sebroeck
Hi Simon, > > I have two watchdogs on my board that I both want to handle. What would > > be the proper approach in this case? > > Fixing the watchdog core to create a class of watchdog drivers and > treating the existing /dev/watchdog as a back compatibility hack. It's > been talked about for a

Re: [PATCH 0/2] watchdog:OMAP3:Add support for IVA2, SECURE WDTs

2009-07-22 Thread Wim Van Sebroeck
Hi Ulrik, > This patch series enables support for IVA2 and SECURE > WDTs, available on omap34xx. > The WDTs will be accessible (when present on device) through: > MPU: /dev/watchdog > SECURE: /dev/watchdog_secure > IVA2: /dev/watchdog_iva2 > > Tested on Zoom1 OMAP3 platform, compile-tested

Re: [PATCH 1/1] watchdog: OMAP fixes: enable clock in probe, trigger timer reload

2009-06-18 Thread Wim Van Sebroeck
Hi Ulrik, > This patch contains two bugfixes: > > 1)In omap_wdt_probe() the watchdog is reset and disabled. This > requires register access and the clks needs to be enabled temporarily > > 2)In omap_wdt_open() the timer register needs to be reloaded > to trigger a new timer value (the default of

Re: [PATCH 1/2] omap: twl4030_wdt: twl4030 watchdog driver

2009-06-04 Thread Wim Van Sebroeck
Date: Fri Mar 27 16:42:17 2009 +0200 [WATCHDOG] twl4030 watchdog driver Implementation of twl4030 watchdog driver. Signed-off-by: Timo Kokkonen Signed-off-by: Atal Shargorodsky Signed-off-by: Wim Van Sebroeck diff --git a/drivers/mfd/twl4030-core.c b/drivers

Re: [PATCH 35/58] move omap_wdt's probe function to .devinit.text

2009-03-29 Thread Wim Van Sebroeck
Hi Uwe, > A pointer to omap_wdt_probe is passed to the core via > platform_driver_register and so the function must not disappear when the > .init sections are discarded. Otherwise (if also having HOTPLUG=y) > unbinding and binding a device to the driver via sysfs will result in an > oops as does

Re: [PATCH 5/5] watchdog: introduce platform_data and remove cpu conditional code

2008-09-20 Thread Wim Van Sebroeck
Hi Russell, > Given my comments on patch 1, it's probably a good idea to resend > just 1 to 3. We can then talk about 4 and 5 some more. > > Wim - can you let me know when you merge the followup patches into your > tree please? Will add patches 1 to 3 when everyone is OK with them. I still saw

Re: [PATCH 5/5] watchdog: introduce platform_data and remove cpu conditional code

2008-09-19 Thread Wim Van Sebroeck
Hi Balbi, > Well, patches 4 and 5 should be ignored. Should I resend or could I rely > on the fact that people won't pick them up ? I will not pick them up (to add them in the watchdog tree). Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body

Re: [PATCH 1/5] watchdog: sync linux-omap changes

2008-09-19 Thread Wim Van Sebroeck
Hi Balbi, > And thanks for the review. I'll fix your comments and resend the series > ;-) Thanks because I had the same objections then Russell. Greetings, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH] watchdog: another ioremap() fix

2008-09-19 Thread Wim Van Sebroeck
Hi All, > On Thu, Sep 18, 2008 at 11:02:58PM +0300, Felipe Balbi wrote: > > Well, what can I say. I'll try to get rid of those cpu conditional code > > in the driver and sync omap_wdt.c with mainline. Send all the patches > > via Wim, so Tony can get them later. > > BTW, I'd also suggest copying

Re: [PATCH] watchdog: another ioremap() fix

2008-09-19 Thread Wim Van Sebroeck
Hi Balbi, > > > convert to use ioremap() and __raw_{read/write} friends. > > > > Why is this going to the OMAP list, not to LKML and cc'd > > the watchdog maintainer? (I added Wim to the cc list...) > > > > If it's worth having, it's worth having in mainline... > > My bad, forgot to Cc lkml. I