On Thu, 24 Dec 2015 00:34:49 +0100
Nicolas Chauvet wrote:
> 2015-12-23 22:54 GMT+01:00 David Rivshin (Allworx) <
> drivshin.allw...@gmail.com>:
>
> > On Wed, 23 Dec 2015 22:20:58 +0100
> > Nicolas Chauvet wrote:
> >
> > > 2015-12-23 1:36 GMT+01:00 Dav
On Wed, 23 Dec 2015 22:20:58 +0100
Nicolas Chauvet wrote:
> 2015-12-23 1:36 GMT+01:00 David Rivshin (Allworx) <
> drivshin.allw...@gmail.com>:
>
> > From: David Rivshin
> >
> > This series is based on the tip of the net tree.
> >
> > The first patc
On Wed, 23 Dec 2015 19:35:37 +0100
Markus Brunner wrote:
> On Wednesday 23 December 2015 12:04:25 David Miller wrote:
> > From: "David Rivshin (Allworx)"
> > Date: Tue, 22 Dec 2015 19:36:31 -0500
> >
> > > Testing by anyone who has real hardware using
From: "David Rivshin (Allworx)"
Date: Tue, 22 Dec 2015 19:36:31 -0500
> Testing by anyone who has real hardware using phy-handle or dual_emac
> with fixed-link would be appreciated.
I'm going to wait for such testing before applying this series.
Thanks.
--
To unsubscribe
From: David Rivshin
If a fixed-link DT subnode is used, the phy_device was looked up so
that a PHY ID string could be constructed and passed to phy_connect().
This is not necessary, as the device_node can be passed directly to
of_phy_connect() instead. This reuses the same codepath as if the
phy
From: David Rivshin
Commit 9e42f715264ff158478fa30eaed847f6e131366b ("drivers: net: cpsw: add
phy-handle parsing") saved the "phy-handle" phandle into a new cpsw_priv
field. However, phy connections are per-slave, so the phy_node field should
be in cpsw_slave_data rather t
From: David Rivshin
This series is based on the tip of the net tree.
The first patch fixes a bug that makes dual_emac mode break if
either slave uses the phy-handle property in the devicetree.
The second patch fixes some cosmetic problems with error messages,
and also makes the binding
From: David Rivshin
The phy-handle, phy_id, and fixed-link properties are mutually exclusive,
and only one need be specified. However if phy-handle was specified, an
error message would complain about the lack of phy_id or fixed-link.
Also, if phy-handle was specified and the subsequent
On Fri, 18 Dec 2015 11:20:21 +0100
Daniel Trautmann wrote:
> On Thu, Dec 17, 2015 at 03:45:08PM -0500, David Miller wrote:
> > From: "David Rivshin (Allworx)"
> > Date: Wed, 16 Dec 2015 23:02:08 -0500
> >
> > > I have tested on the following hardware co
From: "David Rivshin (Allworx)"
Date: Wed, 16 Dec 2015 23:02:08 -0500
> Commit 1f71e8c96fc654724723ce987e0a8b2aeb81746d ("drivers: net: cpsw:
> Add support for fixed-link PHY") added initial fixed-link PHY support
> for CPSW, but missed a few considerations.
>
&
From: "David Rivshin (Allworx)"
Date: Wed, 16 Dec 2015 23:02:08 -0500
> I have tested on the following hardware configurations:
> - (EVMSK) dual emac with two real MDIO-connected phys using RGMII-TXID
> - single emac with fixed-link using RGMII
> Testing of other CPSW em
On Wed, 16 Dec 2015 07:39:16 +0100
Markus Brunner wrote:
> On Monday 14 December 2015 13:04:46 David Rivshin wrote:
> > On Sat, 12 Dec 2015 16:44:19 +0100
> ...
> > > Your patch works fine on my board, which uses MII and dual_emac
> > > with a fixed_phy and a
From: Pascal Speck (Iktek)
Date: Fri, 04 Dec 2015 16:55:17 +0100
When using more than one slave with ti cpsw and fixed phy the pd->phy_id
will be always zero, but slave_data->phy_id must be unique. pd->phy_id
means a "phy hardware id" whereas slave_data->phy_id means an "unique id",
so we should
From: David Rivshin
When a fixed-link sub-node exists in a slave node, the slave node
is also the PHY node. Since this is a separate use of the slave node,
of_node_get() should be used to increment the reference count.
Fixes: 1f71e8c96fc6 ("drivers: net: cpsw: Add support for fixed-lin
From: David Rivshin
Commit 1f71e8c96fc654724723ce987e0a8b2aeb81746d ("drivers: net: cpsw: Add
support for fixed-link PHY") did not parse the "phy-mode" property in
the case of a fixed-link PHY, leaving slave_data->phy_if with its default
of PHY_INTERFACE_MODE_NA(0). Th
the slave node.
- Update binding documentation to no longer say that phy_mode is also
mutually exclusive with fixed-link.
- Dropped unnecessary include of phy_fixed.h.
[1] https://patchwork.ozlabs.org/patch/554989/
David Rivshin (2):
drivers: net: cpsw: fix RMII/RGMII mode when used with
On Sat, 12 Dec 2015 16:44:19 +0100
Markus Brunner wrote:
> On Wednesday 09 December 2015 22:31:15 David Rivshin wrote:
> ...
> > This patch was originally developed in parallel with 1f71e8c96fc6 to
> > accomplish the same goal. When I replaced this patch with
> > 1f71e
rnel log messages seem to indicate
that the interface is set up, there is no network communication. Eventually
a watchdog error occurs:
NETDEV WATCHDOG: eth0 (cpsw): transmit queue 0 timed out
Signed-off-by: David Rivshin (Allworx)
Fixes: 1f71e8c96fc6 ("drivers: net: cpsw: Add support for
From: Tony Lindgren
Date: Wed, 18 Nov 2015 17:27:25 -0800
> Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac
> id to common file") started using of_machine_is_compatible for detecting
> type but missed at dm8148 causing Ethernet to stop working.
>
> Let's fix the issue by
From: Markus Brunner
Date: Tue, 03 Nov 2015 22:09:51 +0100
> Add support for a fixed-link devicetree sub-node in case the the
> cpsw MAC is directly connected to a non-mdio PHY/device.
>
> Signed-off-by: Markus Brunner
Applied.
--
To unsubscribe from this list: send the line "unsubscribe lin
From: Grygorii Strashko
Date: Fri, 23 Oct 2015 14:41:12 +0300
> There is no reasons to probe cpsw from late_initcall level
> and it's not recommended. Hence, use module_platform_driver()
> to register and probe cpsw driver from module_init() level.
>
> Cc: Tony Lindgren
> Acked-by: Mugunthan V
From: Mugunthan V N
Date: Mon, 21 Sep 2015 15:56:49 +0530
> Did a boot test on dra7-evm [1] and am437x-gp-evm [2].
> Pushed a branch [3] for others to test the patch.
>
> [1]: http://pastebin.ubuntu.com/12513420/
> [2]: http://pastebin.ubuntu.com/12513428/
> [3]: git://git.ti.com/~mugunthanvnm/t
ged to signed at some point
in the future for no cost. In which case, your changing the <= to an ==
"because the < part of the case is useless" is arguably wrong.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message t
From: Mugunthan V N
Date: Mon, 7 Sep 2015 15:16:44 +0530
> In DRA72x EVM, by default slave 1 is connected to the onboard
> phy, but slave 2 pins are also muxed with video input module
> which is controlled by pcf857x gpio and currently to select slave
> 0 to connect to phy gpio hogging is used, b
From: Tony Lindgren
Date: Fri, 28 Aug 2015 11:50:15 -0700
> The interrupt handler may not be available when smsc911x probes if the
> interrupt handler is a GPIO controller for example. Let's fix that
> by adding handling for -EPROBE_DEFER.
>
> Cc: Steve Glendinning
> Signed-off-by: Tony Lindgre
From: Mugunthan V N
Date: Wed, 12 Aug 2015 15:22:52 +0530
> With commit 870915feabdc ("drivers: net: cpsw: remove
> disable_irq/enable_irq as irq can be masked from cpsw itself"),
> CPSW on AM335x beagle bone white is broken as there is a errata
> for AM335x PG1.0. This patch series implements th
ue;
I think it would be more obvious if you used a u8 and explicit bitmasks.
The initialisation (as above) would the be explicitly assigning 'not supported'
to the other fields.
The compiler will also generate much better code...
David
From: Alexander Duyck
Date: Wed, 13 May 2015 13:34:13 -0700
> When I had inlined __alloc_rx_skb into __netdev_alloc_skb and
> __napi_alloc_skb I had overlooked the fact that there was a return in the
> __alloc_rx_skb. As a result we weren't reserving headroom or setting the
> skb->dev in certain
From:
Date: Fri, 27 Feb 2015 13:19:44 +0200
> From: Grygorii Strashko
>
> Setting a dev_pm_ops suspend_late/resume_early pair but not a
> set of hibernation functions means those pm functions will
> not be called upon hibernation.
> Fix this by using SET_LATE_SYSTEM_SLEEP_PM_OPS, which appropri
From:
Date: Fri, 27 Feb 2015 13:19:45 +0200
> From: Grygorii Strashko
>
> Setting a dev_pm_ops suspend/resume pair but not a set of
> hibernation functions means those pm functions will not be
> called upon hibernation.
> Fix this by using SIMPLE_DEV_PM_OPS, which appropriately
> assigns the su
, thanks.
I did tweak the testcase to use dtbs_unordered_equal instead of going
through the set of tree1 tests.
The fact that you can only apply a single label by this method is a
bit of a wart, but it's something we can fix later. I had a look at
it and (as I suspect you already discovered
From: Tony Lindgren
Date: Wed, 28 Jan 2015 11:33:03 -0800
> Here are a few patches to add common code for cpsw and davinci_emac for
> getting the MAC address. Looks like we can also now add code to get the
> MAC address on 3517 but in a slightly different way.
Applied to net-next, thanks.
--
To
On Thu, Jan 29, 2015 at 09:07:31PM +1100, David Gibson wrote:
> On Wed, Jan 28, 2015 at 08:20:11PM +0530, Nikhil Devshatwar wrote:
> > This patch changes the dtc grammar to allow following syntax
> >
> > i2cexp: &i2c2 {
> > ...
> > };
> >
> &
sorry I didn't get around to responding to your earlier posting of
this.
The concept is good, and the implementation looks fine.
Only 2 things before I'm ready to merge:
1) It wants a testcase
2) I need to stare at the syntax for a while and convince myself
it's as good as we
From: Felipe Balbi
Date: Mon, 19 Jan 2015 11:52:36 -0600
> Commit c03abd84634d (net: ethernet: cpsw: don't requests IRQs we don't
> use) left one build breakage when NET_POLL_CONTROLLER is enabled.
>
> Fix this build break by referring to the correct irqs_table array.
>
> Fixes: c03abd84634d (n
From: Felipe Balbi
Date: Mon, 19 Jan 2015 08:40:17 -0600
> On Sun, Jan 18, 2015 at 01:07:50AM -0500, David Miller wrote:
>> From: Felipe Balbi
>> Date: Fri, 16 Jan 2015 10:11:12 -0600
>>
>> > CPSW never uses RX_THRESHOLD or MISC interrupts. In
>> > fac
From: Felipe Balbi
Date: Fri, 16 Jan 2015 10:11:11 -0600
> This patch is in preparation for a nicer IRQ
> handling scheme where we use different IRQ
> handlers for each IRQ line (as it should be).
>
> Later, we will also drop IRQs offset 0 and 3
> because they are always disabled in this driver.
From: Felipe Balbi
Date: Fri, 16 Jan 2015 10:11:12 -0600
> CPSW never uses RX_THRESHOLD or MISC interrupts. In
> fact, they are always kept masked in their appropriate
> IRQ Enable register.
>
> Instead of allocating an IRQ that never fires, it's best
> to remove that code altogether and let fut
From: Tony Lindgren
Date: Thu, 15 Jan 2015 14:45:08 -0800
> Here's a repost of the fixes for davinci_emac with patches
> updated for comments and acks collected.
Series applied, thanks Tony.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majo
From: Felipe Balbi
Date: Thu, 15 Jan 2015 19:28:52 -0600
> On Thu, Jan 15, 2015 at 06:16:15PM -0500, David Miller wrote:
>> Indeed, I agree that adding something as a placeholder that just gets
>> immediately removed should be avoided unless it is extremely difficult
>> to
From: Felipe Balbi
Date: Thu, 15 Jan 2015 09:20:53 -0600
> On Thu, Jan 15, 2015 at 01:19:16PM +0530, Mugunthan V N wrote:
>> On Wednesday 14 January 2015 10:28 PM, Felipe Balbi wrote:
>> > CPSW never uses RX_THRESHOLD or MISC interrupts. In
>> > fact, they are always kept masked in their appropri
From: Felipe Balbi
Date: Tue, 13 Jan 2015 13:44:46 -0600
> + ret = devm_request_irq(&pdev->dev, irq, cpsw_interrupt,
> + 0, dev_name(&pdev->dev), priv);
When a function call spans multiple lines, the argument on the second
and subsequent lines must start on the first colu
From: Tony Lindgren
Date: Tue, 13 Jan 2015 11:54:16 -0800
> * Tom Lendacky [150113 11:51]:
>> On 01/13/2015 01:29 PM, Tony Lindgren wrote:
>> >We only use clk_get() to get the frequency, the rest is done by
>> >the runtime PM calls. Let's free the clock too.
>> >
>> >Cc: Brian Hutchinson
>> >Cc
From: Felipe Balbi
Date: Tue, 6 Jan 2015 14:31:19 -0600
> What you're saying here is that you prefer to drop a feature that works
> for all other 1023 IDs because 1 ID is quirky. Sounds like overkill
> to me.
The other option is to software fallback only for VLAN 1.
--
To unsubscribe from this l
From: Felipe Balbi
Date: Tue, 6 Jan 2015 11:43:32 -0600
> CPSW completely hangs if we add, and later remove,
> VLAN ID #1. What happens is that after removing
> VLAN ID #1, no packets will be received by CPSW
> rendering network unusable.
>
> In order to "fix" the issue, we're returning -EINVAL
From: Felipe Balbi
Date: Fri, 2 Jan 2015 16:15:59 -0600
> The CPSW IP implements pulse-signaled interrupts. Due to
> that we must write a correct, pre-defined value to the
> CPDMA_MACEOIVECTOR register so the controller generates
> a pulse on the correct IRQ line to signal the End Of
> Interrupt.
From: Felipe Balbi
Date: Fri, 2 Jan 2015 15:53:35 -0600
> On Fri, Jan 02, 2015 at 04:45:36PM -0500, David Miller wrote:
>> You should instead submit patch #1 all by itself, correctly targetting
>> 'net'.
>>
>> Then, after the next time I merge 'net&#x
From: Felipe Balbi
Date: Fri, 2 Jan 2015 12:10:24 -0600
> In any case, patch 1 should go in during the -rc an get backported
> all the way back to v3.9, while the other patches can (should) be
> delayed for v3.20 merge window.
If that's what you want, the way you submitted these changes it not
t
From: Lokesh Vutla
Date: Thu, 4 Dec 2014 10:24:29 +0530
> CPSW is present in AM33xx, AM43xx, DRA7xx.
> Updating the Kconfig to depend on ARCH_OMAP2PLUS instead of listing
> all SoC's.
>
> Signed-off-by: Lokesh Vutla
Applied to net-next, thanks.
--
To unsubscribe from this list: send the line "
From: Tony Lindgren
Date: Mon, 27 Oct 2014 13:25:56 -0700
> +/**
> + * of_try_set_control_gpio - configure a gpio if it exists
> + */
> +static int try_toggle_control_gpio(struct device *dev,
> +struct gpio_desc **desc,
> +const char
he style of the version check.
Why not the single test:
#if GCC_VERSION < 30300 || (GCC_VERSION >= 40800 && GCC_VERSION < 40803)
#error Your compiler is too buggy; it is known to miscompile code.
#error Known good compilers: 3.3 onwards excluding 4.8.0 through 4.8.2
#endif
David
>
> int main(void)
> --
> 1.8.3.1
s it possible to compile a small code fragment and check the generated
code for the bug?
Possibly predicated on the broken version number to avoid false positives.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Markus Pargmann
Date: Mon, 29 Sep 2014 08:53:12 +0200
> Another resend of this series to add the netdev list.
>
> This series adds support to the cpsw driver to read the MACIDs of the am335x
> chip and use them as fallback. These addresses are only used if there are no
> mac addresses in t
From: Markus Pargmann
Date: Sun, 28 Sep 2014 18:59:14 +0200
> This is a resend of v6 of this series. I added the Acked-by of Tony Lindgren
> for patch 5/7. There are no other changes.
>
> This series adds support to the cpsw driver to read the MACIDs of the am335x
> chip and use them as fallback
Fix a parser-bug in the omap2 muxing code where muxtable-entries will be
wrongly selected if the requested muxname is a *prefix* of their
m0-entry and they have a matching mN-entry. Fix by additionally checking
that the length of the m0_entry is equal.
Signed-off-by: David R. Piegdon
For
From: George Cherian
Date: Fri, 2 May 2014 12:01:58 +0530
> The series adds CPTS support for AM4372.
>
> Patch 1 - DT changes w.r.t clock changes for AM33xx.
> Patch 2 - CPTS clock name harcoding in the driver is removed.
> Easier to pass the clock name from dt rather than hardcoding in
From: Ben Dooks
> On 10/04/14 11:49, Sergei Shtylyov wrote:
> > On 10-04-2014 13:20, David Laight wrote:
> >
> >>> It doesn't do any pin muxing. It switches SoC internal USB
> >>> signals between
> >>> USB controllers. The pins remai
are changing the PHY.
I'd have thought that would happen if you had a single controller
that select between multiply PHY.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More major
From: Nishanth Menon
Date: Fri, 21 Mar 2014 01:52:48 -0500
> Few platforms use external regulator to keep the ethernet MAC supplied.
> So, request and enable the regulator for driver functionality.
>
> Fixes: 66fda75f47dc (regulator: core: Replace direct ops->disable usage)
> Reported-by: Russel
From: Mugunthan V N
Date: Mon, 3 Mar 2014 16:19:06 +0530
> From: Schuyler Patton
>
> This patch fixes a CPDMA RX Descriptor leak that occurs after taking
> the interface down when the CPSW is in Dual MAC mode. Previously
> the CPSW_ALE port was left open up which causes packets to be received
>
From: Mugunthan V N
Date: Thu, 23 Jan 2014 00:03:12 +0530
> Enable promiscuous mode support for CPSW.
>
> Signed-off-by: Mugunthan V N
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo
From: Mugunthan V N
Date: Mon, 20 Jan 2014 17:38:38 +0530
> + if (!enable && ((priv->slaves[0].ndev->flags & IFF_PROMISC) ||
> + (priv->slaves[1].ndev->flags & IFF_PROMISC))) {
This assumption that there are exactly 2 slaves is not valid.
Use the appropri
From: Mugunthan V N
Date: Wed, 18 Dec 2013 21:33:50 +0530
> During checking the interrupts with "cat /proc/interrupts", it is showing
> device name as (null), this change was done with commit id aa1a15e2d where
> request_irq is changed to devm_request_irq also changing the irq name from
> platfor
From: Mugunthan V N
Date: Fri, 13 Dec 2013 18:42:55 +0530
> This patch adds support for enabling In Band mode in 10 mbps speed.
> RGMII supports 1 Gig and 100 mbps mode for Forced mode of operation.
> For 10mbps mode it should be configured to in band mode so that link
> status, duplexity and spe
On Tue, Dec 17, 2013 at 03:31:40PM -0800, David Cohen wrote:
> On Thu, Dec 12, 2013 at 03:38:38PM -0600, Felipe Balbi wrote:
> > hi all,
> >
> > these patches add pm_runtime support for all glue layers.
> >
> > I plan to add pm_runtime support for dwc3 after thes
notice you were removing #ifdef's around pm
callback functions. Instead of saying DWC3 will start to have warnings
when CONFIG_PM is not selected, I'd say your patch set is now a
dependence of my RFC :)
https://lkml.org/lkml/2013/12/13/4
Br, David Cohen
>
> Felipe Balbi (7):
>
From: Mugunthan V N
Date: Fri, 13 Dec 2013 14:35:27 +0530
> During checking the interrupts with "cat /proc/interrupts", it is showing
> device name as (null), this change was done with commit id aa1a15e2d where
> request_irq is changed to devm_request_irq also changing the irq name from
> platfor
ue->initialized)
Are you sure this is thread safe?
If you're sending this patch it means runtime_resume can be called
before omap2430_must_init(), but how about at the same time?
You defined 'initialized' as u8 type, then read/write operations won't
be atomic in ARM.
Br,
On Thu, Dec 12, 2013 at 10:17:19PM -0600, Felipe Balbi wrote:
> On Thu, Dec 12, 2013 at 05:56:05PM -0800, David Cohen wrote:
> > On Thu, Dec 12, 2013 at 03:38:41PM -0600, Felipe Balbi wrote:
> > > teach the PCI glue about pm_runtime so that
> > > it's easier to teac
On Thu, Dec 12, 2013 at 03:38:41PM -0600, Felipe Balbi wrote:
> teach the PCI glue about pm_runtime so that
> it's easier to teach dwc3 core about it
> later.
>
> No functional changes otherwise.
>
> Signed-off-by: Felipe Balbi
I was able to test this one with Intel M
From: Felipe Balbi
Date: Wed, 11 Dec 2013 22:09:05 -0600
> From: Mugunthan V N
>
> When CPSW and Davinci MDIO are build as modules, CPSW crashes when
> accessing CPSW registers in CPSW probe. The same is working in built-in
> as the CPSW clocks are enabled in Davindi MDIO probe, SO Enabling the
From: Olof Johansson
Date: Wed, 11 Dec 2013 15:51:21 -0800
> Only used locally. Found by sparse.
>
> Signed-off-by: Olof Johansson
Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at htt
From: Olof Johansson
Date: Wed, 11 Dec 2013 15:58:07 -0800
> Minor fix for printk format of a phys_addr_t, and the switch of two local
> functions to static since they're not used outside of the file.
>
> Signed-off-by: Olof Johansson
Applied.
--
To unsubscribe from this list: send the line "u
From: Olof Johansson
Date: Wed, 11 Dec 2013 15:51:20 -0800
> Silences the below warnings when building with ARM_LPAE enabled, which
> gives longer dma_addr_t by default:
>
> drivers/net/ethernet/ti/davinci_cpdma.c: In function 'cpdma_desc_pool_create':
> drivers/net/ethernet/ti/davinci_cpdma.c:1
if (musb) {
> omap2430_low_level_init(musb);
> - musb_writel(musb->mregs, OTG_INTERFSEL,
> + if (musb->context.otg_interfsel != 0)
You might want to write an inline comment explaining why you're checking
otg_interfsel for 0 here (
From: Mugunthan V N
Date: Mon, 9 Dec 2013 14:59:05 +0530
> commit 50a5fb068
This commit doesn't appear in any tree.
And any change which makes a real "struct device" return NULL
for dev_name() is broken.
I'm not applying this patch, you have completely failed to
provide any information necessa
From: Mugunthan V N
Date: Fri, 6 Dec 2013 12:28:27 +0530
> From: George Cherian
>
> Use netdev_name while requesting irq so that eth* name is shown
> in /proc/interrupts. Previously it was showing device name as (null)
> for cpsw interrupts. For using netdev_name register_netdev and then
> call
From: Tony Lindgren
Date: Tue, 3 Dec 2013 15:13:02 -0800
> When booted with device tree, we may still have platform data passed
> as auxdata. For am3517 this is needed for passing the interrupt_enable
> and interrupt_disable callbacks that access the omap system control module
> registers. These
From: Mugunthan V N
Date: Mon, 2 Dec 2013 12:53:39 +0530
> When only one port of the two port is pinned out, then dt probe is failing
> because second port phy is not found. fixing this by checking the number of
> slaves and breaking the loop.
>
> Signed-off-by: Mugunthan V N
Of course, this p
> From: Roger Quadros [mailto:rog...@ti.com]
> On 11/29/2013 03:17 PM, David Laight wrote:
...
> >> + timeout = jiffies + msecs_to_jiffies(100);
> >> + while (!(usbhs_read(omap->uhh_base, OMAP_UHH_SYSSTATUS)
> >> + & OMAP_UHH_SYSSTATUS
n't be significant.
I'm not sure of the context this code runs in, but if the reset
is likely to take a significant portion of the 100ms timeout
period, why not just sleep for a few ms between status polls.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Mugunthan V N
Date: Sun, 20 Oct 2013 12:32:26 +0530
> When interrupt pacing is enabled, receive/transmit statistics are not
> updated properly by hardware which leads to ISR return with IRQ_NONE
> and inturn kernel disables the interrupt. This patch removed the checking
> of receive/transmi
On Wed, Oct 02, 2013 at 07:08:41PM +0100, Mark Brown wrote:
> On Wed, Oct 02, 2013 at 11:54:50PM +1000, David Gibson wrote:
> > On Tue, Oct 01, 2013 at 03:54:20PM -0500, Rob Herring wrote:
>
> > > I would expect the schema to replace
> > > Documentation/devicetree
ble-gpios") is-a GPIO-specifier (with parameters
> "enable" for the property name, min/max/expression length, etc.), and
> then the schema validation tool would know to apply rules for a
> specifier list to that property (and be able to check the property na
BTW, what kind of documentation are you expecting here? Is is a text that
> > can be added on top of each schema?
>
> I would expect the schema to replace
> Documentation/devicetree/bindings/* over time. I think the thing that
> needs to be worked out here is how to add free for
review the documentation and the schema for every binding.
Hrm. I'm less optimistic about entirely replacing human-readable
bindings with machine-readable schemas. But I do think the schema
language needs to be substantially more flexible than the draft
presented here.
While I think a sch
;next; p; p = next, next = p ? p->next : NULL)
> + free_property(p);
> +}
> +
> +static void free_node(struct node *n)
> +{
> + if (!n)
> + return;
> +
> + free_node_list(n->children);
> + free_label_list(n->labels);
> + free_property_list(n->proplist);
> + free(n->fullpath);
> + if (n->name && *n->name)
*n->name .. so, the name can (and must) be statically allocated if
it's exactly "". Not a useful optimization, I think.
> + free(n->name);
> + free(n);
> +}
> +
> +static void free_node_list(struct node *n)
> +{
> + struct node *next;
> +
> + if (!n)
> + return;
> +
> + for (next = n->next_sibling;
> + n;
> + n = next, next = n ? n->next_sibling : NULL) {
> + free_node(n);
> + }
> +}
> +
> +void free_dt(struct boot_info *bi)
> +{
> + if (!bi)
> + return;
> +
> + free_node_list(bi->dt);
> + free(bi);
> +}
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgpIqVVeRdOcK.pgp
Description: PGP signature
ahead!
>
>
> Benoit,
>
> Sorry, I meant to ask earlier but forgot.
> Shouldn't this development be based on the
> upstream DTC repository and not the in-kernel
> copy of the DTC?
Absolutely. Please work against upstream dtc.
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgpvQSOHC9Pwv.pgp
Description: PGP signature
From: Mugunthan V N
Date: Sat, 21 Sep 2013 00:50:37 +0530
> This patch series adds the support for configuring GMII_SEL register
> of control module to select the phy mode type and also to configure
> the clock source for RMII phy mode whether to use internal clock or
> the external clock from th
will be highly appreciated
Best regards,
Mr. David Williams
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Patch #3 doesn't apply to net-next because it makes changes to
a file "include/linux/platform_data/cpsw.h" which doesn't exist.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.
From: Mugunthan V N
Date: Mon, 5 Aug 2013 17:30:05 +0530
> The new IP version has a minor changes and the offsets are same as the
> previous version, so adding new IP version support in the driver.
>
> Signed-off-by: Mugunthan V N
> Reviewed-by: Felipe Balbi
Applied.
--
To unsubscribe from th
From: Mugunthan V N
Date: Sat, 3 Aug 2013 16:39:45 +0530
> IRQF_DISABLED is a no-op by now and should be removed.
>
> Signed-off-by: Mugunthan V N
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
Mor
From: Felipe Balbi
Date: Fri, 2 Aug 2013 10:44:10 +0300
> IRQF_DISABLED is a no-op by now and should be
> removed.
>
> Signed-off-by: Felipe Balbi
Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majord
From: Mugunthan V N
Date: Wed, 31 Jul 2013 17:42:26 +0530
> The new IP version has a minor changes and the offsets are same as the
> previous
> version, so instead of adding CPSW version number in the driver, make the
> driver
> to fall through to the latest versions so that the new version of
From: Mugunthan V N
Date: Tue, 23 Jul 2013 15:38:17 +0530
> Add support to show CPSW hardware statistics to user via ethtool
> so user can find if there were any error reported by hardware or
> the system is over loaded duing high data rate transfer.
>
> Signed-off-by: Mugunthan V N
> ---
> Cha
From: Mugunthan V N
Date: Fri, 19 Jul 2013 19:37:21 +0530
> Add support to show CPSW hardware statistics to user via ethtool get_regs
> ops so user can find if there were any error reported or the system is
> over loaded duing hagh data rate transfer.
>
> Signed-off-by: Mugunthan V N
This is n
From: Mugunthan V N
Date: Tue, 11 Jun 2013 15:32:03 +0530
> This patch series fixes the following issues with Davinci MDIO
> * Bring up MDIO driver earlier than Ethernet driver so that ethernet driver
> can communicate with the phy as soon as it is resumed.
> * On suspend/resume cycle the MDIO
From: Linus Walleij
Date: Mon, 10 Jun 2013 17:48:16 +0200
> On Fri, Jun 7, 2013 at 4:49 PM, Mugunthan V N wrote:
>
>>> If you want to merge the direct networking parts of this series into
>>> another tree, I'm fine with that:
>>>
>>> Acked-by:
tle on the new core API quite soon,
> then I can carry the patch to this driver if you obtain David's ACK.
If you want to merge the direct networking parts of this series into
another tree, I'm fine with that:
Acked-by: David S. Miller
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
1 - 100 of 1441 matches
Mail list logo
