Re: [PATCH] ARM: EDMA: Use platform_get_resource functions for DT

2014-02-25 Thread Joel Fernandes
Thanks for your suggestions. On Tue, Feb 25, 2014 at 10:22 AM, Rob Herring wrote: > On Fri, Feb 21, 2014 at 11:36 AM, Joel Fernandes wrote: >> On 02/21/2014 06:15 AM, Mark Rutland wrote: Also, while at it get rid of the assumption in the code that "CC" is at reg index 0 in the DT and x

Re: [PATCH] ARM: EDMA: Use platform_get_resource functions for DT

2014-02-25 Thread Rob Herring
On Fri, Feb 21, 2014 at 11:36 AM, Joel Fernandes wrote: > On 02/21/2014 06:15 AM, Mark Rutland wrote: >>> Also, while at it get rid of the assumption in the code that "CC" is at reg >>> index 0 in the DT and xbar is at offset 1. Instead use reg-names to get the >>> memory resource in concern keepi

Re: [PATCH] ARM: EDMA: Use platform_get_resource functions for DT

2014-02-21 Thread Joel Fernandes
On 02/21/2014 06:15 AM, Mark Rutland wrote: >> Also, while at it get rid of the assumption in the code that "CC" is at reg >> index 0 in the DT and xbar is at offset 1. Instead use reg-names to get the >> memory resource in concern keeping things much cleaner and simpler. This also >> makes it poss

Re: [PATCH] ARM: EDMA: Use platform_get_resource functions for DT

2014-02-21 Thread Russell King - ARM Linux
On Thu, Feb 20, 2014 at 10:24:21PM -0600, Joel Fernandes wrote: > diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c > index dc95efc..ae0ccae 100644 > --- a/arch/arm/common/edma.c > +++ b/arch/arm/common/edma.c > @@ -1469,11 +1470,14 @@ static int edma_xbar_event_map(struct device *dev, >

Re: [PATCH] ARM: EDMA: Use platform_get_resource functions for DT

2014-02-21 Thread Mark Rutland
On Fri, Feb 21, 2014 at 04:24:21AM +, Joel Fernandes wrote: > Currently, EDMA driver uses of_address_to_resource for getting Channel > controller and x-bar register resources. Use platform_get_resource_by_name > instead regardless of whether its DT-boot or not, document the new reg-names > prop

[PATCH] ARM: EDMA: Use platform_get_resource functions for DT

2014-02-20 Thread Joel Fernandes
Currently, EDMA driver uses of_address_to_resource for getting Channel controller and x-bar register resources. Use platform_get_resource_by_name instead regardless of whether its DT-boot or not, document the new reg-names properties. Also, while at it get rid of the assumption in the code that "C