Re: [PATCH] Input: ads7846: add regulator support

2010-02-09 Thread Mike Rapoport
Mark Brown wrote: On Fri, Feb 05, 2010 at 10:45:09PM +0200, Mike Rapoport wrote: On Thu, Feb 4, 2010 at 6:21 PM, Mark Brown The bodge I'm thinking of would do something like log an error and substitute in a dummy regulator when regulator_get() would have failed so that the driver sees

Re: [PATCH] Input: ads7846: add regulator support

2010-02-08 Thread Mark Brown
On Fri, Feb 05, 2010 at 10:45:09PM +0200, Mike Rapoport wrote: On Thu, Feb 4, 2010 at 6:21 PM, Mark Brown The bodge I'm thinking of would do something like log an error and substitute in a dummy regulator when regulator_get() would have failed so that the driver sees behaviour equivalent

Re: [PATCH] Input: ads7846: add regulator support

2010-02-05 Thread Mike Rapoport
On Thu, Feb 4, 2010 at 6:21 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Thu, Feb 04, 2010 at 04:52:26PM +0200, Grazvydas Ignotas wrote: On Thu, Feb 4, 2010 at 4:24 PM, Mark Brown The bodge I'm thinking of would do something like log an error and substitute in a dummy

[PATCH] Input: ads7846: add regulator support

2010-02-04 Thread Grazvydas Ignotas
The ADS7846/TSC2046 touchscreen controllers can (and usually are) connected to various regulators for power, so add regulator support. Make it optional for now to avoid breaking all current users of this driver. Signed-off-by: Grazvydas Ignotas nota...@gmail.com ---

Re: [PATCH] Input: ads7846: add regulator support

2010-02-04 Thread Grazvydas Ignotas
On Thu, Feb 4, 2010 at 4:24 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Thu, Feb 04, 2010 at 03:39:18PM +0200, Grazvydas Ignotas wrote: The ADS7846/TSC2046 touchscreen controllers can (and usually are) connected to various regulators for power, so add regulator support. Make

Re: [PATCH] Input: ads7846: add regulator support

2010-02-04 Thread Mike Rapoport
Mark Brown wrote: On Thu, Feb 04, 2010 at 03:39:18PM +0200, Grazvydas Ignotas wrote: The ADS7846/TSC2046 touchscreen controllers can (and usually are) connected to various regulators for power, so add regulator support. Make it optional for now to avoid breaking all current users of this

Re: [PATCH] Input: ads7846: add regulator support

2010-02-04 Thread Mark Brown
On Thu, Feb 04, 2010 at 05:08:11PM +0200, Mike Rapoport wrote: Mark Brown wrote: This should not be required. The regulator API stubs itself out when it is not built so all API calls report as successful. And what about boards that have the ads7846 tied to power rail and still want to

Re: [PATCH] Input: ads7846: add regulator support

2010-02-04 Thread Mark Brown
On Thu, Feb 04, 2010 at 04:52:26PM +0200, Grazvydas Ignotas wrote: On Thu, Feb 4, 2010 at 4:24 PM, Mark Brown The updates to fix up the boards that need this are fairly straightforward and given that it's fairly easy to identify systems which are using the driver in mainline so I'd really

Re: [PATCH] Input: ads7846: add regulator support

2010-02-04 Thread Dmitry Torokhov
On Thu, Feb 04, 2010 at 04:21:55PM +, Mark Brown wrote: On Thu, Feb 04, 2010 at 04:52:26PM +0200, Grazvydas Ignotas wrote: On Thu, Feb 4, 2010 at 4:24 PM, Mark Brown The updates to fix up the boards that need this are fairly straightforward and given that it's fairly easy to

Re: [PATCH] Input: ads7846: add regulator support

2010-02-04 Thread Mark Brown
On 4 Feb 2010, at 18:08, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Thu, Feb 04, 2010 at 04:21:55PM +, Mark Brown wrote: On Thu, Feb 04, 2010 at 04:52:26PM +0200, Grazvydas Ignotas wrote: On Thu, Feb 4, 2010 at 4:24 PM, Mark Brown The updates to fix up the boards that need