Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-23 Thread Roger Quadros
Hi, On 06/22/2012 05:43 PM, Munegowda, Keshava wrote: On Fri, Jun 22, 2012 at 7:41 PM, Kevin Hilman khil...@ti.com wrote: Munegowda, Keshava keshava_mgo...@ti.com writes: [...] You are not reading what I write. To repeat: your patch fixes the oops during boot, and the suspend hang and

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-23 Thread Munegowda, Keshava
On Mon, Jul 23, 2012 at 2:03 PM, Roger Quadros rog...@ti.com wrote: Hi, On 06/22/2012 05:43 PM, Munegowda, Keshava wrote: On Fri, Jun 22, 2012 at 7:41 PM, Kevin Hilman khil...@ti.com wrote: Munegowda, Keshava keshava_mgo...@ti.com writes: [...] You are not reading what I write. To

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-20 Thread Munegowda, Keshava
On Fri, Jul 20, 2012 at 4:25 AM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Jul 19, 2012 at 03:54:05PM -0700, Greg KH wrote: On Thu, Jul 19, 2012 at 01:20:14PM +0300, Felipe Balbi wrote: Hi, On Thu, Jun 21, 2012 at 07:12:12PM +0530, Keshava Munegowda wrote: This commit

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-19 Thread Munegowda, Keshava
On Thu, Jul 12, 2012 at 12:11 PM, Munegowda, Keshava keshava_mgo...@ti.com wrote: On Wed, Jul 11, 2012 at 7:53 PM, Kevin Hilman khil...@ti.com wrote: Munegowda, Keshava keshava_mgo...@ti.com writes: On Wed, Jul 11, 2012 at 3:59 PM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Keshava, Kevin,

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-19 Thread Felipe Balbi
Hi, On Thu, Jun 21, 2012 at 07:12:12PM +0530, Keshava Munegowda wrote: This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled Fix OMAP EHCI suspend/resume failure (i693) is causing the usb hub and device detection fails in beagle XM causeing NFS not functional. This affects the core

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-19 Thread Munegowda, Keshava
On Thu, Jul 19, 2012 at 3:50 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Jun 21, 2012 at 07:12:12PM +0530, Keshava Munegowda wrote: This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled Fix OMAP EHCI suspend/resume failure (i693) is causing the usb hub and device detection fails

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-19 Thread Alan Stern
On Thu, 19 Jul 2012, Felipe Balbi wrote: Hi, On Thu, Jun 21, 2012 at 07:12:12PM +0530, Keshava Munegowda wrote: This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled Fix OMAP EHCI suspend/resume failure (i693) is causing the usb hub and device detection fails in beagle XM

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-19 Thread Greg KH
On Thu, Jul 19, 2012 at 01:20:14PM +0300, Felipe Balbi wrote: Hi, On Thu, Jun 21, 2012 at 07:12:12PM +0530, Keshava Munegowda wrote: This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled Fix OMAP EHCI suspend/resume failure (i693) is causing the usb hub and device detection fails

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-19 Thread Greg KH
On Thu, Jul 19, 2012 at 03:54:05PM -0700, Greg KH wrote: On Thu, Jul 19, 2012 at 01:20:14PM +0300, Felipe Balbi wrote: Hi, On Thu, Jun 21, 2012 at 07:12:12PM +0530, Keshava Munegowda wrote: This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled Fix OMAP EHCI suspend/resume

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-12 Thread Munegowda, Keshava
On Wed, Jul 11, 2012 at 7:53 PM, Kevin Hilman khil...@ti.com wrote: Munegowda, Keshava keshava_mgo...@ti.com writes: On Wed, Jul 11, 2012 at 3:59 PM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Keshava, Kevin, On Fri, Jul 06, 2012 at 05:29:00PM +0530, Munegowda, Keshava wrote: Samuel

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-11 Thread Samuel Ortiz
Hi Keshava, Kevin, On Fri, Jul 06, 2012 at 05:29:00PM +0530, Munegowda, Keshava wrote: Samuel I have sent that patch to disable the ehci in omap2plus_defconfig; after merging that please merge this patch too. This will fix the crashes in during boot with NFS in beagleXM I'm going

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-11 Thread Munegowda, Keshava
On Wed, Jul 11, 2012 at 3:59 PM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Keshava, Kevin, On Fri, Jul 06, 2012 at 05:29:00PM +0530, Munegowda, Keshava wrote: Samuel I have sent that patch to disable the ehci in omap2plus_defconfig; after merging that please merge this patch

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-11 Thread Kevin Hilman
Munegowda, Keshava keshava_mgo...@ti.com writes: On Wed, Jul 11, 2012 at 3:59 PM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Keshava, Kevin, On Fri, Jul 06, 2012 at 05:29:00PM +0530, Munegowda, Keshava wrote: Samuel I have sent that patch to disable the ehci in

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-06 Thread Munegowda, Keshava
On Thu, Jul 5, 2012 at 4:49 PM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Kevin, Keshava, On Wed, Jul 04, 2012 at 06:33:35AM -0700, Kevin Hilman wrote: Munegowda, Keshava keshava_mgo...@ti.com writes: On Tue, Jul 3, 2012 at 12:17 PM, Munegowda, Keshava keshava_mgo...@ti.com wrote: On

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-06 Thread Munegowda, Keshava
On Fri, Jul 6, 2012 at 3:30 PM, Munegowda, Keshava keshava_mgo...@ti.com wrote: On Thu, Jul 5, 2012 at 4:49 PM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Kevin, Keshava, On Wed, Jul 04, 2012 at 06:33:35AM -0700, Kevin Hilman wrote: Munegowda, Keshava keshava_mgo...@ti.com writes: On

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-05 Thread Samuel Ortiz
Hi Kevin, Keshava, On Wed, Jul 04, 2012 at 06:33:35AM -0700, Kevin Hilman wrote: Munegowda, Keshava keshava_mgo...@ti.com writes: On Tue, Jul 3, 2012 at 12:17 PM, Munegowda, Keshava keshava_mgo...@ti.com wrote: On Mon, Jul 2, 2012 at 10:24 PM, Kevin Hilman khil...@ti.com wrote: Felipe,

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-04 Thread Kevin Hilman
Munegowda, Keshava keshava_mgo...@ti.com writes: On Tue, Jul 3, 2012 at 12:17 PM, Munegowda, Keshava keshava_mgo...@ti.com wrote: On Mon, Jul 2, 2012 at 10:24 PM, Kevin Hilman khil...@ti.com wrote: Felipe, Keshava, Kevin Hilman khil...@ti.com writes: Felipe Balbi ba...@ti.com writes:

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-03 Thread Munegowda, Keshava
On Tue, Jul 3, 2012 at 5:44 AM, Kevin Hilman khil...@ti.com wrote: Kevin Hilman khil...@ti.com writes: Felipe, Keshava, Kevin Hilman khil...@ti.com writes: Felipe Balbi ba...@ti.com writes: [...] Keshava is reverting a fix for a HW errata. I can't accept it as it will cause

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-03 Thread Munegowda, Keshava
On Mon, Jul 2, 2012 at 10:24 PM, Kevin Hilman khil...@ti.com wrote: Felipe, Keshava, Kevin Hilman khil...@ti.com writes: Felipe Balbi ba...@ti.com writes: [...] Keshava is reverting a fix for a HW errata. I can't accept it as it will cause regressions. Granted, regression by regression,

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-03 Thread Munegowda, Keshava
On Tue, Jul 3, 2012 at 12:17 PM, Munegowda, Keshava keshava_mgo...@ti.com wrote: On Mon, Jul 2, 2012 at 10:24 PM, Kevin Hilman khil...@ti.com wrote: Felipe, Keshava, Kevin Hilman khil...@ti.com writes: Felipe Balbi ba...@ti.com writes: [...] Keshava is reverting a fix for a HW errata. I

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-02 Thread Kevin Hilman
Felipe, Keshava, Kevin Hilman khil...@ti.com writes: Felipe Balbi ba...@ti.com writes: [...] Keshava is reverting a fix for a HW errata. I can't accept it as it will cause regressions. Granted, regression by regression, there's no change, but I simply can't knowingly cause a regression to

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-02 Thread Russ Dill
On Mon, Jul 2, 2012 at 9:54 AM, Kevin Hilman khil...@ti.com wrote: Felipe, Keshava, Kevin Hilman khil...@ti.com writes: Felipe Balbi ba...@ti.com writes: [...] Keshava is reverting a fix for a HW errata. I can't accept it as it will cause regressions. Granted, regression by regression,

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-02 Thread Kevin Hilman
Russ Dill russ.d...@gmail.com writes: On Mon, Jul 2, 2012 at 9:54 AM, Kevin Hilman khil...@ti.com wrote: Felipe, Keshava, Kevin Hilman khil...@ti.com writes: Felipe Balbi ba...@ti.com writes: [...] Keshava is reverting a fix for a HW errata. I can't accept it as it will cause

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-02 Thread Samuel Ortiz
Hi Kevin, On Mon, Jul 02, 2012 at 10:55:39AM -0700, Kevin Hilman wrote: I'm also worried that the owners of this code are running out of time to fix these several serious regresions for v3.5. FYI, I only have one omap-usb fix queued for 3.5 in my for-linus branch, see

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-02 Thread Kevin Hilman
Kevin Hilman khil...@ti.com writes: Felipe, Keshava, Kevin Hilman khil...@ti.com writes: Felipe Balbi ba...@ti.com writes: [...] Keshava is reverting a fix for a HW errata. I can't accept it as it will cause regressions. Granted, regression by regression, there's no change, but I

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-06-25 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: [...] Keshava is reverting a fix for a HW errata. I can't accept it as it will cause regressions. Granted, regression by regression, there's no change, but I simply can't knowingly cause a regression to the driver just to have PM working. We need a real fix

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-06-22 Thread Munegowda, Keshava
On Fri, Jun 22, 2012 at 12:32 AM, Kevin Hilman khil...@ti.com wrote: Munegowda, Keshava keshava_mgo...@ti.com writes: On Thu, Jun 21, 2012 at 7:12 PM, Keshava Munegowda keshava_mgo...@ti.com wrote: This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled Fix OMAP EHCI suspend/resume

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-06-22 Thread Felipe Balbi
Hi, On Fri, Jun 22, 2012 at 01:00:39PM +0530, Munegowda, Keshava wrote: On Fri, Jun 22, 2012 at 12:32 AM, Kevin Hilman khil...@ti.com wrote: Munegowda, Keshava keshava_mgo...@ti.com writes: On Thu, Jun 21, 2012 at 7:12 PM, Keshava Munegowda keshava_mgo...@ti.com wrote: This commit

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-06-22 Thread Kevin Hilman
Munegowda, Keshava keshava_mgo...@ti.com writes: [...] hi kevin here is pm count log on beagle XM with the above patch: What are you meaning to show by this log? This dump shows that neither PER or CORE are hitting retention in idle. Which sounds to me like you have not enabled UART

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-06-22 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: Hi, On Fri, Jun 22, 2012 at 01:00:39PM +0530, Munegowda, Keshava wrote: On Fri, Jun 22, 2012 at 12:32 AM, Kevin Hilman khil...@ti.com wrote: Munegowda, Keshava keshava_mgo...@ti.com writes: On Thu, Jun 21, 2012 at 7:12 PM, Keshava Munegowda

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-06-22 Thread Alan Stern
On Fri, 22 Jun 2012, Kevin Hilman wrote: As I said way back in the beginning this thread. The runtime PM of this driver is leaving the device enabled. To test idle retention, ensure the UART auto-suspend is enable for all UARTS: echo 3000

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-06-22 Thread Munegowda, Keshava
On Fri, Jun 22, 2012 at 7:41 PM, Kevin Hilman khil...@ti.com wrote: Munegowda, Keshava keshava_mgo...@ti.com writes: [...] hi kevin here is pm count log on beagle XM with the above patch: What are you meaning to show by this log? This dump shows that neither PER or CORE are hitting

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-06-22 Thread Russ Dill
On Fri, Jun 22, 2012 at 7:14 AM, Kevin Hilman khil...@ti.com wrote: Felipe Balbi ba...@ti.com writes: Hi, On Fri, Jun 22, 2012 at 01:00:39PM +0530, Munegowda, Keshava wrote: On Fri, Jun 22, 2012 at 12:32 AM, Kevin Hilman khil...@ti.com wrote: Munegowda, Keshava keshava_mgo...@ti.com

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-06-22 Thread Munegowda, Keshava
On Fri, Jun 22, 2012 at 8:33 PM, Russ Dill russ.d...@gmail.com wrote: On Fri, Jun 22, 2012 at 7:14 AM, Kevin Hilman khil...@ti.com wrote: Felipe Balbi ba...@ti.com writes: Hi, On Fri, Jun 22, 2012 at 01:00:39PM +0530, Munegowda, Keshava wrote: On Fri, Jun 22, 2012 at 12:32 AM, Kevin Hilman

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-06-22 Thread Kevin Hilman
Munegowda, Keshava keshava_mgo...@ti.com writes: On Fri, Jun 22, 2012 at 7:41 PM, Kevin Hilman khil...@ti.com wrote: Munegowda, Keshava keshava_mgo...@ti.com writes: [...] hi kevin here is pm count log on beagle XM with the above patch: What are you meaning to show by this log? This

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-06-22 Thread Felipe Balbi
Hi, On Fri, Jun 22, 2012 at 07:14:32AM -0700, Kevin Hilman wrote: Felipe Balbi ba...@ti.com writes: Hi, On Fri, Jun 22, 2012 at 01:00:39PM +0530, Munegowda, Keshava wrote: On Fri, Jun 22, 2012 at 12:32 AM, Kevin Hilman khil...@ti.com wrote: Munegowda, Keshava keshava_mgo...@ti.com

[PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-06-21 Thread Keshava Munegowda
This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled Fix OMAP EHCI suspend/resume failure (i693) is causing the usb hub and device detection fails in beagle XM causeing NFS not functional. This affects the core retention too. The same commit logic needs to be revisted adhering to hwmod and

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-06-21 Thread Munegowda, Keshava
On Thu, Jun 21, 2012 at 7:12 PM, Keshava Munegowda keshava_mgo...@ti.com wrote: This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled Fix OMAP EHCI suspend/resume failure (i693) is causing the usb hub and device detection fails in beagle XM causeing NFS not functional. This affects the

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-06-21 Thread Kevin Hilman
Munegowda, Keshava keshava_mgo...@ti.com writes: On Thu, Jun 21, 2012 at 7:12 PM, Keshava Munegowda keshava_mgo...@ti.com wrote: This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled Fix OMAP EHCI suspend/resume failure (i693) is causing the usb hub and device detection fails in beagle