RE: [PATCH] OMAP4: HSMMC cmd line reset change

2010-09-22 Thread Madhusudhan
-Original Message- From: Tony Lindgren [mailto:t...@atomide.com] Sent: Tuesday, September 21, 2010 9:47 AM To: Madhusudhan Cc: c...@laptop.org; linux-...@vger.kernel.org; linux-omap@vger.kernel.org; santosh.shilim...@ti.com Subject: Re: [PATCH] OMAP4: HSMMC cmd line reset change

Re: [PATCH] OMAP4: HSMMC cmd line reset change

2010-09-22 Thread Chris Ball
Hi Madhu, On Wed, Sep 22, 2010 at 12:13:51PM -0500, Madhusudhan wrote: Can you please drop this patch? Sorry, I spoke bit too early on this patch. I need to sort out some stuff internally (seems like it will not be released as an errata). I will post a revised version a bit later. No problem,

Re: [PATCH] OMAP4: HSMMC cmd line reset change

2010-09-21 Thread Tony Lindgren
* Madhusudhan madhu...@ti.com [100920 09:06]: Please don't use cpu_is_omap tests in the drivers, drivers should be generic. Instead, just pass a feature flag in the platform_data for this feature like HSMMC_REVERSE_RESET_LOGIC or similar. This is not a feature. It is like

RE: [PATCH] OMAP4: HSMMC cmd line reset change

2010-09-20 Thread Madhusudhan
-Original Message- From: Tony Lindgren [mailto:t...@atomide.com] Sent: Friday, September 17, 2010 10:48 AM To: Madhusudhan Chikkature Cc: c...@laptop.org; linux-...@vger.kernel.org; linux-omap@vger.kernel.org; santosh.shilim...@ti.com Subject: Re: [PATCH] OMAP4: HSMMC cmd line

Re: [PATCH] OMAP4: HSMMC cmd line reset change

2010-09-17 Thread Tony Lindgren
* Madhusudhan Chikkature madhu...@ti.com [100915 16:50]: OMAP4: HSMMC cmd line reset change The cmd line reset logic is changed in OMAP4 ES2. The new procedure is to monitor a 0-1 transition and then 1-0 transition.The earlier logic would fail on ES2 chips because the loop could exit even

Re: [PATCH] OMAP4: HSMMC cmd line reset change

2010-09-16 Thread Chris Ball
Hi Madhu, On Thu, Sep 16, 2010 at 05:28:11AM +0530, Madhusudhan Chikkature wrote: OMAP4: HSMMC cmd line reset change Please don't repeat the subject line like this -- git am will put it into the patch twice. You can either leave the subject line out of the body of the mail altogether, or put

[PATCH] OMAP4: HSMMC cmd line reset change

2010-09-15 Thread Madhusudhan Chikkature
OMAP4: HSMMC cmd line reset change The cmd line reset logic is changed in OMAP4 ES2. The new procedure is to monitor a 0-1 transition and then 1-0 transition.The earlier logic would fail on ES2 chips because the loop could exit even before the reset is actually complete. Signed-off-by: