Re: [PATCH] OMAP4: PANDA, SDP: Fix EHCI regulator supply

2011-06-27 Thread Jaswinder Singh
On 27 June 2011 15:41, Felipe Balbi wrote: > Hi, > > On Mon, Jun 27, 2011 at 03:35:41PM +0530, Jaswinder Singh wrote: >> On 27 June 2011 14:05, Felipe Balbi wrote: >> >> >> > +static struct regulator_consumer_supply sdp4430_vusb_supply = >> >> >> > +       REGULATOR_SUPPLY("hsusb0", "ehci-omap.0"

Re: [PATCH] OMAP4: PANDA, SDP: Fix EHCI regulator supply

2011-06-27 Thread Jaswinder Singh
Hi Felipe, On 27 June 2011 14:05, Felipe Balbi wrote: >> >> > +static struct regulator_consumer_supply sdp4430_vusb_supply = >> >> > +       REGULATOR_SUPPLY("hsusb0", "ehci-omap.0"); >> > >> > this should be an array. >> Ok, I can make it an array of _one_ element. >> Though I am not sure why is

Re: [PATCH] OMAP4: PANDA, SDP: Fix EHCI regulator supply

2011-06-27 Thread Felipe Balbi
Hi, On Mon, Jun 27, 2011 at 03:35:41PM +0530, Jaswinder Singh wrote: > On 27 June 2011 14:05, Felipe Balbi wrote: > >> >> > +static struct regulator_consumer_supply sdp4430_vusb_supply = > >> >> > +       REGULATOR_SUPPLY("hsusb0", "ehci-omap.0"); > >> > > >> > this should be an array. > >> Ok, I

Re: [PATCH] OMAP4: PANDA, SDP: Fix EHCI regulator supply

2011-06-27 Thread Felipe Balbi
Hi, On Mon, Jun 27, 2011 at 01:38:54PM +0530, Jaswinder Singh wrote: > Hi Felipe, > > On 27 June 2011 13:30, Felipe Balbi wrote: > > >> > > >> > +static struct regulator_consumer_supply sdp4430_vusb_supply = > >> > +       REGULATOR_SUPPLY("hsusb0", "ehci-omap.0"); > > > > this should be an arr

Re: [PATCH] OMAP4: PANDA, SDP: Fix EHCI regulator supply

2011-06-27 Thread Jaswinder Singh
Hi Felipe, On 27 June 2011 13:30, Felipe Balbi wrote: >> > >> > +static struct regulator_consumer_supply sdp4430_vusb_supply = >> > +       REGULATOR_SUPPLY("hsusb0", "ehci-omap.0"); > > this should be an array. Ok, I can make it an array of _one_ element. Though I am not sure why is that a good

Re: [PATCH] OMAP4: PANDA, SDP: Fix EHCI regulator supply

2011-06-27 Thread Felipe Balbi
Hi, On Fri, Jun 24, 2011 at 10:37:56PM +0530, Jaswinder Singh wrote: > [CC'ing Liam and Mark as well] > > On 24 June 2011 20:07, Jassi Brar wrote: > > VUSB is a fixed level line and hence have no set_voltage > > callback in regulator ops, but has apply_uV set to true. > > As a result it fails to

Re: [PATCH] OMAP4: PANDA, SDP: Fix EHCI regulator supply

2011-06-24 Thread Jaswinder Singh
[CC'ing Liam and Mark as well] On 24 June 2011 20:07, Jassi Brar wrote: > VUSB is a fixed level line and hence have no set_voltage > callback in regulator ops, but has apply_uV set to true. > As a result it fails to register with the regulator core. > Remove setting apply_uV. > > Also, assign nam

[PATCH] OMAP4: PANDA, SDP: Fix EHCI regulator supply

2011-06-24 Thread Jassi Brar
VUSB is a fixed level line and hence have no set_voltage callback in regulator ops, but has apply_uV set to true. As a result it fails to register with the regulator core. Remove setting apply_uV. Also, assign name to VUSB supply, without which regulator core fails to find it and assigns the defau