Re: [PATCH 1/2] TPS6235x driver added into the power regulator framework

2008-12-15 Thread Mark Brown
On Mon, Dec 15, 2008 at 10:13:27AM +0530, Pillai, Manikandan wrote: Thanks for your comments.Pls find my responses inlined. For posting on kernel lists you probably want to fix your mail client to insert quote characters before the mail you're replying to - it makes your mail much easier to

RE: [PATCH 1/2] TPS6235x driver added into the power regulator framework

2008-12-14 Thread Pillai, Manikandan
Hi, Thanks for your comments.Pls find my responses inlined. -Original Message- From: Mark Brown [mailto:broo...@sirena.org.uk] Sent: Monday, December 08, 2008 5:53 PM To: Pillai, Manikandan Cc: linux-omap@vger.kernel.org Subject: Re: [PATCH 1/2] TPS6235x driver added into the power

RE: [PATCH 1/2] TPS6235x driver added into the power regulator framework

2008-12-14 Thread Pillai, Manikandan
Hi, Pls find my comments inlined. Regards -Original Message- From: David Brownell [mailto:davi...@pacbell.net] Sent: Monday, December 08, 2008 7:04 PM To: Pillai, Manikandan Cc: linux-omap@vger.kernel.org; Mark Brown Subject: Re: [PATCH 1/2] TPS6235x driver added into the power

[PATCH 1/2] TPS6235x driver added into the power regulator framework

2008-12-08 Thread Manikandan Pillai
Resending this patch after fixing comments received. CONFIG_OMAP3EVM_PR785 has been moved to arch/arm/mach-omap2/Kconfig MUX patch has been separated and sent out separately regulator/core.c changes have been separated and send out earlier Platform driver has been removed Renamed supplies to vdd1

Re: [PATCH 1/2] TPS6235x driver added into the power regulator framework

2008-12-08 Thread Mark Brown
On Mon, Dec 08, 2008 at 03:38:02PM +0530, Manikandan Pillai wrote: Resending this patch after fixing comments received. CONFIG_OMAP3EVM_PR785 has been moved to arch/arm/mach-omap2/Kconfig MUX patch has been separated and sent out separately regulator/core.c changes have been separated and send

Re: [PATCH 1/2] TPS6235x driver added into the power regulator framework

2008-12-08 Thread David Brownell
On Monday 08 December 2008, Manikandan Pillai wrote: +++ b/drivers/regulator/tps6235x-regulator.c @@ -0,0 +1,557 @@ +/* + * tps6235x-regulator.c -- support regulators in tps6235x family chips + * + * Copyright (C) 2008 David Brownell + * Author : Manikandan Pillai[EMAIL PROTECTED] + * No,