Re: [PATCH 1/2 v2] ARM: OMAP: board-4430sdp: Provide regulator to pwm-backlight

2013-03-13 Thread Peter Ujfalusi
On 03/12/2013 11:22 PM, Andrew Chew wrote: The pwm-backlight driver now takes a mandatory regulator that is gotten during driver probe. Initialize a dummy regulator to satisfy this requirement. I can test this tomorrow, but I have one comment: Signed-off-by: Andrew Chew ac...@nvidia.com

RE: [PATCH 1/2 v2] ARM: OMAP: board-4430sdp: Provide regulator to pwm-backlight

2013-03-13 Thread Andrew Chew
+/* Dummy regulator for pwm-backlight driver */ static struct +regulator_consumer_supply backlight_supply = + REGULATOR_SUPPLY(enable, NULL); 'enable' is just too generic, the device name should be also provided: REGULATOR_SUPPLY(enable, pwm-backlight); You're right. I don't

Re: [PATCH 1/2 v2] ARM: OMAP: board-4430sdp: Provide regulator to pwm-backlight

2013-03-13 Thread Thierry Reding
On Wed, Mar 13, 2013 at 01:38:31PM -0700, Andrew Chew wrote: +/* Dummy regulator for pwm-backlight driver */ static struct +regulator_consumer_supply backlight_supply = + REGULATOR_SUPPLY(enable, NULL); 'enable' is just too generic, the device name should be also provided:

RE: [PATCH 1/2 v2] ARM: OMAP: board-4430sdp: Provide regulator to pwm-backlight

2013-03-13 Thread Andrew Chew
From: Thierry Reding [mailto:thierry.red...@avionic-design.de] Sent: Wednesday, March 13, 2013 1:59 PM To: Andrew Chew Cc: Peter Ujfalusi; Alex Courbot; linux-omap@vger.kernel.org Subject: Re: [PATCH 1/2 v2] ARM: OMAP: board-4430sdp: Provide regulator to pwm-backlight * PGP Signed

[PATCH 1/2 v2] ARM: OMAP: board-4430sdp: Provide regulator to pwm-backlight

2013-03-12 Thread Andrew Chew
The pwm-backlight driver now takes a mandatory regulator that is gotten during driver probe. Initialize a dummy regulator to satisfy this requirement. Signed-off-by: Andrew Chew ac...@nvidia.com --- arch/arm/mach-omap2/board-4430sdp.c |5 + 1 file changed, 5 insertions(+) diff --git