Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Kevin Hilman
; Cc: Kevin Hilman; linux-omap@vger.kernel.org; linux-arm- >> ker...@lists.infradead.org >> Subject: Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific >> OPPs >> >> Linus Walleij had written, on 09/16/2010 12:07 PM, the following: >> > 2010/9/1

RE: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Shilimkar, Santosh
.@lists.infradead.org > Subject: Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific > OPPs > > Linus Walleij had written, on 09/16/2010 12:07 PM, the following: > > 2010/9/16 Kevin Hilman : > > > >> lib/opp/* seems more appropriate to me with the

Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Nishanth Menon
Linus Walleij had written, on 09/16/2010 12:07 PM, the following: 2010/9/16 Kevin Hilman : lib/opp/* seems more appropriate to me with the header at include/linux/opp.h as Linus suggested. I second this. I would love to see the generic OPP stuff in lib/opp/* so we put it in the right place fr

Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Linus Walleij
2010/9/16 Kevin Hilman : > lib/opp/* seems more appropriate to me with the header at > include/linux/opp.h as Linus suggested. I second this. I would love to see the generic OPP stuff in lib/opp/* so we put it in the right place from the beginning and don't have to painfully refactor everything l

Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Kevin Hilman
Nishanth Menon writes: > Kevin Hilman had written, on 09/16/2010 10:08 AM, the following: > [..] >>> more than that you name >>> some functions omap_*, and how hard would it be to put it under >>> arch/arm/common/*.c >>> arch/arm/include/asm/*.h >>> >>> Possible even higher up in the directory hi

Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Nishanth Menon
Kevin Hilman had written, on 09/16/2010 10:08 AM, the following: [..] more than that you name some functions omap_*, and how hard would it be to put it under arch/arm/common/*.c arch/arm/include/asm/*.h Possible even higher up in the directory hiearchy in include/linux/opp.h for the header and d

Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Kevin Hilman
Hi Linus, Linus Walleij writes: > 2010/9/15 Kevin Hilman : > >> OMAP SOCs have a standard set of tuples consisting of frequency and >> voltage pairs that the device will support per voltage domain.  These >> are called Operating Performance Points or OPPs. >> (...) >> This introduces a common ha

Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Nishanth Menon
Roger Quadros had written, on 09/16/2010 09:20 AM, the following: [...] +/** + * opp_get_freq() - Gets the frequency corresponding to an opp + * @opp: opp for which frequency has to be returned for + * + * Return frequency in hertz corresponding to the opp, else + * return 0 + */ +unsigned

Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Roger Quadros
On 09/16/2010 05:01 PM, ext Nishanth Menon wrote: Roger Quadros had written, on 09/16/2010 08:54 AM, the following: Since you are anyways re-sending this you might as well fix these nits. thanks for reviewing.. [..] diff --git a/arch/arm/plat-omap/opp.c b/arch/arm/plat-omap/opp.c new file

Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Nishanth Menon
Roger Quadros had written, on 09/16/2010 08:54 AM, the following: Since you are anyways re-sending this you might as well fix these nits. thanks for reviewing.. [..] diff --git a/arch/arm/plat-omap/opp.c b/arch/arm/plat-omap/opp.c new file mode 100644 index 000..17f93b2 --- /dev/null +

Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Roger Quadros
Nishant, Since you are anyways re-sending this you might as well fix these nits. On 09/16/2010 12:56 AM, ext Kevin Hilman wrote: From: Nishanth Menon diff --git a/arch/arm/plat-omap/opp.c b/arch/arm/plat-omap/opp.c new file mode 100644 index 000..17f93b2 --- /dev/null +++ b/arch/arm/pla

Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Linus Walleij
Nishanth Menon wrote: > Linus Walleij had written, on 09/16/2010 07:19 AM, the following: >> 2010/9/15 Kevin Hilman : >> >>> OMAP SOCs have a standard set of tuples consisting of frequency and >>> voltage pairs that the device will support per voltage domain. These >>> are called Operating Perform

Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Nishanth Menon
Linus Walleij had written, on 09/16/2010 07:19 AM, the following: 2010/9/15 Kevin Hilman : OMAP SOCs have a standard set of tuples consisting of frequency and voltage pairs that the device will support per voltage domain. These are called Operating Performance Points or OPPs. (...) This introd

Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Linus Walleij
2010/9/15 Kevin Hilman : > OMAP SOCs have a standard set of tuples consisting of frequency and > voltage pairs that the device will support per voltage domain.  These > are called Operating Performance Points or OPPs. > (...) > This introduces a common handling OPP mechanism accross all OMAPs. > A

RE: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Gopinath, Thara
>>-Original Message- >>From: Menon, Nishanth >>Sent: Thursday, September 16, 2010 4:02 PM >>To: Gopinath, Thara; Kevin Hilman; linux-omap@vger.kernel.org >>Cc: linux-arm-ker...@lists.infradead.org >>Subject: RE: [PATCH 1/4] OMAP: introduc

RE: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Menon, Nishanth
> -Original Message- > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > ow...@vger.kernel.org] On Behalf Of Gopinath, Thara [...] > >>diff --git a/arch/arm/plat-omap/include/plat/opp.h b/arch/arm/plat- > omap/include/plat/opp.h > >>new file mode 100644 > >>index 000..997b56

RE: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Gopinath, Thara
.infradead.org >>Subject: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs >> >>From: Nishanth Menon >> >>OMAP SOCs have a standard set of tuples consisting of frequency and >>voltage pairs that the device will support per voltage domain. These >&

[PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-15 Thread Kevin Hilman
From: Nishanth Menon OMAP SOCs have a standard set of tuples consisting of frequency and voltage pairs that the device will support per voltage domain. These are called Operating Performance Points or OPPs. The actual definitions of OMAP Operating Points varies over silicon within the same famil

[PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-08-10 Thread Kevin Hilman
From: Nishanth Menon OMAP SOCs have a standard set of tuples consisting of frequency and voltage pairs that the device will support per voltage domain. These are called Operating Performance Points or OPPs. The actual definitions of OMAP Operating Points varies over silicon within the same famil

[PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-08-10 Thread Kevin Hilman
From: Nishanth Menon OMAP SOCs have a standard set of tuples consisting of frequency and voltage pairs that the device will support per voltage domain. These are called Operating Performance Points or OPPs. The actual definitions of OMAP Operating Points varies over silicon within the same famil