Re: [PATCH 2/2] musb: musb: dsps: determine the number of instances at runtime

2013-06-18 Thread Felipe Balbi
Hi, On Mon, Jun 17, 2013 at 05:13:34PM +0200, Sebastian Andrzej Siewior wrote: There is no need to hardcode the number of instances here. It is better to determine them at runtime. Even if the device provides two instances one might only want to use one of them. Signed-off-by: Sebastian

Re: [PATCH 2/2] musb: musb: dsps: determine the number of instances at runtime

2013-06-18 Thread Sebastian Andrzej Siewior
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/18/2013 10:31 AM, Felipe Balbi wrote: Hi, Hi Felipe, --- a/drivers/usb/musb/musb_dsps.c +++ b/drivers/usb/musb/musb_dsps.c @@ -110,8 +110,6 @@ struct dsps_musb_wrapper { @@ -646,6 +645,23 @@ static int dsps_probe(struct platform_device

Re: [PATCH 2/2] musb: musb: dsps: determine the number of instances at runtime

2013-06-18 Thread Felipe Balbi
Hi, On Tue, Jun 18, 2013 at 10:43:55AM +0200, Sebastian Andrzej Siewior wrote: --- a/drivers/usb/musb/musb_dsps.c +++ b/drivers/usb/musb/musb_dsps.c @@ -110,8 +110,6 @@ struct dsps_musb_wrapper { @@ -646,6 +645,23 @@ static int dsps_probe(struct platform_device *pdev) }

Re: [PATCH 2/2] musb: musb: dsps: determine the number of instances at runtime

2013-06-18 Thread Sebastian Andrzej Siewior
On 06/18/2013 10:54 AM, Felipe Balbi wrote: Hi, Hi Felipe, This isn't exactly a child node, is it? There is of_get_child_count() but this isn't a child, it is one property. is it because we haven't added DTS support for musb core ? Eventually we can/should add and convert this to

Re: [PATCH 2/2] musb: musb: dsps: determine the number of instances at runtime

2013-06-18 Thread Felipe Balbi
Hi, On Tue, Jun 18, 2013 at 11:24:40AM +0200, Sebastian Andrzej Siewior wrote: On 06/18/2013 10:54 AM, Felipe Balbi wrote: Hi, Hi Felipe, This isn't exactly a child node, is it? There is of_get_child_count() but this isn't a child, it is one property. is it because we haven't

[PATCH 2/2] musb: musb: dsps: determine the number of instances at runtime

2013-06-17 Thread Sebastian Andrzej Siewior
There is no need to hardcode the number of instances here. It is better to determine them at runtime. Even if the device provides two instances one might only want to use one of them. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/usb/musb/musb_dsps.c | 33