[PATCH 3/4] ASoC: TWL4030: Only update the needed bits in *set_dai_sysclk

2009-10-19 Thread Peter Ujfalusi
Do not rewrite the whole register, but only update the needed bits in set_dai_sysclk functions. Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com --- sound/soc/codecs/twl4030.c | 22 -- 1 files changed, 12 insertions(+), 10 deletions(-) diff --git

Re: [PATCH 3/4] ASoC: TWL4030: Only update the needed bits in *set_dai_sysclk

2009-10-19 Thread Mark Brown
On Mon, Oct 19, 2009 at 03:42:19PM +0300, Peter Ujfalusi wrote: + apll_ctrl = twl4030_read_reg_cache(codec, TWL4030_REG_APLL_CTL); + apll_ctrl = ~TWL4030_APLL_INFREQ; switch (freq) { I'll apply this - it's idiomatic for the current driver - but you might want to look at

Re: [PATCH 3/4] ASoC: TWL4030: Only update the needed bits in *set_dai_sysclk

2009-10-19 Thread Peter Ujfalusi
On Monday 19 October 2009 15:55:08 ext Mark Brown wrote: On Mon, Oct 19, 2009 at 03:42:19PM +0300, Peter Ujfalusi wrote: + apll_ctrl = twl4030_read_reg_cache(codec, TWL4030_REG_APLL_CTL); + apll_ctrl = ~TWL4030_APLL_INFREQ; switch (freq) { I'll apply this - it's idiomatic for the