Re: [PATCH 5/5] ARM: OMAP2+: clean up some cppcheck warnings

2012-03-13 Thread Jarkko Nikula
On 03/13/2012 12:43 AM, Paul Walmsley wrote: Resolve some warnings identified by cppcheck in arch/arm/mach-omap2: ... [arch/arm/mach-omap2/mcbsp.c:133]: (warning) scanf without field width limits can crash with huge input data ... diff --git a/arch/arm/mach-omap2/mcbsp.c

Re: [PATCH 5/5] ARM: OMAP2+: clean up some cppcheck warnings

2012-03-13 Thread Paul Walmsley
On Tue, 13 Mar 2012, Jarkko Nikula wrote: On 03/13/2012 12:43 AM, Paul Walmsley wrote: Resolve some warnings identified by cppcheck in arch/arm/mach-omap2: ... [arch/arm/mach-omap2/mcbsp.c:133]: (warning) scanf without field width limits can crash with huge input data ... diff

[PATCH 5/5] ARM: OMAP2+: clean up some cppcheck warnings

2012-03-12 Thread Paul Walmsley
Resolve some warnings identified by cppcheck in arch/arm/mach-omap2: [arch/arm/mach-omap2/usb-tusb6010.c:129]: (style) Checking if unsigned variable 'tmp' is less than zero. [arch/arm/mach-omap2/prm_common.c:241]: (error) Possible null pointer dereference: irq_setup - otherwise it is