Re: [lm-sensors] [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver

2011-09-08 Thread Mark Brown
On Wed, Aug 31, 2011 at 09:40:47PM -0700, Guenter Roeck wrote: On Thu, Sep 01, 2011 at 12:09:14AM -0400, Paul Walmsley wrote: So based on your comments, it sounds like we should move that part of the code to a different driver, and just leave the basic software thermal monitoring here?

Re: [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver

2011-09-06 Thread J, KEERTHY
On Thu, Sep 1, 2011 at 5:26 AM, Paul Walmsley p...@pwsan.com wrote: Hi, On Wed, 31 Aug 2011, Keerthy wrote: On chip temperature sensor driver. The driver monitors the temperature of the MPU subsystem of the OMAP4. It sends notifications to the user space if the temperature crosses user

Re: [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver

2011-09-06 Thread J, KEERTHY
On Thu, Sep 1, 2011 at 6:06 AM, Paul Walmsley p...@pwsan.com wrote: Hi Some comments. On Wed, 31 Aug 2011, Keerthy wrote: diff --git a/drivers/hwmon/omap_temp_sensor.c b/drivers/hwmon/omap_temp_sensor.c new file mode 100644 index 000..67fa424 --- /dev/null +++

Re: [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver

2011-09-06 Thread J, KEERTHY
On Thu, Sep 1, 2011 at 9:39 AM, Paul Walmsley p...@pwsan.com wrote: On Wed, 31 Aug 2011, Guenter Roeck wrote: On Wed, Aug 31, 2011 at 08:36:43PM -0400, Paul Walmsley wrote: Hi Some comments. On Wed, 31 Aug 2011, Keerthy wrote: [ ... ] +} + +/* Sysfs hook functions */

Re: [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver

2011-09-06 Thread J, KEERTHY
On Thu, Sep 1, 2011 at 10:10 AM, Guenter Roeck guenter.ro...@ericsson.com wrote: On Thu, Sep 01, 2011 at 12:09:14AM -0400, Paul Walmsley wrote: On Wed, 31 Aug 2011, Guenter Roeck wrote: On Wed, Aug 31, 2011 at 08:36:43PM -0400, Paul Walmsley wrote: Hi Some comments. On Wed, 31

Re: [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver

2011-09-06 Thread Guenter Roeck
On Tue, 2011-09-06 at 14:02 -0400, J, KEERTHY wrote: On Thu, Sep 1, 2011 at 10:10 AM, Guenter Roeck guenter.ro...@ericsson.com wrote: On Thu, Sep 01, 2011 at 12:09:14AM -0400, Paul Walmsley wrote: On Wed, 31 Aug 2011, Guenter Roeck wrote: On Wed, Aug 31, 2011 at 08:36:43PM -0400, Paul

Re: [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver

2011-09-06 Thread J, KEERTHY
On Tue, Sep 6, 2011 at 11:42 PM, Guenter Roeck guenter.ro...@ericsson.com wrote: On Tue, 2011-09-06 at 14:02 -0400, J, KEERTHY wrote: On Thu, Sep 1, 2011 at 10:10 AM, Guenter Roeck guenter.ro...@ericsson.com wrote: On Thu, Sep 01, 2011 at 12:09:14AM -0400, Paul Walmsley wrote: On Wed, 31

[PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver

2011-08-31 Thread Keerthy
On chip temperature sensor driver. The driver monitors the temperature of the MPU subsystem of the OMAP4. It sends notifications to the user space if the temperature crosses user defined thresholds via kobject_uevent interface. The user is allowed to configure the temperature thresholds vis sysfs

Re: [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver

2011-08-31 Thread Paul Walmsley
Hi, On Wed, 31 Aug 2011, Keerthy wrote: On chip temperature sensor driver. The driver monitors the temperature of the MPU subsystem of the OMAP4. It sends notifications to the user space if the temperature crosses user defined thresholds via kobject_uevent interface. The user is allowed to

Re: [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver

2011-08-31 Thread Paul Walmsley
Hi Some comments. On Wed, 31 Aug 2011, Keerthy wrote: diff --git a/drivers/hwmon/omap_temp_sensor.c b/drivers/hwmon/omap_temp_sensor.c new file mode 100644 index 000..67fa424 --- /dev/null +++ b/drivers/hwmon/omap_temp_sensor.c @@ -0,0 +1,881 @@ You've done almost all the hard work

Re: [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver

2011-08-31 Thread Guenter Roeck
On Wed, Aug 31, 2011 at 08:36:43PM -0400, Paul Walmsley wrote: Hi Some comments. On Wed, 31 Aug 2011, Keerthy wrote: [ ... ] +} + +/* Sysfs hook functions */ These should be conditionally compiled out if sysfs isn't compiled in. The whole point of the hwmon subsystem is to

Re: [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver

2011-08-31 Thread Paul Walmsley
On Wed, 31 Aug 2011, Guenter Roeck wrote: On Wed, Aug 31, 2011 at 08:36:43PM -0400, Paul Walmsley wrote: Hi Some comments. On Wed, 31 Aug 2011, Keerthy wrote: [ ... ] +} + +/* Sysfs hook functions */ These should be conditionally compiled out if sysfs isn't

Re: [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver

2011-08-31 Thread Guenter Roeck
On Wed, Aug 31, 2011 at 01:25:10PM -0400, Keerthy wrote: On chip temperature sensor driver. The driver monitors the temperature of the MPU subsystem of the OMAP4. It sends notifications to the user space if the temperature crosses user defined thresholds via kobject_uevent interface. The user

Re: [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver

2011-08-31 Thread Guenter Roeck
On Thu, Sep 01, 2011 at 12:09:14AM -0400, Paul Walmsley wrote: On Wed, 31 Aug 2011, Guenter Roeck wrote: On Wed, Aug 31, 2011 at 08:36:43PM -0400, Paul Walmsley wrote: Hi Some comments. On Wed, 31 Aug 2011, Keerthy wrote: [ ... ] +} + +/* Sysfs hook