RE: [PATCH resend] OMAP: DSS2: Replace strncmp() with sysfs_streq() in overlay_manager_store()

2010-07-29 Thread Premi, Sanjeev
-Original Message- From: Taneja, Archit Sent: Thursday, July 29, 2010 11:27 AM To: Premi, Sanjeev; tomi.valkei...@nokia.com Cc: linux-omap@vger.kernel.org Subject: RE: [PATCH resend] OMAP: DSS2: Replace strncmp() with sysfs_streq() in overlay_manager_store() [snip]...[snip

RE: [PATCH resend] OMAP: DSS2: Replace strncmp() with sysfs_streq() in overlay_manager_store()

2010-07-29 Thread Taneja, Archit
[snip] [sp] This explains. And my earlier comment was to update the description with need for change. I believe quick summary the discussion above will be good for the patch. Okay, will do. But what am is supposed to add more in the summary? Should I add how sysfs_streq is a

RE: [PATCH resend] OMAP: DSS2: Replace strncmp() with sysfs_streq() in overlay_manager_store()

2010-07-29 Thread Premi, Sanjeev
-Original Message- From: Taneja, Archit Sent: Thursday, July 29, 2010 4:40 PM To: Premi, Sanjeev; tomi.valkei...@nokia.com Cc: linux-omap@vger.kernel.org Subject: RE: [PATCH resend] OMAP: DSS2: Replace strncmp() with sysfs_streq() in overlay_manager_store() [snip

[PATCH resend] OMAP: DSS2: Replace strncmp() with sysfs_streq() in overlay_manager_store()

2010-07-28 Thread Archit Taneja
In the function overlay_manager_store, the length of the string buf is used to comapre the 2 strings, there is a possibility of false positive match if buf is a prefix string of another manager. The use of sysfs_streq() fixes this. Signed-off-by: Archit Taneja arc...@ti.com ---

RE: [PATCH resend] OMAP: DSS2: Replace strncmp() with sysfs_streq() in overlay_manager_store()

2010-07-28 Thread Premi, Sanjeev
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Taneja, Archit Sent: Wednesday, July 28, 2010 11:52 AM To: tomi.valkei...@nokia.com Cc: linux-omap@vger.kernel.org; Taneja, Archit Subject: [PATCH resend] OMAP: DSS2

RE: [PATCH resend] OMAP: DSS2: Replace strncmp() with sysfs_streq() in overlay_manager_store()

2010-07-28 Thread Taneja, Archit
-Original Message- From: Premi, Sanjeev Sent: Wednesday, July 28, 2010 7:28 PM To: Taneja, Archit; tomi.valkei...@nokia.com Cc: linux-omap@vger.kernel.org Subject: RE: [PATCH resend] OMAP: DSS2: Replace strncmp() with sysfs_streq() in overlay_manager_store() -Original

RE: [PATCH resend] OMAP: DSS2: Replace strncmp() with sysfs_streq() in overlay_manager_store()

2010-07-28 Thread Premi, Sanjeev
-Original Message- From: Taneja, Archit Sent: Wednesday, July 28, 2010 8:06 PM To: Premi, Sanjeev; tomi.valkei...@nokia.com Cc: linux-omap@vger.kernel.org Subject: RE: [PATCH resend] OMAP: DSS2: Replace strncmp() with sysfs_streq() in overlay_manager_store

RE: [PATCH resend] OMAP: DSS2: Replace strncmp() with sysfs_streq() in overlay_manager_store()

2010-07-28 Thread Taneja, Archit
: [PATCH resend] OMAP: DSS2: Replace strncmp() with sysfs_streq() in overlay_manager_store() In the function overlay_manager_store, the length of the string buf is used to comapre the 2 strings, there is a possibility of false positive match if buf is a prefix string of another

RE: [PATCH resend] OMAP: DSS2: Replace strncmp() with sysfs_streq() in overlay_manager_store()

2010-07-28 Thread Premi, Sanjeev
-Original Message- From: Taneja, Archit Sent: Thursday, July 29, 2010 9:16 AM To: Premi, Sanjeev; tomi.valkei...@nokia.com Cc: linux-omap@vger.kernel.org Subject: RE: [PATCH resend] OMAP: DSS2: Replace strncmp() with sysfs_streq() in overlay_manager_store() -Original

RE: [PATCH resend] OMAP: DSS2: Replace strncmp() with sysfs_streq() in overlay_manager_store()

2010-07-28 Thread Taneja, Archit
Subject: [PATCH resend] OMAP: DSS2: Replace strncmp() with sysfs_streq() in overlay_manager_store() In the function overlay_manager_store, the length of the string buf is used to comapre the 2 strings, there is a possibility of false positive match if buf