Implement the suggested workaround for OMAP3 regarding to sDMA draining
issue, when the channel is disabled on the fly.
This errata affects the following configuration:
sDMA transfer is source synchronized
Buffering is enabled
SmartStandby is selected.
The issue can be easily reproduced by
Hi,
On Fri, Oct 01, 2010 at 01:04:55PM +0200, ext Peter Ujfalusi wrote:
Implement the suggested workaround for OMAP3 regarding to sDMA draining
issue, when the channel is disabled on the fly.
This errata affects the following configuration:
sDMA transfer is source synchronized
Buffering is
On Friday 01 October 2010 14:50:37 David Cohen wrote:
+ l = sys_cf = dma_read(OCP_SYSCONFIG);
Shouldn't it be avoided?
I'm restoring the OCP_SYSCONFIG register later on, and reusing 'l' here to
avoid
confusing expression when moving the sDMA to NoStandby.
I could as well
On Fri, Oct 01, 2010 at 07:16:53AM -0500, Peter Ujfalusi wrote:
On Friday 01 October 2010 14:50:37 David Cohen wrote:
+ l = sys_cf = dma_read(OCP_SYSCONFIG);
Shouldn't it be avoided?
I'm restoring the OCP_SYSCONFIG register later on, and reusing 'l' here to avoid
confusing
On Fri, Oct 01, 2010 at 02:16:53PM +0200, Peter Ujfalusi wrote:
On Friday 01 October 2010 14:50:37 David Cohen wrote:
+ l = sys_cf = dma_read(OCP_SYSCONFIG);
Shouldn't it be avoided?
I'm restoring the OCP_SYSCONFIG register later on, and reusing 'l' here to
avoid
On Friday 01 October 2010 15:24:41 ext Felipe Balbi wrote:
I think David is concerned about multiple assigments in one line.
CodingStyle asks to avoid that. So probably:
Yes, I did noticed that after I've sent the reply.
sys_cf = dma_read(OCP_SYSCONFIG);
l = sys_cf;
would make
On Friday 01 October 2010 15:17:16 David Cohen wrote:
No problem with those two variables, but you're doing multiple
assignments in one line. You could do something like this:
l = dma_read(OCP_SYSCONFIG);
sys_cf = l;
I have sent the v3 with this fixed.
Thanks you,
Péter
--
To unsubscribe
