Re: [PATCH v3 2/2] drivers: cleanup Kconfig stuff

2010-11-02 Thread Mark Brown
On Tue, Nov 02, 2010 at 02:14:13AM +0200, Felipe Contreras wrote: config REGULATOR_TWL4030 bool TI TWL4030/TWL5030/TWL6030/TPS695x0 PMIC depends on TWL4030_CORE + default y help This driver supports the voltage regulators provided by this family of

Re: [PATCH v3 2/2] drivers: cleanup Kconfig stuff

2010-11-02 Thread Felipe Contreras
On Tue, Nov 2, 2010 at 3:11 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Tue, Nov 02, 2010 at 02:14:13AM +0200, Felipe Contreras wrote:  config REGULATOR_TWL4030       bool TI TWL4030/TWL5030/TWL6030/TPS695x0 PMIC       depends on TWL4030_CORE +     default y       help    

Re: [PATCH v3 2/2] drivers: cleanup Kconfig stuff

2010-11-02 Thread Uwe Kleine-König
On Tue, Nov 02, 2010 at 04:02:18PM +0200, Felipe Contreras wrote: On Tue, Nov 2, 2010 at 3:11 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Tue, Nov 02, 2010 at 02:14:13AM +0200, Felipe Contreras wrote:  config REGULATOR_TWL4030       bool TI

Re: [PATCH v3 2/2] drivers: cleanup Kconfig stuff

2010-11-02 Thread Uwe Kleine-König
On Tue, Nov 02, 2010 at 02:14:13AM +0200, Felipe Contreras wrote: Add missing dependencies, and remove redundant ones, and select sensible defaults. This is more user-friendly, and logical. - TWL4030_CORE people should be able to compile without ARM - REGULATOR_TWL4030 if TWL4030_CORE

Re: [PATCH v3 2/2] drivers: cleanup Kconfig stuff

2010-11-02 Thread Felipe Contreras
2010/11/2 Uwe Kleine-König u.kleine-koe...@pengutronix.de: On Tue, Nov 02, 2010 at 04:02:18PM +0200, Felipe Contreras wrote: On Tue, Nov 2, 2010 at 3:11 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Tue, Nov 02, 2010 at 02:14:13AM +0200, Felipe Contreras wrote:  config

Re: [PATCH v3 2/2] drivers: cleanup Kconfig stuff

2010-11-02 Thread Felipe Contreras
2010/11/2 Uwe Kleine-König u.kleine-koe...@pengutronix.de: On Tue, Nov 02, 2010 at 02:14:13AM +0200, Felipe Contreras wrote: Add missing dependencies, and remove redundant ones, and select sensible defaults. This is more user-friendly, and logical.  - TWL4030_CORE people should be able to

Re: [PATCH v3 2/2] drivers: cleanup Kconfig stuff

2010-11-02 Thread Mark Brown
On Tue, Nov 02, 2010 at 04:02:18PM +0200, Felipe Contreras wrote: On Tue, Nov 2, 2010 at 3:11 PM, Mark Brown This default is not suitable for non-OMAP platforms, it should be conditional on OMAP or something if we're going to do this (though generally we handle this with defconfigs rather

Re: [PATCH v3 2/2] drivers: cleanup Kconfig stuff

2010-11-02 Thread Mark Brown
On Tue, Nov 02, 2010 at 04:18:18PM +0200, Felipe Contreras wrote: 2010/11/2 Uwe Kleine-König u.kleine-koe...@pengutronix.de: Well, all platforms that have TWL4030_CORE will get REGULATOR_TWL4030 by default, too.  (TWL4030_CORE doesn't depend on something omapish.) Yes, I think TWL4030_CORE

Re: [PATCH v3 2/2] drivers: cleanup Kconfig stuff

2010-11-02 Thread Felipe Contreras
On Tue, Nov 2, 2010 at 4:35 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Tue, Nov 02, 2010 at 04:02:18PM +0200, Felipe Contreras wrote: On Tue, Nov 2, 2010 at 3:11 PM, Mark Brown This default is not suitable for non-OMAP platforms, it should be conditional on OMAP or

Re: [PATCH v3 2/2] drivers: cleanup Kconfig stuff

2010-11-02 Thread Felipe Contreras
On Tue, Nov 2, 2010 at 4:39 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Tue, Nov 02, 2010 at 04:18:18PM +0200, Felipe Contreras wrote: 2010/11/2 Uwe Kleine-König u.kleine-koe...@pengutronix.de: Well, all platforms that have TWL4030_CORE will get REGULATOR_TWL4030 by

Re: [PATCH v3 2/2] drivers: cleanup Kconfig stuff

2010-11-02 Thread Mark Brown
On Tue, Nov 02, 2010 at 09:43:30PM +0200, Felipe Contreras wrote: On Tue, Nov 2, 2010 at 4:35 PM, Mark Brown This solution doesn't seem like it scales so well either, it just shifts it into the Kconfig files (where everything is all in central files shared by everyone which has its own

Re: [PATCH v3 2/2] drivers: cleanup Kconfig stuff

2010-11-02 Thread Mark Brown
On Tue, Nov 02, 2010 at 09:46:47PM +0200, Felipe Contreras wrote: On Tue, Nov 2, 2010 at 4:39 PM, Mark Brown It did originally but that dependency was removed to allow build coverage for non-OMAP users. I'm not sure removing that dependency is worth it. There's probably a lot of code in

[PATCH v3 2/2] drivers: cleanup Kconfig stuff

2010-11-01 Thread Felipe Contreras
Add missing dependencies, and remove redundant ones, and select sensible defaults. This is more user-friendly, and logical. - TWL4030_CORE people should be able to compile without ARM - REGULATOR_TWL4030 if TWL4030_CORE and REGULATOR, it's pretty clear we want this - USB_GADGET_SELECTED is