Re: [PATCHv5 16/18] I2C: OMAP: fix missing handling of errata I2C_OMAP3_1P153

2012-04-05 Thread Jon Hunter
On 04/04/2012 02:22 PM, Jon Hunter wrote: Hi Shubhro, On 04/04/2012 12:45 PM, Shubhrajyoti Datta wrote: Hi Jon, + if (dev-flags OMAP_I2C_FLAG_APPLY_ERRATA_I207) + dev-errata |= I2C_OMAP_ERRATA_I207; + if (dev-rev= OMAP_I2C_REV_ON_3430_3530) dev-errata |= I2C_OMAP3_1P153; The errata ID

Re: [PATCHv5 16/18] I2C: OMAP: fix missing handling of errata I2C_OMAP3_1P153

2012-04-04 Thread Jon Hunter
Hi Shubhro, On 04/03/2012 11:02 AM, Shubhrajyoti D wrote: From: Tasslehoff Kjappfottasskj...@gmail.com i2c_probe set the dev-errata flag, but omap_i2c_init cleared the flag again. Move the errata handling to i2c_probe. Signed-off-by: Tasslehoff Kjappfottasskj...@gmail.com Signed-off-by:

Re: [PATCHv5 16/18] I2C: OMAP: fix missing handling of errata I2C_OMAP3_1P153

2012-04-04 Thread Shubhrajyoti Datta
Hi Jon, +       if (dev-flags  OMAP_I2C_FLAG_APPLY_ERRATA_I207) +               dev-errata |= I2C_OMAP_ERRATA_I207; +        if (dev-rev= OMAP_I2C_REV_ON_3430_3530)                dev-errata |= I2C_OMAP3_1P153; The errata ID is not correct. I believe that 1P153 is referring to the

Re: [PATCHv5 16/18] I2C: OMAP: fix missing handling of errata I2C_OMAP3_1P153

2012-04-04 Thread Jon Hunter
Hi Shubhro, On 04/04/2012 12:45 PM, Shubhrajyoti Datta wrote: Hi Jon, + if (dev-flagsOMAP_I2C_FLAG_APPLY_ERRATA_I207) + dev-errata |= I2C_OMAP_ERRATA_I207; + if (dev-rev= OMAP_I2C_REV_ON_3430_3530) dev-errata |= I2C_OMAP3_1P153; The errata

[PATCHv5 16/18] I2C: OMAP: fix missing handling of errata I2C_OMAP3_1P153

2012-04-03 Thread Shubhrajyoti D
From: Tasslehoff Kjappfot tasskj...@gmail.com i2c_probe set the dev-errata flag, but omap_i2c_init cleared the flag again. Move the errata handling to i2c_probe. Signed-off-by: Tasslehoff Kjappfot tasskj...@gmail.com Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com ---