Re: OMAP: DSS2: Common IRQ handler for all OMAPs

2011-02-15 Thread archit taneja
Hi, On Tuesday 15 February 2011 01:15 PM, Valkeinen, Tomi wrote: snip I'm not familiar with genirq/irq_chip. But yes, as Archit said, we can mask/unmask DSS interrupts. I mean, there's only one interrupt line, but DSS has irqstatus and irqenable registers that can be used. If I understood

Re: OMAP: DSS2: Common IRQ handler for all OMAPs

2011-02-15 Thread Felipe Balbi
Hi, On Tue, Feb 15, 2011 at 09:58:24AM +0530, archit taneja wrote: does it make sense to install an irq_chip for that ? I mean, can you mask/unmask dss and or dsi IRQs ? If you can, then it might make sense to take a look into GENIRQ and install an irq_chip for that. Then both dsi and dss

Re: OMAP: DSS2: Common IRQ handler for all OMAPs

2011-02-15 Thread archit taneja
Hi, On Tuesday 15 February 2011 01:35 PM, Balbi, Felipe wrote: Hi, On Tue, Feb 15, 2011 at 09:58:24AM +0530, archit taneja wrote: does it make sense to install an irq_chip for that ? I mean, can you mask/unmask dss and or dsi IRQs ? If you can, then it might make sense to take a look into

Re: OMAP: DSS2: Common IRQ handler for all OMAPs

2011-02-15 Thread Felipe Balbi
Hi, On Tue, Feb 15, 2011 at 01:50:49PM +0530, archit taneja wrote: yes it is. Then it makes sense to have an irq_chip for those two irqs, I think. /proc/interrupt will reflect how the hardware works (DSI and DISPC IRQs being handled by DSS), both dsi and dispc can use normal request_irq()

Re: OMAP: DSS2: Common IRQ handler for all OMAPs

2011-02-15 Thread archit taneja
Hi, On Tuesday 15 February 2011 12:57 PM, Valkeinen, Tomi wrote: snip I meant something like this: dispc.c: dispc_init() { /* did we have a pdev for dispc? if not, this needs to be dss.pdev */ request_irq(platform_get_irq(dispc.pdev, 0), irq_handler, IRQF_SHARED, dispc irq,

Re: OMAP: DSS2: Common IRQ handler for all OMAPs

2011-02-15 Thread Tomi Valkeinen
On Tue, 2011-02-15 at 02:30 -0600, Taneja, Archit wrote: Hi, On Tuesday 15 February 2011 12:57 PM, Valkeinen, Tomi wrote: snip I meant something like this: dispc.c: dispc_init() { /* did we have a pdev for dispc? if not, this needs to be dss.pdev */

Re: OMAP: DSS2: Common IRQ handler for all OMAPs

2011-02-15 Thread archit taneja
Hi, On Tuesday 15 February 2011 02:07 PM, Valkeinen, Tomi wrote: On Tue, 2011-02-15 at 02:30 -0600, Taneja, Archit wrote: Hi, On Tuesday 15 February 2011 12:57 PM, Valkeinen, Tomi wrote: snip I meant something like this: dispc.c: dispc_init() { /* did we have a pdev for dispc? if

Re: OMAP: DSS2: Common IRQ handler for all OMAPs

2011-02-15 Thread archit taneja
Copying Benoit, On Tuesday 15 February 2011 02:07 PM, Valkeinen, Tomi wrote: On Tue, 2011-02-15 at 02:30 -0600, Taneja, Archit wrote: Hi, On Tuesday 15 February 2011 12:57 PM, Valkeinen, Tomi wrote: snip I meant something like this: dispc.c: dispc_init() { /* did we have a pdev

Re: OMAP: DSS2: Common IRQ handler for all OMAPs

2011-02-15 Thread Cousson, Benoit
Hi Archit, On 2/15/2011 10:25 AM, Taneja, Archit wrote: Copying Benoit, On Tuesday 15 February 2011 02:07 PM, Valkeinen, Tomi wrote: On Tue, 2011-02-15 at 02:30 -0600, Taneja, Archit wrote: Hi, On Tuesday 15 February 2011 12:57 PM, Valkeinen, Tomi wrote: snip I meant something like this:

Re: OMAP: DSS2: Common IRQ handler for all OMAPs

2011-02-15 Thread Semwal, Sumit
Hi Benoit, On Tue, Feb 15, 2011 at 3:53 PM, Cousson, Benoit b-cous...@ti.com wrote: Hi Archit, On 2/15/2011 10:25 AM, Taneja, Archit wrote: Copying Benoit, On Tuesday 15 February 2011 02:07 PM, Valkeinen, Tomi wrote: On Tue, 2011-02-15 at 02:30 -0600, Taneja, Archit wrote: Hi, On

Re: OMAP: DSS2: Common IRQ handler for all OMAPs

2011-02-15 Thread Cousson, Benoit
Hi Sumit, On 2/15/2011 11:28 AM, Semwal, Sumit wrote: Hi Benoit, On Tue, Feb 15, 2011 at 3:53 PM, Cousson, Benoitb-cous...@ti.com wrote: Hi Archit, On 2/15/2011 10:25 AM, Taneja, Archit wrote: Copying Benoit, On Tuesday 15 February 2011 02:07 PM, Valkeinen, Tomi wrote: On Tue,

Re: OMAP: DSS2: Common IRQ handler for all OMAPs

2011-02-15 Thread Felipe Balbi
Hi, On Tue, Feb 15, 2011 at 10:37:37AM +0200, Tomi Valkeinen wrote: This approach looks clean, but isn't IRQF_SHARED used the other way around. One irq line and multiple handlers? That is the case here, isn't it (on omap3)? One interrupt line (the DSS irq, the same returned both from

Re: OMAP: DSS2: Common IRQ handler for all OMAPs

2011-02-15 Thread Tomi Valkeinen
On Tue, 2011-02-15 at 04:57 -0600, Balbi, Felipe wrote: Hi, On Tue, Feb 15, 2011 at 10:37:37AM +0200, Tomi Valkeinen wrote: This approach looks clean, but isn't IRQF_SHARED used the other way around. One irq line and multiple handlers? That is the case here, isn't it (on omap3)?

Re: OMAP: DSS2: Common IRQ handler for all OMAPs

2011-02-15 Thread Felipe Balbi
Hi, On Tue, Feb 15, 2011 at 01:25:34PM +0200, Tomi Valkeinen wrote: On Tue, Feb 15, 2011 at 10:37:37AM +0200, Tomi Valkeinen wrote: This approach looks clean, but isn't IRQF_SHARED used the other way around. One irq line and multiple handlers? That is the case here, isn't it (on

Re: OMAP: DSS2: Common IRQ handler for all OMAPs

2011-02-15 Thread archit taneja
Hi, snip Is it okay to have the same irq entry for 2 different hwmods? This requirement comes from OMAP3 where dispc and dsi have a common irq line, where as on OMAP4 dispc and dsi have separate irq lines. Well, no. I explained that in one of my comment about hwmod modification. The hwmod

Re: OMAP: DSS2: Common IRQ handler for all OMAPs

2011-02-15 Thread Cousson, Benoit
On 2/15/2011 1:43 PM, Taneja, Archit wrote: Hi, snip Is it okay to have the same irq entry for 2 different hwmods? This requirement comes from OMAP3 where dispc and dsi have a common irq line, where as on OMAP4 dispc and dsi have separate irq lines. Well, no. I explained that in one of my

Re: OMAP: DSS2: Common IRQ handler for all OMAPs

2011-02-14 Thread Tomi Valkeinen
Hi, On Wed, 2011-02-02 at 08:56 +, archit taneja wrote: OMAP2 has an irq line dedicated for DISPC interrupts, there is no DSI on omap2. OMAP3 has a common irq line for DISPC and DSI interrupts. OMAP4 has seperate irq lines for DISPC and DSI Interrupts. Use dss_features to have a common

Re: OMAP: DSS2: Common IRQ handler for all OMAPs

2011-02-14 Thread Felipe Balbi
Hi, On Mon, Feb 14, 2011 at 04:21:47PM +0200, Tomi Valkeinen wrote: On Wed, 2011-02-02 at 08:56 +, archit taneja wrote: OMAP2 has an irq line dedicated for DISPC interrupts, there is no DSI on omap2. OMAP3 has a common irq line for DISPC and DSI interrupts. OMAP4 has seperate irq

Re: OMAP: DSS2: Common IRQ handler for all OMAPs

2011-02-14 Thread archit taneja
Hi, On Monday 14 February 2011 08:00 PM, Balbi, Felipe wrote: Hi, On Mon, Feb 14, 2011 at 04:21:47PM +0200, Tomi Valkeinen wrote: On Wed, 2011-02-02 at 08:56 +, archit taneja wrote: OMAP2 has an irq line dedicated for DISPC interrupts, there is no DSI on omap2. OMAP3 has a common irq

Re: OMAP: DSS2: Common IRQ handler for all OMAPs

2011-02-14 Thread Tomi Valkeinen
On Mon, 2011-02-14 at 22:28 -0600, Taneja, Archit wrote: Hi, On Monday 14 February 2011 08:00 PM, Balbi, Felipe wrote: Hi, On Mon, Feb 14, 2011 at 04:21:47PM +0200, Tomi Valkeinen wrote: On Wed, 2011-02-02 at 08:56 +, archit taneja wrote: OMAP2 has an irq line dedicated for DISPC

Re: OMAP: DSS2: Common IRQ handler for all OMAPs

2011-02-14 Thread Tomi Valkeinen
On Mon, 2011-02-14 at 08:30 -0600, Balbi, Felipe wrote: Hi, On Mon, Feb 14, 2011 at 04:21:47PM +0200, Tomi Valkeinen wrote: On Wed, 2011-02-02 at 08:56 +, archit taneja wrote: OMAP2 has an irq line dedicated for DISPC interrupts, there is no DSI on omap2. OMAP3 has a common irq

[PATCH] OMAP: DSS2: Common IRQ handler for all OMAPs

2011-02-02 Thread Archit Taneja
OMAP2 has an irq line dedicated for DISPC interrupts, there is no DSI on omap2. OMAP3 has a common irq line for DISPC and DSI interrupts. OMAP4 has seperate irq lines for DISPC and DSI Interrupts. Use dss_features to have a common DSS irq handler for all OMAP revisions. Also, use a member of the