Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-05 Thread Paul Walmsley
Hello Benoît, Rajendra, Kevin, On Fri, 1 Oct 2010, Cousson, Benoit wrote: The issue is that 2420 idlest does not reflect the real status of the OCP bus clock, but just the fact that the idle_req is asserted or not. So potentially, the IP is still not accessible when you think it is. This

RE: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-05 Thread Nayak, Rajendra
: OMAP hwmod driver conversions: watchdog, UART, i2c Hello Benoît, Rajendra, Kevin, On Fri, 1 Oct 2010, Cousson, Benoit wrote: The issue is that 2420 idlest does not reflect the real status of the OCP bus clock, but just the fact that the idle_req is asserted or not. So

RE: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-05 Thread Paul Walmsley
On Tue, 5 Oct 2010, Paul Walmsley wrote: On Tue, 5 Oct 2010, Nayak, Rajendra wrote: -Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Tuesday, October 05, 2010 11:32 AM Some IP blocks may require extra time to become ready for register reads/writes

RE: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-05 Thread Nayak, Rajendra
snip.. Below is an untested patch to provide some mechanism to deal with this -- I'd appreciate everyone's comments on this, particularly the comments in the patch code on how to deal with this problem. Hi Paul, I'll test this patch to see if it solves the issue seen with i2c on

RE: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-05 Thread Nayak, Rajendra
hwmod driver conversions: watchdog, UART, i2c snip.. Below is an untested patch to provide some mechanism to deal with this -- I'd appreciate everyone's comments on this, particularly the comments in the patch code on how to deal with this problem. Hi Paul, I'll test

Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-05 Thread Cousson, Benoit
Hi Paul, On 10/5/2010 8:01 AM, Paul Walmsley wrote: Hello Benoît, Rajendra, Kevin, On Fri, 1 Oct 2010, Cousson, Benoit wrote: The issue is that 2420 idlest does not reflect the real status of the OCP bus clock, but just the fact that the idle_req is asserted or not. So potentially, the IP

Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-05 Thread Kevin Hilman
Nayak, Rajendra rna...@ti.com writes: snip.. Below is an untested patch to provide some mechanism to deal with this -- I'd appreciate everyone's comments on this, particularly the comments in the patch code on how to deal with this problem. Hi Paul, I'll test this patch to see if

RE: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-05 Thread Paul Walmsley
On Tue, 5 Oct 2010, Paul Walmsley wrote: __raw_writew(v, oh-_mpu_rt_va + reg_offs); 28: 16ff3070uxthne r3, r0 2c: 118130b2strhne r3, [r1, r2] gcc for some reason decides to zero-extend it first, but that is not your bug to fix.

RE: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-05 Thread Nayak, Rajendra
: OMAP hwmod driver conversions: watchdog, UART, i2c On Tue, 5 Oct 2010, Nayak, Rajendra wrote: So looks like the issue with i2c on n800 isn't really because of additional delay needed after a clock enable, but related to the omap_readl/writel's done on the 16bit i2c registers as I

RE: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-05 Thread Nayak, Rajendra
] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c Nayak, Rajendra rna...@ti.com writes: snip.. Below is an untested patch to provide some mechanism to deal with this -- I'd appreciate everyone's comments on this, particularly the comments in the patch code

Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-05 Thread Kevin Hilman
, Govindraj Subject: Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c Nayak, Rajendra rna...@ti.com writes: snip.. Below is an untested patch to provide some mechanism to deal with this -- I'd appreciate everyone's comments

RE: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-05 Thread Nayak, Rajendra
; Tony Lindgren; linux-omap@vger.kernel.org; Varadarajan, Charulatha; Raja, Govindraj Subject: Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c Nayak, Rajendra rna...@ti.com writes: snip.. Below is an untested patch to provide some mechanism

Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-05 Thread Kevin Hilman
; Raja, Govindraj Subject: Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c Nayak, Rajendra rna...@ti.com writes: -Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Tuesday, October 05, 2010 10:34 PM To: Nayak, Rajendra

RE: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-05 Thread Nayak, Rajendra
; Tony Lindgren; linux-omap@vger.kernel.org; Varadarajan, Charulatha; Raja, Govindraj Subject: Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c Nayak, Rajendra rna...@ti.com writes: -Original Message- From: Kevin Hilman [mailto:khil

Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-05 Thread Kevin Hilman
; Raja, Govindraj Subject: Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c Nayak, Rajendra rna...@ti.com writes: -Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Wednesday, October 06, 2010 1:19 AM To: Nayak, Rajendra

RE: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-05 Thread Nayak, Rajendra
; Tony Lindgren; linux-omap@vger.kernel.org; Varadarajan, Charulatha; Raja, Govindraj Subject: Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c Nayak, Rajendra rna...@ti.com writes: -Original Message- From: Kevin Hilman [mailto:khil

RE: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-01 Thread Nayak, Rajendra
-Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Thursday, September 30, 2010 9:37 PM To: Tony Lindgren; Nayak, Rajendra Cc: linux-omap@vger.kernel.org; Varadarajan, Charulatha; Raja, Govindraj Subject: Re: [GIT PULL] for testing: OMAP hwmod driver

Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-01 Thread Kevin Hilman
Nayak, Rajendra rna...@ti.com writes: [...] Hmm, this fault is very early and long before any PM code has initialzed. I suspect this happens with the master branch too ?? I've reproduced this now, and it doesn't happen on the master branch and only happens after merge pm-hwmods.

Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-01 Thread Cousson, Benoit
: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c Kevin Hilmankhil...@deeprootsystems.com writes: Kevin Hilmankhil...@deeprootsystems.com writes: Tony Lindgrent...@atomide.com writes: * Kevin Hilmankhil...@deeprootsystems.com [100929 15:15]: Tony Lindgrent

Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-01 Thread Kevin Hilman
Kevin Hilman khil...@deeprootsystems.com writes: Nayak, Rajendra rna...@ti.com writes: [...] Hmm, this fault is very early and long before any PM code has initialzed. I suspect this happens with the master branch too ?? I've reproduced this now, and it doesn't happen on the master

RE: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-01 Thread Paul Walmsley
Hilman Subject: Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c * Tony Lindgren t...@atomide.com [100929 19:10]: Then trying to build for omap1 OSK fails with: In file included from arch/arm/plat-omap/common.c:35: arch/arm/plat-omap/include/plat

RE: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-01 Thread Paul Walmsley
On Fri, 1 Oct 2010, Paul Walmsley wrote: OMAP1 doesn't have a SCM, so this is the wrong fix. A better approach is here: https://patchwork.kernel.org/patch/218992/ Sorry, cut and paste error, should have been http://marc.info/?l=linux-omapm=128596931417802w=2 thanks to Kevin for

Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-01 Thread Tony Lindgren
* Kevin Hilman khil...@deeprootsystems.com [101001 13:38]: Kevin Hilman khil...@deeprootsystems.com writes: Nayak, Rajendra rna...@ti.com writes: [...] Hmm, this fault is very early and long before any PM code has initialzed. I suspect this happens with the master branch too

RE: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-09-30 Thread Shilimkar, Santosh
-Original Message- From: Tony Lindgren [mailto:t...@atomide.com] Sent: Thursday, September 30, 2010 8:00 AM To: Shilimkar, Santosh Cc: linux-omap@vger.kernel.org; Varadarajan, Charulatha; Nayak, Rajendra; Raja, Govindraj; Kevin Hilman Subject: Re: [GIT PULL] for testing: OMAP hwmod

Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-09-30 Thread Kevin Hilman
Tony Lindgren t...@atomide.com writes: * Kevin Hilman khil...@deeprootsystems.com [100929 15:15]: Tony Lindgren t...@atomide.com writes: * Kevin Hilman khil...@deeprootsystems.com [100928 11:25]: Tony, The following pull request will bring hwmod driver conversions for watchdog,

Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-09-30 Thread Kevin Hilman
Kevin Hilman khil...@deeprootsystems.com writes: Tony Lindgren t...@atomide.com writes: * Kevin Hilman khil...@deeprootsystems.com [100929 15:15]: Tony Lindgren t...@atomide.com writes: * Kevin Hilman khil...@deeprootsystems.com [100928 11:25]: Tony, The following pull request will

Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-09-30 Thread Tony Lindgren
* Kevin Hilman khil...@deeprootsystems.com [100930 07:31]: What config are you using to get a small enough kernel to boot on your n810? nolo on my n810 only accepts a maximum size kernel of 2097152 bytes. :( I guess the options there are to leave out tons of boards and some other omaps, or

RE: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-09-29 Thread Varadarajan, Charulatha
Kevin, -Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Tuesday, September 28, 2010 11:55 PM To: linux-omap@vger.kernel.org Cc: Varadarajan, Charulatha; Nayak, Rajendra; Raja, Govindraj Subject: [GIT PULL] for testing: OMAP hwmod driver conversions:

Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-09-29 Thread Kevin Hilman
Varadarajan, Charulatha ch...@ti.com writes: Kevin, -Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Tuesday, September 28, 2010 11:55 PM To: linux-omap@vger.kernel.org Cc: Varadarajan, Charulatha; Nayak, Rajendra; Raja, Govindraj Subject: [GIT

RE: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-09-29 Thread Nayak, Rajendra
snip.. This is with the omap2plus_defconfig and after editing cmdline to have console set to ttyO2. Would be nice to have those fixed before we merge it. Rajendra, can you look into this on OMAP2? This is happening for Tony on both n8x0 and 2430sdp. Sure, I'll have a

RE: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-09-29 Thread Nayak, Rajendra
-Original Message- From: Nayak, Rajendra Sent: Wednesday, September 29, 2010 9:44 PM To: Nayak, Rajendra; Kevin Hilman; Tony Lindgren Cc: linux-omap@vger.kernel.org; Varadarajan, Charulatha; Raja, Govindraj Subject: RE: [GIT PULL] for testing: OMAP hwmod driver conversions

Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-09-29 Thread Kevin Hilman
Nayak, Rajendra rna...@ti.com writes: snip.. This is with the omap2plus_defconfig and after editing cmdline to have console set to ttyO2. Would be nice to have those fixed before we merge it. Rajendra, can you look into this on OMAP2? This is happening for Tony on both

Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-09-29 Thread Kevin Hilman
Nayak, Rajendra rna...@ti.com writes: [...] I forgot to mention, there are similar WARN's that I see on 2430sdp even with UART Govidraj, can you look into these UART issues please? Looks like you might need to double check the bitfields and the module_offs for both of these. Thanks,

RE: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-09-29 Thread Nayak, Rajendra
-Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Thursday, September 30, 2010 12:49 AM To: Nayak, Rajendra; Raja, Govindraj Cc: Tony Lindgren; linux-omap@vger.kernel.org; Varadarajan, Charulatha Subject: Re: [GIT PULL] for testing: OMAP hwmod driver

Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-09-29 Thread Kevin Hilman
PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c Nayak, Rajendra rna...@ti.com writes: [...] I forgot to mention, there are similar WARN's that I see on 2430sdp even with UART Govidraj, can you look into these UART issues please? Looks like you might

RE: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-09-29 Thread Nayak, Rajendra
; Varadarajan, Charulatha Subject: Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c Nayak, Rajendra rna...@ti.com writes: [...] I forgot to mention, there are similar WARN's that I see on 2430sdp even with UART Govidraj, can you look

Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-09-29 Thread Kevin Hilman
Nayak, Rajendra rna...@ti.com writes: [...] Btw, the WARN's come only for UART3 and the error at hwmod init shows that maybe _wait_target_ready fails. [0.00] NR_IRQS:402 [0.00] Clocking rate (Crystal/DPLL/MPU): 13.0/660/330 MHz [0.00] omap_hwmod: uart3: cannot

Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-09-29 Thread Kevin Hilman
Tony Lindgren t...@atomide.com writes: * Kevin Hilman khil...@deeprootsystems.com [100928 11:25]: Tony, The following pull request will bring hwmod driver conversions for watchdog, UART and i2c drivers. It is based on your omap-for-linus branch. The i2c driver is waiting for final

Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-09-29 Thread Tony Lindgren
* Kevin Hilman khil...@deeprootsystems.com [100929 15:15]: Tony Lindgren t...@atomide.com writes: * Kevin Hilman khil...@deeprootsystems.com [100928 11:25]: Tony, The following pull request will bring hwmod driver conversions for watchdog, UART and i2c drivers. It is based on your

Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-09-29 Thread Tony Lindgren
* Tony Lindgren t...@atomide.com [100929 19:10]: Then trying to build for omap1 OSK fails with: In file included from arch/arm/plat-omap/common.c:35: arch/arm/plat-omap/include/plat/control.h:20:40: error: mach/ctrl_module_core_44xx.h: No such file or directory

Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-09-28 Thread Tony Lindgren
* Kevin Hilman khil...@deeprootsystems.com [100928 11:25]: Tony, The following pull request will bring hwmod driver conversions for watchdog, UART and i2c drivers. It is based on your omap-for-linus branch. The i2c driver is waiting for final signoff/ack from the upstream subsystem

Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-09-28 Thread Kevin Hilman
Rajendra, Tony Lindgren t...@atomide.com writes: * Kevin Hilman khil...@deeprootsystems.com [100928 11:25]: Tony, The following pull request will bring hwmod driver conversions for watchdog, UART and i2c drivers. It is based on your omap-for-linus branch. The i2c driver is waiting for

RE: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-09-28 Thread Nayak, Rajendra
-Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Wednesday, September 29, 2010 3:06 AM To: Nayak, Rajendra; Tony Lindgren Cc: linux-omap@vger.kernel.org; Varadarajan, Charulatha; Raja, Govindraj Subject: Re: [GIT PULL] for testing: OMAP hwmod driver