Re: [PATCH] ARM: OMAP: Fix board data to support device only, host only and OTG roles.

2010-05-31 Thread Grazvydas Ignotas
On Fri, May 28, 2010 at 9:32 PM, David Brownell davi...@pacbell.net wrote: --- On Fri, 5/28/10, Steve Sakoman sako...@gmail.com wrote: By the way ... the #ifdeffery should indeed vanish from all board configs except the Davinci DM6446 EVM.  That board is kind of quirky in terms of USB

Re: [PATCH] ARM: OMAP: Fix board data to support device only, host only and OTG roles.

2010-05-31 Thread Felipe Balbi
On Mon, May 31, 2010 at 11:44:05AM +0200, ext Grazvydas Ignotas wrote: If a board is configured as host and driver is set to only support peripheral it is perfectly fine for the driver not to allow that. But why is the driver refusing OTG board setting if it's compiled to only support

Re: [PATCH] ARM: OMAP: Fix board data to support device only, host only and OTG roles.

2010-05-31 Thread David Brownell
--- On Mon, 5/31/10, Grazvydas Ignotas nota...@gmail.com wrote: Another issue is that OTG depends on PM, so if I build PM-less kernel (PM is still more or less in development on OMAPs), Kconfig will only allow host or peripheral for musb, which doesn't match OTG selection in the board

RE: [PATCH] ARM: OMAP: Fix board data to support device only, host only and OTG roles.

2010-05-28 Thread Gadiyar, Anand
David Brownell wrote: incompatible Kconfig role setting there's a patch making that a warning instead of an #error if I'm not wrong. It's not an #error, it's a dev_err(). But more to the point, it's reporting a real error. As the comment in the code explains: /* The

Re: [PATCH] ARM: OMAP: Fix board data to support device only, host only and OTG roles.

2010-05-28 Thread Ming Lei
2010/5/28 Gadiyar, Anand gadi...@ti.com: David Brownell wrote: (Okay, I do know anyone who compiles a custom kernel of this sort is likely capable of patching the board files as needed to downgrade to the desired mode. But I still think the patch at [1] is useful to have.) David NAK the

Re: [PATCH] ARM: OMAP: Fix board data to support device only, host only and OTG roles.

2010-05-28 Thread Ming Lei
sorry, some fixes. 2010/5/28 Ming Lei tom.leim...@gmail.com: 2010/5/28 Gadiyar, Anand gadi...@ti.com: David Brownell wrote: (Okay, I do know anyone who compiles a custom kernel of this sort is likely capable of patching the board files as needed to downgrade to the desired mode. But I still

Re: [PATCH] ARM: OMAP: Fix board data to support device only, host only and OTG roles.

2010-05-28 Thread Steve Sakoman
On Thu, May 20, 2010 at 8:48 AM, David Brownell davi...@pacbell.net wrote: +#ifdef CONFIG_USB_MUSB_OTG +    .mode         = MUSB_OTG, +#elif defined(CONFIG_USB_MUSB_HDRC_HCD) +    .mode         = MUSB_HOST, +#elif defined(CONFIG_USB_GADGET_MUSB_HDRC) .mode         = MUSB_PERIPHERAL,

Re: [PATCH] ARM: OMAP: Fix board data to support device only, host only and OTG roles.

2010-05-28 Thread David Brownell
--- On Fri, 5/28/10, Steve Sakoman sako...@gmail.com wrote: By the way ... the #ifdeffery should indeed vanish from all board configs except the Davinci DM6446 EVM.  That board is kind of quirky in terms of USB support, and needs jumpering to get host or peripheral mode (and can't do

RE: [PATCH] ARM: OMAP: Fix board data to support device only, host only and OTG roles.

2010-05-23 Thread David Brownell
--- On Fri, 5/21/10, Gupta, Ajay Kumar ajay.gu...@ti.com wrote: Then I think these #ifdefferys are required in all the board files. As I already explained: *NO*. Unless the board has been designed in a flakey manner (like the DM6446 EVM) it should have no #ifdeffery in the MUSB

Re: [PATCH] ARM: OMAP: Fix board data to support device only, host only and OTG roles.

2010-05-23 Thread David Brownell
incompatible Kconfig role setting there's a patch making that a warning instead of an #error if I'm not wrong. It's not an #error, it's a dev_err(). But more to the point, it's reporting a real error. As the comment in the code explains: /* The driver might handle more features

Re: [PATCH] ARM: OMAP: Fix board data to support device only, host only and OTG roles.

2010-05-21 Thread Felipe Balbi
On Fri, May 21, 2010 at 07:15:37AM +0200, ext Gupta, Ajay Kumar wrote: Hi, +#ifdef CONFIG_USB_MUSB_OTG +    .mode         = MUSB_OTG, +#elif defined(CONFIG_USB_MUSB_HDRC_HCD) +    .mode         = MUSB_HOST, +#elif defined(CONFIG_USB_GADGET_MUSB_HDRC)     .mode         =

RE: [PATCH] ARM: OMAP: Fix board data to support device only, host only and OTG roles.

2010-05-21 Thread Gupta, Ajay Kumar
Hi, On Fri, May 21, 2010 at 07:15:37AM +0200, ext Gupta, Ajay Kumar wrote: Hi, +#ifdef CONFIG_USB_MUSB_OTG +    .mode         = MUSB_OTG, +#elif defined(CONFIG_USB_MUSB_HDRC_HCD) +    .mode         = MUSB_HOST, +#elif defined(CONFIG_USB_GADGET_MUSB_HDRC)     .mode    

Re: [PATCH] ARM: OMAP: Fix board data to support device only, host only and OTG roles.

2010-05-21 Thread Felipe Balbi
Hi, On Fri, May 21, 2010 at 09:43:29AM +0200, ext Gupta, Ajay Kumar wrote: I meant OTG with ID pin based role. that's the only OTG mode. If your board has OTG support, it will have to act on ID pin. -- balbi DefectiveByDesign.org -- To unsubscribe from this list: send the line unsubscribe

RE: [PATCH] ARM: OMAP: Fix board data to support device only, host only and OTG roles.

2010-05-20 Thread Gupta, Ajay Kumar
Hi, Subject: [PATCH] ARM: OMAP: Fix board data to support device only, host only and OTG roles. Fix board data to support device only, host only and OTG roles. The board data hardcodes the mode to OTG or Peripheral. This fix will allow to use Peripheral, Host and OTG roles independently.

RE: [PATCH] ARM: OMAP: Fix board data to support device only, host only and OTG roles.

2010-05-20 Thread David Brownell
I think better remove .mode parameter from board_data if its not needed anyways But it *IS* needed, as I explained before... if some board supports only some specific mode they can select those specifc config only. No they can't. Recall that kernels are expected to run on multiple

Re: [PATCH] ARM: OMAP: Fix board data to support device only, host only and OTG roles.

2010-05-20 Thread Felipe Balbi
On Thu, May 20, 2010 at 05:15:30PM +0200, ext David Brownell wrote: I think better remove .mode parameter from board_data if its not needed anyways But it *IS* needed, as I explained before... if some board supports only some specific mode they can select those specifc config only.

RE: [PATCH] ARM: OMAP: Fix board data to support device only, host only and OTG roles.

2010-05-20 Thread David Brownell
Subject: [PATCH] ARM: OMAP: Fix board data to support device only, host only and OTG roles. Fix board data to support device only, host only and OTG roles. The board data hardcodes the mode to OTG or Peripheral. Or host. That's correct... because the *BOARD* is hard-wired that

Re: [PATCH] ARM: OMAP: Fix board data to support device only, host only and OTG roles.

2010-05-20 Thread David Brownell
+#ifdef CONFIG_USB_MUSB_OTG +    .mode            = MUSB_OTG, +#elif defined(CONFIG_USB_MUSB_HDRC_HCD) +    .mode            = MUSB_HOST, +#elif defined(CONFIG_USB_GADGET_MUSB_HDRC)     .mode            = MUSB_PERIPHERAL, +#endif         = MUSB_PERIPHERAL, +#endif By the way ...