On Sat, 2012-06-16 at 03:31 +0530, jaswinder.si...@linaro.org wrote:
From: Jassi Brar jaswinder.si...@linaro.org
Explicitly maintaining HDMI phy power state using a flag is prone to
race and un-necessary when we have a zero-cost alternative of checking
the state before trying to set it.
Why
On 18 June 2012 13:41, Tomi Valkeinen tomi.valkei...@ti.com wrote:
Explicitly maintaining HDMI phy power state using a flag is prone to
race and un-necessary when we have a zero-cost alternative of checking
the state before trying to set it.
Why would reading the value from the register be
On Mon, 2012-06-18 at 15:42 +0530, Jassi Brar wrote:
On 18 June 2012 13:41, Tomi Valkeinen tomi.valkei...@ti.com wrote:
Explicitly maintaining HDMI phy power state using a flag is prone to
race and un-necessary when we have a zero-cost alternative of checking
the state before trying to
On 18 June 2012 16:24, Tomi Valkeinen tomi.valkei...@ti.com wrote:
On Mon, 2012-06-18 at 15:42 +0530, Jassi Brar wrote:
BTW, coming to think about it, I am not sure what we need the
spin_lock_irqsave() protection for in hdmi_check_hpd_state() ? It
can't control HPD gpio state change and
On Mon, 2012-06-18 at 17:16 +0530, Jassi Brar wrote:
On 18 June 2012 16:24, Tomi Valkeinen tomi.valkei...@ti.com wrote:
On Mon, 2012-06-18 at 15:42 +0530, Jassi Brar wrote:
BTW, coming to think about it, I am not sure what we need the
spin_lock_irqsave() protection for in
On 18 June 2012 17:54, Tomi Valkeinen tomi.valkei...@ti.com wrote:
On Mon, 2012-06-18 at 17:16 +0530, Jassi Brar wrote:
So preferably I would move request_threaded_irq() to after
hdmi_check_hpd_state() in ti_hdmi_4xxx_phy_enable() and convert the
No, you can't move the check. If you move
On Mon, 2012-06-18 at 18:37 +0530, Jassi Brar wrote:
On 18 June 2012 17:54, Tomi Valkeinen tomi.valkei...@ti.com wrote:
On Mon, 2012-06-18 at 17:16 +0530, Jassi Brar wrote:
So preferably I would move request_threaded_irq() to after
hdmi_check_hpd_state() in ti_hdmi_4xxx_phy_enable() and
On 18 June 2012 18:41, Tomi Valkeinen tomi.valkei...@ti.com wrote:
On Mon, 2012-06-18 at 18:37 +0530, Jassi Brar wrote:
On 18 June 2012 17:54, Tomi Valkeinen tomi.valkei...@ti.com wrote:
On Mon, 2012-06-18 at 17:16 +0530, Jassi Brar wrote:
So preferably I would move request_threaded_irq()
On Saturday 16 June 2012 7:02:00 jaswinder.singh wrote:
From: Jassi Brar jaswinder.si...@linaro.org
Explicitly maintaining HDMI phy power state using a flag is prone to
race and un-necessary when we have a zero-cost alternative of checking
the state before trying to set it.
CC'ed 'Mythri
