On Mon, Apr 09, 2012 at 03:18:22PM -0500, Jon Hunter wrote:
True, but we would always want to use the 32k timer if CONFIG_PM is
specified. So what I am saying is that if a device has a 32ksync timer
and CONFIG_PM is defined, we always want to use the 32ksync timer and a
gptimer should
On Tuesday 10 April 2012 02:14 PM, Russell King - ARM Linux wrote:
On Mon, Apr 09, 2012 at 03:18:22PM -0500, Jon Hunter wrote:
True, but we would always want to use the 32k timer if CONFIG_PM is
specified. So what I am saying is that if a device has a 32ksync timer
and CONFIG_PM is
On Tue, Apr 03, 2012 at 10:52:26AM +0530, Sourav Poddar wrote:
+static int kbd_write_irqstatus(struct omap4_keypad *keypad_data,
+ u32 offset, u32 value)
+{
+ return __raw_writel(value, keypad_data-base + offset);
+}
+
+static int
Hi Kevin,
On Mon, Apr 9, 2012 at 10:40 PM, Kevin Hilman khil...@ti.com wrote:
Paul Walmsley p...@pwsan.com writes:
[...]
I don't understand why a user would ever want to disable dynamic wakeups
on an in-use serial port via the sysfs power/wakeup file. (Disabling
wakeups from suspend is a
On Tue, Apr 10, 2012 at 02:27:36PM +0530, Santosh Shilimkar wrote:
On Tuesday 10 April 2012 02:14 PM, Russell King - ARM Linux wrote:
On Mon, Apr 09, 2012 at 03:18:22PM -0500, Jon Hunter wrote:
True, but we would always want to use the 32k timer if CONFIG_PM is
specified. So what I am
On Tue, Apr 10, 2012 at 2:59 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
On Tue, Apr 10, 2012 at 02:27:36PM +0530, Santosh Shilimkar wrote:
On Tuesday 10 April 2012 02:14 PM, Russell King - ARM Linux wrote:
On Mon, Apr 09, 2012 at 03:18:22PM -0500, Jon Hunter wrote:
True, but
This commit:
commit 46856a68dcb5f67c779d211fd6bcb5d7a2a7f19b
Author: Rajendra Nayak rna...@ti.com
Date: Mon Mar 12 20:32:37 2012 +0530
mmc: omap_hsmmc: Convert hsmmc driver to use device tree
Define dt bindings for the ti-omap-hsmmc, and adapt the driver to extract
data (which was
Hi Tony,
Please Pull the following omap uart changes.
Changes basically involves getting rid of cpu checks
for populating erratas and features and move the same
from serial.c to omap-serial.c, MVR reg is used to find
uart versions and errata flags are populated accordingly.
--
Thanks,
CC'ing Linux-ARM
On Tue, Apr 10, 2012 at 3:32 PM, Govindraj.R govindraj.r...@ti.com wrote:
Hi Tony,
Please Pull the following omap uart changes.
Changes basically involves getting rid of cpu checks
for populating erratas and features and move the same
from serial.c to omap-serial.c, MVR
On Tue, Apr 10, 2012 at 03:37:28PM +0530, Poddar, Sourav wrote:
Hi Felipe,
On Tue, Apr 10, 2012 at 2:54 PM, Felipe Balbi ba...@ti.com wrote:
On Tue, Apr 03, 2012 at 10:52:26AM +0530, Sourav Poddar wrote:
+static int kbd_write_irqstatus(struct omap4_keypad *keypad_data,
+
Hi Felipe,
On Tue, Apr 10, 2012 at 3:46 PM, Felipe Balbi ba...@ti.com wrote:
On Tue, Apr 10, 2012 at 03:37:28PM +0530, Poddar, Sourav wrote:
Hi Felipe,
On Tue, Apr 10, 2012 at 2:54 PM, Felipe Balbi ba...@ti.com wrote:
On Tue, Apr 03, 2012 at 10:52:26AM +0530, Sourav Poddar wrote:
The patch series does the following
- Warn fixes if CONFIG_PM_RUNTIME is not selected.
- I2C register restore only if context if the context is lost
- Bus busy recovery mechanism.
- the reset is not done in init.
v2 changes
-Adds a patch to use devm_* functions
-Also checks the return type of
Restore of context is not done for OMAP4. This patch
adds the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE in the OMAP4
hwmod data which activates the restore for OMAP4.
Currently the OMAP4 does not hit device off still the
driver may have support for it.
Cc: Benoit Cousson b-cous...@ti.com
Cc: Paul Wamsley
The various devm_ functions allocate memory that is released when a driver
detaches. This patch uses devm_kzalloc, devm_request_mem_region and
devm_ioremap for data that is allocated in the probe function of a platform
device and is only freed in the remove function.
Signed-off-by: Shubhrajyoti D
The section number in the recent errata document has changed.
Rename the erratum 1p153 to the unique id i462 instead, so that
it is easier to reference. Also change the function name and comments
to reflect the same.
Cc: Jon Hunter jon-hun...@ti.com
Signed-off-by: Shubhrajyoti D
Currently in the 1.153 errata handling while waiting for transmitter
underflow if NACK is got the XUDF flag is also set.
The flag is set after wait for the condition is over.
Cc: Alexander Shishkin virtu...@slind.org
Cc: Moiz Sonasath m-sonas...@ti.com
Signed-off-by: Shubhrajyoti D
The omap_i2c_remove function may not be needed after
device exit so the memory could be freed.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
drivers/i2c/busses/i2c-omap.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c
No functional change. Makes the read ready processing a separate
function. This is to avoid extremely long level of indentation.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
drivers/i2c/busses/i2c-omap.c | 86 +---
1 files changed, 45 insertions(+),
Currently the i2c driver calls the pm_runtime_enable and never
the disable. This may cause a warning when pm_runtime_enable
checks for the count match.Attempting to fix the same by calling
pm_runtime_disable in the error and the remove path.
Cc: Kevin Hilman khil...@ti.com
Cc: Rajendra Nayak
The reset in the driver at init is not needed anymore as the
following patch has removed the HWMOD_INIT_NO_RESET flag.
6d3c55f [OMAP: hwmod: fix the i2c-reset timeout during bootup]
This patch does the following
-removes the reset from the probe and implements a omap_i2c_reset
function to reset.
Currently i2c register restore is done always.
Adding conditional restore.
The i2c register restore is done only if the context is lost.
Also remove the definition of SYSS_RESETDONE_MASK and use the
one in omap_hwmod.h.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
From: Jon Hunter jon-hun...@ti.com
The OMAP3530 is based upon the same silicon as the OMAP3430 and so the I2C
revision is the same for 3430 and 3530. However, the OMAP3630 device has the
same I2C revision as OMAP4. Correct the revision definition to reflect this.
This patch is based on work done
By definition, wait_for_completion_timeout() returns an unsigned value and
therefore, it is not necessary to check if the return value is less than zero
as this is not possible.
This is based on a patch from Jon Hunter jon-hun...@ti.com
Changes from his patch
- Declare a long as the
In omap_i2c_remove we are accessing the I2C_CON register without
enabling the clocks. Fix the same by enabling the clocks and disabling
it.
This fixes the following crash.
[ 154.723022] [ cut here ]
[ 154.725677] WARNING: at
From: Tasslehoff Kjappfot tasskj...@gmail.com
i2c_probe set the dev-errata flag, but omap_i2c_init cleared the flag again.
Move the errata handling to i2c_probe.
Signed-off-by: Tasslehoff Kjappfot tasskj...@gmail.com
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
If PM runtime get_sync fails return with the error
so that no further reads/writes goes through the interface.
This will avoid possible abort.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
drivers/i2c/busses/i2c-omap.c | 13 ++---
1 files changed, 10 insertions(+), 3
From: Vikram Pandita vikram.pand...@ti.com
In case a peripheral is driving SDA bus low (ie. a start condition), provide
a constant clock output using the test mode of the OMAP I2C controller to
try and clear the bus. Soft reset I2C controller after attempting the bus clear
to ensure that
Use SET_RUNTIME_PM_OPS macro to set runtime functions.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
drivers/i2c/busses/i2c-omap.c | 11 ---
1 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index
Currently in probe
pm_runtime_put(dev-dev);
...
/* i2c device drivers may be active on return from add_adapter() */
adap-nr = pdev-id;
r = i2c_add_numbered_adapter(adap);
if (r) {
dev_err(dev-dev, failure adding adapter\n);
The functions omap_i2c_unidle/idle are called from omap_i2c_runtime_resume
and omap_i2c_runtime_suspend which is compiled for CONFIG_PM_RUNTIME.
This patch removes the omap_i2c_unidle/idle functions and folds them
into the runtime callbacks.
This fixes the below warn when CONFIG_PM_RUNTIME is not
Hi Jon,
On Tue, Apr 10, 2012 at 01:20:37, Hunter, Jon wrote:
Because num_irq (or available irqs for fictitious irq chip) is platform
specific.
Ok, so OMAP_GPMC_NR_IRQS is defined and will not vary from device to
device, so why pass this? Why not use it directly?
Because
On Tue, Apr 10, 2012 at 4:26 PM, Shubhrajyoti D shubhrajy...@ti.com wrote:
The patch series does the following
- Warn fixes if CONFIG_PM_RUNTIME is not selected.
- I2C register restore only if context if the context is lost
- Bus busy recovery mechanism.
- the reset is not done in init.
v2
On Tue, Apr 10, 2012 at 05:01:37PM +0530, S, Venkatraman wrote:
On Tue, Apr 10, 2012 at 4:26 PM, Shubhrajyoti D shubhrajy...@ti.com wrote:
The patch series does the following
- Warn fixes if CONFIG_PM_RUNTIME is not selected.
- I2C register restore only if context if the context is lost
From: Govindraj.R govindraj.r...@ti.com
We populating default uart mux pins if no mux data is provided
by board files. But were not probing the availability of uart pins
in tx/rx mode i.e. mux mode0. If particular pin is used for any other
purpose then default pads were breaking those peripherals
From: Govindraj.R govindraj.r...@ti.com
The following commit:
(7496ba3 ARM: OMAP2+: UART: Add default mux for all uarts)
added default pads for all uarts. But not all boards tend to
use all uarts and most of unused uart pins are muxed for
other purpose. This commit breaks the modules which where
From: Govindraj.R govindraj.r...@ti.com
Default pad populating procedure should first probe whether the uart
pins are available as uart tx/rx pins if yes then we can configure them
and use rx pin for wakeup capability.
Utilise the mux api available to probe the availability of mux pins
in uart
Hi,
On Tue, Apr 10 2012, Russell King - ARM Linux wrote:
This commit:
commit 46856a68dcb5f67c779d211fd6bcb5d7a2a7f19b
Author: Rajendra Nayak rna...@ti.com
Date: Mon Mar 12 20:32:37 2012 +0530
mmc: omap_hsmmc: Convert hsmmc driver to use device tree
Define dt bindings for the
On Tue, Apr 10, 2012 at 7:33 PM, Chris Ball c...@laptop.org wrote:
Hi,
On Tue, Apr 10 2012, Russell King - ARM Linux wrote:
This commit:
commit 46856a68dcb5f67c779d211fd6bcb5d7a2a7f19b
Author: Rajendra Nayak rna...@ti.com
Date: Mon Mar 12 20:32:37 2012 +0530
mmc: omap_hsmmc:
On Tuesday 10 April 2012 05:11 PM, Felipe Balbi wrote:
On Tue, Apr 10, 2012 at 05:01:37PM +0530, S, Venkatraman wrote:
On Tue, Apr 10, 2012 at 4:26 PM, Shubhrajyoti D shubhrajy...@ti.com wrote:
[...]
modpost: Fix modpost license checking of vmlinux.o (2012-04-09 20:52:56
-0700)
are
If of_have_populated_dt is called from module, build fails with allnodes
undefined error, so remove inline and export of_have_populated_dt.
Signed-off-by: Balaji T K balaj...@ti.com
---
drivers/of/base.c |6 ++
include/linux/of.h |6 +-
2 files changed, 7 insertions(+), 5
* Govindraj.R govindraj.r...@ti.com [120410 06:44]:
--- a/arch/arm/mach-omap2/serial.c
+++ b/arch/arm/mach-omap2/serial.c
@@ -120,11 +120,63 @@ static void omap_uart_set_smartidle(struct
platform_device *pdev) {}
#endif /* CONFIG_PM */
#ifdef CONFIG_OMAP_MUX
-static void
Hi Balaji,
On 4/10/2012 5:11 PM, Balaji T K wrote:
If of_have_populated_dt is called from module, build fails with allnodes
undefined error, so remove inline and export of_have_populated_dt.
Is this function really called from the MMC driver?
Regards,
Benoit
Signed-off-by: Balaji T
Hi,
On Tue, Apr 10 2012, Cousson, Benoit wrote:
Hi Balaji,
On 4/10/2012 5:11 PM, Balaji T K wrote:
If of_have_populated_dt is called from module, build fails with allnodes
undefined error, so remove inline and export of_have_populated_dt.
Is this function really called from the MMC driver?
Hi Sourav,
On Tue, Apr 03, 2012 at 10:52:26AM +0530, Sourav Poddar wrote:
From: G, Manjunath Kondaiah manj...@ti.com
Keypad controller register offsets are different for omap4
and omap5. Handle these offsets through static mapping and
assign these mappings during run time.
In addition to
Hi Chris,
On 4/10/2012 6:21 PM, Chris Ball wrote:
Hi,
On Tue, Apr 10 2012, Cousson, Benoit wrote:
Hi Balaji,
On 4/10/2012 5:11 PM, Balaji T K wrote:
If of_have_populated_dt is called from module, build fails with allnodes
undefined error, so remove inline and export of_have_populated_dt.
On Tuesday, April 10, 2012 9:24 AM, Dmitry Torokhov wrote:
On Tue, Apr 03, 2012 at 10:52:26AM +0530, Sourav Poddar wrote:
From: G, Manjunath Kondaiah manj...@ti.com
Keypad controller register offsets are different for omap4
and omap5. Handle these offsets through static mapping and
assign
On Tue, Apr 10, 2012 at 9:11 AM, Tony Lindgren t...@atomide.com wrote:
* Govindraj.R govindraj.r...@ti.com [120410 06:44]:
--- a/arch/arm/mach-omap2/serial.c
+++ b/arch/arm/mach-omap2/serial.c
@@ -120,11 +120,63 @@ static void omap_uart_set_smartidle(struct
platform_device *pdev) {}
#endif
On 04/10/2012 11:29 AM, Cousson, Benoit wrote:
Hi Chris,
On 4/10/2012 6:21 PM, Chris Ball wrote:
Hi,
On Tue, Apr 10 2012, Cousson, Benoit wrote:
Hi Balaji,
On 4/10/2012 5:11 PM, Balaji T K wrote:
If of_have_populated_dt is called from module, build fails with
allnodes
undefined error,
On Thu, Apr 05, 2012 at 01:15:44PM -0500, Rob Clark wrote:
From: Rob Clark r...@ti.com
For now just implementing the exporting APIs, not yet importing. And
kmap is rejected on tiled buffers (although the usefulness of that seems
questionable, but could be added later if needed).
On 04/10/2012 05:11 PM, Balaji T K wrote:
If of_have_populated_dt is called from module, build fails with allnodes
undefined error, so remove inline and export of_have_populated_dt.
Why do you need this function at all? You should not need it. *I*
introduced it because I need it early x86
On Tue, Apr 10, 2012 at 11:39:43AM -0500, H Hartley Sweeten wrote:
On Tuesday, April 10, 2012 9:24 AM, Dmitry Torokhov wrote:
On Tue, Apr 03, 2012 at 10:52:26AM +0530, Sourav Poddar wrote:
From: G, Manjunath Kondaiah manj...@ti.com
Keypad controller register offsets are different for
Raja, Govindraj govindraj.r...@ti.com writes:
Hi Kevin,
On Mon, Apr 9, 2012 at 10:40 PM, Kevin Hilman khil...@ti.com wrote:
Paul Walmsley p...@pwsan.com writes:
[...]
I don't understand why a user would ever want to disable dynamic wakeups
on an in-use serial port via the sysfs
On Tue, 10 Apr 2012, Shubhrajyoti D wrote:
Restore of context is not done for OMAP4. This patch
adds the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE in the OMAP4
hwmod data which activates the restore for OMAP4.
Currently the OMAP4 does not hit device off still the
driver may have support for it.
From: Rob Clark r...@ti.com
For now just implementing the exporting APIs, not yet importing. And
kmap is rejected on tiled buffers (although the usefulness of that seems
questionable, but could be added later if needed).
Signed-off-by: Rob Clark r...@ti.com
---
drivers/staging/omapdrm/Makefile
Hi Afzal,
On 04/10/2012 06:00 AM, Mohammed, Afzal wrote:
Hi Jon,
On Tue, Apr 10, 2012 at 01:20:37, Hunter, Jon wrote:
Because num_irq (or available irqs for fictitious irq chip) is platform
specific.
Ok, so OMAP_GPMC_NR_IRQS is defined and will not vary from device to
device, so why pass
Hi Afzal,
On 04/05/2012 10:46 AM, Afzal Mohammed wrote:
Currently gpmc is configured in platform for nand.
As configuring gpmc has been moved to gpmc driver,
populate details needed for the driver to configure
gpmc. gpmc driver would configure based on this
information.
Signed-off-by: Afzal
On Tue, 10 Apr 2012 12:20:27 -0500, Rob Herring robherri...@gmail.com wrote:
On 04/10/2012 11:29 AM, Cousson, Benoit wrote:
Hi Chris,
On 4/10/2012 6:21 PM, Chris Ball wrote:
Hi,
On Tue, Apr 10 2012, Cousson, Benoit wrote:
Hi Balaji,
On 4/10/2012 5:11 PM, Balaji T K wrote:
If
On 04/10/2012 04:51 AM, Shilimkar, Santosh wrote:
On Tue, Apr 10, 2012 at 2:59 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
On Tue, Apr 10, 2012 at 02:27:36PM +0530, Santosh Shilimkar wrote:
On Tuesday 10 April 2012 02:14 PM, Russell King - ARM Linux wrote:
On Mon, Apr 09,
Hi Rajendra,
On Tue, 13 Mar 2012, Rajendra Nayak wrote:
omap_hwmod_softreset() does not seem to wait for reset status
after doing a softreset. Make it use _ocp_softreset() instead
which does this correctly.
Signed-off-by: Rajendra Nayak rna...@ti.com
Cc: Benoit Cousson b-cous...@ti.com
Hi,
On Wed, Dec 14, 2011 at 5:55 AM, Rajendra Nayak rna...@ti.com wrote:
Pass minimal data needed for console boot, from dt, for
OMAP4 panda/sdp and OMAP3 beagle boards, and get rid of the
static initialization from generic board file.
...
diff --git a/arch/arm/mach-omap2/board-generic.c
On Mon, Apr 9, 2012 at 10:03 PM, Kevin Hilman khil...@ti.com wrote:
Grazvydas Ignotas nota...@gmail.com writes:
While SD card performance loss is not that bad (~7%), NAND one is
worrying (~39%). I've tried disabling/enabling CONFIG_CPU_IDLE, also
cpuidle states over sysfs, it did not have any
This is the latest version of the OMAP warnings cleanup series.
This version fixes most of the warnings with arch/arm/mach-omap1,
arch/arm/mach-omap2, and arch/arm/plat-omap. It also fixes some
bugs discovered in the process.
Boot-tested on 5912OSK, N800, 35xx BeagleBoard, 37xx EVM,
and 4430
Several function declarations used only in the files in which they're
declared should include the static keyboard, but don't:
arch/arm/mach-omap2/serial.c:248:6: warning: symbol 'cmdline_find_option'
was not declared. Should it be static?
arch/arm/mach-omap2/omap-wakeupgen.c:259:6:
Remove the include of mach-omap2/common.h from plat-omap/usb.c. It
appears to be unneeded. Removing it also resolves the sparse warning:
arch/arm/plat-omap/../mach-omap2/common.h:183:12: warning: symbol
'omap_intc_of_init' was not declared. Should it be static?
Signed-off-by: Paul Walmsley
We currently treat the OCM RAM memory as memory that hangs off an
I/O bus, so use memset_io() to clear it rather than memset().
This also takes care of this sparse warning:
arch/arm/plat-omap/sram.c:199:9: warning: cast removes address space of
expression
There is still one SRAM-related sparse
DMTIMER source selection on OMAP1 is broken. omap1_dm_timer_set_src()
tries to use __raw_{read,write}l() to read from and write to physical
addresses, but those functions take virtual addresses.
sparse caught this:
arch/arm/mach-omap1/timer.c:50:13: warning: incorrect type in argument 1
gcc can apparently handle stack-allocated arrays that use a dynamic
variable as the array maximum. Rather than using a mutable quantity,
simply use a constant maximum possible size. To me, code clarity is
improved; and it also avoids the following sparse warnings:
Move the OMAP1 OCPI bus code to arch/arm/mach-omap1, since it is
only used on OMAP1 devices. In the long term, it probably makes sense
to move the OCPI bus code to somewhere under drivers/.
Signed-off-by: Paul Walmsley p...@pwsan.com
Cc: Tony Lindgren t...@atomide.com
---
The H2, H3, Perseus2, and FSample board files all contain the same
duplicated code to handle NAND commands. That code is missing
some casts around conversions from unsigned long to void __iomem *.
Consolidate the duplicated code into a new file,
arch/arm/mach-omap1/board-nand.c. Resolve the
Several C files in arch/arm/mach-omap* and arch/arm/plat-omap declare
functions that are used by other files, but don't include the header
file where the prototype is declared. This results in the following
warnings from sparse:
arch/arm/mach-omap2/irq.c:114:5: warning: symbol
sparse warns when 0 is passed to a function expecting a pointer argument.
Resolve these warnings by replacing the 0 with NULL.
arch/arm/plat-omap/include/plat/dmtimer.h:319:34: warning: Using plain integer
as NULL pointer
arch/arm/plat-omap/include/plat/dmtimer.h:324:35: warning: Using plain
The OMAP1 OHCI driver needs to enable the OCPI IP block before it can
work. Previously, the driver was simply calling a symbol defined in
the OMAP platform code, but this is incorrect: drivers should be fully
decoupled from platform and architecture code.
So instead, modify the driver to call
arch/arm/mach-omap2/gpmc.c passes a return value from ioremap() as the
fifth argument to request_irq() without casting it. This causes
sparse to generate the following warning:
arch/arm/mach-omap2/gpmc.c:759:63: warning: incorrect type in argument 5
(different address spaces)
On Tue, Apr 10, 2012 at 5:51 PM, Shilimkar, Santosh
santosh.shilim...@ti.com wrote:
On Tue, Apr 10, 2012 at 2:59 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
On Tue, Apr 10, 2012 at 02:27:36PM +0530, Santosh Shilimkar wrote:
On Tuesday 10 April 2012 02:14 PM, Russell King - ARM
If prefetch engine is busy, current code forgets to call
dma_unmap_single(), which results in a deadlock later, so add it.
Signed-off-by: Grazvydas Ignotas nota...@gmail.com
---
drivers/mtd/nand/omap2.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git
On Tuesday 10 April 2012 10:50 PM, Rob Herring wrote:
Rob,
Does it make sense to use that in the driver? So far I was using that
only in the arch code to make the difference between the DT boot and the
non-DT boot.
I guess that a driver should rely on of_match_device or non-NULL
On Tuesday 10 April 2012 08:41 PM, Balaji T K wrote:
If of_have_populated_dt is called from module, build fails with allnodes
undefined error, so remove inline and export of_have_populated_dt.
Thanks Balaji, for taking care of this while I was out.
But like Rob and Sebastian mentioned, looks
Hi Jon,
On Wed, Apr 11, 2012 at 00:53:14, Hunter, Jon wrote:
I agree with your argument but I was thinking today only OMAP uses the
GPMC so we could not worry about this. Ok, leave as-is, but can we
modify the code as follows as the else if is not really needed...
if (gpmc-num_irq
Hi Jon,
On Wed, Apr 11, 2012 at 00:54:58, Hunter, Jon wrote:
+#defineGPMC_NAND_CONFIG_NUM4
Where does 4 come from?
It depends on the use case, for NAND, with the way it was being
configured (or number of times gpmc_cs_configure was being called)
4 are needed.
Regards
Afzal
--
To
On Tuesday 10 April 2012 11:43 PM, Paul Walmsley wrote:
On Tue, 10 Apr 2012, Shubhrajyoti D wrote:
Restore of context is not done for OMAP4. This patch
adds the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE in the OMAP4
hwmod data which activates the restore for OMAP4.
Currently the OMAP4 does not hit
80 matches
Mail list logo
