Re: [PATCH] Separate out 3430 LCD panel support from 2430 file
Felipe, I think CONFIG_MACH_OMAP_XXX is chosen in arch/arm/mach-omap2/Kconfig and not in drivers/media/video/omap. Best Regards, Arun On Thu, Jun 12, 2008 at 6:09 PM, Felipe Balbi [EMAIL PROTECTED] wrote: On Thu, 12 Jun 2008 17:24:49 +0530, Gadiyar, Anand [EMAIL PROTECTED] wrote: Separate out 3430 LCD panel support from 2430 SDP. Currently the support for the LCD on 3430SDP is added in the lcd_2430sdp.c file. This patch separates it out to a new file. You're at least missing 3430sdp defconfig updates, Kconfig changes in drivers/media/video/omap and the removal of conditional code in lcd_2430sdp.c Er... Why Kconfig in drivers/media/video/omap? brainfart :-p It uses CONFIG_MACH_OMAP_XXX :-) forget about the Kconfig :-) -- Best Regards, Felipe Balbi http://felipebalbi.com [EMAIL PROTECTED] -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: SDMA, RAM to RAM transfer issue
Hi! Brandon thanks for the reply. config register values in Hex are as follwing: Registers val CSDP: 2 Registers val CEN: 100 Registers val CFN: 1 Registers val CSSA: 87978800 Registers val CDSA: 87978c00 Registers val CCR: 5000 Registers val CSE: 1 Registers val CSF: 1 Registers val CDE: 1 Registers val CDF: 1 values taken just before triggering DMA from kernel module. all for channel 31. with wishes Somz -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/4] more musb/i2c patches
Basically adding module_alias and allowing some twl drivers to be dynamically linked. There's also one patch to make hdrc_cnf.h more omap3-compliant based on the musb configuration for musb ip core on omap3. Please, comment them out. Felipe Balbi (4): usb: musb: musb on omap3 has 32 endpoints usb: musb: add MODULE_ALIAS for udev module loading i2c: allow twl modules to be built as modules i2c: add MODULE_ALIAS to twl4030 drivers drivers/i2c/chips/Kconfig |6 +++--- drivers/i2c/chips/twl4030-core.c|1 + drivers/i2c/chips/twl4030-gpio.c|1 + drivers/i2c/chips/twl4030-madc.c|1 + drivers/i2c/chips/twl4030-poweroff.c|1 + drivers/i2c/chips/twl4030-pwrbutton.c |1 + drivers/i2c/chips/twl4030-pwrirq.c |1 + drivers/i2c/chips/twl4030-usb.c |1 + drivers/input/keyboard/omap-twl4030keypad.c |1 + drivers/rtc/rtc-twl4030.c |1 + drivers/usb/musb/musb_core.c|4 +++- include/asm-arm/arch-omap/hdrc_cnf.h|6 +++--- 12 files changed, 18 insertions(+), 7 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/4] usb: musb: musb on omap3 has 32 endpoints
Fix hdrc_cnf.h for omap3 configuration. Signed-off-by: Felipe Balbi [EMAIL PROTECTED] --- include/asm-arm/arch-omap/hdrc_cnf.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/asm-arm/arch-omap/hdrc_cnf.h b/include/asm-arm/arch-omap/hdrc_cnf.h index 74c8432..271214c 100644 --- a/include/asm-arm/arch-omap/hdrc_cnf.h +++ b/include/asm-arm/arch-omap/hdrc_cnf.h @@ -14,11 +14,11 @@ /* ** Number of Tx endpoints ** */ /* Legal values are 1 - 16 (this value includes EP0) */ -#define MUSB_C_NUM_EPT 8 +#define MUSB_C_NUM_EPT 16 /* ** Number of Rx endpoints ** */ /* Legal values are 1 - 16 (this value includes EP0) */ -#define MUSB_C_NUM_EPR 8 +#define MUSB_C_NUM_EPR 16 /* ** Endpoint 1 to 15 direction types ** */ /* C_EP1_DEF is defined if either Tx endpoint 1 or Rx endpoint 1 are used */ @@ -163,7 +163,7 @@ * Legal values are 2 - 16 * This must be equal to the larger of C_NUM_EPT, C_NUM_EPR */ -#define MUSB_C_NUM_EPS 8 +#define MUSB_C_NUM_EPS 16 /* C_EPMAX_BITS is equal to the largest endpoint FIFO word address bits */ #define MUSB_C_EPMAX_BITS 12 -- 1.5.6.rc1 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 3/4] i2c: allow twl modules to be built as modules
Besides twl core and twl gpio, all the others can be dynamically linked. Signed-off-by: Felipe Balbi [EMAIL PROTECTED] --- drivers/i2c/chips/Kconfig |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/chips/Kconfig b/drivers/i2c/chips/Kconfig index cba8abf..b421727 100644 --- a/drivers/i2c/chips/Kconfig +++ b/drivers/i2c/chips/Kconfig @@ -150,7 +150,7 @@ config TWL4030_MADC called twl4030-madc.ko config TWL4030_USB - bool TWL4030 USB Transceiver Driver + tristate TWL4030 USB Transceiver Driver depends on TWL4030_CORE choice @@ -170,11 +170,11 @@ config TWL4030_USB_HS_ULPI endchoice config TWL4030_PWRBUTTON - bool TWL4030 Power button Driver + tristate TWL4030 Power button Driver depends on TWL4030_CORE config TWL4030_POWEROFF - bool TWL4030 device poweroff + tristate TWL4030 device poweroff depends on TWL4030_CORE config SENSORS_MAX6875 -- 1.5.6.rc1 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/4] usb: musb: add MODULE_ALIAS for udev module loading
platform drivers should add MODULE_ALIAS for allowing udev module loading. Signed-off-by: Felipe Balbi [EMAIL PROTECTED] --- drivers/usb/musb/musb_core.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index 5b92f21..75c3013 100644 --- a/drivers/usb/musb/musb_core.c +++ b/drivers/usb/musb/musb_core.c @@ -134,11 +134,13 @@ MODULE_PARM_DESC(debug, initial debug message level); #define DRIVER_INFO DRIVER_DESC , v MUSB_VERSION -const char musb_driver_name[] = musb_hdrc; +#define MUSB_DRIVER_NAME musb_hdrc +const char musb_driver_name[] = MUSB_DRIVER_NAME; MODULE_DESCRIPTION(DRIVER_INFO); MODULE_AUTHOR(DRIVER_AUTHOR); MODULE_LICENSE(GPL); +MODULE_ALIAS(platform: MUSB_DRIVER_NAME); /*-*/ -- 1.5.6.rc1 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 4/4] i2c: add MODULE_ALIAS to twl4030 drivers
When built as module, it helps udev to probe them. Signed-off-by: Felipe Balbi [EMAIL PROTECTED] --- drivers/i2c/chips/twl4030-core.c|1 + drivers/i2c/chips/twl4030-gpio.c|1 + drivers/i2c/chips/twl4030-madc.c|1 + drivers/i2c/chips/twl4030-poweroff.c|1 + drivers/i2c/chips/twl4030-pwrbutton.c |1 + drivers/i2c/chips/twl4030-pwrirq.c |1 + drivers/i2c/chips/twl4030-usb.c |1 + drivers/input/keyboard/omap-twl4030keypad.c |1 + drivers/rtc/rtc-twl4030.c |1 + 9 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/i2c/chips/twl4030-core.c b/drivers/i2c/chips/twl4030-core.c index 8822653..adc45d4 100644 --- a/drivers/i2c/chips/twl4030-core.c +++ b/drivers/i2c/chips/twl4030-core.c @@ -908,6 +908,7 @@ static void __exit twl4030_exit(void) subsys_initcall(twl4030_init); module_exit(twl4030_exit); +MODULE_ALIAS(i2c: DRIVER_NAME); MODULE_AUTHOR(Texas Instruments, Inc.); MODULE_DESCRIPTION(I2C Core interface for TWL4030); MODULE_LICENSE(GPL); diff --git a/drivers/i2c/chips/twl4030-gpio.c b/drivers/i2c/chips/twl4030-gpio.c index a448943..f16a48b 100644 --- a/drivers/i2c/chips/twl4030-gpio.c +++ b/drivers/i2c/chips/twl4030-gpio.c @@ -827,6 +827,7 @@ static void __exit gpio_twl4030_exit(void) module_init(gpio_twl4030_init); module_exit(gpio_twl4030_exit); +MODULE_ALIAS(i2c:twl4030-gpio); MODULE_AUTHOR(Texas Instruments, Inc.); MODULE_DESCRIPTION(GPIO interface for TWL4030); MODULE_LICENSE(GPL); diff --git a/drivers/i2c/chips/twl4030-madc.c b/drivers/i2c/chips/twl4030-madc.c index f53a3db..72b126b 100644 --- a/drivers/i2c/chips/twl4030-madc.c +++ b/drivers/i2c/chips/twl4030-madc.c @@ -448,6 +448,7 @@ static void __exit twl4030_madc_exit(void) module_init(twl4030_madc_init); module_exit(twl4030_madc_exit); +MODULE_ALIAS(i2c:twl4030-adc); MODULE_AUTHOR(Nokia Corporation); MODULE_DESCRIPTION(twl4030 ADC driver); MODULE_LICENSE(GPL); diff --git a/drivers/i2c/chips/twl4030-poweroff.c b/drivers/i2c/chips/twl4030-poweroff.c index 57c7fc7..0ebab0b 100644 --- a/drivers/i2c/chips/twl4030-poweroff.c +++ b/drivers/i2c/chips/twl4030-poweroff.c @@ -70,6 +70,7 @@ static void __exit twl4030_poweroff_exit(void) module_init(twl4030_poweroff_init); module_exit(twl4030_poweroff_exit); +MODULE_ALIAS(i2c:twl4030-poweroff); MODULE_DESCRIPTION(Triton2 device power off); MODULE_LICENSE(GPL); MODULE_AUTHOR(Peter De Schrijver); diff --git a/drivers/i2c/chips/twl4030-pwrbutton.c b/drivers/i2c/chips/twl4030-pwrbutton.c index cbc31aa..09adc67 100644 --- a/drivers/i2c/chips/twl4030-pwrbutton.c +++ b/drivers/i2c/chips/twl4030-pwrbutton.c @@ -154,6 +154,7 @@ static void __exit twl4030_pwrbutton_exit(void) module_init(twl4030_pwrbutton_init); module_exit(twl4030_pwrbutton_exit); +MODULE_ALIAS(i2c:twl4030-pwrbutton); MODULE_DESCRIPTION(Triton2 Power Button); MODULE_LICENSE(GPL); MODULE_AUTHOR(Peter De Schrijver); diff --git a/drivers/i2c/chips/twl4030-pwrirq.c b/drivers/i2c/chips/twl4030-pwrirq.c index 8f1fec6..a4d2e92 100644 --- a/drivers/i2c/chips/twl4030-pwrirq.c +++ b/drivers/i2c/chips/twl4030-pwrirq.c @@ -222,5 +222,6 @@ static void __exit twl4030_pwrirq_exit(void) } } +MODULE_ALIAS(i2c:twl4030-pwrirq); subsys_initcall(twl4030_pwrirq_init); module_exit(twl4030_pwrirq_exit); diff --git a/drivers/i2c/chips/twl4030-usb.c b/drivers/i2c/chips/twl4030-usb.c index f546d42..ab335ca 100644 --- a/drivers/i2c/chips/twl4030-usb.c +++ b/drivers/i2c/chips/twl4030-usb.c @@ -770,6 +770,7 @@ static void __exit twl4030_usb_exit(void) subsys_initcall(twl4030_usb_init); module_exit(twl4030_usb_exit); +MODULE_ALIAS(i2c:twl4030-usb); MODULE_AUTHOR(Texas Instruments, Inc.); MODULE_DESCRIPTION(TWL4030 USB transceiver driver); MODULE_LICENSE(GPL); diff --git a/drivers/input/keyboard/omap-twl4030keypad.c b/drivers/input/keyboard/omap-twl4030keypad.c index 0344b4c..94ab43b 100644 --- a/drivers/input/keyboard/omap-twl4030keypad.c +++ b/drivers/input/keyboard/omap-twl4030keypad.c @@ -368,6 +368,7 @@ static void __exit omap_kp_exit(void) module_init(omap_kp_init); module_exit(omap_kp_exit); +MODULE_ALIAS(platform:omap_twl4030keypad); MODULE_AUTHOR(Texas Instruments); MODULE_DESCRIPTION(OMAP TWL4030 Keypad Driver); MODULE_LICENSE(GPL); diff --git a/drivers/rtc/rtc-twl4030.c b/drivers/rtc/rtc-twl4030.c index ef0e175..e9386ba 100644 --- a/drivers/rtc/rtc-twl4030.c +++ b/drivers/rtc/rtc-twl4030.c @@ -647,6 +647,7 @@ static void __exit twl4030_rtc_exit(void) platform_driver_unregister(twl4030rtc_driver); } +MODULE_ALIAS(platform:twl4030_rtc); MODULE_AUTHOR(Texas Instruments, MontaVista Software); MODULE_LICENSE(GPL);; -- 1.5.6.rc1 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ARM: OMAP: armv7a Makefile: change -march flag to armv7-a so gcc 4.3.x works
armv7a Makefile: change -march flag to armv7-a so gcc 4.3.x works, armv7a is a CSL-ism. CSL compilers accept both variants. Tested with: gcc 4.2.4, 4.3.0, 4.3.1 and csl 2007q3, 2008q1 Signed-off-by: Koen Kooi [EMAIL PROTECTED] --- arch/arm/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/Makefile b/arch/arm/Makefile index 40a0b44..a3befbd 100644 --- a/arch/arm/Makefile +++ b/arch/arm/Makefile @@ -47,7 +47,7 @@ comma = , # Note that GCC does not numerically define an architecture version # macro, but instead defines a whole series of macros which makes # testing for a specific architecture or later rather impossible. -arch-$(CONFIG_CPU_32v7):=-D__LINUX_ARM_ARCH__=7 $(call cc-option,-march=armv7a,-march=armv5t -Wa$(comma)-march=armv7a) +arch-$(CONFIG_CPU_32v7):=-D__LINUX_ARM_ARCH__=7 $(call cc-option,-march=armv7-a,-march=armv5t -Wa$(comma)-march=armv7-a) arch-$(CONFIG_CPU_32v6):=-D__LINUX_ARM_ARCH__=6 $(call cc-option,-march=armv6,-march=armv5t -Wa$(comma)-march=armv6) # Only override the compiler option if ARMv6. The ARMv6K extensions are # always available in ARMv7 -- 1.5.4.3 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] Added sleep support to UART
Hi Tero, Let me begin by saying that I don't care too much about the 32-bit SCM register read change; I just happen to think that it is easier to read. That said, one comment of yours bears some additional discussion: On Thu, 12 Jun 2008, [EMAIL PROTECTED] wrote: Also, the spec says that these registers can be accessed in either 8, 16 or 32 bit modes so why make it unnecessarily complicated and potentially buggy with shifts (race conditions)? What race are you referring to? Wouldn't such a race exist with the current code? (i.e., a shift should not cause any further race) - Paul -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: SDMA, RAM to RAM transfer issue
Hi! Brandon Thanks alot! for valuable input... i am now using flush_cache_all(); for making all memories updated for testing. and it is working :) with regards Somz On Sat, Jun 14, 2008 at 5:02 AM, Azbell, Brandon [EMAIL PROTECTED] wrote: Somz, The parameter set looks fine and as you indicated, works fine for the 1024 byte transfer. Regarding the 64-byte transfer, which was not represented in the parameters you provided, I suspect that it is getting stuck in the L1 Cache, or possibly L2 Cache, but not actually getting to system memory (DDR). For the 1024 byte transfer, the cache controllers may be needing to flush to make room and therefore it appears to be working. Do you perform a cache flush on the SRC buffer prior to triggering the DMA? Also, do you perform a cache invalidate on the DST buffer prior to reading the buffer and verifying the contents? You should perform this in order to ensure the new contents of the SRC buffer make it to system memory (DDR) prior to the DMA transfer. Brandon Azbell -- Like it or not, you're in the Software Business -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
